From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> To: Bjorn Andersson <bjorn.andersson@linaro.org>, Rob Clark <robdclark@gmail.com>, Abhinav Kumar <quic_abhinavk@quicinc.com>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzk+dt@kernel.org> Cc: freedreno@lists.freedesktop.org, devicetree@vger.kernel.org, David Airlie <airlied@linux.ie>, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Sean Paul <sean@poorly.run> Subject: Re: [PATCH v4 2/2] drm/msm/dpu: Issue MDSS reset during initialization Date: Tue, 26 Apr 2022 01:11:13 +0300 [thread overview] Message-ID: <94435133-b875-3005-ab23-dc4457ec9002@linaro.org> (raw) In-Reply-To: <20220421041550.643964-2-bjorn.andersson@linaro.org> On 21/04/2022 07:15, Bjorn Andersson wrote: > It's typical for the bootloader to bring up the display for showing a > boot splash or efi framebuffer. But in some cases the kernel driver ends > up only partially configuring (in particular) the DPU, which might > result in e.g. that two different data paths attempts to push data to > the interface - with resulting graphical artifacts. > > Naturally the end goal would be to inherit the bootloader's > configuration and provide the user with a glitch free handover from the > boot configuration to a running DPU. > > But as implementing seamless transition from the bootloader > configuration to the running OS will be a considerable effort, start by > simply resetting the entire MDSS to its power-on state, to avoid the > partial configuration. > > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- > > Changes since v3: > - Rebased upon the mdss dpu/mdp restructuring (https://patchwork.freedesktop.org/series/98525/) > > drivers/gpu/drm/msm/msm_mdss.c | 32 ++++++++++++++++++++++++++++++++ > 1 file changed, 32 insertions(+) > > diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c > index f6f0d0fa5ab2..20f154dda9cf 100644 > --- a/drivers/gpu/drm/msm/msm_mdss.c > +++ b/drivers/gpu/drm/msm/msm_mdss.c > @@ -4,11 +4,13 @@ > */ > > #include <linux/clk.h> > +#include <linux/delay.h> > #include <linux/irq.h> > #include <linux/irqchip.h> > #include <linux/irqdesc.h> > #include <linux/irqchip/chained_irq.h> > #include <linux/pm_runtime.h> > +#include <linux/reset.h> > > #include "msm_drv.h" > #include "msm_kms.h" > @@ -193,6 +195,32 @@ static void msm_mdss_destroy(struct msm_mdss *msm_mdss) > irq_set_chained_handler_and_data(irq, NULL, NULL); > } > > +static int msm_mdss_reset(struct device *dev) > +{ > + struct reset_control *reset; > + > + reset = reset_control_get_optional_exclusive(dev, NULL); > + if (!reset) { > + /* Optional reset not specified */ > + return 0; > + } else if (IS_ERR(reset)) { > + return dev_err_probe(dev, PTR_ERR(reset), > + "failed to acquire mdss reset\n"); > + } > + > + reset_control_assert(reset); > + /* > + * Tests indicate that reset has to be held for some period of time, > + * make it one frame in a typical system > + */ > + msleep(20); > + reset_control_deassert(reset); > + > + reset_control_put(reset); > + > + return 0; > +} > + > /* > * MDP5 MDSS uses at most three specified clocks. > */ > @@ -229,6 +257,10 @@ static struct msm_mdss *msm_mdss_init(struct platform_device *pdev, bool is_mdp5 > int ret; > int irq; > > + ret = msm_mdss_reset(&pdev->dev); > + if (ret) > + return ERR_PTR(ret); > + > msm_mdss = devm_kzalloc(&pdev->dev, sizeof(*msm_mdss), GFP_KERNEL); > if (!msm_mdss) > return ERR_PTR(-ENOMEM); -- With best wishes Dmitry
WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> To: Bjorn Andersson <bjorn.andersson@linaro.org>, Rob Clark <robdclark@gmail.com>, Abhinav Kumar <quic_abhinavk@quicinc.com>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzk+dt@kernel.org> Cc: Sean Paul <sean@poorly.run>, David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>, Philipp Zabel <p.zabel@pengutronix.de>, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 2/2] drm/msm/dpu: Issue MDSS reset during initialization Date: Tue, 26 Apr 2022 01:11:13 +0300 [thread overview] Message-ID: <94435133-b875-3005-ab23-dc4457ec9002@linaro.org> (raw) In-Reply-To: <20220421041550.643964-2-bjorn.andersson@linaro.org> On 21/04/2022 07:15, Bjorn Andersson wrote: > It's typical for the bootloader to bring up the display for showing a > boot splash or efi framebuffer. But in some cases the kernel driver ends > up only partially configuring (in particular) the DPU, which might > result in e.g. that two different data paths attempts to push data to > the interface - with resulting graphical artifacts. > > Naturally the end goal would be to inherit the bootloader's > configuration and provide the user with a glitch free handover from the > boot configuration to a running DPU. > > But as implementing seamless transition from the bootloader > configuration to the running OS will be a considerable effort, start by > simply resetting the entire MDSS to its power-on state, to avoid the > partial configuration. > > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- > > Changes since v3: > - Rebased upon the mdss dpu/mdp restructuring (https://patchwork.freedesktop.org/series/98525/) > > drivers/gpu/drm/msm/msm_mdss.c | 32 ++++++++++++++++++++++++++++++++ > 1 file changed, 32 insertions(+) > > diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c > index f6f0d0fa5ab2..20f154dda9cf 100644 > --- a/drivers/gpu/drm/msm/msm_mdss.c > +++ b/drivers/gpu/drm/msm/msm_mdss.c > @@ -4,11 +4,13 @@ > */ > > #include <linux/clk.h> > +#include <linux/delay.h> > #include <linux/irq.h> > #include <linux/irqchip.h> > #include <linux/irqdesc.h> > #include <linux/irqchip/chained_irq.h> > #include <linux/pm_runtime.h> > +#include <linux/reset.h> > > #include "msm_drv.h" > #include "msm_kms.h" > @@ -193,6 +195,32 @@ static void msm_mdss_destroy(struct msm_mdss *msm_mdss) > irq_set_chained_handler_and_data(irq, NULL, NULL); > } > > +static int msm_mdss_reset(struct device *dev) > +{ > + struct reset_control *reset; > + > + reset = reset_control_get_optional_exclusive(dev, NULL); > + if (!reset) { > + /* Optional reset not specified */ > + return 0; > + } else if (IS_ERR(reset)) { > + return dev_err_probe(dev, PTR_ERR(reset), > + "failed to acquire mdss reset\n"); > + } > + > + reset_control_assert(reset); > + /* > + * Tests indicate that reset has to be held for some period of time, > + * make it one frame in a typical system > + */ > + msleep(20); > + reset_control_deassert(reset); > + > + reset_control_put(reset); > + > + return 0; > +} > + > /* > * MDP5 MDSS uses at most three specified clocks. > */ > @@ -229,6 +257,10 @@ static struct msm_mdss *msm_mdss_init(struct platform_device *pdev, bool is_mdp5 > int ret; > int irq; > > + ret = msm_mdss_reset(&pdev->dev); > + if (ret) > + return ERR_PTR(ret); > + > msm_mdss = devm_kzalloc(&pdev->dev, sizeof(*msm_mdss), GFP_KERNEL); > if (!msm_mdss) > return ERR_PTR(-ENOMEM); -- With best wishes Dmitry
next prev parent reply other threads:[~2022-04-25 22:11 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-04-21 4:15 [PATCH v4 1/2] dt-bindings: display: msm: Add optional resets Bjorn Andersson 2022-04-21 4:15 ` Bjorn Andersson 2022-04-21 4:15 ` [PATCH v4 2/2] drm/msm/dpu: Issue MDSS reset during initialization Bjorn Andersson 2022-04-21 4:15 ` Bjorn Andersson 2022-04-25 22:11 ` Dmitry Baryshkov [this message] 2022-04-25 22:11 ` Dmitry Baryshkov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=94435133-b875-3005-ab23-dc4457ec9002@linaro.org \ --to=dmitry.baryshkov@linaro.org \ --cc=airlied@linux.ie \ --cc=bjorn.andersson@linaro.org \ --cc=devicetree@vger.kernel.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=freedreno@lists.freedesktop.org \ --cc=krzk+dt@kernel.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=quic_abhinavk@quicinc.com \ --cc=robdclark@gmail.com \ --cc=robh+dt@kernel.org \ --cc=sean@poorly.run \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.