All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ata: pata_cs5535: Fix W=1 warnings
@ 2022-06-27 13:12 John Garry
  2022-06-28  8:59 ` Damien Le Moal
  2022-06-29  1:51 ` Damien Le Moal
  0 siblings, 2 replies; 11+ messages in thread
From: John Garry @ 2022-06-27 13:12 UTC (permalink / raw)
  To: s.shtylyov, damien.lemoal; +Cc: linux-ide, linux-kernel, John Garry

x86_64 allmodconfig build with W=1 gives these warnings:

drivers/ata/pata_cs5535.c: In function ‘cs5535_set_piomode’:
drivers/ata/pata_cs5535.c:93:11: error: variable ‘dummy’ set but not used [-Werror=unused-but-set-variable]
  u32 reg, dummy;
           ^~~~~
drivers/ata/pata_cs5535.c: In function ‘cs5535_set_dmamode’:
drivers/ata/pata_cs5535.c:132:11: error: variable ‘dummy’ set but not used [-Werror=unused-but-set-variable]
  u32 reg, dummy;
           ^~~~~
cc1: all warnings being treated as errors

Mark variables 'dummy' as "maybe unused" to satisfy when rdmsr() is
stubbed, which is the same as what we already do in pata_cs5536.c .

Signed-off-by: John Garry <john.garry@huawei.com>

diff --git a/drivers/ata/pata_cs5535.c b/drivers/ata/pata_cs5535.c
index 6725931f3c35..c2c3238ff84b 100644
--- a/drivers/ata/pata_cs5535.c
+++ b/drivers/ata/pata_cs5535.c
@@ -90,7 +90,7 @@ static void cs5535_set_piomode(struct ata_port *ap, struct ata_device *adev)
 	static const u16 pio_cmd_timings[5] = {
 		0xF7F4, 0x53F3, 0x13F1, 0x5131, 0x1131
 	};
-	u32 reg, dummy;
+	u32 reg, __maybe_unused dummy;
 	struct ata_device *pair = ata_dev_pair(adev);
 
 	int mode = adev->pio_mode - XFER_PIO_0;
@@ -129,7 +129,7 @@ static void cs5535_set_dmamode(struct ata_port *ap, struct ata_device *adev)
 	static const u32 mwdma_timings[3] = {
 		0x7F0FFFF3, 0x7F035352, 0x7F024241
 	};
-	u32 reg, dummy;
+	u32 reg, __maybe_unused dummy;
 	int mode = adev->dma_mode;
 
 	rdmsr(ATAC_CH0D0_DMA + 2 * adev->devno, reg, dummy);
-- 
2.35.3


^ permalink raw reply related	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2022-06-29 23:04 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-27 13:12 [PATCH] ata: pata_cs5535: Fix W=1 warnings John Garry
2022-06-28  8:59 ` Damien Le Moal
2022-06-28  9:27   ` John Garry
2022-06-28 10:05   ` Sergey Shtylyov
2022-06-28 18:39     ` Sergey Shtylyov
2022-06-29  7:41       ` John Garry
2022-06-29  8:24         ` Damien Le Moal
2022-06-29  1:14     ` Damien Le Moal
2022-06-29  1:51 ` Damien Le Moal
2022-06-29 13:32   ` Sergey Shtylyov
2022-06-29 23:03     ` Damien Le Moal

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.