[PATCH] ARM: config: Add BCM53xx defconfig

[PATCH] ARM: config: Add BCM53xx defconfig

[Linus Walleij]

This adds a BCM530x ARM-based Broadcom default config, typically
for use with NorthStar systems. This is needed because it took
me quite a lot of time to figure out all the different drivers and
intricacies that needed to be enabled to bring a typical specimen
from these systems up.

By simply using this it is easy to configure and boot a mainline
Linux kernel on these systems.

Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
I suppose Florian can merge this, I can also send it directly to
the SOC tree if preferred.
---
 arch/arm/configs/bcm53xx_defconfig | 99 ++++++++++++++++++++++++++++++
 1 file changed, 99 insertions(+)
 create mode 100644 arch/arm/configs/bcm53xx_defconfig

diff --git a/arch/arm/configs/bcm53xx_defconfig b/arch/arm/configs/bcm53xx_defconfig
new file mode 100644
index 000000000000..6e650e7287df
--- /dev/null
+++ b/arch/arm/configs/bcm53xx_defconfig
@@ -0,0 +1,99 @@
+CONFIG_KERNEL_XZ=y
+CONFIG_NO_HZ_FULL=y
+CONFIG_HIGH_RES_TIMERS=y
+CONFIG_PREEMPT=y
+CONFIG_NAMESPACES=y
+CONFIG_EMBEDDED=y
+CONFIG_ARCH_BCM=y
+CONFIG_ARCH_BCM_5301X=y
+CONFIG_ARCH_BCM_53573=y
+CONFIG_SMP=y
+CONFIG_NR_CPUS=2
+CONFIG_HIGHMEM=y
+CONFIG_ARM_APPENDED_DTB=y
+CONFIG_CMDLINE="console=ttyS0,115200"
+CONFIG_NET=y
+CONFIG_UNIX=y
+CONFIG_INET=y
+CONFIG_NET_DSA=y
+CONFIG_CFG80211=y
+CONFIG_MAC80211=y
+CONFIG_PCI=y
+# CONFIG_PCIE_IPROC_PLATFORM is not set
+CONFIG_BCM47XX_NVRAM=y
+CONFIG_BCM47XX_SPROM=y
+CONFIG_MTD=y
+CONFIG_MTD_BCM47XX_PARTS=y
+CONFIG_MTD_PARSER_TRX=y
+CONFIG_MTD_PARTITIONED_MASTER=y
+CONFIG_MTD_JEDECPROBE=y
+CONFIG_MTD_RAW_NAND=y
+CONFIG_MTD_NAND_BRCMNAND=y
+CONFIG_MTD_SPI_NOR=y
+CONFIG_MTD_UBI=y
+CONFIG_NETDEVICES=y
+CONFIG_B53=y
+CONFIG_BGMAC_BCMA=y
+CONFIG_BROADCOM_PHY=y
+CONFIG_MDIO_BUS_MUX_MMIOREG=y
+CONFIG_B43=y
+CONFIG_BRCMFMAC=y
+CONFIG_BRCMFMAC_PCIE=y
+CONFIG_KEYBOARD_GPIO=y
+CONFIG_SERIAL_8250=y
+CONFIG_SERIAL_8250_CONSOLE=y
+CONFIG_SERIAL_OF_PLATFORM=y
+CONFIG_SPI=y
+CONFIG_SPI_GPIO=y
+# CONFIG_PTP_1588_CLOCK is not set
+# CONFIG_PINCTRL_IPROC_GPIO is not set
+CONFIG_GPIO_74X164=y
+CONFIG_THERMAL=y
+CONFIG_WATCHDOG=y
+CONFIG_BCM47XX_WDT=y
+CONFIG_BCMA_HOST_SOC=y
+# CONFIG_BCMA_SFLASH is not set
+CONFIG_BCMA_DRIVER_GMAC_CMN=y
+CONFIG_BCMA_DRIVER_GPIO=y
+CONFIG_BCMA_DEBUG=y
+CONFIG_MFD_SYSCON=y
+CONFIG_REGULATOR=y
+CONFIG_REGULATOR_FIXED_VOLTAGE=y
+CONFIG_HID_A4TECH=y
+CONFIG_HID_BELKIN=y
+CONFIG_HID_CHERRY=y
+CONFIG_HID_CYPRESS=y
+CONFIG_HID_EZKEY=y
+CONFIG_HID_ITE=y
+CONFIG_HID_KENSINGTON=y
+CONFIG_HID_REDRAGON=y
+CONFIG_HID_MICROSOFT=y
+CONFIG_HID_MONTEREY=y
+CONFIG_USB=y
+CONFIG_USB_XHCI_HCD=y
+CONFIG_USB_XHCI_PLATFORM=y
+CONFIG_USB_EHCI_HCD=y
+CONFIG_USB_OHCI_HCD=y
+CONFIG_USB_HCD_BCMA=y
+CONFIG_USB_HCD_SSB=y
+CONFIG_NEW_LEDS=y
+CONFIG_LEDS_CLASS=y
+CONFIG_LEDS_GPIO=y
+CONFIG_LEDS_TRIGGERS=y
+CONFIG_LEDS_TRIGGER_HEARTBEAT=y
+# CONFIG_CLK_BCM_NS2 is not set
+# CONFIG_CLK_BCM_SR is not set
+CONFIG_EXTCON=y
+CONFIG_PWM=y
+CONFIG_PHY_BCM_NS_USB2=y
+CONFIG_PHY_BCM_NS_USB3=y
+# CONFIG_PHY_NS2_PCIE is not set
+# CONFIG_PHY_NS2_USB_DRD is not set
+# CONFIG_PHY_BRCM_SATA is not set
+# CONFIG_PHY_BCM_SR_PCIE is not set
+CONFIG_NVMEM_BRCM_NVRAM=y
+CONFIG_EXT4_FS=y
+CONFIG_TMPFS=y
+CONFIG_UBIFS_FS=y
+# CONFIG_FTRACE is not set
+CONFIG_DEBUG_USER=y
-- 
2.34.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] ARM: config: Add BCM53xx defconfig

[Florian Fainelli]

On 11/7/22 05:49, Linus Walleij wrote:
> This adds a BCM530x ARM-based Broadcom default config, typically
> for use with NorthStar systems. This is needed because it took
> me quite a lot of time to figure out all the different drivers and
> intricacies that needed to be enabled to bring a typical specimen
> from these systems up.
> 
> By simply using this it is easy to configure and boot a mainline
> Linux kernel on these systems.
> 
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> I suppose Florian can merge this, I can also send it directly to
> the SOC tree if preferred.

ARM SoC maintainers would not let us have a cygnus_defconfig many years 
ago, so I doubt they would accept this one. defconfigs are easy to 
maintain out of tree, for better or for worse.
-- 
Florian


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] ARM: config: Add BCM53xx defconfig

[Linus Walleij]

On Mon, Nov 7, 2022 at 6:32 PM Florian Fainelli <f.fainelli@gmail.com> wrote:
> On 11/7/22 05:49, Linus Walleij wrote:
> > This adds a BCM530x ARM-based Broadcom default config, typically
> > for use with NorthStar systems. This is needed because it took
> > me quite a lot of time to figure out all the different drivers and
> > intricacies that needed to be enabled to bring a typical specimen
> > from these systems up.
> >
> > By simply using this it is easy to configure and boot a mainline
> > Linux kernel on these systems.
> >
> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> > ---
> > I suppose Florian can merge this, I can also send it directly to
> > the SOC tree if preferred.
>
> ARM SoC maintainers would not let us have a cygnus_defconfig many years
> ago, so I doubt they would accept this one. defconfigs are easy to
> maintain out of tree, for better or for worse.

Why not, I had to spend hours to come up with this one, it has
general use and is good for my compile tests. Also policies
change, consistency isn't our best game.

Arnd, Olof: can I have this defconfig?

Itr's not like I can't deal with rejection but I want some rationale.

I can send it directly to SoC so you don't need to deal
with it as long as you approve of the usefulness.

Yours,
Linus Walleij

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] ARM: config: Add BCM53xx defconfig

[Rafał Miłecki]

On 7.11.2022 23:25, Linus Walleij wrote:
> On Mon, Nov 7, 2022 at 6:32 PM Florian Fainelli <f.fainelli@gmail.com> wrote:
>> On 11/7/22 05:49, Linus Walleij wrote:
>>> This adds a BCM530x ARM-based Broadcom default config, typically
>>> for use with NorthStar systems. This is needed because it took
>>> me quite a lot of time to figure out all the different drivers and
>>> intricacies that needed to be enabled to bring a typical specimen
>>> from these systems up.
>>>
>>> By simply using this it is easy to configure and boot a mainline
>>> Linux kernel on these systems.
>>>
>>> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
>>> ---
>>> I suppose Florian can merge this, I can also send it directly to
>>> the SOC tree if preferred.
>>
>> ARM SoC maintainers would not let us have a cygnus_defconfig many years
>> ago, so I doubt they would accept this one. defconfigs are easy to
>> maintain out of tree, for better or for worse.
> 
> Why not, I had to spend hours to come up with this one, it has
> general use and is good for my compile tests. Also policies
> change, consistency isn't our best game.
> 
> Arnd, Olof: can I have this defconfig?
> 
> Itr's not like I can't deal with rejection but I want some rationale.
> 
> I can send it directly to SoC so you don't need to deal
> with it as long as you approve of the usefulness.

I'd find it quite useful to have more defconfigs mainline. I didn't
submit one after finding some old discussions we don't have more
defconfigs in kernel.

I'd really appreciate some official policy and explanation on this.


On this particular patch: there are few symbols we should discuss. I
don't see why there is CONFIG_EXT4_FS=y and some others too. Let's get
this policy cleared first though.

Linus: you could also ask me before spending so many hours on this. I'd
recommend looking at
https://git.busybox.net/buildroot/tree/board/broadcom/northstar/linux.config
https://git.busybox.net/buildroot/commit/?id=1500b7d5c818fb021eaa8741eec8130cbbf3477e

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] ARM: config: Add BCM53xx defconfig

[Florian Fainelli]

On 11/7/22 14:25, Linus Walleij wrote:
> On Mon, Nov 7, 2022 at 6:32 PM Florian Fainelli <f.fainelli@gmail.com> wrote:
>> On 11/7/22 05:49, Linus Walleij wrote:
>>> This adds a BCM530x ARM-based Broadcom default config, typically
>>> for use with NorthStar systems. This is needed because it took
>>> me quite a lot of time to figure out all the different drivers and
>>> intricacies that needed to be enabled to bring a typical specimen
>>> from these systems up.
>>>
>>> By simply using this it is easy to configure and boot a mainline
>>> Linux kernel on these systems.
>>>
>>> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
>>> ---
>>> I suppose Florian can merge this, I can also send it directly to
>>> the SOC tree if preferred.
>>
>> ARM SoC maintainers would not let us have a cygnus_defconfig many years
>> ago, so I doubt they would accept this one. defconfigs are easy to
>> maintain out of tree, for better or for worse.

This is the thread I had in mind:

https://lore.kernel.org/linux-arm-kernel/1996601.jhvNxNYxnl@wuerfel/

I do remember pretty vividly that Arnd did not want to see more 
SoC-specific defconfig files but looking at the output of:

shows that we had defconfigs introduced as late as 2022, so either 
something changed and I missed it, or there was something else.

> 
> Why not, I had to spend hours to come up with this one, it has
> general use and is good for my compile tests. Also policies
> change, consistency isn't our best game.
> 
> Arnd, Olof: can I have this defconfig?
> 
> Itr's not like I can't deal with rejection but I want some rationale.
> 
> I can send it directly to SoC so you don't need to deal
> with it as long as you approve of the usefulness.

If it does land, I want to be able to track changes to that defconfig, 
so no it is not the route you want to seek, and I am not opposed to 
merging yet, just telling you that last I was aware it happened, the 
defconfig eventually did not land.

It makes it sound as if because I do not agree with your change, you are 
looking for a higher power to take on your changes which is effectively 
a form of bypass.

Maybe it would be more effective to introduce a generic 
Northstar/Northstar Plus defconfig since the same kernel image can run 
on both types of devices.
-- 
Florian


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] ARM: config: Add BCM53xx defconfig

[Linus Walleij]

On Mon, Nov 7, 2022 at 11:38 PM Rafał Miłecki <zajec5@gmail.com> wrote:

> Linus: you could also ask me before spending so many hours on this. I'd
> recommend looking at
> https://git.busybox.net/buildroot/tree/board/broadcom/northstar/linux.config
> https://git.busybox.net/buildroot/commit/?id=1500b7d5c818fb021eaa8741eec8130cbbf3477e

Ah nice! What I used as a base was the OpenWrt defconfig thinking that
was your baseline but that had USB disabled so I spent some time to get
things in working state.

Yours,
Linus Walleij

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] ARM: config: Add BCM53xx defconfig

[Linus Walleij]

On Mon, Nov 7, 2022 at 11:48 PM Florian Fainelli <f.fainelli@gmail.com> wrote:

> This is the thread I had in mind:
>
> https://lore.kernel.org/linux-arm-kernel/1996601.jhvNxNYxnl@wuerfel/
>
> I do remember pretty vividly that Arnd did not want to see more
> SoC-specific defconfig files but looking at the output of:

I think the belief in multi_v7 is a bit overplayed. For small embedded
systems like what BCM53xx is used for that results in a binary that
is so big it cannot be booted on the target and then the defconfig
is only good for compile tests :/

Compile tests are nice, but I want to do actual boot tests.

> If it does land, I want to be able to track changes to that defconfig,
> so no it is not the route you want to seek, and I am not opposed to
> merging yet, just telling you that last I was aware it happened, the
> defconfig eventually did not land.

OK no problem.

> Maybe it would be more effective to introduce a generic
> Northstar/Northstar Plus defconfig since the same kernel image can run
> on both types of devices.

I think that was what I was trying with bcm53xx_defconfig,
so we can cooperate on the final options to go in.

Yours,
Linus Walleij

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel