* [PATCH] ARM: dts: arm: realview: Fix development chip ROM compatible value
@ 2023-08-30 15:03 ` Geert Uytterhoeven
0 siblings, 0 replies; 9+ messages in thread
From: Geert Uytterhoeven @ 2023-08-30 15:03 UTC (permalink / raw)
To: Linus Walleij, Boris Brezillon, Ricardo Ribalda
Cc: Miquel Raynal, Richard Weinberger, Vignesh Raghavendra,
linux-mtd, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
linux-arm-kernel, devicetree, Geert Uytterhoeven
When the development chip ROM was added, the "direct-mapped" compatible
value was already obsolete. In addition, the device node lacked the
accompanying "probe-type" property, causing the old physmap_of_core
driver to fall back to trying all available probe types.
Unfortunately this fallback was lost when the DT and pdata cases were
merged.
Fix this by using the modern "mtd-rom" compatible value instead.
Fixes: 5c3f5edbe0a1dff3 ("ARM: realview: add flash devices to the PB1176 DTS")
Fixes: 642b1e8dbed7bbbf ("mtd: maps: Merge physmap_of.c into physmap-core.c")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
Untested due to lack of hardware.
---
arch/arm/boot/dts/arm/arm-realview-pb1176.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/arm/arm-realview-pb1176.dts b/arch/arm/boot/dts/arm/arm-realview-pb1176.dts
index efed325af88d206f..d99bac02232b3703 100644
--- a/arch/arm/boot/dts/arm/arm-realview-pb1176.dts
+++ b/arch/arm/boot/dts/arm/arm-realview-pb1176.dts
@@ -451,7 +451,7 @@ pb1176_serial3: serial@1010f000 {
/* Direct-mapped development chip ROM */
pb1176_rom@10200000 {
- compatible = "direct-mapped";
+ compatible = "mtd-rom";
reg = <0x10200000 0x4000>;
bank-width = <1>;
};
--
2.34.1
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH] ARM: dts: arm: realview: Fix development chip ROM compatible value
@ 2023-08-30 15:03 ` Geert Uytterhoeven
0 siblings, 0 replies; 9+ messages in thread
From: Geert Uytterhoeven @ 2023-08-30 15:03 UTC (permalink / raw)
To: Linus Walleij, Boris Brezillon, Ricardo Ribalda
Cc: Miquel Raynal, Richard Weinberger, Vignesh Raghavendra,
linux-mtd, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
linux-arm-kernel, devicetree, Geert Uytterhoeven
When the development chip ROM was added, the "direct-mapped" compatible
value was already obsolete. In addition, the device node lacked the
accompanying "probe-type" property, causing the old physmap_of_core
driver to fall back to trying all available probe types.
Unfortunately this fallback was lost when the DT and pdata cases were
merged.
Fix this by using the modern "mtd-rom" compatible value instead.
Fixes: 5c3f5edbe0a1dff3 ("ARM: realview: add flash devices to the PB1176 DTS")
Fixes: 642b1e8dbed7bbbf ("mtd: maps: Merge physmap_of.c into physmap-core.c")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
Untested due to lack of hardware.
---
arch/arm/boot/dts/arm/arm-realview-pb1176.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/arm/arm-realview-pb1176.dts b/arch/arm/boot/dts/arm/arm-realview-pb1176.dts
index efed325af88d206f..d99bac02232b3703 100644
--- a/arch/arm/boot/dts/arm/arm-realview-pb1176.dts
+++ b/arch/arm/boot/dts/arm/arm-realview-pb1176.dts
@@ -451,7 +451,7 @@ pb1176_serial3: serial@1010f000 {
/* Direct-mapped development chip ROM */
pb1176_rom@10200000 {
- compatible = "direct-mapped";
+ compatible = "mtd-rom";
reg = <0x10200000 0x4000>;
bank-width = <1>;
};
--
2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH] ARM: dts: arm: realview: Fix development chip ROM compatible value
@ 2023-08-30 15:03 ` Geert Uytterhoeven
0 siblings, 0 replies; 9+ messages in thread
From: Geert Uytterhoeven @ 2023-08-30 15:03 UTC (permalink / raw)
To: Linus Walleij, Boris Brezillon, Ricardo Ribalda
Cc: Miquel Raynal, Richard Weinberger, Vignesh Raghavendra,
linux-mtd, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
linux-arm-kernel, devicetree, Geert Uytterhoeven
When the development chip ROM was added, the "direct-mapped" compatible
value was already obsolete. In addition, the device node lacked the
accompanying "probe-type" property, causing the old physmap_of_core
driver to fall back to trying all available probe types.
Unfortunately this fallback was lost when the DT and pdata cases were
merged.
Fix this by using the modern "mtd-rom" compatible value instead.
Fixes: 5c3f5edbe0a1dff3 ("ARM: realview: add flash devices to the PB1176 DTS")
Fixes: 642b1e8dbed7bbbf ("mtd: maps: Merge physmap_of.c into physmap-core.c")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
Untested due to lack of hardware.
---
arch/arm/boot/dts/arm/arm-realview-pb1176.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/arm/arm-realview-pb1176.dts b/arch/arm/boot/dts/arm/arm-realview-pb1176.dts
index efed325af88d206f..d99bac02232b3703 100644
--- a/arch/arm/boot/dts/arm/arm-realview-pb1176.dts
+++ b/arch/arm/boot/dts/arm/arm-realview-pb1176.dts
@@ -451,7 +451,7 @@ pb1176_serial3: serial@1010f000 {
/* Direct-mapped development chip ROM */
pb1176_rom@10200000 {
- compatible = "direct-mapped";
+ compatible = "mtd-rom";
reg = <0x10200000 0x4000>;
bank-width = <1>;
};
--
2.34.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] ARM: dts: arm: realview: Fix development chip ROM compatible value
2023-08-30 15:03 ` Geert Uytterhoeven
(?)
@ 2023-09-12 7:18 ` Linus Walleij
-1 siblings, 0 replies; 9+ messages in thread
From: Linus Walleij @ 2023-09-12 7:18 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Boris Brezillon, Ricardo Ribalda, Miquel Raynal,
Richard Weinberger, Vignesh Raghavendra, linux-mtd, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, linux-arm-kernel, devicetree
On Wed, Aug 30, 2023 at 5:03 PM Geert Uytterhoeven
<geert+renesas@glider.be> wrote:
> When the development chip ROM was added, the "direct-mapped" compatible
> value was already obsolete. In addition, the device node lacked the
> accompanying "probe-type" property, causing the old physmap_of_core
> driver to fall back to trying all available probe types.
> Unfortunately this fallback was lost when the DT and pdata cases were
> merged.
>
> Fix this by using the modern "mtd-rom" compatible value instead.
>
> Fixes: 5c3f5edbe0a1dff3 ("ARM: realview: add flash devices to the PB1176 DTS")
> Fixes: 642b1e8dbed7bbbf ("mtd: maps: Merge physmap_of.c into physmap-core.c")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Patch applied!
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] ARM: dts: arm: realview: Fix development chip ROM compatible value
@ 2023-09-12 7:18 ` Linus Walleij
0 siblings, 0 replies; 9+ messages in thread
From: Linus Walleij @ 2023-09-12 7:18 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Boris Brezillon, Ricardo Ribalda, Miquel Raynal,
Richard Weinberger, Vignesh Raghavendra, linux-mtd, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, linux-arm-kernel, devicetree
On Wed, Aug 30, 2023 at 5:03 PM Geert Uytterhoeven
<geert+renesas@glider.be> wrote:
> When the development chip ROM was added, the "direct-mapped" compatible
> value was already obsolete. In addition, the device node lacked the
> accompanying "probe-type" property, causing the old physmap_of_core
> driver to fall back to trying all available probe types.
> Unfortunately this fallback was lost when the DT and pdata cases were
> merged.
>
> Fix this by using the modern "mtd-rom" compatible value instead.
>
> Fixes: 5c3f5edbe0a1dff3 ("ARM: realview: add flash devices to the PB1176 DTS")
> Fixes: 642b1e8dbed7bbbf ("mtd: maps: Merge physmap_of.c into physmap-core.c")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Patch applied!
Yours,
Linus Walleij
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] ARM: dts: arm: realview: Fix development chip ROM compatible value
@ 2023-09-12 7:18 ` Linus Walleij
0 siblings, 0 replies; 9+ messages in thread
From: Linus Walleij @ 2023-09-12 7:18 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Boris Brezillon, Ricardo Ribalda, Miquel Raynal,
Richard Weinberger, Vignesh Raghavendra, linux-mtd, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, linux-arm-kernel, devicetree
On Wed, Aug 30, 2023 at 5:03 PM Geert Uytterhoeven
<geert+renesas@glider.be> wrote:
> When the development chip ROM was added, the "direct-mapped" compatible
> value was already obsolete. In addition, the device node lacked the
> accompanying "probe-type" property, causing the old physmap_of_core
> driver to fall back to trying all available probe types.
> Unfortunately this fallback was lost when the DT and pdata cases were
> merged.
>
> Fix this by using the modern "mtd-rom" compatible value instead.
>
> Fixes: 5c3f5edbe0a1dff3 ("ARM: realview: add flash devices to the PB1176 DTS")
> Fixes: 642b1e8dbed7bbbf ("mtd: maps: Merge physmap_of.c into physmap-core.c")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Patch applied!
Yours,
Linus Walleij
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] ARM: dts: arm: realview: Fix development chip ROM compatible value
2023-09-12 7:18 ` Linus Walleij
(?)
@ 2024-02-14 16:46 ` Geert Uytterhoeven
-1 siblings, 0 replies; 9+ messages in thread
From: Geert Uytterhoeven @ 2024-02-14 16:46 UTC (permalink / raw)
To: Linus Walleij
Cc: Boris Brezillon, Ricardo Ribalda, Miquel Raynal,
Richard Weinberger, Vignesh Raghavendra, linux-mtd, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, linux-arm-kernel, devicetree
Hi Linus,
On Tue, Sep 12, 2023 at 9:18 AM Linus Walleij <linus.walleij@linaro.org> wrote:
> On Wed, Aug 30, 2023 at 5:03 PM Geert Uytterhoeven
> <geert+renesas@glider.be> wrote:
> > When the development chip ROM was added, the "direct-mapped" compatible
> > value was already obsolete. In addition, the device node lacked the
> > accompanying "probe-type" property, causing the old physmap_of_core
> > driver to fall back to trying all available probe types.
> > Unfortunately this fallback was lost when the DT and pdata cases were
> > merged.
> >
> > Fix this by using the modern "mtd-rom" compatible value instead.
> >
> > Fixes: 5c3f5edbe0a1dff3 ("ARM: realview: add flash devices to the PB1176 DTS")
> > Fixes: 642b1e8dbed7bbbf ("mtd: maps: Merge physmap_of.c into physmap-core.c")
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> Patch applied!
Looks like this fell through the cracks?
Shall I resend?
Thanks!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] ARM: dts: arm: realview: Fix development chip ROM compatible value
@ 2024-02-14 16:46 ` Geert Uytterhoeven
0 siblings, 0 replies; 9+ messages in thread
From: Geert Uytterhoeven @ 2024-02-14 16:46 UTC (permalink / raw)
To: Linus Walleij
Cc: Boris Brezillon, Ricardo Ribalda, Miquel Raynal,
Richard Weinberger, Vignesh Raghavendra, linux-mtd, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, linux-arm-kernel, devicetree
Hi Linus,
On Tue, Sep 12, 2023 at 9:18 AM Linus Walleij <linus.walleij@linaro.org> wrote:
> On Wed, Aug 30, 2023 at 5:03 PM Geert Uytterhoeven
> <geert+renesas@glider.be> wrote:
> > When the development chip ROM was added, the "direct-mapped" compatible
> > value was already obsolete. In addition, the device node lacked the
> > accompanying "probe-type" property, causing the old physmap_of_core
> > driver to fall back to trying all available probe types.
> > Unfortunately this fallback was lost when the DT and pdata cases were
> > merged.
> >
> > Fix this by using the modern "mtd-rom" compatible value instead.
> >
> > Fixes: 5c3f5edbe0a1dff3 ("ARM: realview: add flash devices to the PB1176 DTS")
> > Fixes: 642b1e8dbed7bbbf ("mtd: maps: Merge physmap_of.c into physmap-core.c")
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> Patch applied!
Looks like this fell through the cracks?
Shall I resend?
Thanks!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] ARM: dts: arm: realview: Fix development chip ROM compatible value
@ 2024-02-14 16:46 ` Geert Uytterhoeven
0 siblings, 0 replies; 9+ messages in thread
From: Geert Uytterhoeven @ 2024-02-14 16:46 UTC (permalink / raw)
To: Linus Walleij
Cc: Boris Brezillon, Ricardo Ribalda, Miquel Raynal,
Richard Weinberger, Vignesh Raghavendra, linux-mtd, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, linux-arm-kernel, devicetree
Hi Linus,
On Tue, Sep 12, 2023 at 9:18 AM Linus Walleij <linus.walleij@linaro.org> wrote:
> On Wed, Aug 30, 2023 at 5:03 PM Geert Uytterhoeven
> <geert+renesas@glider.be> wrote:
> > When the development chip ROM was added, the "direct-mapped" compatible
> > value was already obsolete. In addition, the device node lacked the
> > accompanying "probe-type" property, causing the old physmap_of_core
> > driver to fall back to trying all available probe types.
> > Unfortunately this fallback was lost when the DT and pdata cases were
> > merged.
> >
> > Fix this by using the modern "mtd-rom" compatible value instead.
> >
> > Fixes: 5c3f5edbe0a1dff3 ("ARM: realview: add flash devices to the PB1176 DTS")
> > Fixes: 642b1e8dbed7bbbf ("mtd: maps: Merge physmap_of.c into physmap-core.c")
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> Patch applied!
Looks like this fell through the cracks?
Shall I resend?
Thanks!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2024-02-14 16:47 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-30 15:03 [PATCH] ARM: dts: arm: realview: Fix development chip ROM compatible value Geert Uytterhoeven
2023-08-30 15:03 ` Geert Uytterhoeven
2023-08-30 15:03 ` Geert Uytterhoeven
2023-09-12 7:18 ` Linus Walleij
2023-09-12 7:18 ` Linus Walleij
2023-09-12 7:18 ` Linus Walleij
2024-02-14 16:46 ` Geert Uytterhoeven
2024-02-14 16:46 ` Geert Uytterhoeven
2024-02-14 16:46 ` Geert Uytterhoeven
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.