* [dpdk-dev] [PATCH] net/virtio-user: do not reset virtqueues for split ring
@ 2020-02-05 2:11 Tiwei Bie
2020-02-05 3:07 ` Ding, Xuan
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Tiwei Bie @ 2020-02-05 2:11 UTC (permalink / raw)
To: dev, maxime.coquelin, zhihong.wang; +Cc: Xuan Ding
Add missing braces to avoid resetting virtqueues unconditionally
during reconnection.
Fixes: 6ebbf4109f35 ("net/virtio-user: fix packed ring server mode")
Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
---
Cc: Xuan Ding <xuan.ding@intel.com>
drivers/net/virtio/virtio_user_ethdev.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/virtio/virtio_user_ethdev.c b/drivers/net/virtio/virtio_user_ethdev.c
index f3b35d1bd..e61af4068 100644
--- a/drivers/net/virtio/virtio_user_ethdev.c
+++ b/drivers/net/virtio/virtio_user_ethdev.c
@@ -89,10 +89,11 @@ virtio_user_server_reconnect(struct virtio_user_dev *dev)
dev->features &= dev->device_features;
/* For packed ring, resetting queues is required in reconnection. */
- if (vtpci_packed_queue(hw))
+ if (vtpci_packed_queue(hw)) {
PMD_INIT_LOG(NOTICE, "Packets on the fly will be dropped"
" when packed ring reconnecting.");
virtio_user_reset_queues_packed(eth_dev);
+ }
ret = virtio_user_start_device(dev);
if (ret < 0)
--
2.24.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] net/virtio-user: do not reset virtqueues for split ring
2020-02-05 2:11 [dpdk-dev] [PATCH] net/virtio-user: do not reset virtqueues for split ring Tiwei Bie
@ 2020-02-05 3:07 ` Ding, Xuan
2020-02-05 7:52 ` Maxime Coquelin
2020-02-05 9:45 ` Maxime Coquelin
2 siblings, 0 replies; 4+ messages in thread
From: Ding, Xuan @ 2020-02-05 3:07 UTC (permalink / raw)
To: Bie, Tiwei, dev, maxime.coquelin, Wang, Zhihong
Hi Tiwei,
Corrected on my local, thank you for your fix in advance.
Regards,
Xuan Ding
> -----Original Message-----
> From: Bie, Tiwei <tiwei.bie@intel.com>
> Sent: Wednesday, February 5, 2020 10:11 AM
> To: dev@dpdk.org; maxime.coquelin@redhat.com; Wang, Zhihong
> <zhihong.wang@intel.com>
> Cc: Ding, Xuan <xuan.ding@intel.com>
> Subject: [PATCH] net/virtio-user: do not reset virtqueues for split ring
>
> Add missing braces to avoid resetting virtqueues unconditionally during
> reconnection.
>
> Fixes: 6ebbf4109f35 ("net/virtio-user: fix packed ring server mode")
>
> Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
> ---
> Cc: Xuan Ding <xuan.ding@intel.com>
>
> drivers/net/virtio/virtio_user_ethdev.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/virtio/virtio_user_ethdev.c
> b/drivers/net/virtio/virtio_user_ethdev.c
> index f3b35d1bd..e61af4068 100644
> --- a/drivers/net/virtio/virtio_user_ethdev.c
> +++ b/drivers/net/virtio/virtio_user_ethdev.c
> @@ -89,10 +89,11 @@ virtio_user_server_reconnect(struct virtio_user_dev
> *dev)
> dev->features &= dev->device_features;
>
> /* For packed ring, resetting queues is required in reconnection. */
> - if (vtpci_packed_queue(hw))
> + if (vtpci_packed_queue(hw)) {
> PMD_INIT_LOG(NOTICE, "Packets on the fly will be dropped"
> " when packed ring reconnecting.");
> virtio_user_reset_queues_packed(eth_dev);
> + }
>
> ret = virtio_user_start_device(dev);
> if (ret < 0)
> --
> 2.24.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] net/virtio-user: do not reset virtqueues for split ring
2020-02-05 2:11 [dpdk-dev] [PATCH] net/virtio-user: do not reset virtqueues for split ring Tiwei Bie
2020-02-05 3:07 ` Ding, Xuan
@ 2020-02-05 7:52 ` Maxime Coquelin
2020-02-05 9:45 ` Maxime Coquelin
2 siblings, 0 replies; 4+ messages in thread
From: Maxime Coquelin @ 2020-02-05 7:52 UTC (permalink / raw)
To: Tiwei Bie, dev, zhihong.wang; +Cc: Xuan Ding
On 2/5/20 3:11 AM, Tiwei Bie wrote:
> Add missing braces to avoid resetting virtqueues unconditionally
> during reconnection.
>
> Fixes: 6ebbf4109f35 ("net/virtio-user: fix packed ring server mode")
>
> Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
> ---
> Cc: Xuan Ding <xuan.ding@intel.com>
>
> drivers/net/virtio/virtio_user_ethdev.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/virtio/virtio_user_ethdev.c b/drivers/net/virtio/virtio_user_ethdev.c
> index f3b35d1bd..e61af4068 100644
> --- a/drivers/net/virtio/virtio_user_ethdev.c
> +++ b/drivers/net/virtio/virtio_user_ethdev.c
> @@ -89,10 +89,11 @@ virtio_user_server_reconnect(struct virtio_user_dev *dev)
> dev->features &= dev->device_features;
>
> /* For packed ring, resetting queues is required in reconnection. */
> - if (vtpci_packed_queue(hw))
> + if (vtpci_packed_queue(hw)) {
> PMD_INIT_LOG(NOTICE, "Packets on the fly will be dropped"
> " when packed ring reconnecting.");
> virtio_user_reset_queues_packed(eth_dev);
> + }
>
> ret = virtio_user_start_device(dev);
> if (ret < 0)
>
Oops, thank you Tiwei for fixing it!
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Maxime
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] net/virtio-user: do not reset virtqueues for split ring
2020-02-05 2:11 [dpdk-dev] [PATCH] net/virtio-user: do not reset virtqueues for split ring Tiwei Bie
2020-02-05 3:07 ` Ding, Xuan
2020-02-05 7:52 ` Maxime Coquelin
@ 2020-02-05 9:45 ` Maxime Coquelin
2 siblings, 0 replies; 4+ messages in thread
From: Maxime Coquelin @ 2020-02-05 9:45 UTC (permalink / raw)
To: Tiwei Bie, dev, zhihong.wang; +Cc: Xuan Ding
On 2/5/20 3:11 AM, Tiwei Bie wrote:
> Add missing braces to avoid resetting virtqueues unconditionally
> during reconnection.
>
> Fixes: 6ebbf4109f35 ("net/virtio-user: fix packed ring server mode")
>
> Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
> ---
> Cc: Xuan Ding <xuan.ding@intel.com>
>
> drivers/net/virtio/virtio_user_ethdev.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Applied to dpdk-next-virtio tree.
Thanks,
Maxime
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-02-05 9:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-05 2:11 [dpdk-dev] [PATCH] net/virtio-user: do not reset virtqueues for split ring Tiwei Bie
2020-02-05 3:07 ` Ding, Xuan
2020-02-05 7:52 ` Maxime Coquelin
2020-02-05 9:45 ` Maxime Coquelin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.