All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: rockchip: Assign RK3288 EDP_24M input centrally
@ 2016-01-25 11:19 ` Sjoerd Simons
  0 siblings, 0 replies; 5+ messages in thread
From: Sjoerd Simons @ 2016-01-25 11:19 UTC (permalink / raw)
  To: Heiko Stuebner; +Cc: linux-rockchip, linux-kernel, linux-arm-kernel, devicetree

The EDP 24M clock can be fed either by an SoC internal fixed clock or
from an external IC. Change the default parent to the internal clock in
the main rk3288 dtsi, to ensure (by default) it gets setup with a
non-orphaned clock (hardware defaults to the externa clock).

This prevents potential issues when the clock framework get support for
deferring on orphaned clocks, while specific boards can always change
the parent clock if an external input is preferred.

Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>

---

 arch/arm/boot/dts/rk3288-veyron.dtsi | 5 -----
 arch/arm/boot/dts/rk3288.dtsi        | 3 +++
 2 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/arch/arm/boot/dts/rk3288-veyron.dtsi b/arch/arm/boot/dts/rk3288-veyron.dtsi
index 9fce91f..5e61f07 100644
--- a/arch/arm/boot/dts/rk3288-veyron.dtsi
+++ b/arch/arm/boot/dts/rk3288-veyron.dtsi
@@ -340,11 +340,6 @@
 	i2c-scl-rising-time-ns = <1000>;
 };
 
-&power {
-	assigned-clocks = <&cru SCLK_EDP_24M>;
-	assigned-clock-parents = <&xin24m>;
-};
-
 &pwm1 {
 	status = "okay";
 };
diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi
index 8ac49f3..03bb747 100644
--- a/arch/arm/boot/dts/rk3288.dtsi
+++ b/arch/arm/boot/dts/rk3288.dtsi
@@ -630,6 +630,9 @@
 			#address-cells = <1>;
 			#size-cells = <0>;
 
+			assigned-clocks = <&cru SCLK_EDP_24M>;
+			assigned-clock-parents = <&xin24m>;
+
 			/*
 			 * Note: Although SCLK_* are the working clocks
 			 * of device without including on the NOC, needed for
-- 
2.7.0

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* [PATCH] ARM: dts: rockchip: Assign RK3288 EDP_24M input centrally
@ 2016-01-25 11:19 ` Sjoerd Simons
  0 siblings, 0 replies; 5+ messages in thread
From: Sjoerd Simons @ 2016-01-25 11:19 UTC (permalink / raw)
  To: Heiko Stuebner
  Cc: linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	devicetree-u79uwXL29TY76Z2rM5mHXA

The EDP 24M clock can be fed either by an SoC internal fixed clock or
from an external IC. Change the default parent to the internal clock in
the main rk3288 dtsi, to ensure (by default) it gets setup with a
non-orphaned clock (hardware defaults to the externa clock).

This prevents potential issues when the clock framework get support for
deferring on orphaned clocks, while specific boards can always change
the parent clock if an external input is preferred.

Signed-off-by: Sjoerd Simons <sjoerd.simons-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>

---

 arch/arm/boot/dts/rk3288-veyron.dtsi | 5 -----
 arch/arm/boot/dts/rk3288.dtsi        | 3 +++
 2 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/arch/arm/boot/dts/rk3288-veyron.dtsi b/arch/arm/boot/dts/rk3288-veyron.dtsi
index 9fce91f..5e61f07 100644
--- a/arch/arm/boot/dts/rk3288-veyron.dtsi
+++ b/arch/arm/boot/dts/rk3288-veyron.dtsi
@@ -340,11 +340,6 @@
 	i2c-scl-rising-time-ns = <1000>;
 };
 
-&power {
-	assigned-clocks = <&cru SCLK_EDP_24M>;
-	assigned-clock-parents = <&xin24m>;
-};
-
 &pwm1 {
 	status = "okay";
 };
diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi
index 8ac49f3..03bb747 100644
--- a/arch/arm/boot/dts/rk3288.dtsi
+++ b/arch/arm/boot/dts/rk3288.dtsi
@@ -630,6 +630,9 @@
 			#address-cells = <1>;
 			#size-cells = <0>;
 
+			assigned-clocks = <&cru SCLK_EDP_24M>;
+			assigned-clock-parents = <&xin24m>;
+
 			/*
 			 * Note: Although SCLK_* are the working clocks
 			 * of device without including on the NOC, needed for
-- 
2.7.0

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* [PATCH] ARM: dts: rockchip: Assign RK3288 EDP_24M input centrally
@ 2016-01-25 11:19 ` Sjoerd Simons
  0 siblings, 0 replies; 5+ messages in thread
From: Sjoerd Simons @ 2016-01-25 11:19 UTC (permalink / raw)
  To: linux-arm-kernel

The EDP 24M clock can be fed either by an SoC internal fixed clock or
from an external IC. Change the default parent to the internal clock in
the main rk3288 dtsi, to ensure (by default) it gets setup with a
non-orphaned clock (hardware defaults to the externa clock).

This prevents potential issues when the clock framework get support for
deferring on orphaned clocks, while specific boards can always change
the parent clock if an external input is preferred.

Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>

---

 arch/arm/boot/dts/rk3288-veyron.dtsi | 5 -----
 arch/arm/boot/dts/rk3288.dtsi        | 3 +++
 2 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/arch/arm/boot/dts/rk3288-veyron.dtsi b/arch/arm/boot/dts/rk3288-veyron.dtsi
index 9fce91f..5e61f07 100644
--- a/arch/arm/boot/dts/rk3288-veyron.dtsi
+++ b/arch/arm/boot/dts/rk3288-veyron.dtsi
@@ -340,11 +340,6 @@
 	i2c-scl-rising-time-ns = <1000>;
 };
 
-&power {
-	assigned-clocks = <&cru SCLK_EDP_24M>;
-	assigned-clock-parents = <&xin24m>;
-};
-
 &pwm1 {
 	status = "okay";
 };
diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi
index 8ac49f3..03bb747 100644
--- a/arch/arm/boot/dts/rk3288.dtsi
+++ b/arch/arm/boot/dts/rk3288.dtsi
@@ -630,6 +630,9 @@
 			#address-cells = <1>;
 			#size-cells = <0>;
 
+			assigned-clocks = <&cru SCLK_EDP_24M>;
+			assigned-clock-parents = <&xin24m>;
+
 			/*
 			 * Note: Although SCLK_* are the working clocks
 			 * of device without including on the NOC, needed for
-- 
2.7.0

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: dts: rockchip: Assign RK3288 EDP_24M input centrally
  2016-01-25 11:19 ` Sjoerd Simons
@ 2016-01-25 13:50   ` Heiko Stübner
  -1 siblings, 0 replies; 5+ messages in thread
From: Heiko Stübner @ 2016-01-25 13:50 UTC (permalink / raw)
  To: Sjoerd Simons; +Cc: linux-rockchip, linux-kernel, linux-arm-kernel, devicetree

Am Montag, 25. Januar 2016, 12:19:26 schrieb Sjoerd Simons:
> The EDP 24M clock can be fed either by an SoC internal fixed clock or
> from an external IC. Change the default parent to the internal clock in
> the main rk3288 dtsi, to ensure (by default) it gets setup with a
> non-orphaned clock (hardware defaults to the externa clock).
> 
> This prevents potential issues when the clock framework get support for
> deferring on orphaned clocks, while specific boards can always change
> the parent clock if an external input is preferred.
> 
> Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>

applied to dts32 for 4.6

^ permalink raw reply	[flat|nested] 5+ messages in thread
* [PATCH] ARM: dts: rockchip: Assign RK3288 EDP_24M input centrally
@ 2016-01-25 13:50   ` Heiko Stübner
  0 siblings, 0 replies; 5+ messages in thread
From: Heiko Stübner @ 2016-01-25 13:50 UTC (permalink / raw)
  To: linux-arm-kernel

Am Montag, 25. Januar 2016, 12:19:26 schrieb Sjoerd Simons:
> The EDP 24M clock can be fed either by an SoC internal fixed clock or
> from an external IC. Change the default parent to the internal clock in
> the main rk3288 dtsi, to ensure (by default) it gets setup with a
> non-orphaned clock (hardware defaults to the externa clock).
> 
> This prevents potential issues when the clock framework get support for
> deferring on orphaned clocks, while specific boards can always change
> the parent clock if an external input is preferred.
> 
> Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>

applied to dts32 for 4.6

^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-01-25 13:50 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-01-25 11:19 [PATCH] ARM: dts: rockchip: Assign RK3288 EDP_24M input centrally Sjoerd Simons
2016-01-25 11:19 ` Sjoerd Simons
2016-01-25 11:19 ` Sjoerd Simons
2016-01-25 13:50 ` Heiko Stübner
2016-01-25 13:50   ` Heiko Stübner

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.