* [Buildroot] [PATCH 1/1] Force cmake packages to use makefiles
@ 2022-10-07 16:27 Woody Douglass via buildroot
2022-10-30 16:45 ` Yann E. MORIN
2022-11-13 14:33 ` Peter Korsgaard
0 siblings, 2 replies; 3+ messages in thread
From: Woody Douglass via buildroot @ 2022-10-07 16:27 UTC (permalink / raw)
To: buildroot; +Cc: s.martin49
Force cmake packages to use the "Unix Makefiles" generator
in case CMAKE_GENERATOR is set in the host environment. This
patch further isolates the buildroot build environment from
the host.
Signed-off-by: Woodrow Douglass <wdouglass@carnegierobotics.com>
---
package/pkg-cmake.mk | 2 ++
1 file changed, 2 insertions(+)
diff --git a/package/pkg-cmake.mk b/package/pkg-cmake.mk
index 081960b5bf..db9fdebb8d 100644
--- a/package/pkg-cmake.mk
+++ b/package/pkg-cmake.mk
@@ -88,6 +88,7 @@ define $(2)_CONFIGURE_CMDS
rm -f CMakeCache.txt && \
PATH=$$(BR_PATH) \
$$($$(PKG)_CONF_ENV) $$(BR2_CMAKE) $$($$(PKG)_SRCDIR) \
+ -G"Unix MakeFiles" \
-DCMAKE_TOOLCHAIN_FILE="$$(HOST_DIR)/share/buildroot/to
olchainfile.cmake" \
-DCMAKE_INSTALL_PREFIX="/usr" \
-DCMAKE_INSTALL_RUNSTATEDIR="/run" \
@@ -118,6 +119,7 @@ define $(2)_CONFIGURE_CMDS
PKG_CONFIG_ALLOW_SYSTEM_CFLAGS=1 \
PKG_CONFIG_ALLOW_SYSTEM_LIBS=1 \
$$($$(PKG)_CONF_ENV) $$(BR2_CMAKE) $$($$(PKG)_SRCDIR) \
+ -G"Unix MakeFiles" \
-DCMAKE_INSTALL_SO_NO_EXE=0 \
-DCMAKE_FIND_ROOT_PATH="$$(HOST_DIR)" \
-DCMAKE_FIND_ROOT_PATH_MODE_PROGRAM="BOTH" \
--
2.20.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH 1/1] Force cmake packages to use makefiles
2022-10-07 16:27 [Buildroot] [PATCH 1/1] Force cmake packages to use makefiles Woody Douglass via buildroot
@ 2022-10-30 16:45 ` Yann E. MORIN
2022-11-13 14:33 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Yann E. MORIN @ 2022-10-30 16:45 UTC (permalink / raw)
To: Woody Douglass; +Cc: s.martin49, buildroot
Woody, All,
On 2022-10-07 16:27 +0000, Woody Douglass via buildroot spake thusly:
>
> Force cmake packages to use the "Unix Makefiles" generator
> in case CMAKE_GENERATOR is set in the host environment. This
> patch further isolates the buildroot build environment from
> the host.
>
> Signed-off-by: Woodrow Douglass <wdouglass@carnegierobotics.com>
> ---
> package/pkg-cmake.mk | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/package/pkg-cmake.mk b/package/pkg-cmake.mk
> index 081960b5bf..db9fdebb8d 100644
> --- a/package/pkg-cmake.mk
> +++ b/package/pkg-cmake.mk
> @@ -88,6 +88,7 @@ define $(2)_CONFIGURE_CMDS
> rm -f CMakeCache.txt && \
> PATH=$$(BR_PATH) \
> $$($$(PKG)_CONF_ENV) $$(BR2_CMAKE) $$($$(PKG)_SRCDIR) \
> + -G"Unix MakeFiles" \
> -DCMAKE_TOOLCHAIN_FILE="$$(HOST_DIR)/share/buildroot/to
> olchainfile.cmake" \
Your patch was damaged, so I had to manaully fix it when applying.
Normally, sending patches with "git send-email" takes care of properly
formatting patches.
Applied to master, thanks.
Regards,
Yann E. MORIN.
> -DCMAKE_INSTALL_PREFIX="/usr" \
> -DCMAKE_INSTALL_RUNSTATEDIR="/run" \
> @@ -118,6 +119,7 @@ define $(2)_CONFIGURE_CMDS
> PKG_CONFIG_ALLOW_SYSTEM_CFLAGS=1 \
> PKG_CONFIG_ALLOW_SYSTEM_LIBS=1 \
> $$($$(PKG)_CONF_ENV) $$(BR2_CMAKE) $$($$(PKG)_SRCDIR) \
> + -G"Unix MakeFiles" \
> -DCMAKE_INSTALL_SO_NO_EXE=0 \
> -DCMAKE_FIND_ROOT_PATH="$$(HOST_DIR)" \
> -DCMAKE_FIND_ROOT_PATH_MODE_PROGRAM="BOTH" \
> --
> 2.20.1
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH 1/1] Force cmake packages to use makefiles
2022-10-07 16:27 [Buildroot] [PATCH 1/1] Force cmake packages to use makefiles Woody Douglass via buildroot
2022-10-30 16:45 ` Yann E. MORIN
@ 2022-11-13 14:33 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2022-11-13 14:33 UTC (permalink / raw)
To: Woody Douglass via buildroot; +Cc: Woody Douglass, s.martin49
>>>>> "Woody" == Woody Douglass via buildroot <buildroot@buildroot.org> writes:
> Force cmake packages to use the "Unix Makefiles" generator
> in case CMAKE_GENERATOR is set in the host environment. This
> patch further isolates the buildroot build environment from
> the host.
> Signed-off-by: Woodrow Douglass <wdouglass@carnegierobotics.com>
Committed to 2022.08.x and 2022.02.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-11-13 14:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-07 16:27 [Buildroot] [PATCH 1/1] Force cmake packages to use makefiles Woody Douglass via buildroot
2022-10-30 16:45 ` Yann E. MORIN
2022-11-13 14:33 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.