* [PATCH] RDMA/rxe: Generate a completion for unsupported/invalid opcode
@ 2022-04-08 3:30 Xiao Yang
2022-04-08 18:11 ` Bob Pearson
2022-04-08 18:26 ` Jason Gunthorpe
0 siblings, 2 replies; 5+ messages in thread
From: Xiao Yang @ 2022-04-08 3:30 UTC (permalink / raw)
To: rpearsonhpe, leon, jgg; +Cc: linux-rdma, Xiao Yang
Current rxe_requester() doesn't generate a completion when processing an
unsupported/invalid opcode. If rxe driver doesn't support a new opcode
(e.g. RDMA Atomic Write) and RDMA library supports it, an application
using the new opcode can reproduce this issue. Fix the issue by calling
"goto err;".
Signed-off-by: Xiao Yang <yangx.jy@fujitsu.com>
---
drivers/infiniband/sw/rxe/rxe_req.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/infiniband/sw/rxe/rxe_req.c b/drivers/infiniband/sw/rxe/rxe_req.c
index ae5fbc79dd5c..8a1cff80a68e 100644
--- a/drivers/infiniband/sw/rxe/rxe_req.c
+++ b/drivers/infiniband/sw/rxe/rxe_req.c
@@ -661,7 +661,7 @@ int rxe_requester(void *arg)
opcode = next_opcode(qp, wqe, wqe->wr.opcode);
if (unlikely(opcode < 0)) {
wqe->status = IB_WC_LOC_QP_OP_ERR;
- goto exit;
+ goto err;
}
mask = rxe_opcode[opcode].mask;
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] RDMA/rxe: Generate a completion for unsupported/invalid opcode
2022-04-08 3:30 [PATCH] RDMA/rxe: Generate a completion for unsupported/invalid opcode Xiao Yang
@ 2022-04-08 18:11 ` Bob Pearson
2022-04-08 18:26 ` Jason Gunthorpe
1 sibling, 0 replies; 5+ messages in thread
From: Bob Pearson @ 2022-04-08 18:11 UTC (permalink / raw)
To: Xiao Yang, leon, jgg; +Cc: linux-rdma
On 4/7/22 22:30, Xiao Yang wrote:
> Current rxe_requester() doesn't generate a completion when processing an
> unsupported/invalid opcode. If rxe driver doesn't support a new opcode
> (e.g. RDMA Atomic Write) and RDMA library supports it, an application
> using the new opcode can reproduce this issue. Fix the issue by calling
> "goto err;".
>
> Signed-off-by: Xiao Yang <yangx.jy@fujitsu.com>
> ---
> drivers/infiniband/sw/rxe/rxe_req.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/sw/rxe/rxe_req.c b/drivers/infiniband/sw/rxe/rxe_req.c
> index ae5fbc79dd5c..8a1cff80a68e 100644
> --- a/drivers/infiniband/sw/rxe/rxe_req.c
> +++ b/drivers/infiniband/sw/rxe/rxe_req.c
> @@ -661,7 +661,7 @@ int rxe_requester(void *arg)
> opcode = next_opcode(qp, wqe, wqe->wr.opcode);
> if (unlikely(opcode < 0)) {
> wqe->status = IB_WC_LOC_QP_OP_ERR;
> - goto exit;
> + goto err;
> }
>
> mask = rxe_opcode[opcode].mask;
Much better! This looks correct.
Reviewed-by: Bob Pearson <rpearsonhpe@gmail.com>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] RDMA/rxe: Generate a completion for unsupported/invalid opcode
2022-04-08 3:30 [PATCH] RDMA/rxe: Generate a completion for unsupported/invalid opcode Xiao Yang
2022-04-08 18:11 ` Bob Pearson
@ 2022-04-08 18:26 ` Jason Gunthorpe
2022-04-08 19:34 ` Bob Pearson
1 sibling, 1 reply; 5+ messages in thread
From: Jason Gunthorpe @ 2022-04-08 18:26 UTC (permalink / raw)
To: Xiao Yang; +Cc: rpearsonhpe, leon, linux-rdma
On Fri, Apr 08, 2022 at 11:30:29AM +0800, Xiao Yang wrote:
> Current rxe_requester() doesn't generate a completion when processing an
> unsupported/invalid opcode. If rxe driver doesn't support a new opcode
> (e.g. RDMA Atomic Write) and RDMA library supports it, an application
> using the new opcode can reproduce this issue. Fix the issue by calling
> "goto err;".
>
> Signed-off-by: Xiao Yang <yangx.jy@fujitsu.com>
> ---
> drivers/infiniband/sw/rxe/rxe_req.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Fixes line?
Jason
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] RDMA/rxe: Generate a completion for unsupported/invalid opcode
2022-04-08 18:26 ` Jason Gunthorpe
@ 2022-04-08 19:34 ` Bob Pearson
2022-04-10 11:29 ` yangx.jy
0 siblings, 1 reply; 5+ messages in thread
From: Bob Pearson @ 2022-04-08 19:34 UTC (permalink / raw)
To: Jason Gunthorpe, Xiao Yang; +Cc: leon, linux-rdma
On 4/8/22 13:26, Jason Gunthorpe wrote:
> On Fri, Apr 08, 2022 at 11:30:29AM +0800, Xiao Yang wrote:
>> Current rxe_requester() doesn't generate a completion when processing an
>> unsupported/invalid opcode. If rxe driver doesn't support a new opcode
>> (e.g. RDMA Atomic Write) and RDMA library supports it, an application
>> using the new opcode can reproduce this issue. Fix the issue by calling
>> "goto err;".
>>
>> Signed-off-by: Xiao Yang <yangx.jy@fujitsu.com>
>> ---
>> drivers/infiniband/sw/rxe/rxe_req.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Fixes line?
>
> Jason
That would be
Fixes: 8700e3e7c485 ("Soft RoCE (RXE) - The software RoCE driver")
Been there forever.
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] RDMA/rxe: Generate a completion for unsupported/invalid opcode
2022-04-08 19:34 ` Bob Pearson
@ 2022-04-10 11:29 ` yangx.jy
0 siblings, 0 replies; 5+ messages in thread
From: yangx.jy @ 2022-04-10 11:29 UTC (permalink / raw)
To: Bob Pearson, Jason Gunthorpe; +Cc: leon, linux-rdma
On 2022/4/9 3:34, Bob Pearson wrote:
> On 4/8/22 13:26, Jason Gunthorpe wrote:
>> On Fri, Apr 08, 2022 at 11:30:29AM +0800, Xiao Yang wrote:
>>> Current rxe_requester() doesn't generate a completion when processing an
>>> unsupported/invalid opcode. If rxe driver doesn't support a new opcode
>>> (e.g. RDMA Atomic Write) and RDMA library supports it, an application
>>> using the new opcode can reproduce this issue. Fix the issue by calling
>>> "goto err;".
>>>
>>> Signed-off-by: Xiao Yang <yangx.jy@fujitsu.com>
>>> ---
>>> drivers/infiniband/sw/rxe/rxe_req.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> Fixes line?
>>
>> Jason
>
> That would be
>
> Fixes: 8700e3e7c485 ("Soft RoCE (RXE) - The software RoCE driver")
>
Right, I will send v2 patch with the Fixes line.
Best Regards,
Xiao Yang
>
> Been there forever.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-04-10 11:29 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-08 3:30 [PATCH] RDMA/rxe: Generate a completion for unsupported/invalid opcode Xiao Yang
2022-04-08 18:11 ` Bob Pearson
2022-04-08 18:26 ` Jason Gunthorpe
2022-04-08 19:34 ` Bob Pearson
2022-04-10 11:29 ` yangx.jy
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.