* [PATCH] ACPICA: Fix indentation
@ 2017-12-08 16:29 Vasyl Gomonovych
2017-12-08 17:06 ` [Devel] " Rafael J. Wysocki
0 siblings, 1 reply; 9+ messages in thread
From: Vasyl Gomonovych @ 2017-12-08 16:29 UTC (permalink / raw)
To: robert.moore, lv.zheng, rafael.j.wysocki, lenb, gomonovych
Cc: linux-acpi, devel, linux-kernel
This patch avoids that smatch reports the following:
drivers/acpi/acpica/exdump.c:623 acpi_ex_dump_operand() warn: inconsistent indenting
Signed-off-by: Vasyl Gomonovych <gomonovych@gmail.com>
---
drivers/acpi/acpica/exdump.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/acpi/acpica/exdump.c b/drivers/acpi/acpica/exdump.c
index 83398dc..f43d3d7 100644
--- a/drivers/acpi/acpica/exdump.c
+++ b/drivers/acpi/acpica/exdump.c
@@ -619,8 +619,8 @@ void acpi_ex_dump_operand(union acpi_operand_object *obj_desc, u32 depth)
ACPI_FUNCTION_NAME(ex_dump_operand)
- /* Check if debug output enabled */
- if (!ACPI_IS_DEBUG_ENABLED(ACPI_LV_EXEC, _COMPONENT)) {
+ /* Check if debug output enabled */
+ if (!ACPI_IS_DEBUG_ENABLED(ACPI_LV_EXEC, _COMPONENT)) {
return;
}
--
1.9.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] ACPICA: Fix indentation
@ 2017-12-08 17:06 ` Rafael J. Wysocki
0 siblings, 0 replies; 9+ messages in thread
From: Rafael J. Wysocki @ 2017-12-08 17:06 UTC (permalink / raw)
To: Vasyl Gomonovych
Cc: Robert Moore, Lv, Rafael Wysocki, Len Brown,
ACPI Devel Maling List, devel, Linux Kernel Mailing List,
Schmauss, Erik
On Fri, Dec 8, 2017 at 5:29 PM, Vasyl Gomonovych <gomonovych@gmail.com> wrote:
> This patch avoids that smatch reports the following:
> drivers/acpi/acpica/exdump.c:623 acpi_ex_dump_operand() warn: inconsistent indenting
>
> Signed-off-by: Vasyl Gomonovych <gomonovych@gmail.com>
This is ACPICA code, so changes like this should go in via the upstream.
Erik may want to pick this up, however.
> ---
> drivers/acpi/acpica/exdump.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/acpi/acpica/exdump.c b/drivers/acpi/acpica/exdump.c
> index 83398dc..f43d3d7 100644
> --- a/drivers/acpi/acpica/exdump.c
> +++ b/drivers/acpi/acpica/exdump.c
> @@ -619,8 +619,8 @@ void acpi_ex_dump_operand(union acpi_operand_object *obj_desc, u32 depth)
>
> ACPI_FUNCTION_NAME(ex_dump_operand)
>
> - /* Check if debug output enabled */
> - if (!ACPI_IS_DEBUG_ENABLED(ACPI_LV_EXEC, _COMPONENT)) {
> + /* Check if debug output enabled */
> + if (!ACPI_IS_DEBUG_ENABLED(ACPI_LV_EXEC, _COMPONENT)) {
> return;
> }
>
> --
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Devel] [PATCH] ACPICA: Fix indentation
@ 2017-12-08 17:06 ` Rafael J. Wysocki
0 siblings, 0 replies; 9+ messages in thread
From: Rafael J. Wysocki @ 2017-12-08 17:06 UTC (permalink / raw)
To: devel
[-- Attachment #1: Type: text/plain, Size: 1134 bytes --]
On Fri, Dec 8, 2017 at 5:29 PM, Vasyl Gomonovych <gomonovych(a)gmail.com> wrote:
> This patch avoids that smatch reports the following:
> drivers/acpi/acpica/exdump.c:623 acpi_ex_dump_operand() warn: inconsistent indenting
>
> Signed-off-by: Vasyl Gomonovych <gomonovych(a)gmail.com>
This is ACPICA code, so changes like this should go in via the upstream.
Erik may want to pick this up, however.
> ---
> drivers/acpi/acpica/exdump.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/acpi/acpica/exdump.c b/drivers/acpi/acpica/exdump.c
> index 83398dc..f43d3d7 100644
> --- a/drivers/acpi/acpica/exdump.c
> +++ b/drivers/acpi/acpica/exdump.c
> @@ -619,8 +619,8 @@ void acpi_ex_dump_operand(union acpi_operand_object *obj_desc, u32 depth)
>
> ACPI_FUNCTION_NAME(ex_dump_operand)
>
> - /* Check if debug output enabled */
> - if (!ACPI_IS_DEBUG_ENABLED(ACPI_LV_EXEC, _COMPONENT)) {
> + /* Check if debug output enabled */
> + if (!ACPI_IS_DEBUG_ENABLED(ACPI_LV_EXEC, _COMPONENT)) {
> return;
> }
>
> --
^ permalink raw reply [flat|nested] 9+ messages in thread
* RE: [PATCH] ACPICA: Fix indentation
@ 2017-12-08 21:13 ` Moore, Robert
0 siblings, 0 replies; 9+ messages in thread
From: Moore, Robert @ 2017-12-08 21:13 UTC (permalink / raw)
To: Rafael J. Wysocki, Vasyl Gomonovych
Cc: Wysocki, Rafael J, Len Brown, ACPI Devel Maling List, devel,
Linux Kernel Mailing List, Schmauss, Erik
This type of thing more often than not is caused by running the code through indent (lindent).
Original ACPICA code:
ACPI_FUNCTION_NAME (ExDumpOperand)
/* Check if debug output enabled */
if (!ACPI_IS_DEBUG_ENABLED (ACPI_LV_EXEC, _COMPONENT))
{
return;
}
Raw "linuxized" code:
ACPI_FUNCTION_NAME (ex_dump_operand)
/* Check if debug output enabled */
if (!ACPI_IS_DEBUG_ENABLED (ACPI_LV_EXEC, _COMPONENT)) {
return;
}
> -----Original Message-----
> From: rjwysocki@gmail.com [mailto:rjwysocki@gmail.com] On Behalf Of
> Rafael J. Wysocki
> Sent: Friday, December 8, 2017 9:06 AM
> To: Vasyl Gomonovych <gomonovych@gmail.com>
> Cc: Moore, Robert <robert.moore@intel.com>; Zheng, Lv
> <lv.zheng@intel.com>; Wysocki, Rafael J <rafael.j.wysocki@intel.com>;
> Len Brown <lenb@kernel.org>; ACPI Devel Maling List <linux-
> acpi@vger.kernel.org>; devel@acpica.org; Linux Kernel Mailing List
> <linux-kernel@vger.kernel.org>; Schmauss, Erik <erik.schmauss@intel.com>
> Subject: Re: [PATCH] ACPICA: Fix indentation
>
> On Fri, Dec 8, 2017 at 5:29 PM, Vasyl Gomonovych <gomonovych@gmail.com>
> wrote:
> > This patch avoids that smatch reports the following:
> > drivers/acpi/acpica/exdump.c:623 acpi_ex_dump_operand() warn:
> > inconsistent indenting
> >
> > Signed-off-by: Vasyl Gomonovych <gomonovych@gmail.com>
>
> This is ACPICA code, so changes like this should go in via the upstream.
>
> Erik may want to pick this up, however.
>
> > ---
> > drivers/acpi/acpica/exdump.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/acpi/acpica/exdump.c
> > b/drivers/acpi/acpica/exdump.c index 83398dc..f43d3d7 100644
> > --- a/drivers/acpi/acpica/exdump.c
> > +++ b/drivers/acpi/acpica/exdump.c
> > @@ -619,8 +619,8 @@ void acpi_ex_dump_operand(union
> > acpi_operand_object *obj_desc, u32 depth)
> >
> > ACPI_FUNCTION_NAME(ex_dump_operand)
> >
> > - /* Check if debug output enabled */
> > - if (!ACPI_IS_DEBUG_ENABLED(ACPI_LV_EXEC, _COMPONENT)) {
> > + /* Check if debug output enabled */
> > + if (!ACPI_IS_DEBUG_ENABLED(ACPI_LV_EXEC, _COMPONENT)) {
> > return;
> > }
> >
> > --
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Devel] [PATCH] ACPICA: Fix indentation
@ 2017-12-08 21:13 ` Moore, Robert
0 siblings, 0 replies; 9+ messages in thread
From: Moore, Robert @ 2017-12-08 21:13 UTC (permalink / raw)
To: devel
[-- Attachment #1: Type: text/plain, Size: 2320 bytes --]
This type of thing more often than not is caused by running the code through indent (lindent).
Original ACPICA code:
ACPI_FUNCTION_NAME (ExDumpOperand)
/* Check if debug output enabled */
if (!ACPI_IS_DEBUG_ENABLED (ACPI_LV_EXEC, _COMPONENT))
{
return;
}
Raw "linuxized" code:
ACPI_FUNCTION_NAME (ex_dump_operand)
/* Check if debug output enabled */
if (!ACPI_IS_DEBUG_ENABLED (ACPI_LV_EXEC, _COMPONENT)) {
return;
}
> -----Original Message-----
> From: rjwysocki(a)gmail.com [mailto:rjwysocki(a)gmail.com] On Behalf Of
> Rafael J. Wysocki
> Sent: Friday, December 8, 2017 9:06 AM
> To: Vasyl Gomonovych <gomonovych(a)gmail.com>
> Cc: Moore, Robert <robert.moore(a)intel.com>; Zheng, Lv
> <lv.zheng(a)intel.com>; Wysocki, Rafael J <rafael.j.wysocki(a)intel.com>;
> Len Brown <lenb(a)kernel.org>; ACPI Devel Maling List <linux-
> acpi(a)vger.kernel.org>; devel(a)acpica.org; Linux Kernel Mailing List
> <linux-kernel(a)vger.kernel.org>; Schmauss, Erik <erik.schmauss(a)intel.com>
> Subject: Re: [PATCH] ACPICA: Fix indentation
>
> On Fri, Dec 8, 2017 at 5:29 PM, Vasyl Gomonovych <gomonovych(a)gmail.com>
> wrote:
> > This patch avoids that smatch reports the following:
> > drivers/acpi/acpica/exdump.c:623 acpi_ex_dump_operand() warn:
> > inconsistent indenting
> >
> > Signed-off-by: Vasyl Gomonovych <gomonovych(a)gmail.com>
>
> This is ACPICA code, so changes like this should go in via the upstream.
>
> Erik may want to pick this up, however.
>
> > ---
> > drivers/acpi/acpica/exdump.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/acpi/acpica/exdump.c
> > b/drivers/acpi/acpica/exdump.c index 83398dc..f43d3d7 100644
> > --- a/drivers/acpi/acpica/exdump.c
> > +++ b/drivers/acpi/acpica/exdump.c
> > @@ -619,8 +619,8 @@ void acpi_ex_dump_operand(union
> > acpi_operand_object *obj_desc, u32 depth)
> >
> > ACPI_FUNCTION_NAME(ex_dump_operand)
> >
> > - /* Check if debug output enabled */
> > - if (!ACPI_IS_DEBUG_ENABLED(ACPI_LV_EXEC, _COMPONENT)) {
> > + /* Check if debug output enabled */
> > + if (!ACPI_IS_DEBUG_ENABLED(ACPI_LV_EXEC, _COMPONENT)) {
> > return;
> > }
> >
> > --
^ permalink raw reply [flat|nested] 9+ messages in thread
* RE: [PATCH] ACPICA: Fix indentation
@ 2017-12-13 21:53 ` Schmauss, Erik
0 siblings, 0 replies; 9+ messages in thread
From: Schmauss, Erik @ 2017-12-13 21:53 UTC (permalink / raw)
To: Rafael J. Wysocki, Vasyl Gomonovych
Cc: Moore, Robert, Zheng, Lv, Wysocki, Rafael J, Len Brown,
ACPI Devel Maling List, devel, Linux Kernel Mailing List
> -----Original Message-----
> From: rjwysocki@gmail.com [mailto:rjwysocki@gmail.com] On Behalf Of Rafael
> J. Wysocki
> Sent: Friday, December 8, 2017 9:06 AM
> To: Vasyl Gomonovych <gomonovych@gmail.com>
> Cc: Moore, Robert <robert.moore@intel.com>; Zheng, Lv
> <lv.zheng@intel.com>; Wysocki, Rafael J <rafael.j.wysocki@intel.com>; Len
> Brown <lenb@kernel.org>; ACPI Devel Maling List <linux-acpi@vger.kernel.org>;
> devel@acpica.org; Linux Kernel Mailing List <linux-kernel@vger.kernel.org>;
> Schmauss, Erik <erik.schmauss@intel.com>
> Subject: Re: [PATCH] ACPICA: Fix indentation
>
> On Fri, Dec 8, 2017 at 5:29 PM, Vasyl Gomonovych <gomonovych@gmail.com>
> wrote:
> > This patch avoids that smatch reports the following:
> > drivers/acpi/acpica/exdump.c:623 acpi_ex_dump_operand() warn:
> > inconsistent indenting
> >
> > Signed-off-by: Vasyl Gomonovych <gomonovych@gmail.com>
>
> This is ACPICA code, so changes like this should go in via the upstream.
>
Hi,
> Erik may want to pick this up, however.
>
Thanks for pointing this out. I found solution to fix the indentation issue. It will be in the next release.
Erik
> > ---
> > drivers/acpi/acpica/exdump.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/acpi/acpica/exdump.c
> > b/drivers/acpi/acpica/exdump.c index 83398dc..f43d3d7 100644
> > --- a/drivers/acpi/acpica/exdump.c
> > +++ b/drivers/acpi/acpica/exdump.c
> > @@ -619,8 +619,8 @@ void acpi_ex_dump_operand(union
> > acpi_operand_object *obj_desc, u32 depth)
> >
> > ACPI_FUNCTION_NAME(ex_dump_operand)
> >
> > - /* Check if debug output enabled */
> > - if (!ACPI_IS_DEBUG_ENABLED(ACPI_LV_EXEC, _COMPONENT)) {
> > + /* Check if debug output enabled */
> > + if (!ACPI_IS_DEBUG_ENABLED(ACPI_LV_EXEC, _COMPONENT)) {
> > return;
> > }
> >
> > --
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Devel] [PATCH] ACPICA: Fix indentation
@ 2017-12-13 21:53 ` Schmauss, Erik
0 siblings, 0 replies; 9+ messages in thread
From: Schmauss, Erik @ 2017-12-13 21:53 UTC (permalink / raw)
To: devel
[-- Attachment #1: Type: text/plain, Size: 1958 bytes --]
> -----Original Message-----
> From: rjwysocki(a)gmail.com [mailto:rjwysocki(a)gmail.com] On Behalf Of Rafael
> J. Wysocki
> Sent: Friday, December 8, 2017 9:06 AM
> To: Vasyl Gomonovych <gomonovych(a)gmail.com>
> Cc: Moore, Robert <robert.moore(a)intel.com>; Zheng, Lv
> <lv.zheng(a)intel.com>; Wysocki, Rafael J <rafael.j.wysocki(a)intel.com>; Len
> Brown <lenb(a)kernel.org>; ACPI Devel Maling List <linux-acpi(a)vger.kernel.org>;
> devel(a)acpica.org; Linux Kernel Mailing List <linux-kernel(a)vger.kernel.org>;
> Schmauss, Erik <erik.schmauss(a)intel.com>
> Subject: Re: [PATCH] ACPICA: Fix indentation
>
> On Fri, Dec 8, 2017 at 5:29 PM, Vasyl Gomonovych <gomonovych(a)gmail.com>
> wrote:
> > This patch avoids that smatch reports the following:
> > drivers/acpi/acpica/exdump.c:623 acpi_ex_dump_operand() warn:
> > inconsistent indenting
> >
> > Signed-off-by: Vasyl Gomonovych <gomonovych(a)gmail.com>
>
> This is ACPICA code, so changes like this should go in via the upstream.
>
Hi,
> Erik may want to pick this up, however.
>
Thanks for pointing this out. I found solution to fix the indentation issue. It will be in the next release.
Erik
> > ---
> > drivers/acpi/acpica/exdump.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/acpi/acpica/exdump.c
> > b/drivers/acpi/acpica/exdump.c index 83398dc..f43d3d7 100644
> > --- a/drivers/acpi/acpica/exdump.c
> > +++ b/drivers/acpi/acpica/exdump.c
> > @@ -619,8 +619,8 @@ void acpi_ex_dump_operand(union
> > acpi_operand_object *obj_desc, u32 depth)
> >
> > ACPI_FUNCTION_NAME(ex_dump_operand)
> >
> > - /* Check if debug output enabled */
> > - if (!ACPI_IS_DEBUG_ENABLED(ACPI_LV_EXEC, _COMPONENT)) {
> > + /* Check if debug output enabled */
> > + if (!ACPI_IS_DEBUG_ENABLED(ACPI_LV_EXEC, _COMPONENT)) {
> > return;
> > }
> >
> > --
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] ACPICA: Fix indentation
@ 2017-12-13 22:27 ` Rafael J. Wysocki
0 siblings, 0 replies; 9+ messages in thread
From: Rafael J. Wysocki @ 2017-12-13 22:27 UTC (permalink / raw)
To: Schmauss, Erik
Cc: Rafael J. Wysocki, Vasyl Gomonovych, Moore, Robert, Zheng, Lv,
Wysocki, Rafael J, Len Brown, ACPI Devel Maling List, devel,
Linux Kernel Mailing List
On Wed, Dec 13, 2017 at 10:53 PM, Schmauss, Erik
<erik.schmauss@intel.com> wrote:
>
>> -----Original Message-----
>> From: rjwysocki@gmail.com [mailto:rjwysocki@gmail.com] On Behalf Of Rafael
>> J. Wysocki
>> Sent: Friday, December 8, 2017 9:06 AM
>> To: Vasyl Gomonovych <gomonovych@gmail.com>
>> Cc: Moore, Robert <robert.moore@intel.com>; Zheng, Lv
>> <lv.zheng@intel.com>; Wysocki, Rafael J <rafael.j.wysocki@intel.com>; Len
>> Brown <lenb@kernel.org>; ACPI Devel Maling List <linux-acpi@vger.kernel.org>;
>> devel@acpica.org; Linux Kernel Mailing List <linux-kernel@vger.kernel.org>;
>> Schmauss, Erik <erik.schmauss@intel.com>
>> Subject: Re: [PATCH] ACPICA: Fix indentation
>>
>> On Fri, Dec 8, 2017 at 5:29 PM, Vasyl Gomonovych <gomonovych@gmail.com>
>> wrote:
>> > This patch avoids that smatch reports the following:
>> > drivers/acpi/acpica/exdump.c:623 acpi_ex_dump_operand() warn:
>> > inconsistent indenting
>> >
>> > Signed-off-by: Vasyl Gomonovych <gomonovych@gmail.com>
>>
>> This is ACPICA code, so changes like this should go in via the upstream.
>>
>
> Hi,
>> Erik may want to pick this up, however.
>>
>
> Thanks for pointing this out. I found solution to fix the indentation issue. It will be in the next release.
Cool, thanks!
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Devel] [PATCH] ACPICA: Fix indentation
@ 2017-12-13 22:27 ` Rafael J. Wysocki
0 siblings, 0 replies; 9+ messages in thread
From: Rafael J. Wysocki @ 2017-12-13 22:27 UTC (permalink / raw)
To: devel
[-- Attachment #1: Type: text/plain, Size: 1313 bytes --]
On Wed, Dec 13, 2017 at 10:53 PM, Schmauss, Erik
<erik.schmauss(a)intel.com> wrote:
>
>> -----Original Message-----
>> From: rjwysocki(a)gmail.com [mailto:rjwysocki(a)gmail.com] On Behalf Of Rafael
>> J. Wysocki
>> Sent: Friday, December 8, 2017 9:06 AM
>> To: Vasyl Gomonovych <gomonovych(a)gmail.com>
>> Cc: Moore, Robert <robert.moore(a)intel.com>; Zheng, Lv
>> <lv.zheng(a)intel.com>; Wysocki, Rafael J <rafael.j.wysocki(a)intel.com>; Len
>> Brown <lenb(a)kernel.org>; ACPI Devel Maling List <linux-acpi(a)vger.kernel.org>;
>> devel(a)acpica.org; Linux Kernel Mailing List <linux-kernel(a)vger.kernel.org>;
>> Schmauss, Erik <erik.schmauss(a)intel.com>
>> Subject: Re: [PATCH] ACPICA: Fix indentation
>>
>> On Fri, Dec 8, 2017 at 5:29 PM, Vasyl Gomonovych <gomonovych(a)gmail.com>
>> wrote:
>> > This patch avoids that smatch reports the following:
>> > drivers/acpi/acpica/exdump.c:623 acpi_ex_dump_operand() warn:
>> > inconsistent indenting
>> >
>> > Signed-off-by: Vasyl Gomonovych <gomonovych(a)gmail.com>
>>
>> This is ACPICA code, so changes like this should go in via the upstream.
>>
>
> Hi,
>> Erik may want to pick this up, however.
>>
>
> Thanks for pointing this out. I found solution to fix the indentation issue. It will be in the next release.
Cool, thanks!
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2017-12-13 22:27 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-08 16:29 [PATCH] ACPICA: Fix indentation Vasyl Gomonovych
2017-12-08 17:06 ` Rafael J. Wysocki
2017-12-08 17:06 ` [Devel] " Rafael J. Wysocki
2017-12-08 21:13 ` Moore, Robert
2017-12-08 21:13 ` [Devel] " Moore, Robert
2017-12-13 21:53 ` Schmauss, Erik
2017-12-13 21:53 ` [Devel] " Schmauss, Erik
2017-12-13 22:27 ` Rafael J. Wysocki
2017-12-13 22:27 ` [Devel] " Rafael J. Wysocki
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.