* [PATCH] core/loader.py: fix regex to include all available test cases
@ 2017-12-05 15:51 leonardo.sandoval.gonzalez
2017-12-06 11:50 ` Joshua Lock
0 siblings, 1 reply; 3+ messages in thread
From: leonardo.sandoval.gonzalez @ 2017-12-05 15:51 UTC (permalink / raw)
To: openembedded-core
From: Leonardo Sandoval <leonardo.sandoval.gonzalez@linux.intel.com>
Some test cases (i.e. eSDK.oeSDKExtSelfTest*) does not match with current regex,
fix it to accept these (and previous ones).
Without it, the following runtime exception is observed when executing eSDK
selftest (oe-selftest -r eSDK)
Traceback (most recent call last):
File "/openembedded-core/scripts/oe-selftest", line 70, in <module>
ret = main()
File "/openembedded-core/scripts/oe-selftest", line 57, in main
results = args.func(logger, args)
File "/openembedded-core/meta/lib/oeqa/selftest/context.py", line 253, in run
rc = self._internal_run(logger, args)
File "/openembedded-core/meta/lib/oeqa/selftest/context.py", line 205, in _internal_run
self.tc.loadTests(self.module_paths, **self.tc_kwargs['load'])
File "/openembedded-core/meta/lib/oeqa/core/context.py", line 58, in loadTests
modules_required, filters)
File "/openembedded-core/meta/lib/oeqa/core/loader.py", line 69, in __init__
self.modules = _built_modules_dict(modules)
File "/openembedded-core/meta/lib/oeqa/core/loader.py", line 48, in _built_modules_dict
module_name, class_name, test_name = m.groups()
AttributeError: 'NoneType' object has no attribute 'groups'
Signed-off-by: Leonardo Sandoval <leonardo.sandoval.gonzalez@linux.intel.com>
---
meta/lib/oeqa/core/loader.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/lib/oeqa/core/loader.py b/meta/lib/oeqa/core/loader.py
index 975a081ba4..9ab4df0a60 100644
--- a/meta/lib/oeqa/core/loader.py
+++ b/meta/lib/oeqa/core/loader.py
@@ -43,7 +43,7 @@ def _built_modules_dict(modules):
for module in modules:
# Assumption: package and module names do not contain upper case
# characters, whereas class names do
- m = re.match(r'^([^A-Z]+)(?:\.([A-Z][^.]*)(?:\.([^.]+))?)?$', module)
+ m = re.match(r'^([a-zA-Z]+)(?:\.([a-zA-Z][^.]*)(?:\.([^.]+))?)?$', module)
module_name, class_name, test_name = m.groups()
--
2.12.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] core/loader.py: fix regex to include all available test cases
2017-12-05 15:51 [PATCH] core/loader.py: fix regex to include all available test cases leonardo.sandoval.gonzalez
@ 2017-12-06 11:50 ` Joshua Lock
2017-12-06 15:58 ` Leonardo Sandoval
0 siblings, 1 reply; 3+ messages in thread
From: Joshua Lock @ 2017-12-06 11:50 UTC (permalink / raw)
To: openembedded-core
On 05/12/17 15:51, leonardo.sandoval.gonzalez@linux.intel.com wrote:
> From: Leonardo Sandoval <leonardo.sandoval.gonzalez@linux.intel.com>
>
> Some test cases (i.e. eSDK.oeSDKExtSelfTest*) does not match with current regex,
> fix it to accept these (and previous ones).
>
> Without it, the following runtime exception is observed when executing eSDK
> selftest (oe-selftest -r eSDK)
>
> Traceback (most recent call last):
> File "/openembedded-core/scripts/oe-selftest", line 70, in <module>
> ret = main()
> File "/openembedded-core/scripts/oe-selftest", line 57, in main
> results = args.func(logger, args)
> File "/openembedded-core/meta/lib/oeqa/selftest/context.py", line 253, in run
> rc = self._internal_run(logger, args)
> File "/openembedded-core/meta/lib/oeqa/selftest/context.py", line 205, in _internal_run
> self.tc.loadTests(self.module_paths, **self.tc_kwargs['load'])
> File "/openembedded-core/meta/lib/oeqa/core/context.py", line 58, in loadTests
> modules_required, filters)
> File "/openembedded-core/meta/lib/oeqa/core/loader.py", line 69, in __init__
> self.modules = _built_modules_dict(modules)
> File "/openembedded-core/meta/lib/oeqa/core/loader.py", line 48, in _built_modules_dict
> module_name, class_name, test_name = m.groups()
> AttributeError: 'NoneType' object has no attribute 'groups'
>
> Signed-off-by: Leonardo Sandoval <leonardo.sandoval.gonzalez@linux.intel.com>
LGTM and fixes [YOCTO #12385], thanks!
Acked-by: Joshua Lock <joshua.g.lock@intel.com>
> ---
> meta/lib/oeqa/core/loader.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/lib/oeqa/core/loader.py b/meta/lib/oeqa/core/loader.py
> index 975a081ba4..9ab4df0a60 100644
> --- a/meta/lib/oeqa/core/loader.py
> +++ b/meta/lib/oeqa/core/loader.py
> @@ -43,7 +43,7 @@ def _built_modules_dict(modules):
> for module in modules:
> # Assumption: package and module names do not contain upper case
> # characters, whereas class names do
> - m = re.match(r'^([^A-Z]+)(?:\.([A-Z][^.]*)(?:\.([^.]+))?)?$', module)
> + m = re.match(r'^([a-zA-Z]+)(?:\.([a-zA-Z][^.]*)(?:\.([^.]+))?)?$', module)
>
> module_name, class_name, test_name = m.groups()
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] core/loader.py: fix regex to include all available test cases
2017-12-06 11:50 ` Joshua Lock
@ 2017-12-06 15:58 ` Leonardo Sandoval
0 siblings, 0 replies; 3+ messages in thread
From: Leonardo Sandoval @ 2017-12-06 15:58 UTC (permalink / raw)
To: Joshua Lock; +Cc: openembedded-core
On Wed, 6 Dec 2017 11:50:58 +0000
Joshua Lock <joshua.g.lock@linux.intel.com> wrote:
> On 05/12/17 15:51, leonardo.sandoval.gonzalez@linux.intel.com wrote:
> > From: Leonardo Sandoval <leonardo.sandoval.gonzalez@linux.intel.com>
> >
> > Some test cases (i.e. eSDK.oeSDKExtSelfTest*) does not match with current regex,
> > fix it to accept these (and previous ones).
> >
> > Without it, the following runtime exception is observed when executing eSDK
> > selftest (oe-selftest -r eSDK)
> >
> > Traceback (most recent call last):
> > File "/openembedded-core/scripts/oe-selftest", line 70, in <module>
> > ret = main()
> > File "/openembedded-core/scripts/oe-selftest", line 57, in main
> > results = args.func(logger, args)
> > File "/openembedded-core/meta/lib/oeqa/selftest/context.py", line 253, in run
> > rc = self._internal_run(logger, args)
> > File "/openembedded-core/meta/lib/oeqa/selftest/context.py", line 205, in _internal_run
> > self.tc.loadTests(self.module_paths, **self.tc_kwargs['load'])
> > File "/openembedded-core/meta/lib/oeqa/core/context.py", line 58, in loadTests
> > modules_required, filters)
> > File "/openembedded-core/meta/lib/oeqa/core/loader.py", line 69, in __init__
> > self.modules = _built_modules_dict(modules)
> > File "/openembedded-core/meta/lib/oeqa/core/loader.py", line 48, in _built_modules_dict
> > module_name, class_name, test_name = m.groups()
> > AttributeError: 'NoneType' object has no attribute 'groups'
> >
> > Signed-off-by: Leonardo Sandoval <leonardo.sandoval.gonzalez@linux.intel.com>
>
> LGTM and fixes [YOCTO #12385], thanks!
>
unfortunately, I found another way that this breaks ('bitbake -c testimage core-image-full-cmdline', which also uses the core loader) so there is a need for a V2.
> Acked-by: Joshua Lock <joshua.g.lock@intel.com>
>
> > ---
> > meta/lib/oeqa/core/loader.py | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/meta/lib/oeqa/core/loader.py b/meta/lib/oeqa/core/loader.py
> > index 975a081ba4..9ab4df0a60 100644
> > --- a/meta/lib/oeqa/core/loader.py
> > +++ b/meta/lib/oeqa/core/loader.py
> > @@ -43,7 +43,7 @@ def _built_modules_dict(modules):
> > for module in modules:
> > # Assumption: package and module names do not contain upper case
> > # characters, whereas class names do
> > - m = re.match(r'^([^A-Z]+)(?:\.([A-Z][^.]*)(?:\.([^.]+))?)?$', module)
> > + m = re.match(r'^([a-zA-Z]+)(?:\.([a-zA-Z][^.]*)(?:\.([^.]+))?)?$', module)
> >
> > module_name, class_name, test_name = m.groups()
> >
> >
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-12-06 15:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-05 15:51 [PATCH] core/loader.py: fix regex to include all available test cases leonardo.sandoval.gonzalez
2017-12-06 11:50 ` Joshua Lock
2017-12-06 15:58 ` Leonardo Sandoval
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.