From: Afzal Mohammed <afzal@ti.com> To: <linux-omap@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <devicetree-discuss@lists.ozlabs.org>, <linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org> Cc: Russell King <linux@arm.linux.org.uk>, Tony Lindgren <tony@atomide.com>, Marc Zyngier <marc.zyngier@arm.com>, Nicolas Pitre <nico@linaro.org>, Santosh Shilimkar <santosh.shilimkar@ti.com>, Will Deacon <will.deacon@arm.com>, Linus Walleij <linus.walleij@linaro.org>, Rob Herring <rob.herring@calxeda.com>, Grant Likely <grant.likely@secretlab.ca>, Rob Landley <rob@landley.net>, Sekhar Nori <nsekhar@ti.com>, Syed Mohammed Khasim <khasim@ti.com> Subject: [RFC 3/8] ARM: twd: clock rate from DT (if no DT clk tree) Date: Mon, 18 Feb 2013 12:00:21 +0530 [thread overview] Message-ID: <94cb377171f84ceefd667aead4602d70adab6619.1361166003.git.afzal@ti.com> (raw) In-Reply-To: <cover.1361166003.git.afzal@ti.com> Add an optional property to find clock-frequency from DT. This helps as a fallback mechanism in case there is no representation of clock tree in DT. Signed-off-by: Afzal Mohammed <afzal@ti.com> --- Documentation/devicetree/bindings/arm/twd.txt | 7 ++++++- arch/arm/kernel/smp_twd.c | 8 ++++++++ 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/arm/twd.txt b/Documentation/devicetree/bindings/arm/twd.txt index 75b8610..fdafa4f 100644 --- a/Documentation/devicetree/bindings/arm/twd.txt +++ b/Documentation/devicetree/bindings/arm/twd.txt @@ -7,8 +7,9 @@ and watchdog. The TWD is usually attached to a GIC to deliver its two per-processor interrupts. -** Timer node required properties: +** Timer node properties: +Required properties: - compatible : Should be one of: "arm,cortex-a9-twd-timer" "arm,cortex-a5-twd-timer" @@ -19,12 +20,16 @@ interrupts. - reg : Specify the base address and the size of the TWD timer register window. +Optional property: +- clock-frequency : frequency(Hz) of peripheral clock fed to timer + Example: twd-timer@2c000600 { compatible = "arm,arm11mp-twd-timer""; reg = <0x2c000600 0x20>; interrupts = <1 13 0xf01>; + clock-frequency = <300000000>; }; ** Watchdog node properties: diff --git a/arch/arm/kernel/smp_twd.c b/arch/arm/kernel/smp_twd.c index 118f4f2..aac0f9f 100644 --- a/arch/arm/kernel/smp_twd.c +++ b/arch/arm/kernel/smp_twd.c @@ -247,7 +247,15 @@ static void twd_get_clock(struct device_node *np) twd_clk = clk_get_sys("smp_twd", NULL); if (IS_ERR(twd_clk)) { + u32 freq; + pr_err("smp_twd: clock not found %d\n", (int) PTR_ERR(twd_clk)); + + /* If there is no representation of clock tree in DT, + provide a fallback option to obtain frequency + */ + if (np && !of_property_read_u32(np, "clock-frequency", &freq)) + twd_timer_rate = freq; return; } -- 1.7.12
WARNING: multiple messages have this Message-ID (diff)
From: Afzal Mohammed <afzal-l0cyMroinI0@public.gmane.org> To: linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>, Nicolas Pitre <nico-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>, Sekhar Nori <nsekhar-l0cyMroinI0@public.gmane.org>, Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>, Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>, Santosh Shilimkar <santosh.shilimkar-l0cyMroinI0@public.gmane.org>, Syed Mohammed Khasim <khasim-l0cyMroinI0@public.gmane.org> Subject: [RFC 3/8] ARM: twd: clock rate from DT (if no DT clk tree) Date: Mon, 18 Feb 2013 12:00:21 +0530 [thread overview] Message-ID: <94cb377171f84ceefd667aead4602d70adab6619.1361166003.git.afzal@ti.com> (raw) In-Reply-To: <cover.1361166003.git.afzal-l0cyMroinI0@public.gmane.org> Add an optional property to find clock-frequency from DT. This helps as a fallback mechanism in case there is no representation of clock tree in DT. Signed-off-by: Afzal Mohammed <afzal-l0cyMroinI0@public.gmane.org> --- Documentation/devicetree/bindings/arm/twd.txt | 7 ++++++- arch/arm/kernel/smp_twd.c | 8 ++++++++ 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/arm/twd.txt b/Documentation/devicetree/bindings/arm/twd.txt index 75b8610..fdafa4f 100644 --- a/Documentation/devicetree/bindings/arm/twd.txt +++ b/Documentation/devicetree/bindings/arm/twd.txt @@ -7,8 +7,9 @@ and watchdog. The TWD is usually attached to a GIC to deliver its two per-processor interrupts. -** Timer node required properties: +** Timer node properties: +Required properties: - compatible : Should be one of: "arm,cortex-a9-twd-timer" "arm,cortex-a5-twd-timer" @@ -19,12 +20,16 @@ interrupts. - reg : Specify the base address and the size of the TWD timer register window. +Optional property: +- clock-frequency : frequency(Hz) of peripheral clock fed to timer + Example: twd-timer@2c000600 { compatible = "arm,arm11mp-twd-timer""; reg = <0x2c000600 0x20>; interrupts = <1 13 0xf01>; + clock-frequency = <300000000>; }; ** Watchdog node properties: diff --git a/arch/arm/kernel/smp_twd.c b/arch/arm/kernel/smp_twd.c index 118f4f2..aac0f9f 100644 --- a/arch/arm/kernel/smp_twd.c +++ b/arch/arm/kernel/smp_twd.c @@ -247,7 +247,15 @@ static void twd_get_clock(struct device_node *np) twd_clk = clk_get_sys("smp_twd", NULL); if (IS_ERR(twd_clk)) { + u32 freq; + pr_err("smp_twd: clock not found %d\n", (int) PTR_ERR(twd_clk)); + + /* If there is no representation of clock tree in DT, + provide a fallback option to obtain frequency + */ + if (np && !of_property_read_u32(np, "clock-frequency", &freq)) + twd_timer_rate = freq; return; } -- 1.7.12
next prev parent reply other threads:[~2013-02-18 6:30 UTC|newest] Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-02-18 6:28 [RFC 0/8] ARM: AM43 (OMAP2+) boot support Afzal Mohammed 2013-02-18 6:28 ` Afzal Mohammed 2013-02-18 6:28 ` Afzal Mohammed 2013-02-18 6:30 ` [RFC 1/8] ARM: localtimer: return percpu clkevt on register Afzal Mohammed 2013-02-18 6:30 ` Afzal Mohammed 2013-02-18 6:30 ` [RFC 2/8] ARM: twd: register clock event for 1 core SMP Afzal Mohammed 2013-02-18 6:30 ` Afzal Mohammed 2013-02-18 13:47 ` Rob Herring 2013-02-18 13:47 ` Rob Herring 2013-02-18 13:47 ` Rob Herring 2013-02-19 8:00 ` Mohammed, Afzal 2013-02-19 8:00 ` Mohammed, Afzal 2013-02-19 8:00 ` Mohammed, Afzal 2013-02-18 6:30 ` Afzal Mohammed [this message] 2013-02-18 6:30 ` [RFC 3/8] ARM: twd: clock rate from DT (if no DT clk tree) Afzal Mohammed 2013-02-18 6:30 ` [RFC 4/8] ARM: am33xx: ll debug config help Afzal Mohammed 2013-02-18 6:30 ` Afzal Mohammed 2013-02-18 6:30 ` [RFC 5/8] ARM: OMAP2+: am43: Kconfig Afzal Mohammed 2013-02-18 6:30 ` Afzal Mohammed 2013-02-18 6:30 ` [RFC 6/8] ARM: OMAP2+: am43: basic dt support Afzal Mohammed 2013-02-18 6:30 ` Afzal Mohammed 2013-02-18 6:30 ` [RFC 7/8] ARM: dts: am4372: initial support Afzal Mohammed 2013-02-18 6:30 ` Afzal Mohammed 2013-02-18 6:30 ` [RFC 8/8] ARM: dts: am43-pre-silicon support Afzal Mohammed 2013-02-18 6:30 ` Afzal Mohammed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=94cb377171f84ceefd667aead4602d70adab6619.1361166003.git.afzal@ti.com \ --to=afzal@ti.com \ --cc=devicetree-discuss@lists.ozlabs.org \ --cc=grant.likely@secretlab.ca \ --cc=khasim@ti.com \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-doc@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-omap@vger.kernel.org \ --cc=linux@arm.linux.org.uk \ --cc=marc.zyngier@arm.com \ --cc=nico@linaro.org \ --cc=nsekhar@ti.com \ --cc=rob.herring@calxeda.com \ --cc=rob@landley.net \ --cc=santosh.shilimkar@ti.com \ --cc=tony@atomide.com \ --cc=will.deacon@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.