Re: [PATCH v3 08/14] memory: tegra: Enable compile testing for all drivers

[Dmitry Osipenko <digetx@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 2671 bytes --]

28.05.2021 01:30, kernel test robot пишет:
> Hi Dmitry,
> 
> I love your patch! Perhaps something to improve:
> 
> [auto build test WARNING on regulator/for-next]
> [also build test WARNING on robh/for-next v5.13-rc3 next-20210527]
> [cannot apply to tegra/for-next]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch]
> 
> url:    https://github.com/0day-ci/linux/commits/Dmitry-Osipenko/NVIDIA-Tegra-memory-and-power-management-changes-for-5-14/20210528-044947
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next
> config: mips-allyesconfig (attached as .config)
> compiler: mips-linux-gcc (GCC) 9.3.0
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # https://github.com/0day-ci/linux/commit/0e5281d15492508d5d64059f451652fd4f8969dc
>         git remote add linux-review https://github.com/0day-ci/linux
>         git fetch --no-tags linux-review Dmitry-Osipenko/NVIDIA-Tegra-memory-and-power-management-changes-for-5-14/20210528-044947
>         git checkout 0e5281d15492508d5d64059f451652fd4f8969dc
>         # save the attached .config to linux build tree
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=mips 
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> 
> All warnings (new ones prefixed by >>):
> 
>    In file included from drivers/memory/tegra/tegra210-emc-core.c:8:
>    include/linux/clk/tegra.h:220:1: error: expected identifier or '(' before '{' token
>      220 | {
>          | ^
>    In file included from drivers/memory/tegra/tegra210-emc-core.c:8:
>>> include/linux/clk/tegra.h:218:1: warning: 'tegra210_clk_emc_attach' used but never defined
>      218 | tegra210_clk_emc_attach(struct clk *clk,
>          | ^~~~~~~~~~~~~~~~~~~~~~~

Indeed, there is offending ';'. I will fix it in v5, hopefully that's the last issue with the stubs.

diff --git a/include/linux/clk/tegra.h b/include/linux/clk/tegra.h
index 5667fe7a979c..9400f0554c60 100644
--- a/include/linux/clk/tegra.h
+++ b/include/linux/clk/tegra.h
@@ -216,7 +216,7 @@ static inline int tegra210_clk_handle_mbist_war(unsigned int id)
 
 static inline int
 tegra210_clk_emc_attach(struct clk *clk,
-			struct tegra210_clk_emc_provider *provider);
+			struct tegra210_clk_emc_provider *provider)
 {
 	return 0;
 }