[Feature] Send hostname in DHCP request

* [Feature] Send hostname in DHCP request
@ 2020-07-17 14:58 Roberto Roobre Santalla
  2020-07-17 16:03 ` Denis Kenzior
  0 siblings, 1 reply; 3+ messages in thread
From: Roberto Roobre Santalla @ 2020-07-17 14:58 UTC (permalink / raw)
  To: iwd

[-- Attachment #1: Type: text/plain, Size: 1257 bytes --]

Hello,

This is my first time submitting a patch/feature request over email, I
hope I do not mess up :)

First of all, thank you for your work on iwd, I have recently started
to use it on my laptop and seems to be working very well.
I have, however, noticed that when using the built-in IP management, my
hostname was not being sent to the DHCP server. This is unfortunate
since it breaks my home network, which uses dnsmasq to build dns
records on-the-fly for hosts.

I have written and extremely simple, PoC patch which calls gethostname
and pass the returned string to the ell dhcp client.

What are your thoughts about this feature?

Regards,
- ℝ

═════════════════════════════════════
 👤 Roberto Santalla Fernández
─────────────────────────────────────
 🔑 https://keybase.io/roobre/key.asc
 🔑  0E19 86A3 593E 6226
─────────────────────────────────────
 🌍 https://roobre.es
═════════════════════════════════════


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-netconfig-Send-hostname-in-dhcp-request.patch --]
[-- Type: text/x-patch, Size: 1254 bytes --]

From f4bdd182e7d7953f5857e21ca72f39b59f0a37d0 Mon Sep 17 00:00:00 2001
From: Roberto Santalla <roobre@roobre.es>
Date: Fri, 17 Jul 2020 16:40:42 +0200
Subject: [PATCH] netconfig: Send hostname in dhcp request

---
 src/netconfig.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/src/netconfig.c b/src/netconfig.c
index 701ae38b..a05054ca 100644
--- a/src/netconfig.c
+++ b/src/netconfig.c
@@ -30,6 +30,7 @@
 #include <netinet/if_ether.h>
 #include <netinet/in.h>
 #include <linux/rtnetlink.h>
+#include <unistd.h>
 
 #include <ell/ell.h>
 
@@ -1109,6 +1110,8 @@ bool netconfig_configure(struct netconfig *netconfig,
 				const uint8_t *mac_address,
 				netconfig_notify_func_t notify, void *user_data)
 {
+	char hostname[128];
+
 	netconfig->active_settings = active_settings;
 	netconfig->notify = notify;
 	netconfig->user_data = user_data;
@@ -1116,6 +1119,10 @@ bool netconfig_configure(struct netconfig *netconfig,
 	l_dhcp_client_set_address(netconfig->dhcp_client, ARPHRD_ETHER,
 							mac_address, ETH_ALEN);
 
+	if (gethostname(hostname, 128) == 0) {
+		l_dhcp_client_set_hostname(netconfig->dhcp_client, hostname);
+	}
+
 	netconfig_ipv4_select_and_install(netconfig);
 
 	netconfig_ipv6_select_and_install(netconfig);
-- 
2.27.0


[-- Attachment #3: signature.asc --]
[-- Type: application/pgp-signature, Size: 512 bytes --]

^ permalink raw reply related	[flat|nested] 3+ messages in thread