All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] providers.py: do not skip recipes providing 'virtual/x' in world builds
@ 2022-01-01 11:29 Alexander Kanavin
  2022-01-03 22:38 ` [bitbake-devel] " Richard Purdie
  0 siblings, 1 reply; 7+ messages in thread
From: Alexander Kanavin @ 2022-01-01 11:29 UTC (permalink / raw)
  To: bitbake-devel; +Cc: Alexander Kanavin

This is very old code pre-dating 2005, and the reasons are probably lost in
history.

Doing this skipping means that anything providing 'virtual/x' is excluded
from populating packages to deploy/ in world builds, and thus, from reproducubility
and packaging tests.

This issue has been largely masked until 'package_ipk/deb/rpm: Drop recursive do_build task dependencies'
as previously recipes without virtual/x provides would pull in the dependent rpms instead of the world target
doing that directly.

I have noticed the issue by observing that go-runtime is no longer reported as
non-reproducible when it should be.

Signed-off-by: Alexander Kanavin <alex@linutronix.de>
---
 bitbake/lib/bb/providers.py | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/bitbake/lib/bb/providers.py b/bitbake/lib/bb/providers.py
index 8c1c31a5c5..3c4462fbdd 100644
--- a/bitbake/lib/bb/providers.py
+++ b/bitbake/lib/bb/providers.py
@@ -429,10 +429,6 @@ def buildWorldTargetList(dataCache, task=None):
             terminal = False
 
         for p in dataCache.pn_provides[pn]:
-            if p.startswith('virtual/'):
-                logger.debug2("World build skipping %s due to %s provider starting with virtual/", f, p)
-                terminal = False
-                break
             for pf in dataCache.providers[p]:
                 if dataCache.pkg_fn[pf] != pn:
                     logger.debug2("World build skipping %s due to both us and %s providing %s", f, pf, p)
-- 
2.20.1



^ permalink raw reply related	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2022-01-04  9:56 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-01 11:29 [PATCH] providers.py: do not skip recipes providing 'virtual/x' in world builds Alexander Kanavin
2022-01-03 22:38 ` [bitbake-devel] " Richard Purdie
2022-01-04  3:31   ` Christopher Larson
2022-01-04  7:43   ` Alexander Kanavin
     [not found]     ` <f80391bccd5070fed6d7d7196bba726459ff9146.camel@linuxfoundation.org>
2022-01-04  9:45       ` Alexander Kanavin
     [not found]       ` <16C7082A88BDA2A4.18901@lists.openembedded.org>
2022-01-04  9:56         ` Alexander Kanavin
     [not found]   ` <16C7017F7DB92566.4600@lists.openembedded.org>
2022-01-04  9:04     ` Alexander Kanavin

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.