* [PATCH net 2/2] selftest: udpgso_bench.sh explicitly requires bash
[not found] <cover.1539246206.git.pabeni@redhat.com>
@ 2018-10-11 8:54 ` Paolo Abeni
2018-10-11 8:58 ` Paolo Abeni
0 siblings, 1 reply; 2+ messages in thread
From: Paolo Abeni @ 2018-10-11 8:54 UTC (permalink / raw)
To: netdev; +Cc: David S. Miller, Florian Westphal, Willem de Bruijn
The udpgso_bench.sh script requires several bash-only features. This
may cause random failures if the default shell is not bash.
Address the above explicitly requiring bash as the script interpreter
Fixes: 3a687bef148d ("selftests: udp gso benchmark")
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
---
tools/testing/selftests/net/udpgso_bench.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/net/udpgso_bench.sh b/tools/testing/selftests/net/udpgso_bench.sh
index 850767befa47..99e537ab5ad9 100755
--- a/tools/testing/selftests/net/udpgso_bench.sh
+++ b/tools/testing/selftests/net/udpgso_bench.sh
@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/bin/bash
# SPDX-License-Identifier: GPL-2.0
#
# Run a series of udpgso benchmarks
--
2.17.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net 2/2] selftest: udpgso_bench.sh explicitly requires bash
2018-10-11 8:54 ` [PATCH net 2/2] selftest: udpgso_bench.sh explicitly requires bash Paolo Abeni
@ 2018-10-11 8:58 ` Paolo Abeni
0 siblings, 0 replies; 2+ messages in thread
From: Paolo Abeni @ 2018-10-11 8:58 UTC (permalink / raw)
To: netdev; +Cc: David S. Miller, Florian Westphal, Willem de Bruijn
On Thu, 2018-10-11 at 10:54 +0200, Paolo Abeni wrote:
> The udpgso_bench.sh script requires several bash-only features. This
> may cause random failures if the default shell is not bash.
> Address the above explicitly requiring bash as the script interpreter
> Fixes: 3a687bef148d ("selftests: udp gso benchmark")
> Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Oops... fat fingers! this is a duplicate of:
https://patchwork.ozlabs.org/patch/982350/
David, can you please drop this one from patchwork?
Thanks!
Paolo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-10-11 16:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <cover.1539246206.git.pabeni@redhat.com>
2018-10-11 8:54 ` [PATCH net 2/2] selftest: udpgso_bench.sh explicitly requires bash Paolo Abeni
2018-10-11 8:58 ` Paolo Abeni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.