All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vignesh R <vigneshr@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 03/16] spi: Add non DM version of SPI_MEM
Date: Fri, 14 Dec 2018 16:27:41 +0530	[thread overview]
Message-ID: <94eca227-9ddd-b58e-ac95-dbe148970bb2@ti.com> (raw)
In-Reply-To: <CAMty3ZCWKr+CdwjOxMvazW-Ps1psnksnNUKuo=vf5dfMyiSuFA@mail.gmail.com>

Hi,

On 14/12/18 3:32 PM, Jagan Teki wrote:
> On Thu, Dec 13, 2018 at 2:19 PM Vignesh R <vigneshr@ti.com> wrote:
>>
>>
>>
>> On 13/12/18 1:55 AM, Jagan Teki wrote:
>>> On Wed, Dec 12, 2018 at 11:08 PM Vignesh R <vigneshr@ti.com> wrote:
>>>>
>>>> Add non DM version of SPI_MEM to support easy migration to new SPI NOR
>>>> framework. This can be removed once DM_SPI conversion is complete.
>>>
>>> Our intention to use new driver to follow dm, why we need to support
>>> non-dm? any usecases?
>>>
>>
>> As said by others, AFAICS, DM_SPI migration is not going to be complete
>> anytime soon. There are many boards and configs that don't enable
>> DM_SPI. I propose you add a patch to print _warning during build_ for
>> boards that don't have DM_SPI enabled (like DM_MMC and DM_USB) targeting
>> v2019.07 or v2019.04 as deadline for removal. At the deadline you can
>> remove spi-mem-nodm.c along with all other non DM code in SPI core.
> 
> I don't understand why DM_SPI migration came to this topic? It's a
> separate thread/issue.
> 


I respectfully disagree. If DM_SPI migration was complete then SPI_MEM
would be available for use by all subsystem. This patch wouldn't have
been needed.


> Do you think any development opensource project will agree to push the
> code which may remove it in future? ie what my point here.
> 


Do you agree some code needs to be added to spi-nor layer so as not to
break non DM_SPI converted boards but make use spi-mem APIs in spi-nor?
If yes, then that code is spi-mem-nodm.c. I can rename it as
spi_mem_emulation.c or something, but that does not change the fact.

Else, are you proposing to do following in spi-nor-core like in rfc v1[1]?

#if defined(CONFIG_DM_SPI) && defined(CONFIG_SPI_MEM)
/* call spi_mem_*_ops() */
#else
/* call SPI ops like spi_xfer() etc
#endif

I am not seeing any solution here. Please have a look at spi-mem.c and
spi-nor.c interaction. What do you propose as a solution to use spi-mem
APIs but not break non DM_SPI drivers?

[1]https://patchwork.ozlabs.org/patch/1004836/

-- 
Regards
Vignesh

  reply	other threads:[~2018-12-14 10:57 UTC|newest]

Thread overview: 71+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-12 17:32 [U-Boot] [PATCH 00/16] SF: Migrate to Linux SPI NOR framework Vignesh R
2018-12-12 17:32 ` [U-Boot] [PATCH 01/16] spi: spi-mem: Allow use of spi_mem_exec_op for all SPI modes Vignesh R
2018-12-12 17:32 ` [U-Boot] [PATCH 02/16] spi-mem: Claim SPI bus before spi mem access Vignesh R
2018-12-12 17:32 ` [U-Boot] [PATCH 03/16] spi: Add non DM version of SPI_MEM Vignesh R
2018-12-12 20:25   ` Jagan Teki
2018-12-12 20:40     ` Boris Brezillon
2018-12-12 20:45       ` Jagan Teki
2018-12-12 21:02         ` Boris Brezillon
2018-12-12 21:07           ` Jagan Teki
2018-12-12 21:25             ` Boris Brezillon
2018-12-12 23:10               ` Jagan Teki
2018-12-12 23:20                 ` Tom Rini
2018-12-12 23:55                 ` Boris Brezillon
2018-12-14  9:59                   ` Jagan Teki
2019-01-04 21:28                     ` Simon Glass
2018-12-13  9:38               ` Vignesh R
2018-12-13  9:41                 ` Miquel Raynal
2018-12-13  8:50     ` Vignesh R
2018-12-14 10:02       ` Jagan Teki
2018-12-14 10:57         ` Vignesh R [this message]
2018-12-14 13:59           ` Jagan Teki
2019-01-28  6:57   ` Jagan Teki
2019-01-28  9:45     ` Vignesh R
2018-12-12 17:32 ` [U-Boot] [PATCH 04/16] sh: bitops: add hweight*() macros Vignesh R
2018-12-12 17:32 ` [U-Boot] [PATCH 05/16] mtd: spi: Port SPI NOR framework from Linux Vignesh R
2018-12-12 20:31   ` Jagan Teki
2018-12-12 22:56     ` Tom Rini
2018-12-12 23:21       ` Jagan Teki
2018-12-13  3:01         ` Tom Rini
2018-12-13  7:47           ` Stefan Roese
2018-12-13 11:44           ` Vignesh R
2018-12-12 17:32 ` [U-Boot] [PATCH 06/16] mtd: spi: Switch to new SPI NOR framework Vignesh R
2018-12-12 17:32 ` [U-Boot] [PATCH 07/16] mtd: spi: Remove unused files Vignesh R
2018-12-12 20:38   ` Jagan Teki
2018-12-13  9:07     ` Vignesh R
2018-12-12 17:32 ` [U-Boot] [PATCH 08/16] mtd: spi: Add lightweight SPI flash stack for SPL Vignesh R
2018-12-12 17:32 ` [U-Boot] [PATCH 09/16] sf_mtd: Simply mtd operations Vignesh R
2018-12-12 20:31   ` Boris Brezillon
2018-12-13  2:11   ` Daniel Schwierzeck
2018-12-13  7:46   ` Stefan Roese
2018-12-13  8:24   ` Vignesh R
2018-12-13  9:40     ` Stefan Roese
2018-12-12 17:32 ` [U-Boot] [PATCH 10/16] configs: Get rid of SPI_FLASH_BAR Vignesh R
2018-12-12 20:41   ` Jagan Teki
2018-12-12 20:51     ` Boris Brezillon
2018-12-12 20:54     ` Simon Goldschmidt
2018-12-13 10:41     ` Vignesh R
2018-12-12 17:32 ` [U-Boot] [PATCH 11/16] configs: Remove SF_DUAL_FLASH Vignesh R
2018-12-12 20:50   ` Jagan Teki
2018-12-12 17:32 ` [U-Boot] [PATCH 12/16] axm_defconfig: Enable simple malloc in SPL Vignesh R
2018-12-12 17:32 ` [U-Boot] [PATCH 13/16] taurus_defconfig: " Vignesh R
2018-12-12 17:32 ` [U-Boot] [PATCH 14/16] da850_am18xxevm: Enable tiny printf Vignesh R
2018-12-12 17:32 ` [U-Boot] [PATCH 15/16] turris_omnia_defconfig: " Vignesh R
2018-12-12 17:32 ` [U-Boot] [PATCH 16/16] MAINTAINERS: Add an entry for SPI NOR Vignesh R
2018-12-12 21:01   ` Jagan Teki
2018-12-14  8:03     ` Vignesh R
2018-12-14 10:13 ` [U-Boot] [PATCH 00/16] SF: Migrate to Linux SPI NOR framework Jagan Teki
2018-12-14 15:54   ` Vignesh R
2018-12-14 16:14     ` Simon Goldschmidt
2018-12-14 16:27       ` Vignesh R
2018-12-14 16:38         ` Simon Goldschmidt
2018-12-14 16:42           ` Vignesh R
2018-12-15 13:59             ` Jagan Teki
2018-12-15 14:42               ` Jagan Teki
2018-12-15  6:31         ` Stefan Roese
2018-12-15 13:54     ` Jagan Teki
2018-12-15 15:43       ` Vignesh R
2018-12-18 12:32         ` Jagan Teki
2018-12-18 17:19           ` Vignesh R
2018-12-21  8:55             ` Ashish Kumar
2018-12-15 15:43       ` Vignesh R

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=94eca227-9ddd-b58e-ac95-dbe148970bb2@ti.com \
    --to=vigneshr@ti.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.