All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Andreas Färber" <afaerber@suse.de>
To: Andrew Lunn <andrew@lunn.ch>
Cc: netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	"Uwe Kleine-König" <uwe@kleine-koenig.org>,
	"Michal Hrusecki" <Michal.Hrusecky@nic.cz>,
	"Tomas Hlavacek" <tomas.hlavacek@nic.cz>,
	"Bed??icha Ko??atu" <bedrich.kosata@nic.cz>,
	"Vivien Didelot" <vivien.didelot@savoirfairelinux.com>,
	"Florian Fainelli" <f.fainelli@gmail.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] net: dsa: mv88e6xxx: Add 88E6176 device tree support
Date: Sun, 27 Nov 2016 22:50:22 +0100	[thread overview]
Message-ID: <9500470d-09c3-3ecb-994b-3d108bffc99e@suse.de> (raw)
In-Reply-To: <20161127212709.GD13318@lunn.ch>

Am 27.11.2016 um 22:27 schrieb Andrew Lunn:
> On Sun, Nov 27, 2016 at 09:57:59PM +0100, Andreas Färber wrote:
>> This model is found on the Turris Omnia.
> 
> This driver already supports nearly 30 different Marvell switch
> models. Please document why the marvell,mv88e6176 is special and why
> it needs its own compatible string when the others don't.

I don't understand.

The commit message above already points out for which device this is
(and you also know from the LAKML thread).

You as driver author should know that the .data pointer is vital to your
driver - you even recently accepted another model that conflicted with
my patch. So are you arguing for a ", which uses a Device Tree for
booting" half-sentence here?

The others not having an entry simply means no one needed them yet.

And any Turris Omnia side changes need to go through the mvebu tree.

Regards,
Andreas

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)

WARNING: multiple messages have this Message-ID (diff)
From: "Andreas Färber" <afaerber@suse.de>
To: Andrew Lunn <andrew@lunn.ch>
Cc: "Florian Fainelli" <f.fainelli@gmail.com>,
	"Michal Hrusecki" <Michal.Hrusecky@nic.cz>,
	"Uwe Kleine-König" <uwe@kleine-koenig.org>,
	"Vivien Didelot" <vivien.didelot@savoirfairelinux.com>,
	netdev@vger.kernel.org, "Tomas Hlavacek" <tomas.hlavacek@nic.cz>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	"Bed??icha Ko??atu" <bedrich.kosata@nic.cz>
Subject: Re: [PATCH 2/2] net: dsa: mv88e6xxx: Add 88E6176 device tree support
Date: Sun, 27 Nov 2016 22:50:22 +0100	[thread overview]
Message-ID: <9500470d-09c3-3ecb-994b-3d108bffc99e@suse.de> (raw)
In-Reply-To: <20161127212709.GD13318@lunn.ch>

Am 27.11.2016 um 22:27 schrieb Andrew Lunn:
> On Sun, Nov 27, 2016 at 09:57:59PM +0100, Andreas Färber wrote:
>> This model is found on the Turris Omnia.
> 
> This driver already supports nearly 30 different Marvell switch
> models. Please document why the marvell,mv88e6176 is special and why
> it needs its own compatible string when the others don't.

I don't understand.

The commit message above already points out for which device this is
(and you also know from the LAKML thread).

You as driver author should know that the .data pointer is vital to your
driver - you even recently accepted another model that conflicted with
my patch. So are you arguing for a ", which uses a Device Tree for
booting" half-sentence here?

The others not having an entry simply means no one needed them yet.

And any Turris Omnia side changes need to go through the mvebu tree.

Regards,
Andreas

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)

WARNING: multiple messages have this Message-ID (diff)
From: afaerber@suse.de (Andreas Färber)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] net: dsa: mv88e6xxx: Add 88E6176 device tree support
Date: Sun, 27 Nov 2016 22:50:22 +0100	[thread overview]
Message-ID: <9500470d-09c3-3ecb-994b-3d108bffc99e@suse.de> (raw)
In-Reply-To: <20161127212709.GD13318@lunn.ch>

Am 27.11.2016 um 22:27 schrieb Andrew Lunn:
> On Sun, Nov 27, 2016 at 09:57:59PM +0100, Andreas F?rber wrote:
>> This model is found on the Turris Omnia.
> 
> This driver already supports nearly 30 different Marvell switch
> models. Please document why the marvell,mv88e6176 is special and why
> it needs its own compatible string when the others don't.

I don't understand.

The commit message above already points out for which device this is
(and you also know from the LAKML thread).

You as driver author should know that the .data pointer is vital to your
driver - you even recently accepted another model that conflicted with
my patch. So are you arguing for a ", which uses a Device Tree for
booting" half-sentence here?

The others not having an entry simply means no one needed them yet.

And any Turris Omnia side changes need to go through the mvebu tree.

Regards,
Andreas

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany
GF: Felix Imend?rffer, Jane Smithard, Graham Norton
HRB 21284 (AG N?rnberg)

  reply	other threads:[~2016-11-27 21:51 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-27 20:57 [PATCH 1/2] Documentation: net: dsa: marvell: Add 88E6176 Andreas Färber
2016-11-27 20:57 ` Andreas Färber
2016-11-27 20:57 ` Andreas Färber
2016-11-27 20:57 ` [PATCH 2/2] net: dsa: mv88e6xxx: Add 88E6176 device tree support Andreas Färber
2016-11-27 20:57   ` Andreas Färber
2016-11-27 21:27   ` Andrew Lunn
2016-11-27 21:27     ` Andrew Lunn
2016-11-27 21:50     ` Andreas Färber [this message]
2016-11-27 21:50       ` Andreas Färber
2016-11-27 21:50       ` Andreas Färber
2016-11-27 22:08       ` Andrew Lunn
2016-11-27 22:08         ` Andrew Lunn
2016-11-27 22:42         ` Andreas Färber
2016-11-27 22:42           ` Andreas Färber
2016-11-27 23:10           ` Andrew Lunn
2016-11-27 23:10             ` Andrew Lunn
2016-11-28  8:09             ` Uwe Kleine-König
2016-11-28  8:09               ` Uwe Kleine-König
2016-11-28 13:17               ` Andrew Lunn
2016-11-28 13:17                 ` Andrew Lunn
2016-11-28 13:17                 ` Andrew Lunn
2016-11-28 15:44                 ` Uwe Kleine-König
2016-11-28 15:44                   ` Uwe Kleine-König
2016-11-28 15:44                   ` Uwe Kleine-König
2016-11-28 16:14                   ` Andrew Lunn
2016-11-28 16:14                     ` Andrew Lunn
2016-11-28 16:14                     ` Andrew Lunn
2016-11-29 17:54                   ` Vivien Didelot
2016-11-29 17:54                     ` Vivien Didelot
2016-11-29 18:20                     ` Andrew Lunn
2016-11-29 18:20                       ` Andrew Lunn
2016-11-29 18:20                       ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9500470d-09c3-3ecb-994b-3d108bffc99e@suse.de \
    --to=afaerber@suse.de \
    --cc=Michal.Hrusecky@nic.cz \
    --cc=andrew@lunn.ch \
    --cc=bedrich.kosata@nic.cz \
    --cc=f.fainelli@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=tomas.hlavacek@nic.cz \
    --cc=uwe@kleine-koenig.org \
    --cc=vivien.didelot@savoirfairelinux.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.