[Buildroot] [PATCH v2 1/1] openssh: add support for HW SSL engines

[Buildroot] [PATCH v2 1/1] openssh: add support for HW SSL engines

[Gilad Ben-Yossef]

Enable support for OpenSSH to use a hardware SSL engine if
cryptodev-linux is included. Without this, OpenSSH uses only
OpenSSL software crypto implementation.

Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
CC: Baruch Siach <baruch@tkos.co.il>
CC: Arnout Vandecappelle <arnout@mind.be>
---

Changes from v1:
Incorporated style feedback from Baruch and Arnout.

 package/openssh/openssh.mk | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/package/openssh/openssh.mk b/package/openssh/openssh.mk
index f971e99..7e197b0 100644
--- a/package/openssh/openssh.mk
+++ b/package/openssh/openssh.mk
@@ -28,6 +28,13 @@ endif
 
 OPENSSH_DEPENDENCIES = zlib openssl
 
+ifeq ($(BR2_PACKAGE_CRYPTODEV_LINUX),y)
+OPENSSH_DEPENDENCIES += cryptodev-linux
+OPENSSH_CONF_OPTS += --with-ssl-engine
+else
+OPENSSH_CONF_OPTS += --without-ssl-engine
+endif
+
 ifeq ($(BR2_PACKAGE_LINUX_PAM),y)
 define OPENSSH_INSTALL_PAM_CONF
 	$(INSTALL) -D -m 644 $(@D)/contrib/sshd.pam.generic $(TARGET_DIR)/etc/pam.d/sshd
-- 
2.1.4

[Buildroot] [PATCH v2 1/1] openssh: add support for HW SSL engines

[Arnout Vandecappelle]

On 18-04-17 15:03, Gilad Ben-Yossef wrote:
> Enable support for OpenSSH to use a hardware SSL engine if
> cryptodev-linux is included. Without this, OpenSSH uses only
> OpenSSL software crypto implementation.

 You should have also explained that you haven't tested OCF, but OK.

Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

 Regards,
 Arnout

> 
> Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
> CC: Baruch Siach <baruch@tkos.co.il>
> CC: Arnout Vandecappelle <arnout@mind.be>
> ---
> 
> Changes from v1:
> Incorporated style feedback from Baruch and Arnout.
> 
>  package/openssh/openssh.mk | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/package/openssh/openssh.mk b/package/openssh/openssh.mk
> index f971e99..7e197b0 100644
> --- a/package/openssh/openssh.mk
> +++ b/package/openssh/openssh.mk
> @@ -28,6 +28,13 @@ endif
>  
>  OPENSSH_DEPENDENCIES = zlib openssl
>  
> +ifeq ($(BR2_PACKAGE_CRYPTODEV_LINUX),y)
> +OPENSSH_DEPENDENCIES += cryptodev-linux
> +OPENSSH_CONF_OPTS += --with-ssl-engine
> +else
> +OPENSSH_CONF_OPTS += --without-ssl-engine
> +endif
> +
>  ifeq ($(BR2_PACKAGE_LINUX_PAM),y)
>  define OPENSSH_INSTALL_PAM_CONF
>  	$(INSTALL) -D -m 644 $(@D)/contrib/sshd.pam.generic $(TARGET_DIR)/etc/pam.d/sshd
> 

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

[Buildroot] [PATCH v2 1/1] openssh: add support for HW SSL engines

[Peter Korsgaard]

>>>>> "Gilad" == Gilad Ben-Yossef <gilad@benyossef.com> writes:

 > Enable support for OpenSSH to use a hardware SSL engine if
 > cryptodev-linux is included. Without this, OpenSSH uses only
 > OpenSSL software crypto implementation.

 > Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
 > CC: Baruch Siach <baruch@tkos.co.il>
 > CC: Arnout Vandecappelle <arnout@mind.be>
 > ---

 > Changes from v1:
 > Incorporated style feedback from Baruch and Arnout.

Committed, thanks.

-- 
Bye, Peter Korsgaard