* [Intel-gfx] [PATCH] drm/i915/guc: Expand guc_info debugfs with more information
@ 2020-07-01 14:27 Michał Winiarski
2020-07-01 15:10 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
` (3 more replies)
0 siblings, 4 replies; 7+ messages in thread
From: Michał Winiarski @ 2020-07-01 14:27 UTC (permalink / raw)
To: intel-gfx; +Cc: Michał Winiarski
From: Michał Winiarski <michal.winiarski@intel.com>
The information about platform/driver/user view of GuC firmware usage
currently requires user to either go through kernel log or parse the
combination of "enable_guc" modparam and various debugfs entries.
Let's keep things simple and add a "supported/used/wanted" matrix
(already used internally by i915) in guc_info debugfs.
Signed-off-by: Michał Winiarski <michal.winiarski@intel.com>
Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Cc: Lukasz Fiedorowicz <lukasz.fiedorowicz@intel.com>
Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
---
drivers/gpu/drm/i915/gt/uc/intel_guc.c | 23 ++++++++++++++++-------
1 file changed, 16 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc.c b/drivers/gpu/drm/i915/gt/uc/intel_guc.c
index 861657897c0f..446a41946f56 100644
--- a/drivers/gpu/drm/i915/gt/uc/intel_guc.c
+++ b/drivers/gpu/drm/i915/gt/uc/intel_guc.c
@@ -733,19 +733,28 @@ int intel_guc_allocate_and_map_vma(struct intel_guc *guc, u32 size,
*/
void intel_guc_load_status(struct intel_guc *guc, struct drm_printer *p)
{
+ struct intel_uc *uc = container_of(guc, struct intel_uc, guc);
struct intel_gt *gt = guc_to_gt(guc);
struct intel_uncore *uncore = gt->uncore;
intel_wakeref_t wakeref;
- if (!intel_guc_is_supported(guc)) {
- drm_printf(p, "GuC not supported\n");
+ drm_printf(p, "[guc] supported:%s wanted:%s used:%s\n",
+ yesno(intel_uc_supports_guc(uc)),
+ yesno(intel_uc_wants_guc(uc)),
+ yesno(intel_uc_uses_guc(uc)));
+ drm_printf(p, "[huc] supported:%s wanted:%s used:%s\n",
+ yesno(intel_uc_supports_huc(uc)),
+ yesno(intel_uc_wants_huc(uc)),
+ yesno(intel_uc_uses_huc(uc)));
+ drm_printf(p, "[submission] supported:%s wanted:%s used:%s\n",
+ yesno(intel_uc_supports_guc_submission(uc)),
+ yesno(intel_uc_wants_guc_submission(uc)),
+ yesno(intel_uc_uses_guc_submission(uc)));
+
+ if (!intel_guc_is_supported(guc) || !intel_guc_is_wanted(guc))
return;
- }
- if (!intel_guc_is_wanted(guc)) {
- drm_printf(p, "GuC disabled\n");
- return;
- }
+ drm_puts(p, "\n");
intel_uc_fw_dump(&guc->fw, p);
--
2.27.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/guc: Expand guc_info debugfs with more information
2020-07-01 14:27 [Intel-gfx] [PATCH] drm/i915/guc: Expand guc_info debugfs with more information Michał Winiarski
@ 2020-07-01 15:10 ` Patchwork
2020-07-01 16:45 ` [Intel-gfx] [PATCH] " Daniele Ceraolo Spurio
` (2 subsequent siblings)
3 siblings, 0 replies; 7+ messages in thread
From: Patchwork @ 2020-07-01 15:10 UTC (permalink / raw)
To: Michał Winiarski; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/guc: Expand guc_info debugfs with more information
URL : https://patchwork.freedesktop.org/series/78997/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8686 -> Patchwork_18058
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18058/index.html
Known issues
------------
Here are the changes found in Patchwork_18058 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_pm_backlight@basic-brightness:
- fi-whl-u: [PASS][1] -> [DMESG-WARN][2] ([i915#95])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8686/fi-whl-u/igt@i915_pm_backlight@basic-brightness.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18058/fi-whl-u/igt@i915_pm_backlight@basic-brightness.html
* igt@i915_pm_rpm@basic-pci-d3-state:
- fi-bsw-kefka: [PASS][3] -> [DMESG-WARN][4] ([i915#1982])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8686/fi-bsw-kefka/igt@i915_pm_rpm@basic-pci-d3-state.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18058/fi-bsw-kefka/igt@i915_pm_rpm@basic-pci-d3-state.html
* igt@kms_flip@basic-flip-vs-wf_vblank@c-edp1:
- fi-icl-u2: [PASS][5] -> [DMESG-WARN][6] ([i915#1982]) +1 similar issue
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8686/fi-icl-u2/igt@kms_flip@basic-flip-vs-wf_vblank@c-edp1.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18058/fi-icl-u2/igt@kms_flip@basic-flip-vs-wf_vblank@c-edp1.html
#### Possible fixes ####
* igt@i915_pm_rpm@module-reload:
- fi-glk-dsi: [DMESG-WARN][7] ([i915#1982]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8686/fi-glk-dsi/igt@i915_pm_rpm@module-reload.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18058/fi-glk-dsi/igt@i915_pm_rpm@module-reload.html
* igt@kms_busy@basic@flip:
- fi-kbl-x1275: [DMESG-WARN][9] ([i915#62] / [i915#92] / [i915#95]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8686/fi-kbl-x1275/igt@kms_busy@basic@flip.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18058/fi-kbl-x1275/igt@kms_busy@basic@flip.html
#### Warnings ####
* igt@debugfs_test@read_all_entries:
- fi-kbl-x1275: [DMESG-WARN][11] ([i915#62] / [i915#92]) -> [DMESG-WARN][12] ([i915#62] / [i915#92] / [i915#95])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8686/fi-kbl-x1275/igt@debugfs_test@read_all_entries.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18058/fi-kbl-x1275/igt@debugfs_test@read_all_entries.html
* igt@i915_pm_rpm@module-reload:
- fi-kbl-x1275: [DMESG-FAIL][13] ([i915#62]) -> [SKIP][14] ([fdo#109271])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8686/fi-kbl-x1275/igt@i915_pm_rpm@module-reload.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18058/fi-kbl-x1275/igt@i915_pm_rpm@module-reload.html
* igt@kms_flip@basic-flip-vs-wf_vblank@a-dp1:
- fi-kbl-x1275: [DMESG-WARN][15] ([i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][16] ([i915#62] / [i915#92]) +7 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8686/fi-kbl-x1275/igt@kms_flip@basic-flip-vs-wf_vblank@a-dp1.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18058/fi-kbl-x1275/igt@kms_flip@basic-flip-vs-wf_vblank@a-dp1.html
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
[i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (42 -> 37)
------------------------------
Additional (2): fi-cml-u2 fi-tgl-u2
Missing (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper fi-bdw-samus
Build changes
-------------
* Linux: CI_DRM_8686 -> Patchwork_18058
CI-20190529: 20190529
CI_DRM_8686: 7ac6088487e9ffebed115a6447371087b07b784c @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5718: af1ef32bfae90bcdbaf1b5d84c61ff4e04368505 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_18058: 3bdb63a31053743687af9e08ad0432835b7bbeb7 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
3bdb63a31053 drm/i915/guc: Expand guc_info debugfs with more information
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18058/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/guc: Expand guc_info debugfs with more information
2020-07-01 14:27 [Intel-gfx] [PATCH] drm/i915/guc: Expand guc_info debugfs with more information Michał Winiarski
2020-07-01 15:10 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
@ 2020-07-01 16:45 ` Daniele Ceraolo Spurio
2020-07-06 14:10 ` Michał Winiarski
2020-07-01 16:46 ` Fiedorowicz, Lukasz
2020-07-01 22:06 ` [Intel-gfx] ✓ Fi.CI.IGT: success for " Patchwork
3 siblings, 1 reply; 7+ messages in thread
From: Daniele Ceraolo Spurio @ 2020-07-01 16:45 UTC (permalink / raw)
To: Michał Winiarski, intel-gfx; +Cc: Michał Winiarski
On 7/1/2020 7:27 AM, Michał Winiarski wrote:
> From: Michał Winiarski <michal.winiarski@intel.com>
>
> The information about platform/driver/user view of GuC firmware usage
> currently requires user to either go through kernel log or parse the
> combination of "enable_guc" modparam and various debugfs entries.
> Let's keep things simple and add a "supported/used/wanted" matrix
> (already used internally by i915) in guc_info debugfs.
>
> Signed-off-by: Michał Winiarski <michal.winiarski@intel.com>
> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
> Cc: Lukasz Fiedorowicz <lukasz.fiedorowicz@intel.com>
> Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
> ---
> drivers/gpu/drm/i915/gt/uc/intel_guc.c | 23 ++++++++++++++++-------
> 1 file changed, 16 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc.c b/drivers/gpu/drm/i915/gt/uc/intel_guc.c
> index 861657897c0f..446a41946f56 100644
> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc.c
> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc.c
> @@ -733,19 +733,28 @@ int intel_guc_allocate_and_map_vma(struct intel_guc *guc, u32 size,
> */
> void intel_guc_load_status(struct intel_guc *guc, struct drm_printer *p)
> {
> + struct intel_uc *uc = container_of(guc, struct intel_uc, guc);
> struct intel_gt *gt = guc_to_gt(guc);
> struct intel_uncore *uncore = gt->uncore;
> intel_wakeref_t wakeref;
>
> - if (!intel_guc_is_supported(guc)) {
> - drm_printf(p, "GuC not supported\n");
> + drm_printf(p, "[guc] supported:%s wanted:%s used:%s\n",
> + yesno(intel_uc_supports_guc(uc)),
> + yesno(intel_uc_wants_guc(uc)),
> + yesno(intel_uc_uses_guc(uc)));
There are intel_guc equivalents for there uc functions, so we can use
those and avoid the intel_uc var if we ditch the HuC (see comment below):
intel_guc_is_supported
intel_guc_is_wanted
intel_guc_is_used
Same for the others.
> + drm_printf(p, "[huc] supported:%s wanted:%s used:%s\n",
> + yesno(intel_uc_supports_huc(uc)),
> + yesno(intel_uc_wants_huc(uc)),
> + yesno(intel_uc_uses_huc(uc)));
The HuC view should go to the huc_info debugfs
> + drm_printf(p, "[submission] supported:%s wanted:%s used:%s\n",
> + yesno(intel_uc_supports_guc_submission(uc)),
> + yesno(intel_uc_wants_guc_submission(uc)),
> + yesno(intel_uc_uses_guc_submission(uc)));
> +
> + if (!intel_guc_is_supported(guc) || !intel_guc_is_wanted(guc))
intel_guc_is_wanted implies intel_guc_is_supported so you can
potentially test only that, but I agree that having both is clearer to read.
Daniele
> return;
> - }
>
> - if (!intel_guc_is_wanted(guc)) {
> - drm_printf(p, "GuC disabled\n");
> - return;
> - }
> + drm_puts(p, "\n");
>
> intel_uc_fw_dump(&guc->fw, p);
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/guc: Expand guc_info debugfs with more information
2020-07-01 14:27 [Intel-gfx] [PATCH] drm/i915/guc: Expand guc_info debugfs with more information Michał Winiarski
2020-07-01 15:10 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2020-07-01 16:45 ` [Intel-gfx] [PATCH] " Daniele Ceraolo Spurio
@ 2020-07-01 16:46 ` Fiedorowicz, Lukasz
2020-07-01 22:06 ` [Intel-gfx] ✓ Fi.CI.IGT: success for " Patchwork
3 siblings, 0 replies; 7+ messages in thread
From: Fiedorowicz, Lukasz @ 2020-07-01 16:46 UTC (permalink / raw)
To: intel-gfx, michal; +Cc: Winiarski, Michal
On Wed, 2020-07-01 at 16:27 +0200, Michał Winiarski wrote:
> From: Michał Winiarski <michal.winiarski@intel.com>
>
> The information about platform/driver/user view of GuC firmware usage
> currently requires user to either go through kernel log or parse the
> combination of "enable_guc" modparam and various debugfs entries.
> Let's keep things simple and add a "supported/used/wanted" matrix
> (already used internally by i915) in guc_info debugfs.
>
> Signed-off-by: Michał Winiarski <michal.winiarski@intel.com>
LGTM
Reviewed-by: Lukasz Fiedorowicz <lukasz.fiedorowicz@intel.com>
> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
> Cc: Lukasz Fiedorowicz <lukasz.fiedorowicz@intel.com>
> Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
> ---
> drivers/gpu/drm/i915/gt/uc/intel_guc.c | 23 ++++++++++++++++-------
> 1 file changed, 16 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc.c
> b/drivers/gpu/drm/i915/gt/uc/intel_guc.c
> index 861657897c0f..446a41946f56 100644
> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc.c
> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc.c
> @@ -733,19 +733,28 @@ int intel_guc_allocate_and_map_vma(struct
> intel_guc *guc, u32 size,
> */
> void intel_guc_load_status(struct intel_guc *guc, struct drm_printer
> *p)
> {
> + struct intel_uc *uc = container_of(guc, struct intel_uc, guc);
> struct intel_gt *gt = guc_to_gt(guc);
> struct intel_uncore *uncore = gt->uncore;
> intel_wakeref_t wakeref;
>
> - if (!intel_guc_is_supported(guc)) {
> - drm_printf(p, "GuC not supported\n");
> + drm_printf(p, "[guc] supported:%s wanted:%s used:%s\n",
> + yesno(intel_uc_supports_guc(uc)),
> + yesno(intel_uc_wants_guc(uc)),
> + yesno(intel_uc_uses_guc(uc)));
> + drm_printf(p, "[huc] supported:%s wanted:%s used:%s\n",
> + yesno(intel_uc_supports_huc(uc)),
> + yesno(intel_uc_wants_huc(uc)),
> + yesno(intel_uc_uses_huc(uc)));
> + drm_printf(p, "[submission] supported:%s wanted:%s used:%s\n",
> + yesno(intel_uc_supports_guc_submission(uc)),
> + yesno(intel_uc_wants_guc_submission(uc)),
> + yesno(intel_uc_uses_guc_submission(uc)));
> +
> + if (!intel_guc_is_supported(guc) || !intel_guc_is_wanted(guc))
> return;
> - }
>
> - if (!intel_guc_is_wanted(guc)) {
> - drm_printf(p, "GuC disabled\n");
> - return;
> - }
> + drm_puts(p, "\n");
>
> intel_uc_fw_dump(&guc->fw, p);
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/guc: Expand guc_info debugfs with more information
2020-07-01 14:27 [Intel-gfx] [PATCH] drm/i915/guc: Expand guc_info debugfs with more information Michał Winiarski
` (2 preceding siblings ...)
2020-07-01 16:46 ` Fiedorowicz, Lukasz
@ 2020-07-01 22:06 ` Patchwork
3 siblings, 0 replies; 7+ messages in thread
From: Patchwork @ 2020-07-01 22:06 UTC (permalink / raw)
To: Michał Winiarski; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/guc: Expand guc_info debugfs with more information
URL : https://patchwork.freedesktop.org/series/78997/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8686_full -> Patchwork_18058_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_18058_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_fenced_exec_thrash@no-spare-fences-interruptible:
- shard-snb: [PASS][1] -> [TIMEOUT][2] ([i915#1958] / [i915#2119]) +3 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8686/shard-snb2/igt@gem_fenced_exec_thrash@no-spare-fences-interruptible.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18058/shard-snb6/igt@gem_fenced_exec_thrash@no-spare-fences-interruptible.html
* igt@gem_mmap_gtt@ptrace:
- shard-apl: [PASS][3] -> [DMESG-WARN][4] ([i915#1635] / [i915#95]) +17 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8686/shard-apl1/igt@gem_mmap_gtt@ptrace.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18058/shard-apl2/igt@gem_mmap_gtt@ptrace.html
* igt@i915_selftest@mock@requests:
- shard-snb: [PASS][5] -> [INCOMPLETE][6] ([i915#2110] / [i915#82])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8686/shard-snb6/igt@i915_selftest@mock@requests.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18058/shard-snb5/igt@i915_selftest@mock@requests.html
* igt@kms_big_fb@linear-64bpp-rotate-180:
- shard-glk: [PASS][7] -> [DMESG-FAIL][8] ([i915#118] / [i915#95])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8686/shard-glk5/igt@kms_big_fb@linear-64bpp-rotate-180.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18058/shard-glk8/igt@kms_big_fb@linear-64bpp-rotate-180.html
* igt@kms_cursor_crc@pipe-b-cursor-64x64-random:
- shard-kbl: [PASS][9] -> [DMESG-WARN][10] ([i915#93] / [i915#95]) +3 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8686/shard-kbl4/igt@kms_cursor_crc@pipe-b-cursor-64x64-random.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18058/shard-kbl7/igt@kms_cursor_crc@pipe-b-cursor-64x64-random.html
* igt@kms_cursor_crc@pipe-b-cursor-suspend:
- shard-skl: [PASS][11] -> [INCOMPLETE][12] ([i915#300])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8686/shard-skl6/igt@kms_cursor_crc@pipe-b-cursor-suspend.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18058/shard-skl6/igt@kms_cursor_crc@pipe-b-cursor-suspend.html
* igt@kms_draw_crc@draw-method-xrgb2101010-blt-untiled:
- shard-glk: [PASS][13] -> [DMESG-WARN][14] ([i915#1982])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8686/shard-glk9/igt@kms_draw_crc@draw-method-xrgb2101010-blt-untiled.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18058/shard-glk3/igt@kms_draw_crc@draw-method-xrgb2101010-blt-untiled.html
* igt@kms_flip@flip-vs-expired-vblank@c-edp1:
- shard-skl: [PASS][15] -> [FAIL][16] ([i915#79])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8686/shard-skl6/igt@kms_flip@flip-vs-expired-vblank@c-edp1.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18058/shard-skl6/igt@kms_flip@flip-vs-expired-vblank@c-edp1.html
* igt@kms_flip@flip-vs-suspend-interruptible@b-hdmi-a1:
- shard-hsw: [PASS][17] -> [INCOMPLETE][18] ([i915#2055])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8686/shard-hsw4/igt@kms_flip@flip-vs-suspend-interruptible@b-hdmi-a1.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18058/shard-hsw4/igt@kms_flip@flip-vs-suspend-interruptible@b-hdmi-a1.html
* igt@kms_flip@flip-vs-suspend@c-dp1:
- shard-kbl: [PASS][19] -> [DMESG-WARN][20] ([i915#180]) +7 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8686/shard-kbl7/igt@kms_flip@flip-vs-suspend@c-dp1.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18058/shard-kbl4/igt@kms_flip@flip-vs-suspend@c-dp1.html
* igt@kms_flip@modeset-vs-vblank-race-interruptible@a-dp1:
- shard-kbl: [PASS][21] -> [DMESG-WARN][22] ([i915#1982])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8686/shard-kbl2/igt@kms_flip@modeset-vs-vblank-race-interruptible@a-dp1.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18058/shard-kbl1/igt@kms_flip@modeset-vs-vblank-race-interruptible@a-dp1.html
* igt@kms_flip@plain-flip-fb-recreate@a-edp1:
- shard-skl: [PASS][23] -> [FAIL][24] ([i915#1928])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8686/shard-skl6/igt@kms_flip@plain-flip-fb-recreate@a-edp1.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18058/shard-skl6/igt@kms_flip@plain-flip-fb-recreate@a-edp1.html
* igt@kms_frontbuffer_tracking@fbcpsr-modesetfrombusy:
- shard-tglb: [PASS][25] -> [DMESG-WARN][26] ([i915#1982]) +3 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8686/shard-tglb6/igt@kms_frontbuffer_tracking@fbcpsr-modesetfrombusy.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18058/shard-tglb8/igt@kms_frontbuffer_tracking@fbcpsr-modesetfrombusy.html
* igt@kms_hdr@bpc-switch-dpms:
- shard-skl: [PASS][27] -> [FAIL][28] ([i915#1188]) +1 similar issue
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8686/shard-skl7/igt@kms_hdr@bpc-switch-dpms.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18058/shard-skl3/igt@kms_hdr@bpc-switch-dpms.html
* igt@kms_plane_alpha_blend@pipe-a-coverage-7efc:
- shard-skl: [PASS][29] -> [FAIL][30] ([fdo#108145] / [i915#265])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8686/shard-skl6/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18058/shard-skl4/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html
* igt@kms_plane_cursor@pipe-a-primary-size-128:
- shard-snb: [PASS][31] -> [SKIP][32] ([fdo#109271])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8686/shard-snb1/igt@kms_plane_cursor@pipe-a-primary-size-128.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18058/shard-snb2/igt@kms_plane_cursor@pipe-a-primary-size-128.html
* igt@kms_prime@basic-crc@second-to-first:
- shard-kbl: [PASS][33] -> [DMESG-FAIL][34] ([i915#95])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8686/shard-kbl3/igt@kms_prime@basic-crc@second-to-first.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18058/shard-kbl6/igt@kms_prime@basic-crc@second-to-first.html
* igt@kms_vblank@pipe-b-query-idle:
- shard-skl: [PASS][35] -> [DMESG-WARN][36] ([i915#1982]) +11 similar issues
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8686/shard-skl4/igt@kms_vblank@pipe-b-query-idle.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18058/shard-skl8/igt@kms_vblank@pipe-b-query-idle.html
* igt@kms_vblank@pipe-c-wait-idle:
- shard-apl: [PASS][37] -> [DMESG-WARN][38] ([i915#1982])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8686/shard-apl6/igt@kms_vblank@pipe-c-wait-idle.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18058/shard-apl4/igt@kms_vblank@pipe-c-wait-idle.html
* igt@perf_pmu@module-unload:
- shard-iclb: [PASS][39] -> [DMESG-WARN][40] ([i915#1982])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8686/shard-iclb8/igt@perf_pmu@module-unload.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18058/shard-iclb5/igt@perf_pmu@module-unload.html
#### Possible fixes ####
* igt@gem_ctx_persistence@processes:
- shard-skl: [FAIL][41] ([i915#1528]) -> [PASS][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8686/shard-skl8/igt@gem_ctx_persistence@processes.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18058/shard-skl8/igt@gem_ctx_persistence@processes.html
* igt@gen9_exec_parse@allowed-all:
- shard-apl: [DMESG-WARN][43] ([i915#1436] / [i915#716]) -> [PASS][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8686/shard-apl3/igt@gen9_exec_parse@allowed-all.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18058/shard-apl3/igt@gen9_exec_parse@allowed-all.html
* igt@kms_addfb_basic@addfb25-modifier-no-flag:
- shard-kbl: [DMESG-WARN][45] ([i915#93] / [i915#95]) -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8686/shard-kbl6/igt@kms_addfb_basic@addfb25-modifier-no-flag.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18058/shard-kbl2/igt@kms_addfb_basic@addfb25-modifier-no-flag.html
* igt@kms_big_fb@y-tiled-64bpp-rotate-180:
- shard-glk: [DMESG-FAIL][47] ([i915#118] / [i915#95]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8686/shard-glk8/igt@kms_big_fb@y-tiled-64bpp-rotate-180.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18058/shard-glk5/igt@kms_big_fb@y-tiled-64bpp-rotate-180.html
* igt@kms_cursor_crc@pipe-a-cursor-128x128-random:
- shard-skl: [FAIL][49] ([i915#54]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8686/shard-skl2/igt@kms_cursor_crc@pipe-a-cursor-128x128-random.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18058/shard-skl2/igt@kms_cursor_crc@pipe-a-cursor-128x128-random.html
* igt@kms_flip@flip-vs-suspend-interruptible@a-dp1:
- shard-kbl: [DMESG-WARN][51] ([i915#180]) -> [PASS][52] +8 similar issues
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8686/shard-kbl1/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18058/shard-kbl6/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-pgflip-blt:
- shard-iclb: [DMESG-WARN][53] ([i915#1982]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8686/shard-iclb3/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-pgflip-blt.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18058/shard-iclb8/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-pgflip-blt.html
* igt@kms_frontbuffer_tracking@fbcpsr-tiling-y:
- shard-tglb: [DMESG-WARN][55] ([i915#1982]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8686/shard-tglb8/igt@kms_frontbuffer_tracking@fbcpsr-tiling-y.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18058/shard-tglb3/igt@kms_frontbuffer_tracking@fbcpsr-tiling-y.html
* igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min:
- shard-skl: [FAIL][57] ([fdo#108145] / [i915#265]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8686/shard-skl2/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18058/shard-skl2/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min.html
* igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
- shard-skl: [DMESG-WARN][59] ([i915#1982]) -> [PASS][60] +10 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8686/shard-skl4/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18058/shard-skl8/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
* igt@kms_psr@no_drrs:
- shard-iclb: [FAIL][61] ([i915#173]) -> [PASS][62]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8686/shard-iclb1/igt@kms_psr@no_drrs.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18058/shard-iclb5/igt@kms_psr@no_drrs.html
* igt@kms_psr@psr2_cursor_mmap_gtt:
- shard-iclb: [SKIP][63] ([fdo#109441]) -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8686/shard-iclb3/igt@kms_psr@psr2_cursor_mmap_gtt.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18058/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_gtt.html
* igt@kms_setmode@basic:
- shard-snb: [FAIL][65] ([i915#31]) -> [PASS][66]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8686/shard-snb1/igt@kms_setmode@basic.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18058/shard-snb2/igt@kms_setmode@basic.html
* igt@kms_vblank@pipe-a-query-idle-hang:
- shard-apl: [DMESG-WARN][67] ([i915#1982]) -> [PASS][68] +1 similar issue
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8686/shard-apl4/igt@kms_vblank@pipe-a-query-idle-hang.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18058/shard-apl6/igt@kms_vblank@pipe-a-query-idle-hang.html
* igt@perf@blocking:
- shard-glk: [DMESG-WARN][69] ([i915#118] / [i915#95]) -> [PASS][70]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8686/shard-glk6/igt@perf@blocking.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18058/shard-glk9/igt@perf@blocking.html
* igt@perf@blocking-parameterized:
- shard-iclb: [FAIL][71] ([i915#1542]) -> [PASS][72]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8686/shard-iclb4/igt@perf@blocking-parameterized.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18058/shard-iclb6/igt@perf@blocking-parameterized.html
* igt@perf@invalid-oa-metric-set-id:
- shard-apl: [DMESG-WARN][73] ([i915#1635] / [i915#95]) -> [PASS][74] +18 similar issues
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8686/shard-apl8/igt@perf@invalid-oa-metric-set-id.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18058/shard-apl7/igt@perf@invalid-oa-metric-set-id.html
#### Warnings ####
* igt@gem_exec_reloc@basic-concurrent16:
- shard-snb: [FAIL][75] ([i915#1930]) -> [TIMEOUT][76] ([i915#1958] / [i915#2119])
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8686/shard-snb2/igt@gem_exec_reloc@basic-concurrent16.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18058/shard-snb6/igt@gem_exec_reloc@basic-concurrent16.html
* igt@kms_color_chamelium@pipe-a-ctm-max:
- shard-apl: [SKIP][77] ([fdo#109271] / [fdo#111827]) -> [SKIP][78] ([fdo#109271] / [fdo#111827] / [i915#1635])
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8686/shard-apl8/igt@kms_color_chamelium@pipe-a-ctm-max.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18058/shard-apl7/igt@kms_color_chamelium@pipe-a-ctm-max.html
* igt@kms_color_chamelium@pipe-b-ctm-0-75:
- shard-apl: [SKIP][79] ([fdo#109271] / [fdo#111827] / [i915#1635]) -> [SKIP][80] ([fdo#109271] / [fdo#111827])
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8686/shard-apl1/igt@kms_color_chamelium@pipe-b-ctm-0-75.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18058/shard-apl2/igt@kms_color_chamelium@pipe-b-ctm-0-75.html
* igt@kms_content_protection@srm:
- shard-kbl: [TIMEOUT][81] ([i915#1319] / [i915#1958] / [i915#2119]) -> [TIMEOUT][82] ([i915#1319] / [i915#2119])
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8686/shard-kbl3/igt@kms_content_protection@srm.html
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18058/shard-kbl6/igt@kms_content_protection@srm.html
* igt@kms_draw_crc@draw-method-rgb565-mmap-gtt-ytiled:
- shard-snb: [SKIP][83] ([fdo#109271]) -> [TIMEOUT][84] ([i915#1958] / [i915#2119]) +1 similar issue
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8686/shard-snb2/igt@kms_draw_crc@draw-method-rgb565-mmap-gtt-ytiled.html
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18058/shard-snb6/igt@kms_draw_crc@draw-method-rgb565-mmap-gtt-ytiled.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-cur-indfb-draw-mmap-wc:
- shard-apl: [SKIP][85] ([fdo#109271]) -> [SKIP][86] ([fdo#109271] / [i915#1635]) +9 similar issues
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8686/shard-apl8/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-cur-indfb-draw-mmap-wc.html
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18058/shard-apl4/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-cur-indfb-draw-mmap-wc.html
* igt@kms_frontbuffer_tracking@psr-1p-rte:
- shard-apl: [SKIP][87] ([fdo#109271] / [i915#1635]) -> [SKIP][88] ([fdo#109271]) +5 similar issues
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8686/shard-apl8/igt@kms_frontbuffer_tracking@psr-1p-rte.html
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18058/shard-apl4/igt@kms_frontbuffer_tracking@psr-1p-rte.html
* igt@perf_pmu@module-unload:
- shard-tglb: [DMESG-WARN][89] ([i915#1982]) -> [DMESG-WARN][90] ([i915#402])
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8686/shard-tglb2/igt@perf_pmu@module-unload.html
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18058/shard-tglb1/igt@perf_pmu@module-unload.html
* igt@runner@aborted:
- shard-apl: ([FAIL][91], [FAIL][92], [FAIL][93]) ([fdo#109271] / [i915#1610] / [i915#1635] / [i915#716]) -> [FAIL][94] ([i915#1635])
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8686/shard-apl4/igt@runner@aborted.html
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8686/shard-apl1/igt@runner@aborted.html
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8686/shard-apl3/igt@runner@aborted.html
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18058/shard-apl6/igt@runner@aborted.html
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#1319]: https://gitlab.freedesktop.org/drm/intel/issues/1319
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#1528]: https://gitlab.freedesktop.org/drm/intel/issues/1528
[i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542
[i915#1610]: https://gitlab.freedesktop.org/drm/intel/issues/1610
[i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635
[i915#173]: https://gitlab.freedesktop.org/drm/intel/issues/173
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1928]: https://gitlab.freedesktop.org/drm/intel/issues/1928
[i915#1930]: https://gitlab.freedesktop.org/drm/intel/issues/1930
[i915#1958]: https://gitlab.freedesktop.org/drm/intel/issues/1958
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2055]: https://gitlab.freedesktop.org/drm/intel/issues/2055
[i915#2110]: https://gitlab.freedesktop.org/drm/intel/issues/2110
[i915#2119]: https://gitlab.freedesktop.org/drm/intel/issues/2119
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#300]: https://gitlab.freedesktop.org/drm/intel/issues/300
[i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
[i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
[i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#82]: https://gitlab.freedesktop.org/drm/intel/issues/82
[i915#93]: https://gitlab.freedesktop.org/drm/intel/issues/93
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Build changes
-------------
* Linux: CI_DRM_8686 -> Patchwork_18058
CI-20190529: 20190529
CI_DRM_8686: 7ac6088487e9ffebed115a6447371087b07b784c @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5718: af1ef32bfae90bcdbaf1b5d84c61ff4e04368505 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_18058: 3bdb63a31053743687af9e08ad0432835b7bbeb7 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18058/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/guc: Expand guc_info debugfs with more information
2020-07-01 16:45 ` [Intel-gfx] [PATCH] " Daniele Ceraolo Spurio
@ 2020-07-06 14:10 ` Michał Winiarski
2020-07-06 14:30 ` Daniele Ceraolo Spurio
0 siblings, 1 reply; 7+ messages in thread
From: Michał Winiarski @ 2020-07-06 14:10 UTC (permalink / raw)
To: Daniele Ceraolo Spurio, intel-gfx; +Cc: Michał Winiarski
Quoting Daniele Ceraolo Spurio (2020-07-01 18:45:52)
>
>
> On 7/1/2020 7:27 AM, Michał Winiarski wrote:
> > From: Michał Winiarski <michal.winiarski@intel.com>
> >
> > The information about platform/driver/user view of GuC firmware usage
> > currently requires user to either go through kernel log or parse the
> > combination of "enable_guc" modparam and various debugfs entries.
> > Let's keep things simple and add a "supported/used/wanted" matrix
> > (already used internally by i915) in guc_info debugfs.
> >
> > Signed-off-by: Michał Winiarski <michal.winiarski@intel.com>
> > Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
> > Cc: Lukasz Fiedorowicz <lukasz.fiedorowicz@intel.com>
> > Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
> > ---
> > drivers/gpu/drm/i915/gt/uc/intel_guc.c | 23 ++++++++++++++++-------
> > 1 file changed, 16 insertions(+), 7 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc.c b/drivers/gpu/drm/i915/gt/uc/intel_guc.c
> > index 861657897c0f..446a41946f56 100644
> > --- a/drivers/gpu/drm/i915/gt/uc/intel_guc.c
> > +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc.c
> > @@ -733,19 +733,28 @@ int intel_guc_allocate_and_map_vma(struct intel_guc *guc, u32 size,
> > */
> > void intel_guc_load_status(struct intel_guc *guc, struct drm_printer *p)
> > {
> > + struct intel_uc *uc = container_of(guc, struct intel_uc, guc);
> > struct intel_gt *gt = guc_to_gt(guc);
> > struct intel_uncore *uncore = gt->uncore;
> > intel_wakeref_t wakeref;
> >
> > - if (!intel_guc_is_supported(guc)) {
> > - drm_printf(p, "GuC not supported\n");
> > + drm_printf(p, "[guc] supported:%s wanted:%s used:%s\n",
> > + yesno(intel_uc_supports_guc(uc)),
> > + yesno(intel_uc_wants_guc(uc)),
> > + yesno(intel_uc_uses_guc(uc)));
>
> There are intel_guc equivalents for there uc functions, so we can use
> those and avoid the intel_uc var if we ditch the HuC (see comment below):
>
> intel_guc_is_supported
> intel_guc_is_wanted
> intel_guc_is_used
>
> Same for the others.
>
> > + drm_printf(p, "[huc] supported:%s wanted:%s used:%s\n",
> > + yesno(intel_uc_supports_huc(uc)),
> > + yesno(intel_uc_wants_huc(uc)),
> > + yesno(intel_uc_uses_huc(uc)));
>
> The HuC view should go to the huc_info debugfs
This was intentional. For HuC the "wants" part is controlled by "enable_guc",
and it's actually helpful to see that "guc is used because the user/platform
wants huc", all in the single "cat guc_info".
In other words - this is still (at least partially) GuC view :)
So, given the above, do you still think we should move it to huc_info?
-Michał
>
> > + drm_printf(p, "[submission] supported:%s wanted:%s used:%s\n",
> > + yesno(intel_uc_supports_guc_submission(uc)),
> > + yesno(intel_uc_wants_guc_submission(uc)),
> > + yesno(intel_uc_uses_guc_submission(uc)));
> > +
> > + if (!intel_guc_is_supported(guc) || !intel_guc_is_wanted(guc))
>
> intel_guc_is_wanted implies intel_guc_is_supported so you can
> potentially test only that, but I agree that having both is clearer to read.
>
> Daniele
>
> > return;
> > - }
> >
> > - if (!intel_guc_is_wanted(guc)) {
> > - drm_printf(p, "GuC disabled\n");
> > - return;
> > - }
> > + drm_puts(p, "\n");
> >
> > intel_uc_fw_dump(&guc->fw, p);
> >
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/guc: Expand guc_info debugfs with more information
2020-07-06 14:10 ` Michał Winiarski
@ 2020-07-06 14:30 ` Daniele Ceraolo Spurio
0 siblings, 0 replies; 7+ messages in thread
From: Daniele Ceraolo Spurio @ 2020-07-06 14:30 UTC (permalink / raw)
To: Michał Winiarski, intel-gfx; +Cc: Michał Winiarski
On 7/6/2020 7:10 AM, Michał Winiarski wrote:
> Quoting Daniele Ceraolo Spurio (2020-07-01 18:45:52)
>>
>> On 7/1/2020 7:27 AM, Michał Winiarski wrote:
>>> From: Michał Winiarski <michal.winiarski@intel.com>
>>>
>>> The information about platform/driver/user view of GuC firmware usage
>>> currently requires user to either go through kernel log or parse the
>>> combination of "enable_guc" modparam and various debugfs entries.
>>> Let's keep things simple and add a "supported/used/wanted" matrix
>>> (already used internally by i915) in guc_info debugfs.
>>>
>>> Signed-off-by: Michał Winiarski <michal.winiarski@intel.com>
>>> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
>>> Cc: Lukasz Fiedorowicz <lukasz.fiedorowicz@intel.com>
>>> Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
>>> ---
>>> drivers/gpu/drm/i915/gt/uc/intel_guc.c | 23 ++++++++++++++++-------
>>> 1 file changed, 16 insertions(+), 7 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc.c b/drivers/gpu/drm/i915/gt/uc/intel_guc.c
>>> index 861657897c0f..446a41946f56 100644
>>> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc.c
>>> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc.c
>>> @@ -733,19 +733,28 @@ int intel_guc_allocate_and_map_vma(struct intel_guc *guc, u32 size,
>>> */
>>> void intel_guc_load_status(struct intel_guc *guc, struct drm_printer *p)
>>> {
>>> + struct intel_uc *uc = container_of(guc, struct intel_uc, guc);
>>> struct intel_gt *gt = guc_to_gt(guc);
>>> struct intel_uncore *uncore = gt->uncore;
>>> intel_wakeref_t wakeref;
>>>
>>> - if (!intel_guc_is_supported(guc)) {
>>> - drm_printf(p, "GuC not supported\n");
>>> + drm_printf(p, "[guc] supported:%s wanted:%s used:%s\n",
>>> + yesno(intel_uc_supports_guc(uc)),
>>> + yesno(intel_uc_wants_guc(uc)),
>>> + yesno(intel_uc_uses_guc(uc)));
>> There are intel_guc equivalents for there uc functions, so we can use
>> those and avoid the intel_uc var if we ditch the HuC (see comment below):
>>
>> intel_guc_is_supported
>> intel_guc_is_wanted
>> intel_guc_is_used
>>
>> Same for the others.
>>
>>> + drm_printf(p, "[huc] supported:%s wanted:%s used:%s\n",
>>> + yesno(intel_uc_supports_huc(uc)),
>>> + yesno(intel_uc_wants_huc(uc)),
>>> + yesno(intel_uc_uses_huc(uc)));
>> The HuC view should go to the huc_info debugfs
> This was intentional. For HuC the "wants" part is controlled by "enable_guc",
> and it's actually helpful to see that "guc is used because the user/platform
> wants huc", all in the single "cat guc_info".
> In other words - this is still (at least partially) GuC view :)
>
> So, given the above, do you still think we should move it to huc_info?
Ok, I see where you're coming from. For things that touch both GuC and
HuC we usually go for the uC notation, so IMO a new uc-level file would
be more appropriate here (e.g. gt/uc/usage).
However, if you have a reason to capture this in a single file with
other GuC-related details I'm ok if we stick to guc_info.
Daniele
> -Michał
>
>>> + drm_printf(p, "[submission] supported:%s wanted:%s used:%s\n",
>>> + yesno(intel_uc_supports_guc_submission(uc)),
>>> + yesno(intel_uc_wants_guc_submission(uc)),
>>> + yesno(intel_uc_uses_guc_submission(uc)));
>>> +
>>> + if (!intel_guc_is_supported(guc) || !intel_guc_is_wanted(guc))
>> intel_guc_is_wanted implies intel_guc_is_supported so you can
>> potentially test only that, but I agree that having both is clearer to read.
>>
>> Daniele
>>
>>> return;
>>> - }
>>>
>>> - if (!intel_guc_is_wanted(guc)) {
>>> - drm_printf(p, "GuC disabled\n");
>>> - return;
>>> - }
>>> + drm_puts(p, "\n");
>>>
>>> intel_uc_fw_dump(&guc->fw, p);
>>>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-07-06 14:31 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-01 14:27 [Intel-gfx] [PATCH] drm/i915/guc: Expand guc_info debugfs with more information Michał Winiarski
2020-07-01 15:10 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2020-07-01 16:45 ` [Intel-gfx] [PATCH] " Daniele Ceraolo Spurio
2020-07-06 14:10 ` Michał Winiarski
2020-07-06 14:30 ` Daniele Ceraolo Spurio
2020-07-01 16:46 ` Fiedorowicz, Lukasz
2020-07-01 22:06 ` [Intel-gfx] ✓ Fi.CI.IGT: success for " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.