All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Linus Walleij <linus.walleij@linaro.org>,
	YueHaibing <yuehaibing@huawei.com>
Cc: airlied@linux.ie, daniel@ffwll.ch, tzimmermann@suse.de,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2 -next] drm/display: Fix build error without CONFIG_OF
Date: Mon, 23 May 2022 15:57:14 +0300	[thread overview]
Message-ID: <9534934e-4c4a-ba2f-3bc3-d6d241e625bb@linaro.org> (raw)
In-Reply-To: <CACRpkdaKrk+cj9Yvpe3kmR1iJFczi-yckHiKeLGu9F=hRFiU9w@mail.gmail.com>

On 23/05/2022 15:54, Linus Walleij wrote:
> On Mon, May 23, 2022 at 2:46 PM Linus Walleij <linus.walleij@linaro.org> wrote:
>> On Fri, May 6, 2022 at 2:33 PM YueHaibing <yuehaibing@huawei.com> wrote:
>>
>>> While CONFIG_OF is n but COMPILE_TEST is y, we got this:
>>>
>>> WARNING: unmet direct dependencies detected for DRM_DP_AUX_BUS
>>>    Depends on [n]: HAS_IOMEM [=y] && DRM [=y] && OF [=n]
>>>    Selected by [y]:
>>>    - DRM_MSM [=y] && HAS_IOMEM [=y] && DRM [=y] && (ARCH_QCOM || SOC_IMX5 || COMPILE_TEST [=y]) && COMMON_CLK [=y] && IOMMU_SUPPORT [=y] && (QCOM_OCMEM [=n] || QCOM_OCMEM [=n]=n) && (QCOM_LLCC [=y] || QCOM_LLCC [=y]=n) && (QCOM_COMMAND_DB [=n] || QCOM_COMMAND_DB [=n]=n)
>>>
>>> Make DRM_DP_AUX_BUS depends on OF || COMPILE_TEST to fix this warning.
>>>
>>> Fixes: f5d01644921b ("drm/msm: select DRM_DP_AUX_BUS for the AUX bus support")
>>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>>
>> Patch applied to the DRM tree.
> 
> Nope, failed:
> 
> $ dim push-branch drm-misc-next
> dim: ac890b9eeb9b ("drm/display: Fix build error without CONFIG_OF"):
> Fixes: SHA1 in not pointing at an ancestor:
> dim:     f5d01644921b ("drm/msm: select DRM_DP_AUX_BUS for the AUX bus support")
> dim: ERROR: issues in commits detected, aborting
> 
> I don't know what to do with this, sorry. The other committers are maybe better
> with this kind of situations. I think it is designed to stop me from
> shooting myself
> in the foot.

It 'Fixes' a commit in the drm/msm tree, however a fix is not 
msm-specific. We can push it out through the drm/msm, but we'd need an 
ack from drm/core.

-- 
With best wishes
Dmitry

WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Linus Walleij <linus.walleij@linaro.org>,
	YueHaibing <yuehaibing@huawei.com>
Cc: airlied@linux.ie, dri-devel@lists.freedesktop.org,
	tzimmermann@suse.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 -next] drm/display: Fix build error without CONFIG_OF
Date: Mon, 23 May 2022 15:57:14 +0300	[thread overview]
Message-ID: <9534934e-4c4a-ba2f-3bc3-d6d241e625bb@linaro.org> (raw)
In-Reply-To: <CACRpkdaKrk+cj9Yvpe3kmR1iJFczi-yckHiKeLGu9F=hRFiU9w@mail.gmail.com>

On 23/05/2022 15:54, Linus Walleij wrote:
> On Mon, May 23, 2022 at 2:46 PM Linus Walleij <linus.walleij@linaro.org> wrote:
>> On Fri, May 6, 2022 at 2:33 PM YueHaibing <yuehaibing@huawei.com> wrote:
>>
>>> While CONFIG_OF is n but COMPILE_TEST is y, we got this:
>>>
>>> WARNING: unmet direct dependencies detected for DRM_DP_AUX_BUS
>>>    Depends on [n]: HAS_IOMEM [=y] && DRM [=y] && OF [=n]
>>>    Selected by [y]:
>>>    - DRM_MSM [=y] && HAS_IOMEM [=y] && DRM [=y] && (ARCH_QCOM || SOC_IMX5 || COMPILE_TEST [=y]) && COMMON_CLK [=y] && IOMMU_SUPPORT [=y] && (QCOM_OCMEM [=n] || QCOM_OCMEM [=n]=n) && (QCOM_LLCC [=y] || QCOM_LLCC [=y]=n) && (QCOM_COMMAND_DB [=n] || QCOM_COMMAND_DB [=n]=n)
>>>
>>> Make DRM_DP_AUX_BUS depends on OF || COMPILE_TEST to fix this warning.
>>>
>>> Fixes: f5d01644921b ("drm/msm: select DRM_DP_AUX_BUS for the AUX bus support")
>>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>>
>> Patch applied to the DRM tree.
> 
> Nope, failed:
> 
> $ dim push-branch drm-misc-next
> dim: ac890b9eeb9b ("drm/display: Fix build error without CONFIG_OF"):
> Fixes: SHA1 in not pointing at an ancestor:
> dim:     f5d01644921b ("drm/msm: select DRM_DP_AUX_BUS for the AUX bus support")
> dim: ERROR: issues in commits detected, aborting
> 
> I don't know what to do with this, sorry. The other committers are maybe better
> with this kind of situations. I think it is designed to stop me from
> shooting myself
> in the foot.

It 'Fixes' a commit in the drm/msm tree, however a fix is not 
msm-specific. We can push it out through the drm/msm, but we'd need an 
ack from drm/core.

-- 
With best wishes
Dmitry

  reply	other threads:[~2022-05-23 12:57 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-06 12:32 [PATCH v2 -next] drm/display: Fix build error without CONFIG_OF YueHaibing
2022-05-06 12:32 ` YueHaibing
2022-05-06 13:01 ` Dmitry Baryshkov
2022-05-06 13:01   ` Dmitry Baryshkov
2022-05-06 15:52 ` Abhinav Kumar
2022-05-06 15:52   ` Abhinav Kumar
2022-05-21  2:43 ` YueHaibing
2022-05-21  2:43   ` YueHaibing
2022-05-23 12:46 ` Linus Walleij
2022-05-23 12:46   ` Linus Walleij
2022-05-23 12:54   ` Linus Walleij
2022-05-23 12:54     ` Linus Walleij
2022-05-23 12:57     ` Dmitry Baryshkov [this message]
2022-05-23 12:57       ` Dmitry Baryshkov
2022-05-25 13:36     ` Dmitry Baryshkov
2022-05-25 13:36       ` Dmitry Baryshkov
2022-05-26 20:08       ` Linus Walleij
2022-05-26 20:08         ` Linus Walleij
2022-05-27  9:56         ` Dmitry Baryshkov
2022-05-27  9:56           ` Dmitry Baryshkov
2022-05-26 15:02     ` Dmitry Baryshkov
2022-05-26 15:02       ` Dmitry Baryshkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9534934e-4c4a-ba2f-3bc3-d6d241e625bb@linaro.org \
    --to=dmitry.baryshkov@linaro.org \
    --cc=airlied@linux.ie \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tzimmermann@suse.de \
    --cc=yuehaibing@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.