From: Christophe Leroy <christophe.leroy@csgroup.eu>
To: Michael Ellerman <mpe@ellerman.id.au>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Cc: "mike.kravetz@oracle.com" <mike.kravetz@oracle.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"aneesh.kumar@linux.ibm.com" <aneesh.kumar@linux.ibm.com>
Subject: Re: [PATCH 1/2] powerpc/mm/64s: Drop pgd_huge()
Date: Sat, 3 Sep 2022 15:06:27 +0000 [thread overview]
Message-ID: <9534a2bd-57d7-400c-500b-4a591dbb3fbc@csgroup.eu> (raw)
In-Reply-To: <20220903123640.719846-1-mpe@ellerman.id.au>
Le 03/09/2022 à 14:36, Michael Ellerman a écrit :
...
>
> However in commit ba95b5d03596 ("powerpc/mm/book3s/64: Rework page table
> geometry for lower memory usage") the page table layout was reworked to
> shrink the size of the PGD.
>
> As a result the 16GB page size now fits at the PUD level when using 64K
> base page size.
>
> Therefore there are no longer any supported configurations where
> pgd_huge() can be true, so drop the definitions for pgd_huge(), and
> fallback to the generic definition which is always false.
We also have pgd_huge defined as always false in:
arch/powerpc/include/asm/page.h
arch/powerpc/include/asm/nohash/pgtable.h
Those could be removed as well as there is a default definition in
include/linux/hugetlb.h
And then all uses of pgd_huge() in the core mm can be dropped because
powerpc was the only user.
Christophe
WARNING: multiple messages have this Message-ID (diff)
From: Christophe Leroy <christophe.leroy@csgroup.eu>
To: Michael Ellerman <mpe@ellerman.id.au>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
"aneesh.kumar@linux.ibm.com" <aneesh.kumar@linux.ibm.com>,
"mike.kravetz@oracle.com" <mike.kravetz@oracle.com>
Subject: Re: [PATCH 1/2] powerpc/mm/64s: Drop pgd_huge()
Date: Sat, 3 Sep 2022 15:06:27 +0000 [thread overview]
Message-ID: <9534a2bd-57d7-400c-500b-4a591dbb3fbc@csgroup.eu> (raw)
In-Reply-To: <20220903123640.719846-1-mpe@ellerman.id.au>
Le 03/09/2022 à 14:36, Michael Ellerman a écrit :
...
>
> However in commit ba95b5d03596 ("powerpc/mm/book3s/64: Rework page table
> geometry for lower memory usage") the page table layout was reworked to
> shrink the size of the PGD.
>
> As a result the 16GB page size now fits at the PUD level when using 64K
> base page size.
>
> Therefore there are no longer any supported configurations where
> pgd_huge() can be true, so drop the definitions for pgd_huge(), and
> fallback to the generic definition which is always false.
We also have pgd_huge defined as always false in:
arch/powerpc/include/asm/page.h
arch/powerpc/include/asm/nohash/pgtable.h
Those could be removed as well as there is a default definition in
include/linux/hugetlb.h
And then all uses of pgd_huge() in the core mm can be dropped because
powerpc was the only user.
Christophe
next prev parent reply other threads:[~2022-09-03 15:06 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-03 12:36 [PATCH 1/2] powerpc/mm/64s: Drop pgd_huge() Michael Ellerman
2022-09-03 12:36 ` Michael Ellerman
2022-09-03 12:36 ` [PATCH 2/2] powerpc/mm/64s: Drop p4d_leaf() Michael Ellerman
2022-09-03 12:36 ` Michael Ellerman
2022-09-03 15:11 ` Christophe Leroy
2022-09-03 15:11 ` Christophe Leroy
2022-09-04 11:32 ` Michael Ellerman
2022-09-04 11:32 ` Michael Ellerman
2022-09-04 16:57 ` Aneesh Kumar K.V
2022-09-04 16:57 ` Aneesh Kumar K.V
2022-09-03 15:06 ` Christophe Leroy [this message]
2022-09-03 15:06 ` [PATCH 1/2] powerpc/mm/64s: Drop pgd_huge() Christophe Leroy
2022-09-04 11:24 ` Michael Ellerman
2022-09-04 11:24 ` Michael Ellerman
2022-09-04 16:57 ` Aneesh Kumar K.V
2022-09-04 16:57 ` Aneesh Kumar K.V
2022-10-04 13:24 ` Michael Ellerman
2022-10-04 13:24 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9534a2bd-57d7-400c-500b-4a591dbb3fbc@csgroup.eu \
--to=christophe.leroy@csgroup.eu \
--cc=aneesh.kumar@linux.ibm.com \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mike.kravetz@oracle.com \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.