* "mlx4_en: Enabling new steering" brokenness
@ 2011-07-28 21:04 Roland Dreier
[not found] ` <1311887099-14339-1-git-send-email-roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
0 siblings, 1 reply; 2+ messages in thread
From: Roland Dreier @ 2011-07-28 21:04 UTC (permalink / raw)
To: Yevgeny Petrilin
Cc: netdev-u79uwXL29TY76Z2rM5mHXA, linux-rdma-u79uwXL29TY76Z2rM5mHXA
Hi Yevgeny!
So I have a system with an mlx4_en device with pretty old FW (version
2.7.700), old enough that the firmware doesn't have the capability
MLX4_DEV_CAP_FLAG_VEP_UC_STEER set. And it looks like mlx4_en is
completely broken in this case, at least since your commit
1679200f91da ("mlx4_en: Enabling new steering"). If I try to bring up
the interface, I just see:
mlx4_en: eth1: Failed to allocate RSS indirection QP
And this is failing because the QPN in 0.
The problem is in drivers/net/mlx4/port.c:mlx4_register_mac():
if (!(dev->caps.flags & MLX4_DEV_CAP_FLAG_VEP_UC_STEER))
*qpn = info->base_qpn + free;
but absolutely nothing ever initializes info->base_qpn. It looks like
the intention of the code is to initialize this in
mlx4_init_port_info(); however even the below hack doesn't seem to fix
things completely -- I still seem to have problems on the RX side
unless I enable promiscuous mode by running tcpdump:
diff --git a/drivers/net/mlx4/main.c b/drivers/net/mlx4/main.c
index c94b342..38092c7 100644
--- a/drivers/net/mlx4/main.c
+++ b/drivers/net/mlx4/main.c
@@ -1125,6 +1125,13 @@ static int mlx4_init_port_info(struct mlx4_dev *dev, int port)
info->port_attr.store = set_port_type;
sysfs_attr_init(&info->port_attr.attr);
+ err = mlx4_qp_reserve_range(dev, 1, 1, &info->base_qpn);
+ if (err) {
+ mlx4_err(dev, "Failed to reserve QP range for port %d\n", port);
+ info->port = -1;
+ return err;
+ }
+
err = device_create_file(&dev->pdev->dev, &info->port_attr);
if (err) {
mlx4_err(dev, "Failed to create file for port %d\n", port);
Could you take a look at getting this working? (Or update the driver
so it immediately fails with an informative message if you want to
rely on certain FW versions; and then strip out the old broken
compatibility code)
Thanks!
Roland
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 2+ messages in thread
* RE: "mlx4_en: Enabling new steering" brokenness
[not found] ` <1311887099-14339-1-git-send-email-roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
@ 2011-07-29 4:34 ` Yevgeny Petrilin
0 siblings, 0 replies; 2+ messages in thread
From: Yevgeny Petrilin @ 2011-07-29 4:34 UTC (permalink / raw)
To: Roland Dreier
Cc: netdev-u79uwXL29TY76Z2rM5mHXA, linux-rdma-u79uwXL29TY76Z2rM5mHXA
Hello Roland,
I'll check this ASAP.
Thanks,
Yevgeny
> -----Original Message-----
> From: Roland Dreier [mailto:roland-BHEL68pLQRGGvPXPguhicg@public.gmane.org] On Behalf Of Roland
> Dreier
> Sent: Friday, July 29, 2011 12:05 AM
> To: Yevgeny Petrilin
> Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> Subject: "mlx4_en: Enabling new steering" brokenness
>
> Hi Yevgeny!
>
> So I have a system with an mlx4_en device with pretty old FW (version
> 2.7.700), old enough that the firmware doesn't have the capability
> MLX4_DEV_CAP_FLAG_VEP_UC_STEER set. And it looks like mlx4_en is
> completely broken in this case, at least since your commit
> 1679200f91da ("mlx4_en: Enabling new steering"). If I try to bring up
> the interface, I just see:
>
> mlx4_en: eth1: Failed to allocate RSS indirection QP
>
> And this is failing because the QPN in 0.
>
> The problem is in drivers/net/mlx4/port.c:mlx4_register_mac():
>
> if (!(dev->caps.flags & MLX4_DEV_CAP_FLAG_VEP_UC_STEER))
> *qpn = info->base_qpn + free;
>
> but absolutely nothing ever initializes info->base_qpn. It looks like
> the intention of the code is to initialize this in
> mlx4_init_port_info(); however even the below hack doesn't seem to fix
> things completely -- I still seem to have problems on the RX side
> unless I enable promiscuous mode by running tcpdump:
>
> diff --git a/drivers/net/mlx4/main.c b/drivers/net/mlx4/main.c
> index c94b342..38092c7 100644
> --- a/drivers/net/mlx4/main.c
> +++ b/drivers/net/mlx4/main.c
> @@ -1125,6 +1125,13 @@ static int mlx4_init_port_info(struct mlx4_dev
> *dev, int port)
> info->port_attr.store = set_port_type;
> sysfs_attr_init(&info->port_attr.attr);
>
> + err = mlx4_qp_reserve_range(dev, 1, 1, &info->base_qpn);
> + if (err) {
> + mlx4_err(dev, "Failed to reserve QP range for port %d\n",
> port);
> + info->port = -1;
> + return err;
> + }
> +
> err = device_create_file(&dev->pdev->dev, &info->port_attr);
> if (err) {
> mlx4_err(dev, "Failed to create file for port %d\n", port);
>
> Could you take a look at getting this working? (Or update the driver
> so it immediately fails with an informative message if you want to
> rely on certain FW versions; and then strip out the old broken
> compatibility code)
>
> Thanks!
> Roland
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-07-29 4:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-07-28 21:04 "mlx4_en: Enabling new steering" brokenness Roland Dreier
[not found] ` <1311887099-14339-1-git-send-email-roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2011-07-29 4:34 ` Yevgeny Petrilin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.