[PATCH] imx28-xea: Add missing imx28-lwe.dtsi

[PATCH] imx28-xea: Add missing imx28-lwe.dtsi

[Fabio Estevam]

From: Fabio Estevam <festevam@denx.de>

The following build error is seen when building imx28_xea_defconfig:

arch/arm/dts/.imx28-xea.dtb.pre.tmp:8:10: fatal error: imx28-lwe.dtsi: No such file or directory

This happens because commit ebcca534f557 ("imx28: synchronise device tree
with linux") missed to import the imx28-lwe.dtsi file from Linux.

Fix it by importing the file from Linux 6.1-rc1.

Fixes: ebcca534f557 ("imx28: synchronise device tree with linux")
Signed-off-by: Fabio Estevam <festevam@denx.de>
---
This applies against u-boot-imx master-next branch.

 arch/arm/dts/imx28-lwe.dtsi | 170 ++++++++++++++++++++++++++++++++++++
 1 file changed, 170 insertions(+)
 create mode 100644 arch/arm/dts/imx28-lwe.dtsi

diff --git a/arch/arm/dts/imx28-lwe.dtsi b/arch/arm/dts/imx28-lwe.dtsi
new file mode 100644
index 000000000000..bb971e660db8
--- /dev/null
+++ b/arch/arm/dts/imx28-lwe.dtsi
@@ -0,0 +1,170 @@
+// SPDX-License-Identifier: GPL-2.0-or-later OR MIT
+/*
+ * Copyright 2021
+ * Lukasz Majewski, DENX Software Engineering, lukma@denx.de
+ */
+
+/dts-v1/;
+#include "imx28.dtsi"
+
+/ {
+	aliases {
+		spi2 = &ssp3;
+	};
+
+	chosen {
+		bootargs = "root=/dev/mmcblk0p2 rootfstype=ext4 ro rootwait console=ttyAMA0,115200 panic=1";
+	};
+
+	memory@40000000 {
+		reg = <0x40000000 0x08000000>;
+	};
+
+	reg_3v3: regulator-reg-3v3 {
+		compatible = "regulator-fixed";
+		regulator-name = "3V3";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+	};
+
+	reg_usb_5v: regulator-reg-usb-5v {
+		compatible = "regulator-fixed";
+		regulator-name = "usb_vbus";
+		regulator-min-microvolt = <5000000>;
+		regulator-max-microvolt = <5000000>;
+	};
+
+	reg_fec_3v3: regulator-reg-fec-3v3 {
+		compatible = "regulator-fixed";
+		regulator-name = "fec-phy";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+	};
+};
+
+&duart {
+	pinctrl-names = "default";
+	pinctrl-0 = <&duart_pins_a>;
+	status = "okay";
+};
+
+&i2c0 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&i2c0_pins_a>;
+	status = "okay";
+};
+
+&saif0 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&saif0_pins_a>;
+	#sound-dai-cells = <0>;
+	assigned-clocks = <&clks 53>;
+	assigned-clock-rates = <12000000>;
+	status = "okay";
+};
+
+&saif1 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&saif1_pins_a>;
+	fsl,saif-master = <&saif0>;
+	#sound-dai-cells = <0>;
+	status = "okay";
+};
+
+&spi3_pins_a {
+	fsl,pinmux-ids = <
+		MX28_PAD_AUART2_RX__SSP3_D4
+		MX28_PAD_AUART2_TX__SSP3_D5
+		MX28_PAD_SSP3_SCK__SSP3_SCK
+		MX28_PAD_SSP3_MOSI__SSP3_CMD
+		MX28_PAD_SSP3_MISO__SSP3_D0
+		MX28_PAD_SSP3_SS0__SSP3_D3
+		MX28_PAD_AUART2_TX__GPIO_3_9
+	>;
+};
+
+&ssp0 {
+	compatible = "fsl,imx28-mmc";
+	pinctrl-names = "default";
+	pinctrl-0 = <&mmc0_8bit_pins_a>;
+	bus-width = <8>;
+	vmmc-supply = <&reg_3v3>;
+	non-removable;
+	status = "okay";
+};
+
+&ssp2 {
+	compatible = "fsl,imx28-spi";
+	pinctrl-names = "default";
+	pinctrl-0 = <&spi2_pins_a>;
+	status = "okay";
+};
+
+&ssp3 {
+	compatible = "fsl,imx28-spi";
+	pinctrl-names = "default";
+	pinctrl-0 = <&spi3_pins_a>;
+	status = "okay";
+
+	flash@0 {
+		compatible = "jedec,spi-nor";
+		spi-max-frequency = <40000000>;
+		reg = <0>;
+
+		partitions {
+			compatible = "fixed-partitions";
+			#address-cells = <1>;
+			#size-cells = <1>;
+
+			partition@0 {
+				label = "u-boot";
+				reg = <0 0x80000>;
+				read-only;
+			};
+
+			partition@80000 {
+				label = "env0";
+				reg = <0x80000 0x10000>;
+			};
+
+			partition@90000 {
+				label = "env1";
+				reg = <0x90000 0x10000>;
+			};
+
+			partition@100000 {
+				label = "kernel";
+				reg = <0x100000 0x400000>;
+			};
+
+			partition@500000 {
+				label = "swupdate";
+				reg = <0x500000 0x800000>;
+			};
+		};
+	};
+};
+
+&usb0 {
+	vbus-supply = <&reg_usb_5v>;
+	pinctrl-names = "default";
+	pinctrl-0 = <&usb0_pins_b>, <&usb0_id_pins_a>;
+	dr_mode = "host";
+	status = "okay";
+};
+
+&usbphy0 {
+	status = "okay";
+};
+
+&usb1 {
+	vbus-supply = <&reg_usb_5v>;
+	pinctrl-names = "default";
+	pinctrl-0 = <&usb1_pins_b>;
+	dr_mode = "host";
+	status = "okay";
+};
+
+&usbphy1 {
+	status = "okay";
+};
-- 
2.25.1

Re: [PATCH] imx28-xea: Add missing imx28-lwe.dtsi

[Marcel Ziswiler]

Hi Fabio

On Sat, 2022-10-22 at 08:22 -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> The following build error is seen when building imx28_xea_defconfig:
> 
> arch/arm/dts/.imx28-xea.dtb.pre.tmp:8:10: fatal error: imx28-lwe.dtsi: No such file or directory
> 
> This happens because commit ebcca534f557 ("imx28: synchronise device tree
> with linux") missed to import the imx28-lwe.dtsi file from Linux.

Thanks for this fix and sorry about that.

> Fix it by importing the file from Linux 6.1-rc1.
> 
> Fixes: ebcca534f557 ("imx28: synchronise device tree with linux")
> Signed-off-by: Fabio Estevam <festevam@denx.de>

Reviewed-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>

> ---
> This applies against u-boot-imx master-next branch.
> 
>  arch/arm/dts/imx28-lwe.dtsi | 170 ++++++++++++++++++++++++++++++++++++
>  1 file changed, 170 insertions(+)
>  create mode 100644 arch/arm/dts/imx28-lwe.dtsi
> 
> diff --git a/arch/arm/dts/imx28-lwe.dtsi b/arch/arm/dts/imx28-lwe.dtsi
> new file mode 100644
> index 000000000000..bb971e660db8
> --- /dev/null
> +++ b/arch/arm/dts/imx28-lwe.dtsi
> @@ -0,0 +1,170 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later OR MIT
> +/*
> + * Copyright 2021
> + * Lukasz Majewski, DENX Software Engineering, lukma@denx.de
> + */
> +
> +/dts-v1/;
> +#include "imx28.dtsi"
> +
> +/ {
> +       aliases {
> +               spi2 = &ssp3;
> +       };
> +
> +       chosen {
> +               bootargs = "root=/dev/mmcblk0p2 rootfstype=ext4 ro rootwait console=ttyAMA0,115200 panic=1";
> +       };
> +
> +       memory@40000000 {
> +               reg = <0x40000000 0x08000000>;
> +       };
> +
> +       reg_3v3: regulator-reg-3v3 {
> +               compatible = "regulator-fixed";
> +               regulator-name = "3V3";
> +               regulator-min-microvolt = <3300000>;
> +               regulator-max-microvolt = <3300000>;
> +       };
> +
> +       reg_usb_5v: regulator-reg-usb-5v {
> +               compatible = "regulator-fixed";
> +               regulator-name = "usb_vbus";
> +               regulator-min-microvolt = <5000000>;
> +               regulator-max-microvolt = <5000000>;
> +       };
> +
> +       reg_fec_3v3: regulator-reg-fec-3v3 {
> +               compatible = "regulator-fixed";
> +               regulator-name = "fec-phy";
> +               regulator-min-microvolt = <3300000>;
> +               regulator-max-microvolt = <3300000>;
> +       };
> +};
> +
> +&duart {
> +       pinctrl-names = "default";
> +       pinctrl-0 = <&duart_pins_a>;
> +       status = "okay";
> +};
> +
> +&i2c0 {
> +       pinctrl-names = "default";
> +       pinctrl-0 = <&i2c0_pins_a>;
> +       status = "okay";
> +};
> +
> +&saif0 {
> +       pinctrl-names = "default";
> +       pinctrl-0 = <&saif0_pins_a>;
> +       #sound-dai-cells = <0>;
> +       assigned-clocks = <&clks 53>;
> +       assigned-clock-rates = <12000000>;
> +       status = "okay";
> +};
> +
> +&saif1 {
> +       pinctrl-names = "default";
> +       pinctrl-0 = <&saif1_pins_a>;
> +       fsl,saif-master = <&saif0>;
> +       #sound-dai-cells = <0>;
> +       status = "okay";
> +};
> +
> +&spi3_pins_a {
> +       fsl,pinmux-ids = <
> +               MX28_PAD_AUART2_RX__SSP3_D4
> +               MX28_PAD_AUART2_TX__SSP3_D5
> +               MX28_PAD_SSP3_SCK__SSP3_SCK
> +               MX28_PAD_SSP3_MOSI__SSP3_CMD
> +               MX28_PAD_SSP3_MISO__SSP3_D0
> +               MX28_PAD_SSP3_SS0__SSP3_D3
> +               MX28_PAD_AUART2_TX__GPIO_3_9
> +       >;
> +};
> +
> +&ssp0 {
> +       compatible = "fsl,imx28-mmc";
> +       pinctrl-names = "default";
> +       pinctrl-0 = <&mmc0_8bit_pins_a>;
> +       bus-width = <8>;
> +       vmmc-supply = <&reg_3v3>;
> +       non-removable;
> +       status = "okay";
> +};
> +
> +&ssp2 {
> +       compatible = "fsl,imx28-spi";
> +       pinctrl-names = "default";
> +       pinctrl-0 = <&spi2_pins_a>;
> +       status = "okay";
> +};
> +
> +&ssp3 {
> +       compatible = "fsl,imx28-spi";
> +       pinctrl-names = "default";
> +       pinctrl-0 = <&spi3_pins_a>;
> +       status = "okay";
> +
> +       flash@0 {
> +               compatible = "jedec,spi-nor";
> +               spi-max-frequency = <40000000>;
> +               reg = <0>;
> +
> +               partitions {
> +                       compatible = "fixed-partitions";
> +                       #address-cells = <1>;
> +                       #size-cells = <1>;
> +
> +                       partition@0 {
> +                               label = "u-boot";
> +                               reg = <0 0x80000>;
> +                               read-only;
> +                       };
> +
> +                       partition@80000 {
> +                               label = "env0";
> +                               reg = <0x80000 0x10000>;
> +                       };
> +
> +                       partition@90000 {
> +                               label = "env1";
> +                               reg = <0x90000 0x10000>;
> +                       };
> +
> +                       partition@100000 {
> +                               label = "kernel";
> +                               reg = <0x100000 0x400000>;
> +                       };
> +
> +                       partition@500000 {
> +                               label = "swupdate";
> +                               reg = <0x500000 0x800000>;
> +                       };
> +               };
> +       };
> +};
> +
> +&usb0 {
> +       vbus-supply = <&reg_usb_5v>;
> +       pinctrl-names = "default";
> +       pinctrl-0 = <&usb0_pins_b>, <&usb0_id_pins_a>;
> +       dr_mode = "host";
> +       status = "okay";
> +};
> +
> +&usbphy0 {
> +       status = "okay";
> +};
> +
> +&usb1 {
> +       vbus-supply = <&reg_usb_5v>;
> +       pinctrl-names = "default";
> +       pinctrl-0 = <&usb1_pins_b>;
> +       dr_mode = "host";
> +       status = "okay";
> +};
> +
> +&usbphy1 {
> +       status = "okay";
> +};

Cheers

Marcel

Re: [PATCH] imx28-xea: Add missing imx28-lwe.dtsi

[Michael Nazzareno Trimarchi]

Hi Fabio

On Sat, Oct 22, 2022 at 3:02 PM Marcel Ziswiler
<marcel.ziswiler@toradex.com> wrote:
>
> Hi Fabio
>
> On Sat, 2022-10-22 at 08:22 -0300, Fabio Estevam wrote:
> > From: Fabio Estevam <festevam@denx.de>
> >
> > The following build error is seen when building imx28_xea_defconfig:
> >
> > arch/arm/dts/.imx28-xea.dtb.pre.tmp:8:10: fatal error: imx28-lwe.dtsi: No such file or directory
> >
> > This happens because commit ebcca534f557 ("imx28: synchronise device tree
> > with linux") missed to import the imx28-lwe.dtsi file from Linux.
>
> Thanks for this fix and sorry about that.
>
> > Fix it by importing the file from Linux 6.1-rc1.
> >
> > Fixes: ebcca534f557 ("imx28: synchronise device tree with linux")
> > Signed-off-by: Fabio Estevam <festevam@denx.de>
>

I have seen patches that fix build issues but how they land in the
first place. I mean
CI is used to avoid build regression

Michael

> Reviewed-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
>
> > ---
> > This applies against u-boot-imx master-next branch.
> >
> >  arch/arm/dts/imx28-lwe.dtsi | 170 ++++++++++++++++++++++++++++++++++++
> >  1 file changed, 170 insertions(+)
> >  create mode 100644 arch/arm/dts/imx28-lwe.dtsi
> >
> > diff --git a/arch/arm/dts/imx28-lwe.dtsi b/arch/arm/dts/imx28-lwe.dtsi
> > new file mode 100644
> > index 000000000000..bb971e660db8
> > --- /dev/null
> > +++ b/arch/arm/dts/imx28-lwe.dtsi
> > @@ -0,0 +1,170 @@
> > +// SPDX-License-Identifier: GPL-2.0-or-later OR MIT
> > +/*
> > + * Copyright 2021
> > + * Lukasz Majewski, DENX Software Engineering, lukma@denx.de
> > + */
> > +
> > +/dts-v1/;
> > +#include "imx28.dtsi"
> > +
> > +/ {
> > +       aliases {
> > +               spi2 = &ssp3;
> > +       };
> > +
> > +       chosen {
> > +               bootargs = "root=/dev/mmcblk0p2 rootfstype=ext4 ro rootwait console=ttyAMA0,115200 panic=1";
> > +       };
> > +
> > +       memory@40000000 {
> > +               reg = <0x40000000 0x08000000>;
> > +       };
> > +
> > +       reg_3v3: regulator-reg-3v3 {
> > +               compatible = "regulator-fixed";
> > +               regulator-name = "3V3";
> > +               regulator-min-microvolt = <3300000>;
> > +               regulator-max-microvolt = <3300000>;
> > +       };
> > +
> > +       reg_usb_5v: regulator-reg-usb-5v {
> > +               compatible = "regulator-fixed";
> > +               regulator-name = "usb_vbus";
> > +               regulator-min-microvolt = <5000000>;
> > +               regulator-max-microvolt = <5000000>;
> > +       };
> > +
> > +       reg_fec_3v3: regulator-reg-fec-3v3 {
> > +               compatible = "regulator-fixed";
> > +               regulator-name = "fec-phy";
> > +               regulator-min-microvolt = <3300000>;
> > +               regulator-max-microvolt = <3300000>;
> > +       };
> > +};
> > +
> > +&duart {
> > +       pinctrl-names = "default";
> > +       pinctrl-0 = <&duart_pins_a>;
> > +       status = "okay";
> > +};
> > +
> > +&i2c0 {
> > +       pinctrl-names = "default";
> > +       pinctrl-0 = <&i2c0_pins_a>;
> > +       status = "okay";
> > +};
> > +
> > +&saif0 {
> > +       pinctrl-names = "default";
> > +       pinctrl-0 = <&saif0_pins_a>;
> > +       #sound-dai-cells = <0>;
> > +       assigned-clocks = <&clks 53>;
> > +       assigned-clock-rates = <12000000>;
> > +       status = "okay";
> > +};
> > +
> > +&saif1 {
> > +       pinctrl-names = "default";
> > +       pinctrl-0 = <&saif1_pins_a>;
> > +       fsl,saif-master = <&saif0>;
> > +       #sound-dai-cells = <0>;
> > +       status = "okay";
> > +};
> > +
> > +&spi3_pins_a {
> > +       fsl,pinmux-ids = <
> > +               MX28_PAD_AUART2_RX__SSP3_D4
> > +               MX28_PAD_AUART2_TX__SSP3_D5
> > +               MX28_PAD_SSP3_SCK__SSP3_SCK
> > +               MX28_PAD_SSP3_MOSI__SSP3_CMD
> > +               MX28_PAD_SSP3_MISO__SSP3_D0
> > +               MX28_PAD_SSP3_SS0__SSP3_D3
> > +               MX28_PAD_AUART2_TX__GPIO_3_9
> > +       >;
> > +};
> > +
> > +&ssp0 {
> > +       compatible = "fsl,imx28-mmc";
> > +       pinctrl-names = "default";
> > +       pinctrl-0 = <&mmc0_8bit_pins_a>;
> > +       bus-width = <8>;
> > +       vmmc-supply = <&reg_3v3>;
> > +       non-removable;
> > +       status = "okay";
> > +};
> > +
> > +&ssp2 {
> > +       compatible = "fsl,imx28-spi";
> > +       pinctrl-names = "default";
> > +       pinctrl-0 = <&spi2_pins_a>;
> > +       status = "okay";
> > +};
> > +
> > +&ssp3 {
> > +       compatible = "fsl,imx28-spi";
> > +       pinctrl-names = "default";
> > +       pinctrl-0 = <&spi3_pins_a>;
> > +       status = "okay";
> > +
> > +       flash@0 {
> > +               compatible = "jedec,spi-nor";
> > +               spi-max-frequency = <40000000>;
> > +               reg = <0>;
> > +
> > +               partitions {
> > +                       compatible = "fixed-partitions";
> > +                       #address-cells = <1>;
> > +                       #size-cells = <1>;
> > +
> > +                       partition@0 {
> > +                               label = "u-boot";
> > +                               reg = <0 0x80000>;
> > +                               read-only;
> > +                       };
> > +
> > +                       partition@80000 {
> > +                               label = "env0";
> > +                               reg = <0x80000 0x10000>;
> > +                       };
> > +
> > +                       partition@90000 {
> > +                               label = "env1";
> > +                               reg = <0x90000 0x10000>;
> > +                       };
> > +
> > +                       partition@100000 {
> > +                               label = "kernel";
> > +                               reg = <0x100000 0x400000>;
> > +                       };
> > +
> > +                       partition@500000 {
> > +                               label = "swupdate";
> > +                               reg = <0x500000 0x800000>;
> > +                       };
> > +               };
> > +       };
> > +};
> > +
> > +&usb0 {
> > +       vbus-supply = <&reg_usb_5v>;
> > +       pinctrl-names = "default";
> > +       pinctrl-0 = <&usb0_pins_b>, <&usb0_id_pins_a>;
> > +       dr_mode = "host";
> > +       status = "okay";
> > +};
> > +
> > +&usbphy0 {
> > +       status = "okay";
> > +};
> > +
> > +&usb1 {
> > +       vbus-supply = <&reg_usb_5v>;
> > +       pinctrl-names = "default";
> > +       pinctrl-0 = <&usb1_pins_b>;
> > +       dr_mode = "host";
> > +       status = "okay";
> > +};
> > +
> > +&usbphy1 {
> > +       status = "okay";
> > +};
>
> Cheers
>
> Marcel



-- 
Michael Nazzareno Trimarchi
Co-Founder & Chief Executive Officer
M. +39 347 913 2170
michael@amarulasolutions.com
__________________________________

Amarula Solutions BV
Joop Geesinkweg 125, 1114 AB, Amsterdam, NL
T. +31 (0)85 111 9172
info@amarulasolutions.com
www.amarulasolutions.com

Re: [PATCH] imx28-xea: Add missing imx28-lwe.dtsi

[Fabio Estevam]

Hi Michael,

On Sat, Oct 22, 2022 at 10:19 AM Michael Nazzareno Trimarchi
<michael@amarulasolutions.com> wrote:

> I have seen patches that fix build issues but how they land in the
> first place. I mean
> CI is used to avoid build regression

I am sorry, but I could not understand your message. Care to clarify?

Thanks

Re: [PATCH] imx28-xea: Add missing imx28-lwe.dtsi

[Michael Nazzareno Trimarchi]

Hi

On Sat, Oct 22, 2022 at 3:24 PM Fabio Estevam <festevam@gmail.com> wrote:
>
> Hi Michael,
>
> On Sat, Oct 22, 2022 at 10:19 AM Michael Nazzareno Trimarchi
> <michael@amarulasolutions.com> wrote:
>
> > I have seen patches that fix build issues but how they land in the
> > first place. I mean
> > CI is used to avoid build regression
>
> I am sorry, but I could not understand your message. Care to clarify?
>
> Thanks

On my side the Continuous Integration using gitlab-ci, verify board combinations
and test the build. I'm asking if this build breakage happen because
those boards
are not built.

Michael
-- 
Michael Nazzareno Trimarchi
Co-Founder & Chief Executive Officer
M. +39 347 913 2170
michael@amarulasolutions.com
__________________________________

Amarula Solutions BV
Joop Geesinkweg 125, 1114 AB, Amsterdam, NL
T. +31 (0)85 111 9172
info@amarulasolutions.com
www.amarulasolutions.com

Re: [PATCH] imx28-xea: Add missing imx28-lwe.dtsi

[Fabio Estevam]

On Sat, Oct 22, 2022 at 10:31 AM Michael Nazzareno Trimarchi
<michael@amarulasolutions.com> wrote:

> On my side the Continuous Integration using gitlab-ci, verify board combinations
> and test the build. I'm asking if this build breakage happen because
> those boards
> are not built.

All boards are built by CI and the  build error was reported at:
https://source.denx.de/u-boot/custodians/u-boot-imx/-/jobs/517428

Re: [PATCH] imx28-xea: Add missing imx28-lwe.dtsi

[Michael Nazzareno Trimarchi]

Hi

On Sat, Oct 22, 2022 at 3:35 PM Fabio Estevam <festevam@gmail.com> wrote:
>
> On Sat, Oct 22, 2022 at 10:31 AM Michael Nazzareno Trimarchi
> <michael@amarulasolutions.com> wrote:
>
> > On my side the Continuous Integration using gitlab-ci, verify board combinations
> > and test the build. I'm asking if this build breakage happen because
> > those boards
> > are not built.
>
> All boards are built by CI and the  build error was reported at:
> https://source.denx.de/u-boot/custodians/u-boot-imx/-/jobs/517428

Should the patches need to be resend if they are not building? so you
want to take care of them

Michael


-- 
Michael Nazzareno Trimarchi
Co-Founder & Chief Executive Officer
M. +39 347 913 2170
michael@amarulasolutions.com
__________________________________

Amarula Solutions BV
Joop Geesinkweg 125, 1114 AB, Amsterdam, NL
T. +31 (0)85 111 9172
info@amarulasolutions.com
www.amarulasolutions.com

Re: [PATCH] imx28-xea: Add missing imx28-lwe.dtsi

[Stefano Babic]

Hi everybody,

On 22.10.22 15:44, Michael Nazzareno Trimarchi wrote:
> Hi
> 
> On Sat, Oct 22, 2022 at 3:35 PM Fabio Estevam <festevam@gmail.com> wrote:
>>
>> On Sat, Oct 22, 2022 at 10:31 AM Michael Nazzareno Trimarchi
>> <michael@amarulasolutions.com> wrote:
>>
>>> On my side the Continuous Integration using gitlab-ci, verify board combinations
>>> and test the build. I'm asking if this build breakage happen because
>>> those boards
>>> are not built.
>>
>> All boards are built by CI and the  build error was reported at:
>> https://source.denx.de/u-boot/custodians/u-boot-imx/-/jobs/517428
> 
> Should the patches need to be resend if they are not building? so you
> want to take care of them
> 

Just to clarify: the broken patches *are* not applied. As pointed by 
Michael, CI is used to check build *before* applying. What you are 
looking is my master-next branch, that is patches are applied first to a 
test branch (master-next) before going to master. If CI is broken, they 
are simply removed. That is my next step, I have seen that 
imx28-lwe.dtsi is missing, too. But as patch is not applied, I will 
kindly ask Marcel to squash Fabio's in his series and repost.

Thanks,
Stefano

> Michael
> 
> 

Re: [PATCH] imx28-xea: Add missing imx28-lwe.dtsi

[Marcel Ziswiler]

On Sat, 2022-10-22 at 17:44 +0200, Stefano Babic wrote:
> Hi everybody,
> 
> On 22.10.22 15:44, Michael Nazzareno Trimarchi wrote:
> > Hi
> > 
> > On Sat, Oct 22, 2022 at 3:35 PM Fabio Estevam <festevam@gmail.com> wrote:
> > > 
> > > On Sat, Oct 22, 2022 at 10:31 AM Michael Nazzareno Trimarchi
> > > <michael@amarulasolutions.com> wrote:
> > > 
> > > > On my side the Continuous Integration using gitlab-ci, verify board combinations
> > > > and test the build. I'm asking if this build breakage happen because
> > > > those boards
> > > > are not built.
> > > 
> > > All boards are built by CI and the  build error was reported at:
> > > https://source.denx.de/u-boot/custodians/u-boot-imx/-/jobs/517428
> > 
> > Should the patches need to be resend if they are not building? so you
> > want to take care of them
> > 
> 
> Just to clarify: the broken patches *are* not applied. As pointed by 
> Michael, CI is used to check build *before* applying. What you are 
> looking is my master-next branch, that is patches are applied first to a 
> test branch (master-next) before going to master. If CI is broken, they 
> are simply removed. That is my next step, I have seen that 
> imx28-lwe.dtsi is missing, too. But as patch is not applied, I will 
> kindly ask Marcel to squash Fabio's in his series and repost.

https://patchwork.ozlabs.org/project/uboot/cover/20221022215945.84052-1-marcel@ziswiler.com/

> Thanks,
> Stefano
> 
> > Michael