From: Sean Anderson <seanga2@gmail.com>
To: u-boot@lists.denx.de
Subject: [PATCH 5/6] simple-pm-bus: Use -ENOSYS for checking missing system call
Date: Sun, 21 Mar 2021 00:39:09 -0400 [thread overview]
Message-ID: <9555ee9b-5a64-057d-445b-af8e37a8f638@gmail.com> (raw)
In-Reply-To: <20210321031824.2170848-6-sjg@chromium.org>
On 3/20/21 11:18 PM, Simon Glass wrote:
> We don't need to check -ENOTSUPP since this is not used for this purpose
> in U-Boot. Update the code accordingly.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
>
> drivers/core/simple-pm-bus.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/core/simple-pm-bus.c b/drivers/core/simple-pm-bus.c
> index 7a18953cba1..1bb0d86e289 100644
> --- a/drivers/core/simple-pm-bus.c
> +++ b/drivers/core/simple-pm-bus.c
> @@ -21,7 +21,7 @@ static int simple_pm_bus_probe(struct udevice *dev)
> return ret;
>
> ret = clk_enable_bulk(bulk);
> - if (ret && ret != -ENOSYS && ret != -ENOTSUPP) {
> + if (ret && ret != -ENOSYS) {
> clk_release_bulk(bulk);
> return ret;
> }
> @@ -34,7 +34,7 @@ static int simple_pm_bus_remove(struct udevice *dev)
> struct clk_bulk *bulk = dev_get_priv(dev);
>
> ret = clk_release_bulk(bulk);
> - if (ret && ret != -ENOSYS && ret != -ENOTSUPP)
> + if (ret && ret != -ENOSYS)
> return ret;
> else
> return 0;
>
Nak. This cannot be removed until all drivers have been converted to use
-ENOSYS.
--Sean
next prev parent reply other threads:[~2021-03-21 4:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-21 3:18 [PATCH 0/6] Use -ENOSYS consistently Simon Glass
2021-03-21 3:18 ` [PATCH 1/6] usb: Return -ENOSYS when system call is not available Simon Glass
2021-03-21 4:09 ` Marek Vasut
2021-03-21 4:12 ` Simon Glass
2021-03-21 18:29 ` Marek Vasut
2021-03-21 3:18 ` [PATCH 2/6] spi: " Simon Glass
2021-03-21 3:18 ` [PATCH 3/6] tlv_eeprom: " Simon Glass
2021-03-21 3:18 ` [PATCH 4/6] clk: " Simon Glass
2021-03-21 4:37 ` Sean Anderson
2021-03-23 4:08 ` Simon Glass
2021-03-21 3:18 ` [PATCH 5/6] simple-pm-bus: Use -ENOSYS for checking missing system call Simon Glass
2021-03-21 4:39 ` Sean Anderson [this message]
2021-03-21 3:18 ` [PATCH 6/6] pinctrl: Return -ENOSYS when system call is not available Simon Glass
2021-03-21 16:38 ` [PATCH 0/6] Use -ENOSYS consistently Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9555ee9b-5a64-057d-445b-af8e37a8f638@gmail.com \
--to=seanga2@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.