All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [PATCH 1/6] usb: Return -ENOSYS when system call is not available
Date: Sun, 21 Mar 2021 19:29:26 +0100	[thread overview]
Message-ID: <5589df4c-b884-ef77-ee82-3495d6736380@denx.de> (raw)
In-Reply-To: <CAPnjgZ1wLO9z0VKUgbzFqokfC2HDW+KFGsYs-SH4NNV8FEB7cg@mail.gmail.com>

On 3/21/21 5:12 AM, Simon Glass wrote:
> Hi Marek,
> 
> On Sun, 21 Mar 2021 at 17:09, Marek Vasut <marex@denx.de> wrote:
>>
>> On 3/21/21 4:18 AM, Simon Glass wrote:
>>> Update usb_gadget_release() to use -ENOSYS, which is the correct error
>>> code for U-Boot.
>>
>> It would be good if you could explain _why_ this change is required. Why
>> is ENOSYS the correct return value ? It is not clear from the patch
>> description, sorry.
> 
> That is the value used throughout driver model, so it is a convention.
> As per the cover letter and one on the patches, people are not sure
> which one to use, because -ENOTSUPP has crept in in a few places.

I agree with Tom, this needs to be documented first, then the document 
should be agreed upon, and only then should these fixes follow.

  reply	other threads:[~2021-03-21 18:29 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-21  3:18 [PATCH 0/6] Use -ENOSYS consistently Simon Glass
2021-03-21  3:18 ` [PATCH 1/6] usb: Return -ENOSYS when system call is not available Simon Glass
2021-03-21  4:09   ` Marek Vasut
2021-03-21  4:12     ` Simon Glass
2021-03-21 18:29       ` Marek Vasut [this message]
2021-03-21  3:18 ` [PATCH 2/6] spi: " Simon Glass
2021-03-21  3:18 ` [PATCH 3/6] tlv_eeprom: " Simon Glass
2021-03-21  3:18 ` [PATCH 4/6] clk: " Simon Glass
2021-03-21  4:37   ` Sean Anderson
2021-03-23  4:08     ` Simon Glass
2021-03-21  3:18 ` [PATCH 5/6] simple-pm-bus: Use -ENOSYS for checking missing system call Simon Glass
2021-03-21  4:39   ` Sean Anderson
2021-03-21  3:18 ` [PATCH 6/6] pinctrl: Return -ENOSYS when system call is not available Simon Glass
2021-03-21 16:38 ` [PATCH 0/6] Use -ENOSYS consistently Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5589df4c-b884-ef77-ee82-3495d6736380@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.