From: Robin Murphy <robin.murphy@arm.com> To: Marc Zyngier <marc.zyngier@arm.com>, Heiko Stuebner <heiko@sntech.de> Cc: Lin Huang <hl@rock-chips.com>, Jeffy Chen <jeffy.chen@rock-chips.com>, Douglas Anderson <dianders@chromium.org>, linux-rockchip@lists.infradead.org, Enric Balletbo i Serra <enric.balletbo@collabora.com>, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] arm64: rk3399: Add capacity-dmips-mhz attributes Date: Sun, 24 Feb 2019 20:07:49 +0000 [thread overview] Message-ID: <9562f9e4-b832-5cc1-821f-696ededf8a02@arm.com> (raw) In-Reply-To: <20190224143525.15539-1-marc.zyngier@arm.com> Hi Marc, On 2019-02-24 2:35 pm, Marc Zyngier wrote: > The RK3399 has the interesting property to be a so called "big-little" > system, where not all the CPUs are equal (the A53s are much weaker > than the A72s). > > So far, we're not telling the OS that there is such a difference in > processing capacity, and Linux assumes that they are equal. Too bad. > > Let's tell the OS about this by using the capacity-dmips-mhz > property. The values used here are those used on the Juno platform, > which is quite similar. This leads to the scheduler knowing that > it can pack more tasks on the A72s, and leads to a better interactive > experience. > > Signed-off-by: Marc Zyngier <marc.zyngier@arm.com> > --- > arch/arm64/boot/dts/rockchip/rk3399.dtsi | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi > index 6cc1c9fa4ea6..7eab31184aee 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi > @@ -75,6 +75,7 @@ > #cooling-cells = <2>; /* min followed by max */ > dynamic-power-coefficient = <100>; > cpu-idle-states = <&CPU_SLEEP &CLUSTER_SLEEP>; > + capacity-dmips-mhz = <578>; Probably better to use the value from Juno r2 (485) which should more appropriately represent A53 vs. A72, rather than A53 vs. A57. > }; > > cpu_l1: cpu@1 { > @@ -86,6 +87,7 @@ > #cooling-cells = <2>; /* min followed by max */ > dynamic-power-coefficient = <100>; > cpu-idle-states = <&CPU_SLEEP &CLUSTER_SLEEP>; > + capacity-dmips-mhz = <578>; > }; > > cpu_l2: cpu@2 { > @@ -97,6 +99,7 @@ > #cooling-cells = <2>; /* min followed by max */ > dynamic-power-coefficient = <100>; > cpu-idle-states = <&CPU_SLEEP &CLUSTER_SLEEP>; > + capacity-dmips-mhz = <578>; > }; > > cpu_l3: cpu@3 { > @@ -108,6 +111,7 @@ > #cooling-cells = <2>; /* min followed by max */ > dynamic-power-coefficient = <100>; > cpu-idle-states = <&CPU_SLEEP &CLUSTER_SLEEP>; > + capacity-dmips-mhz = <578>; > }; > > cpu_b0: cpu@100 { > @@ -118,7 +122,7 @@ > clocks = <&cru ARMCLKB>; > #cooling-cells = <2>; /* min followed by max */ > dynamic-power-coefficient = <436>; > - cpu-idle-states = <&CPU_SLEEP &CLUSTER_SLEEP>; Oops. Otherwise, though, I was on the verge of tackling this myself now that my 3399 board is building its own kernels - annoyance at the linking bottleneck steadfastly refusing to move off CPU0 (except occasionally to another little core) has been growing steadily :) With the nits fixed, Tested-by: Robin Murphy <robin.murphy@arm.com> Cheers, Robin. > + capacity-dmips-mhz = <1024>; > }; > > cpu_b1: cpu@101 { > @@ -130,6 +134,7 @@ > #cooling-cells = <2>; /* min followed by max */ > dynamic-power-coefficient = <436>; > cpu-idle-states = <&CPU_SLEEP &CLUSTER_SLEEP>; > + capacity-dmips-mhz = <1024>; > }; > > idle-states { >
WARNING: multiple messages have this Message-ID (diff)
From: Robin Murphy <robin.murphy@arm.com> To: Marc Zyngier <marc.zyngier@arm.com>, Heiko Stuebner <heiko@sntech.de> Cc: Lin Huang <hl@rock-chips.com>, Jeffy Chen <jeffy.chen@rock-chips.com>, Douglas Anderson <dianders@chromium.org>, linux-rockchip@lists.infradead.org, Enric Balletbo i Serra <enric.balletbo@collabora.com>, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] arm64: rk3399: Add capacity-dmips-mhz attributes Date: Sun, 24 Feb 2019 20:07:49 +0000 [thread overview] Message-ID: <9562f9e4-b832-5cc1-821f-696ededf8a02@arm.com> (raw) In-Reply-To: <20190224143525.15539-1-marc.zyngier@arm.com> Hi Marc, On 2019-02-24 2:35 pm, Marc Zyngier wrote: > The RK3399 has the interesting property to be a so called "big-little" > system, where not all the CPUs are equal (the A53s are much weaker > than the A72s). > > So far, we're not telling the OS that there is such a difference in > processing capacity, and Linux assumes that they are equal. Too bad. > > Let's tell the OS about this by using the capacity-dmips-mhz > property. The values used here are those used on the Juno platform, > which is quite similar. This leads to the scheduler knowing that > it can pack more tasks on the A72s, and leads to a better interactive > experience. > > Signed-off-by: Marc Zyngier <marc.zyngier@arm.com> > --- > arch/arm64/boot/dts/rockchip/rk3399.dtsi | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi > index 6cc1c9fa4ea6..7eab31184aee 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi > @@ -75,6 +75,7 @@ > #cooling-cells = <2>; /* min followed by max */ > dynamic-power-coefficient = <100>; > cpu-idle-states = <&CPU_SLEEP &CLUSTER_SLEEP>; > + capacity-dmips-mhz = <578>; Probably better to use the value from Juno r2 (485) which should more appropriately represent A53 vs. A72, rather than A53 vs. A57. > }; > > cpu_l1: cpu@1 { > @@ -86,6 +87,7 @@ > #cooling-cells = <2>; /* min followed by max */ > dynamic-power-coefficient = <100>; > cpu-idle-states = <&CPU_SLEEP &CLUSTER_SLEEP>; > + capacity-dmips-mhz = <578>; > }; > > cpu_l2: cpu@2 { > @@ -97,6 +99,7 @@ > #cooling-cells = <2>; /* min followed by max */ > dynamic-power-coefficient = <100>; > cpu-idle-states = <&CPU_SLEEP &CLUSTER_SLEEP>; > + capacity-dmips-mhz = <578>; > }; > > cpu_l3: cpu@3 { > @@ -108,6 +111,7 @@ > #cooling-cells = <2>; /* min followed by max */ > dynamic-power-coefficient = <100>; > cpu-idle-states = <&CPU_SLEEP &CLUSTER_SLEEP>; > + capacity-dmips-mhz = <578>; > }; > > cpu_b0: cpu@100 { > @@ -118,7 +122,7 @@ > clocks = <&cru ARMCLKB>; > #cooling-cells = <2>; /* min followed by max */ > dynamic-power-coefficient = <436>; > - cpu-idle-states = <&CPU_SLEEP &CLUSTER_SLEEP>; Oops. Otherwise, though, I was on the verge of tackling this myself now that my 3399 board is building its own kernels - annoyance at the linking bottleneck steadfastly refusing to move off CPU0 (except occasionally to another little core) has been growing steadily :) With the nits fixed, Tested-by: Robin Murphy <robin.murphy@arm.com> Cheers, Robin. > + capacity-dmips-mhz = <1024>; > }; > > cpu_b1: cpu@101 { > @@ -130,6 +134,7 @@ > #cooling-cells = <2>; /* min followed by max */ > dynamic-power-coefficient = <436>; > cpu-idle-states = <&CPU_SLEEP &CLUSTER_SLEEP>; > + capacity-dmips-mhz = <1024>; > }; > > idle-states { > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-02-24 20:07 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-02-24 14:35 [PATCH] arm64: rk3399: Add capacity-dmips-mhz attributes Marc Zyngier 2019-02-24 14:35 ` Marc Zyngier 2019-02-24 20:07 ` Robin Murphy [this message] 2019-02-24 20:07 ` Robin Murphy 2019-02-24 21:06 ` Marc Zyngier 2019-02-24 21:06 ` Marc Zyngier [not found] ` <20190224210657.2cb54039-Fmn/x+r+pSA9//JtdbceeD8Kkb2uy4ct@public.gmane.org> 2019-03-02 12:39 ` Heiko Stuebner 2019-03-02 12:39 ` Heiko Stuebner 2019-03-02 13:11 ` Marc Zyngier 2019-03-02 13:11 ` Marc Zyngier [not found] ` <20190302131122.4d82da1b-Fmn/x+r+pSA9//JtdbceeD8Kkb2uy4ct@public.gmane.org> 2019-03-02 14:10 ` Heiko Stuebner 2019-03-02 14:10 ` Heiko Stuebner
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=9562f9e4-b832-5cc1-821f-696ededf8a02@arm.com \ --to=robin.murphy@arm.com \ --cc=dianders@chromium.org \ --cc=enric.balletbo@collabora.com \ --cc=heiko@sntech.de \ --cc=hl@rock-chips.com \ --cc=jeffy.chen@rock-chips.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-rockchip@lists.infradead.org \ --cc=marc.zyngier@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.