Re: [PATCH -next] block: Revert "block: increase BLKCG_MAX_POLS"

Re: [PATCH -next] block: Revert "block: increase BLKCG_MAX_POLS"

[Oleksandr Natalenko]

Hello.

On pátek 3. února 2023 9:13:57 CET Yu Kuai wrote:
> From: Yu Kuai <yukuai3@huawei.com>
> 
> This reverts commit ec645dc96699ea6c37b6de86c84d7288ea9a4ddf.
> 
> This can save some memory, because after commit 0f7839955114 ("Revert
> "block/mq-deadline: Add cgroup support""), there are total 5 policies.
> 
> Signed-off-by: Yu Kuai <yukuai3@huawei.com>
> ---
>  include/linux/blkdev.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
> index 41a41561b773..c6861c7fdad9 100644
> --- a/include/linux/blkdev.h
> +++ b/include/linux/blkdev.h
> @@ -54,7 +54,7 @@ extern struct class block_class;
>   * Maximum number of blkcg policies allowed to be registered concurrently.
>   * Defined here to simplify include dependency.
>   */
> -#define BLKCG_MAX_POLS		6
> +#define BLKCG_MAX_POLS		5
>  
>  #define DISK_MAX_PARTS			256
>  #define DISK_NAME_LEN			32

Last time I asked about reverting this change, it was suggested that we may keep it [1].

[1] https://lore.kernel.org/linux-block/1dc051a8-4d59-8137-2406-f74026b170bd@kernel.dk/

-- 
Oleksandr Natalenko (post-factum)

Re: [PATCH -next] block: Revert "block: increase BLKCG_MAX_POLS"

[Yu Kuai]

Hi,

在 2023/02/03 15:59, Oleksandr Natalenko 写道:
> Hello.
> 
> On pátek 3. února 2023 9:13:57 CET Yu Kuai wrote:
>> From: Yu Kuai <yukuai3@huawei.com>
>>
>> This reverts commit ec645dc96699ea6c37b6de86c84d7288ea9a4ddf.
>>
>> This can save some memory, because after commit 0f7839955114 ("Revert
>> "block/mq-deadline: Add cgroup support""), there are total 5 policies.
>>
>> Signed-off-by: Yu Kuai <yukuai3@huawei.com>
>> ---
>>   include/linux/blkdev.h | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
>> index 41a41561b773..c6861c7fdad9 100644
>> --- a/include/linux/blkdev.h
>> +++ b/include/linux/blkdev.h
>> @@ -54,7 +54,7 @@ extern struct class block_class;
>>    * Maximum number of blkcg policies allowed to be registered concurrently.
>>    * Defined here to simplify include dependency.
>>    */
>> -#define BLKCG_MAX_POLS		6
>> +#define BLKCG_MAX_POLS		5
>>   
>>   #define DISK_MAX_PARTS			256
>>   #define DISK_NAME_LEN			32
> 
> Last time I asked about reverting this change, it was suggested that we may keep it [1].
> 
> [1] https://lore.kernel.org/linux-block/1dc051a8-4d59-8137-2406-f74026b170bd@kernel.dk/
> 

I see now, thanks for the reply.

Kuai

[PATCH -next] block: Revert "block: increase BLKCG_MAX_POLS"

[Yu Kuai]

From: Yu Kuai <yukuai3@huawei.com>

This reverts commit ec645dc96699ea6c37b6de86c84d7288ea9a4ddf.

This can save some memory, because after commit 0f7839955114 ("Revert
"block/mq-deadline: Add cgroup support""), there are total 5 policies.

Signed-off-by: Yu Kuai <yukuai3@huawei.com>
---
 include/linux/blkdev.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index 41a41561b773..c6861c7fdad9 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -54,7 +54,7 @@ extern struct class block_class;
  * Maximum number of blkcg policies allowed to be registered concurrently.
  * Defined here to simplify include dependency.
  */
-#define BLKCG_MAX_POLS		6
+#define BLKCG_MAX_POLS		5
 
 #define DISK_MAX_PARTS			256
 #define DISK_NAME_LEN			32
-- 
2.31.1