[meta-python][PATCH] pycrypto: Add recipe to have support on python3

[meta-python][PATCH] pycrypto: Add recipe to have support on python3

[Ricardo Silva]

The pycrypto module sources can be used for both python2 and python3,
but a recipe for python3 was missing, so add it.

Recipe is basically the same as for python2 (python-pycrypto_2.6.1.bb),
but using distutils3 instead.

Signed-off-by: Ricardo Silva <rjpdasilva@gmail.com>
---
 .../recipes-devtools/python/python3-pycrypto_2.6.1.bb       | 13 +++++++++++++
 1 file changed, 13 insertions(+)
 create mode 100644 meta-python/recipes-devtools/python/python3-pycrypto_2.6.1.bb

diff --git a/meta-python/recipes-devtools/python/python3-pycrypto_2.6.1.bb b/meta-python/recipes-devtools/python/python3-pycrypto_2.6.1.bb
new file mode 100644
index 000000000..2878c8599
--- /dev/null
+++ b/meta-python/recipes-devtools/python/python3-pycrypto_2.6.1.bb
@@ -0,0 +1,13 @@
+inherit distutils3
+require python-pycrypto.inc
+
+SRC_URI += "file://cross-compiling.patch \
+            file://CVE-2013-7459.patch \
+           "
+
+# We explicitly call distutils_do_install, since we want it to run, but
+# *don't* want the autotools install to run, since this package doesn't
+# provide a "make install" target.
+do_install() {
+       distutils3_do_install
+}
-- 
2.15.1

Re: [meta-python][PATCH] pycrypto: Add recipe to have support on python3

[Tim Orling]

> On Jan 4, 2018, at 8:06 AM, Ricardo Silva <rjpdasilva@gmail.com> wrote:
> 
> The pycrypto module sources can be used for both python2 and python3,
> but a recipe for python3 was missing, so add it.
> 
> Recipe is basically the same as for python2 (python-pycrypto_2.6.1.bb),
> but using distutils3 instead.
> 
> Signed-off-by: Ricardo Silva <rjpdasilva@gmail.com>
> ---
> .../recipes-devtools/python/python3-pycrypto_2.6.1.bb       | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
> create mode 100644 meta-python/recipes-devtools/python/python3-pycrypto_2.6.1.bb
> 
> diff --git a/meta-python/recipes-devtools/python/python3-pycrypto_2.6.1.bb b/meta-python/recipes-devtools/python/python3-pycrypto_2.6.1.bb
> new file mode 100644
> index 000000000..2878c8599
> --- /dev/null
> +++ b/meta-python/recipes-devtools/python/python3-pycrypto_2.6.1.bb
> @@ -0,0 +1,13 @@
> +inherit distutils3
> +require python-pycrypto.inc
> +
> +SRC_URI += "file://cross-compiling.patch \
> +            file://CVE-2013-7459.patch \
> +

These will not be picked up as they are in "python-pycrypto" directory (not in “files” or “python3-pycrypto”, etc.). This will result in a fetcher failure.

Rather than duplicate the SRC_URI in both python2- and python3- recipes, we should add them to python-pycrypto.inc and add the following to python-pycrypto.inc

FILESEXTRAPATHS_prepend := "${THISDIR}/python-pycrypto:”

>           "
> +
> +# We explicitly call distutils_do_install, since we want it to run, but
> +# *don't* want the autotools install to run, since this package doesn't
> +# provide a "make install" target.
> +do_install() {
> +       distutils3_do_install
> +}
> -- 
> 2.15.1
> 
> -- 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Re: [meta-python][PATCH] pycrypto: Add recipe to have support on python3

[Ricardo Silva]

Hi Tim,

Thanks for reviewing.

On 01/04/2018 04:44 PM, Tim Orling wrote:
> 
>> On Jan 4, 2018, at 8:06 AM, Ricardo Silva <rjpdasilva@gmail.com> wrote:
>>
>> The pycrypto module sources can be used for both python2 and python3,
>> but a recipe for python3 was missing, so add it.
>>
>> Recipe is basically the same as for python2 (python-pycrypto_2.6.1.bb),
>> but using distutils3 instead.
>>
>> Signed-off-by: Ricardo Silva <rjpdasilva@gmail.com>
>> ---
>> .../recipes-devtools/python/python3-pycrypto_2.6.1.bb       | 13 +++++++++++++
>> 1 file changed, 13 insertions(+)
>> create mode 100644 meta-python/recipes-devtools/python/python3-pycrypto_2.6.1.bb
>>
>> diff --git a/meta-python/recipes-devtools/python/python3-pycrypto_2.6.1.bb b/meta-python/recipes-devtools/python/python3-pycrypto_2.6.1.bb
>> new file mode 100644
>> index 000000000..2878c8599
>> --- /dev/null
>> +++ b/meta-python/recipes-devtools/python/python3-pycrypto_2.6.1.bb
>> @@ -0,0 +1,13 @@
>> +inherit distutils3
>> +require python-pycrypto.inc
>> +
>> +SRC_URI += "file://cross-compiling.patch \
>> +            file://CVE-2013-7459.patch \
>> +
> 
> These will not be picked up as they are in "python-pycrypto" directory (not in “files” or “python3-pycrypto”, etc.). This will result in a fetcher failure.

You're right.
I had a leftover files that made my tests pass. Should have tested with a clean tree.

> 
> Rather than duplicate the SRC_URI in both python2- and python3- recipes, we should add them to python-pycrypto.inc and add the following to python-pycrypto.inc
> 
> FILESEXTRAPATHS_prepend := "${THISDIR}/python-pycrypto:”
> 

Agree.
Shall I send a v2 with your suggested changes?

Regards,

Ricardo Silva

Re: [meta-python][PATCH] pycrypto: Add recipe to have support on python3

[Tim Orling]

> On Jan 4, 2018, at 8:51 AM, Ricardo Silva <rjpdasilva@gmail.com> wrote:
> 
>> 
>> Rather than duplicate the SRC_URI in both python2- and python3- recipes, we should add them to python-pycrypto.inc and add the following to python-pycrypto.inc
>> 
>> FILESEXTRAPATHS_prepend := "${THISDIR}/python-pycrypto:”
>> 
> 
> Agree.
> Shall I send a v2 with your suggested changes?
> 

Yes, please. If you don’t mind (it will need to remove the extra SRC_URI lines from python2 recipe, add the SRC_URI lines and FILESEXTRAPATHS to .inc and then add the python3 recipe).

> Regards,
> 
> Ricardo Silva

Re: [meta-python][PATCH] pycrypto: Add recipe to have support on python3

[Ricardo Silva]

Hi Tim,

On 01/04/2018 04:56 PM, Tim Orling wrote:
> 
>> On Jan 4, 2018, at 8:51 AM, Ricardo Silva <rjpdasilva@gmail.com> wrote:
>>
>>>
>>> Rather than duplicate the SRC_URI in both python2- and python3- recipes, we should add them to python-pycrypto.inc and add the following to python-pycrypto.inc
>>>
>>> FILESEXTRAPATHS_prepend := "${THISDIR}/python-pycrypto:”
>>>
>>
>> Agree.
>> Shall I send a v2 with your suggested changes?
>>
> 
> Yes, please. If you don’t mind (it will need to remove the extra SRC_URI lines from python2 recipe, add the SRC_URI lines and FILESEXTRAPATHS to .inc and then add the python3 recipe).

Glad to. You mean the changes should be split over a patch series, or OK
to have a single patch with all the changes?

Also note that the .inc file already had :
	FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
so I would just change that to:
	FILESEXTRAPATHS_prepend := "${THISDIR}/python-pycrypto:"

Regards,

Ricardo Silva

Re: [meta-python][PATCH] pycrypto: Add recipe to have support on python3

[Tim Orling]

> On Jan 4, 2018, at 9:27 AM, Ricardo Silva <rjpdasilva@gmail.com> wrote:
> 
> Hi Tim,
> 
> On 01/04/2018 04:56 PM, Tim Orling wrote:
>> 
>>> On Jan 4, 2018, at 8:51 AM, Ricardo Silva <rjpdasilva@gmail.com> wrote:
>>> 
>>>> 
>>>> Rather than duplicate the SRC_URI in both python2- and python3- recipes, we should add them to python-pycrypto.inc and add the following to python-pycrypto.inc
>>>> 
>>>> FILESEXTRAPATHS_prepend := "${THISDIR}/python-pycrypto:”
>>>> 
>>> 
>>> Agree.
>>> Shall I send a v2 with your suggested changes?
>>> 
>> 
>> Yes, please. If you don’t mind (it will need to remove the extra SRC_URI lines from python2 recipe, add the SRC_URI lines and FILESEXTRAPATHS to .inc and then add the python3 recipe).
> 
> Glad to. You mean the changes should be split over a patch series, or OK
> to have a single patch with all the changes?
> 

Single patch touching all three files is fine.

> Also note that the .inc file already had :
> 	FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
> so I would just change that to:
> 	FILESEXTRAPATHS_prepend := "${THISDIR}/python-pycrypto:”
> 

Correct. As ${PN} would resolve to python3-pycrypto and not work as intended :)


> Regards,
> 
> Ricardo Silva