From: Dmitry Osipenko <digetx@gmail.com>
To: Sameer Pujar <spujar@nvidia.com>,
tiwai@suse.com, broonie@kernel.org, lgirdwood@gmail.com,
thierry.reding@gmail.com, perex@perex.cz
Cc: jonathanh@nvidia.com, alsa-devel@alsa-project.org,
devicetree@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Mohan Kumar <mkumard@nvidia.com>,
robh+dt@kernel.org
Subject: Re: [PATCH 1/3] ALSA: hda/tegra: Skip reset on BPMP devices
Date: Tue, 7 Dec 2021 18:35:21 +0300 [thread overview]
Message-ID: <95cc7efa-251c-690b-9afa-53ee9e052c34@gmail.com> (raw)
In-Reply-To: <f32cde65-63dc-67f8-ded8-b58ea5e89f4e@nvidia.com>
07.12.2021 17:49, Sameer Pujar пишет:
...
>>> How the reload case would be different? Can you please specify more
>>> details if you are referring to a particular scenario?
>> You have a shared power domain. Since power domain can be turned off
>> only when nobody keeps domain turned on, you now making reset of HDA
>> controller dependent on the state of display driver.
>
> I don't think that the state of display driver would affect. The HDA
> driver itself can issue unpowergate calls which in turn ensures h/w
> reset. If display driver is already runtime active, HDA driver runtime
> resume after this would be still fine since h/w reset is already applied
> during display runtime resume. Note that both HDA and display resets are
> connected to this power-domain and BPMP applies these resets during
> unpowergate.
HDA won't be reset while display is active on T186+.
HDA will be reset while is display is inactive on T186+.
HDA will be reset regardless of display state on pre-T186.
This is a pure inconsistency of the reset behaviour. Please don't do it.
WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Osipenko <digetx@gmail.com>
To: Sameer Pujar <spujar@nvidia.com>,
tiwai@suse.com, broonie@kernel.org, lgirdwood@gmail.com,
thierry.reding@gmail.com, perex@perex.cz
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
jonathanh@nvidia.com, robh+dt@kernel.org,
linux-tegra@vger.kernel.org, Mohan Kumar <mkumard@nvidia.com>
Subject: Re: [PATCH 1/3] ALSA: hda/tegra: Skip reset on BPMP devices
Date: Tue, 7 Dec 2021 18:35:21 +0300 [thread overview]
Message-ID: <95cc7efa-251c-690b-9afa-53ee9e052c34@gmail.com> (raw)
In-Reply-To: <f32cde65-63dc-67f8-ded8-b58ea5e89f4e@nvidia.com>
07.12.2021 17:49, Sameer Pujar пишет:
...
>>> How the reload case would be different? Can you please specify more
>>> details if you are referring to a particular scenario?
>> You have a shared power domain. Since power domain can be turned off
>> only when nobody keeps domain turned on, you now making reset of HDA
>> controller dependent on the state of display driver.
>
> I don't think that the state of display driver would affect. The HDA
> driver itself can issue unpowergate calls which in turn ensures h/w
> reset. If display driver is already runtime active, HDA driver runtime
> resume after this would be still fine since h/w reset is already applied
> during display runtime resume. Note that both HDA and display resets are
> connected to this power-domain and BPMP applies these resets during
> unpowergate.
HDA won't be reset while display is active on T186+.
HDA will be reset while is display is inactive on T186+.
HDA will be reset regardless of display state on pre-T186.
This is a pure inconsistency of the reset behaviour. Please don't do it.
next prev parent reply other threads:[~2021-12-07 15:35 UTC|newest]
Thread overview: 79+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-07 6:32 [PATCH 0/3] Fix Tegra194 HDA regression Sameer Pujar
2021-12-07 6:32 ` Sameer Pujar
2021-12-07 6:32 ` [PATCH 1/3] ALSA: hda/tegra: Skip reset on BPMP devices Sameer Pujar
2021-12-07 6:32 ` Sameer Pujar
2021-12-07 8:16 ` Thierry Reding
2021-12-07 8:16 ` Thierry Reding
2021-12-07 8:36 ` Takashi Iwai
2021-12-07 8:36 ` Takashi Iwai
2021-12-07 9:09 ` Sameer Pujar
2021-12-07 9:09 ` Sameer Pujar
2021-12-07 10:22 ` Dmitry Osipenko
2021-12-07 10:22 ` Dmitry Osipenko
2021-12-07 10:44 ` Dmitry Osipenko
2021-12-07 10:44 ` Dmitry Osipenko
2021-12-07 10:58 ` Dmitry Osipenko
2021-12-07 10:58 ` Dmitry Osipenko
2021-12-07 11:02 ` Jon Hunter
2021-12-07 11:02 ` Jon Hunter
2021-12-07 11:57 ` Dmitry Osipenko
2021-12-07 11:57 ` Dmitry Osipenko
2021-12-07 15:07 ` Jon Hunter
2021-12-07 15:07 ` Jon Hunter
2021-12-07 12:00 ` Sameer Pujar
2021-12-07 12:00 ` Sameer Pujar
2021-12-07 12:05 ` Dmitry Osipenko
2021-12-07 12:05 ` Dmitry Osipenko
2021-12-07 12:40 ` Sameer Pujar
2021-12-07 12:40 ` Sameer Pujar
2021-12-07 14:07 ` Dmitry Osipenko
2021-12-07 14:07 ` Dmitry Osipenko
2021-12-07 14:49 ` Sameer Pujar
2021-12-07 14:49 ` Sameer Pujar
2021-12-07 15:35 ` Dmitry Osipenko [this message]
2021-12-07 15:35 ` Dmitry Osipenko
2021-12-07 17:37 ` Sameer Pujar
2021-12-07 17:37 ` Sameer Pujar
2021-12-07 18:02 ` Dmitry Osipenko
2021-12-07 18:02 ` Dmitry Osipenko
2021-12-08 5:22 ` Sameer Pujar
2021-12-08 5:22 ` Sameer Pujar
2021-12-08 12:05 ` Dmitry Osipenko
2021-12-08 12:05 ` Dmitry Osipenko
2021-12-14 6:02 ` Sameer Pujar
2021-12-14 6:02 ` Sameer Pujar
2021-12-14 6:09 ` Dmitry Osipenko
2021-12-14 6:09 ` Dmitry Osipenko
2021-12-14 6:15 ` Dmitry Osipenko
2021-12-14 6:15 ` Dmitry Osipenko
2021-12-14 7:22 ` Sameer Pujar
2021-12-14 7:22 ` Sameer Pujar
2021-12-14 13:56 ` Dmitry Osipenko
2021-12-14 13:56 ` Dmitry Osipenko
2021-12-14 14:29 ` Takashi Iwai
2021-12-14 14:29 ` Takashi Iwai
2021-12-14 15:34 ` Dmitry Osipenko
2021-12-14 15:34 ` Dmitry Osipenko
2021-12-20 10:32 ` Sameer Pujar
2021-12-20 10:32 ` Sameer Pujar
2021-12-07 6:32 ` [PATCH 2/3] dt-bindings: sound: tegra: Update HDA resets Sameer Pujar
2021-12-07 6:32 ` Sameer Pujar
2021-12-07 8:18 ` Thierry Reding
2021-12-07 8:18 ` Thierry Reding
2021-12-07 9:27 ` Sameer Pujar
2021-12-07 9:27 ` Sameer Pujar
2021-12-07 10:14 ` Dmitry Osipenko
2021-12-07 10:14 ` Dmitry Osipenko
2021-12-07 11:04 ` Sameer Pujar
2021-12-07 11:04 ` Sameer Pujar
2021-12-07 12:02 ` Dmitry Osipenko
2021-12-07 12:02 ` Dmitry Osipenko
2021-12-07 12:22 ` Sameer Pujar
2021-12-07 12:22 ` Sameer Pujar
2021-12-07 6:32 ` [PATCH 3/3] arm64: tegra: Remove non existent Tegra194 reset Sameer Pujar
2021-12-07 6:32 ` Sameer Pujar
2021-12-07 8:04 ` [PATCH 0/3] Fix Tegra194 HDA regression Takashi Iwai
2021-12-07 8:04 ` Takashi Iwai
2021-12-07 8:21 ` Thierry Reding
2021-12-07 8:21 ` Thierry Reding
2021-12-07 8:47 ` Sameer Pujar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=95cc7efa-251c-690b-9afa-53ee9e052c34@gmail.com \
--to=digetx@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mkumard@nvidia.com \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=spujar@nvidia.com \
--cc=stable@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.