From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Ming Lei <ming.lei@redhat.com>, Jens Axboe <axboe@kernel.dk>,
Christoph Hellwig <hch@lst.de>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>
Cc: Sagi Grimberg <sagi@grimberg.me>, Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCH V2 1/5] nvme: add APIs for stopping/starting admin queue
Date: Fri, 1 Oct 2021 05:56:04 +0000 [thread overview]
Message-ID: <95d25bd6-f632-67cc-657e-5158c6412256@nvidia.com> (raw)
In-Reply-To: <20210930125621.1161726-2-ming.lei@redhat.com>
On 9/30/2021 5:56 AM, Ming Lei wrote:
> External email: Use caution opening links or attachments
>
>
> Add two APIs for stopping and starting admin queue.
>
> Signed-off-by: Ming Lei <ming.lei@redhat.com>
this patch looks good to me, but from the feedback I've received in past
we need to add the new functions in the patch where they are actually
used than adding it in a separate patch.
WARNING: multiple messages have this Message-ID (diff)
From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Ming Lei <ming.lei@redhat.com>, Jens Axboe <axboe@kernel.dk>,
Christoph Hellwig <hch@lst.de>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>
Cc: Sagi Grimberg <sagi@grimberg.me>, Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCH V2 1/5] nvme: add APIs for stopping/starting admin queue
Date: Fri, 1 Oct 2021 05:56:04 +0000 [thread overview]
Message-ID: <95d25bd6-f632-67cc-657e-5158c6412256@nvidia.com> (raw)
In-Reply-To: <20210930125621.1161726-2-ming.lei@redhat.com>
On 9/30/2021 5:56 AM, Ming Lei wrote:
> External email: Use caution opening links or attachments
>
>
> Add two APIs for stopping and starting admin queue.
>
> Signed-off-by: Ming Lei <ming.lei@redhat.com>
this patch looks good to me, but from the feedback I've received in past
we need to add the new functions in the patch where they are actually
used than adding it in a separate patch.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-10-01 5:56 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-30 12:56 [PATCH V2 0/5] blk-mq: support concurrent queue quiescing Ming Lei
2021-09-30 12:56 ` Ming Lei
2021-09-30 12:56 ` [PATCH V2 1/5] nvme: add APIs for stopping/starting admin queue Ming Lei
2021-09-30 12:56 ` Ming Lei
2021-10-01 5:56 ` Chaitanya Kulkarni [this message]
2021-10-01 5:56 ` Chaitanya Kulkarni
2021-10-05 2:23 ` Ming Lei
2021-10-05 2:23 ` Ming Lei
2021-10-05 3:38 ` Chaitanya Kulkarni
2021-10-05 3:38 ` Chaitanya Kulkarni
2021-10-05 8:04 ` Ming Lei
2021-10-05 8:04 ` Ming Lei
2021-10-11 11:39 ` Christoph Hellwig
2021-10-11 11:39 ` Christoph Hellwig
2021-10-13 4:25 ` Chaitanya Kulkarni
2021-10-13 4:25 ` Chaitanya Kulkarni
2021-09-30 12:56 ` [PATCH V2 2/5] nvme: apply nvme API to quiesce/unquiesce " Ming Lei
2021-09-30 12:56 ` Ming Lei
2021-10-01 5:57 ` Chaitanya Kulkarni
2021-10-01 5:57 ` Chaitanya Kulkarni
2021-09-30 12:56 ` [PATCH V2 3/5] nvme: prepare for pairing quiescing and unquiescing Ming Lei
2021-09-30 12:56 ` Ming Lei
2021-09-30 12:56 ` [PATCH V2 4/5] nvme: paring quiesce/unquiesce Ming Lei
2021-09-30 12:56 ` Ming Lei
2021-09-30 12:56 ` [PATCH V2 5/5] blk-mq: support concurrent queue quiesce/unquiesce Ming Lei
2021-09-30 12:56 ` Ming Lei
2021-09-30 15:56 ` Bart Van Assche
2021-09-30 15:56 ` Bart Van Assche
2021-10-05 2:31 ` Ming Lei
2021-10-05 2:31 ` Ming Lei
2021-10-08 3:22 ` yukuai (C)
2021-10-08 3:22 ` yukuai (C)
2021-10-08 5:10 ` Ming Lei
2021-10-08 5:10 ` Ming Lei
2021-10-08 6:22 ` yukuai (C)
2021-10-08 6:22 ` yukuai (C)
2021-10-08 6:35 ` Ming Lei
2021-10-08 6:35 ` Ming Lei
2021-10-08 7:13 ` yukuai (C)
2021-10-08 7:13 ` yukuai (C)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=95d25bd6-f632-67cc-657e-5158c6412256@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=ming.lei@redhat.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.