[Intel-wired-lan] [PATCH net v2] i40e: Fix parameters in aq_get_phy_register()

[Intel-wired-lan] [PATCH net v2] i40e: Fix parameters in aq_get_phy_register()

[Grzegorz Siwik]

Change parameters order in aq_get_phy_register() due to wrong
statistics in PHY reported by ethtool. Previosly all PHY statistics were
exactly the same for all interfaces
Now statistics are reported correctly - different for different interfaces

Fixes: 0514db37dd78 ("i40e: Extend PHY access with page change flag")
Signed-off-by: Grzegorz Siwik <grzegorz.siwik@intel.com>
---
v2:
-Changed target tree to net
---
 drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
index 96d5202..0e92668 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
@@ -5480,7 +5480,7 @@ static int i40e_get_module_eeprom(struct net_device *netdev,
 
 		status = i40e_aq_get_phy_register(hw,
 				I40E_AQ_PHY_REG_ACCESS_EXTERNAL_MODULE,
-				true, addr, offset, &value, NULL);
+				addr, true, offset, &value, NULL);
 		if (status)
 			return -EIO;
 		data[i] = value;
-- 
1.8.3.1

[Intel-wired-lan] [PATCH net v2] i40e: Fix parameters in aq_get_phy_register()

[Paul Menzel]

Dear Grzegorz,


Maybe use something like below as the commit message summary:

> i40e: ethtool: Report correct statistics for each interface

Am 22.03.21 um 16:11 schrieb Grzegorz Siwik:
> Change parameters order in aq_get_phy_register() due to wrong
> statistics in PHY reported by ethtool. Previosly all PHY statistics were

Nit: Previously

> exactly the same for all interfaces
> Now statistics are reported correctly - different for different interfaces
> 
> Fixes: 0514db37dd78 ("i40e: Extend PHY access with page change flag")
> Signed-off-by: Grzegorz Siwik <grzegorz.siwik@intel.com>
> ---
> v2:
> -Changed target tree to net
> ---
>   drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
> index 96d5202..0e92668 100644
> --- a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
> +++ b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
> @@ -5480,7 +5480,7 @@ static int i40e_get_module_eeprom(struct net_device *netdev,
>   
>   		status = i40e_aq_get_phy_register(hw,
>   				I40E_AQ_PHY_REG_ACCESS_EXTERNAL_MODULE,
> -				true, addr, offset, &value, NULL);
> +				addr, true, offset, &value, NULL);
>   		if (status)
>   			return -EIO;
>   		data[i] = value;

The rest looks good.


Kind regards,

Paul