All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Hildenbrand <david@redhat.com>
To: nixiaoming <nixiaoming@huawei.com>,
	agraf@suse.com, pbonzini@redhat.com, rkrcmar@redhat.com,
	benh@kernel.crashing.org, paulus@samba.org, mpe@ellerman.id.au
Cc: kvm-ppc@vger.kernel.org, kvm@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fix memory leak on kvm_vm_ioctl_create_spapr_tce
Date: Tue, 22 Aug 2017 17:15:53 +0200	[thread overview]
Message-ID: <95fe182a-fd21-77a1-33df-0e609c2845fd@redhat.com> (raw)
In-Reply-To: <20170822142823.69425-1-nixiaoming@huawei.com>

On 22.08.2017 16:28, nixiaoming wrote:
> miss kfree(stt) when anon_inode_getfd return fail
> so add check anon_inode_getfd return val, and kfree stt
> 
> Signed-off-by: nixiaoming <nixiaoming@huawei.com>
> ---
>  arch/powerpc/kvm/book3s_64_vio.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/powerpc/kvm/book3s_64_vio.c b/arch/powerpc/kvm/book3s_64_vio.c
> index a160c14..a0b4459 100644
> --- a/arch/powerpc/kvm/book3s_64_vio.c
> +++ b/arch/powerpc/kvm/book3s_64_vio.c
> @@ -341,8 +341,11 @@ long kvm_vm_ioctl_create_spapr_tce(struct kvm *kvm,
>  
>  	mutex_unlock(&kvm->lock);
>  
> -	return anon_inode_getfd("kvm-spapr-tce", &kvm_spapr_tce_fops,
> +	ret = anon_inode_getfd("kvm-spapr-tce", &kvm_spapr_tce_fops,
>  				stt, O_RDWR | O_CLOEXEC);
> +	if (ret < 0)
> +		goto fail;
> +	return ret;
>  
>  fail:
>  	if (stt) {
> 


stt has already been added to kvm->arch.spapr_tce_tables, so freeing it
is evil IMHO. I don't know that code, so I don't know if there is some
other place that will make sure that everything in
kvm->arch.spapr_tce_tables will properly get freed, even when no release
function has been called (kvm_spapr_tce_release).
-- 

Thanks,

David

WARNING: multiple messages have this Message-ID (diff)
From: David Hildenbrand <david@redhat.com>
To: nixiaoming <nixiaoming@huawei.com>,
	agraf@suse.com, pbonzini@redhat.com, rkrcmar@redhat.com,
	benh@kernel.crashing.org, paulus@samba.org, mpe@ellerman.id.au
Cc: kvm-ppc@vger.kernel.org, kvm@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fix memory leak on kvm_vm_ioctl_create_spapr_tce
Date: Tue, 22 Aug 2017 15:15:53 +0000	[thread overview]
Message-ID: <95fe182a-fd21-77a1-33df-0e609c2845fd@redhat.com> (raw)
In-Reply-To: <20170822142823.69425-1-nixiaoming@huawei.com>

On 22.08.2017 16:28, nixiaoming wrote:
> miss kfree(stt) when anon_inode_getfd return fail
> so add check anon_inode_getfd return val, and kfree stt
> 
> Signed-off-by: nixiaoming <nixiaoming@huawei.com>
> ---
>  arch/powerpc/kvm/book3s_64_vio.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/powerpc/kvm/book3s_64_vio.c b/arch/powerpc/kvm/book3s_64_vio.c
> index a160c14..a0b4459 100644
> --- a/arch/powerpc/kvm/book3s_64_vio.c
> +++ b/arch/powerpc/kvm/book3s_64_vio.c
> @@ -341,8 +341,11 @@ long kvm_vm_ioctl_create_spapr_tce(struct kvm *kvm,
>  
>  	mutex_unlock(&kvm->lock);
>  
> -	return anon_inode_getfd("kvm-spapr-tce", &kvm_spapr_tce_fops,
> +	ret = anon_inode_getfd("kvm-spapr-tce", &kvm_spapr_tce_fops,
>  				stt, O_RDWR | O_CLOEXEC);
> +	if (ret < 0)
> +		goto fail;
> +	return ret;
>  
>  fail:
>  	if (stt) {
> 


stt has already been added to kvm->arch.spapr_tce_tables, so freeing it
is evil IMHO. I don't know that code, so I don't know if there is some
other place that will make sure that everything in
kvm->arch.spapr_tce_tables will properly get freed, even when no release
function has been called (kvm_spapr_tce_release).
-- 

Thanks,

David

  reply	other threads:[~2017-08-22 15:16 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-22 14:28 [PATCH] fix memory leak on kvm_vm_ioctl_create_spapr_tce nixiaoming
2017-08-22 14:28 ` nixiaoming
2017-08-22 15:15 ` David Hildenbrand [this message]
2017-08-22 15:15   ` David Hildenbrand
2017-08-22 15:23   ` David Hildenbrand
2017-08-22 15:23     ` David Hildenbrand
2017-08-23  1:43     ` Nixiaoming
2017-08-23  1:43       ` Nixiaoming
2017-08-23  1:43       ` Nixiaoming
2017-08-23  6:06       ` Paul Mackerras
2017-08-23  6:06         ` Paul Mackerras
2017-08-23  8:25         ` David Hildenbrand
2017-08-23  8:25           ` David Hildenbrand
2017-08-23  9:16           ` David Hildenbrand
2017-08-23  9:16             ` David Hildenbrand
2017-08-23 10:17           ` 答复: " Nixiaoming
2017-08-23 10:17             ` 答复: [PATCH] fix memory leak on kvm_vm_ioc =?utf-8?B?dGxfY3JlYXRlX3NwY Nixiaoming
2017-08-23 10:17             ` 答复: [PATCH] fix memory leak on kvm_vm_ioctl_create_spapr_tce Nixiaoming
2017-08-24  1:06           ` Nixiaoming
2017-08-24  1:06             ` Nixiaoming
2017-08-24  1:06             ` Nixiaoming
2017-08-27 21:02         ` Al Viro
2017-08-27 21:02           ` Al Viro
2017-08-28  4:38           ` Paul Mackerras
2017-08-28  4:38             ` Paul Mackerras
2017-08-28  5:28             ` Al Viro
2017-08-28  5:28               ` Al Viro
2017-08-28  6:06               ` Paul Mackerras
2017-08-28  6:06                 ` Paul Mackerras
2017-08-28 11:31               ` Michael Ellerman
2017-08-28 11:31                 ` Michael Ellerman
  -- strict thread matches above, loose matches on Subject: below --
2017-08-22 14:18 [PATCH] fix memory leak on kvm_vm_ioctl_get_htab_fd nixiaoming
2017-08-22 14:18 ` nixiaoming
2017-08-22 15:51 ` Paolo Bonzini
2017-08-22 15:51   ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=95fe182a-fd21-77a1-33df-0e609c2845fd@redhat.com \
    --to=david@redhat.com \
    --cc=agraf@suse.com \
    --cc=benh@kernel.crashing.org \
    --cc=kvm-ppc@vger.kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mpe@ellerman.id.au \
    --cc=nixiaoming@huawei.com \
    --cc=paulus@samba.org \
    --cc=pbonzini@redhat.com \
    --cc=rkrcmar@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.