* [PATCH iproute2] ss: mptcp: fix add_addr_accepted stat print
@ 2020-11-18 14:24 Andrea Claudi
2020-11-18 15:05 ` Matthieu Baerts
2020-12-15 21:59 ` Stephen Hemminger
0 siblings, 2 replies; 3+ messages in thread
From: Andrea Claudi @ 2020-11-18 14:24 UTC (permalink / raw)
To: netdev; +Cc: stephen, dsahern
add_addr_accepted value is not printed if add_addr_signal value is 0.
Fix this properly looking for add_addr_accepted value, instead.
Fixes: 9c3be2c0eee01 ("ss: mptcp: add msk diag interface support")
Signed-off-by: Andrea Claudi <aclaudi@redhat.com>
---
misc/ss.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/misc/ss.c b/misc/ss.c
index 77e1847ee2473..0593627b77e31 100644
--- a/misc/ss.c
+++ b/misc/ss.c
@@ -3136,7 +3136,7 @@ static void mptcp_stats_print(struct mptcp_info *s)
out(" subflows:%d", s->mptcpi_subflows);
if (s->mptcpi_add_addr_signal)
out(" add_addr_signal:%d", s->mptcpi_add_addr_signal);
- if (s->mptcpi_add_addr_signal)
+ if (s->mptcpi_add_addr_accepted)
out(" add_addr_accepted:%d", s->mptcpi_add_addr_accepted);
if (s->mptcpi_subflows_max)
out(" subflows_max:%d", s->mptcpi_subflows_max);
--
2.26.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH iproute2] ss: mptcp: fix add_addr_accepted stat print
2020-11-18 14:24 [PATCH iproute2] ss: mptcp: fix add_addr_accepted stat print Andrea Claudi
@ 2020-11-18 15:05 ` Matthieu Baerts
2020-12-15 21:59 ` Stephen Hemminger
1 sibling, 0 replies; 3+ messages in thread
From: Matthieu Baerts @ 2020-11-18 15:05 UTC (permalink / raw)
To: Andrea Claudi, netdev; +Cc: stephen, dsahern
Hi Andrea,
On 18/11/2020 15:24, Andrea Claudi wrote:
> add_addr_accepted value is not printed if add_addr_signal value is 0.
> Fix this properly looking for add_addr_accepted value, instead.
Good catch! We missed that when reviewing the code on MPTCP ML!
Acked-by: Matthieu Baerts <matthieu.baerts@tessares.net>
Cheers,
Matt
--
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH iproute2] ss: mptcp: fix add_addr_accepted stat print
2020-11-18 14:24 [PATCH iproute2] ss: mptcp: fix add_addr_accepted stat print Andrea Claudi
2020-11-18 15:05 ` Matthieu Baerts
@ 2020-12-15 21:59 ` Stephen Hemminger
1 sibling, 0 replies; 3+ messages in thread
From: Stephen Hemminger @ 2020-12-15 21:59 UTC (permalink / raw)
To: Andrea Claudi; +Cc: netdev, dsahern
On Wed, 18 Nov 2020 15:24:18 +0100
Andrea Claudi <aclaudi@redhat.com> wrote:
> add_addr_accepted value is not printed if add_addr_signal value is 0.
> Fix this properly looking for add_addr_accepted value, instead.
>
> Fixes: 9c3be2c0eee01 ("ss: mptcp: add msk diag interface support")
> Signed-off-by: Andrea Claudi <aclaudi@redhat.com>
> ---
Applied, this seems to have gotten lost somehow from patchwork.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-12-15 22:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-18 14:24 [PATCH iproute2] ss: mptcp: fix add_addr_accepted stat print Andrea Claudi
2020-11-18 15:05 ` Matthieu Baerts
2020-12-15 21:59 ` Stephen Hemminger
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.