[PATCH v2 04/18] arm64: dts: m3ulcb-kf: initial device tree

[PATCH v2 04/18] arm64: dts: m3ulcb-kf: initial device tree

[Vladimir Barinov]

Add the initial device tree for the M3ULCB with Kingfisher extension
infotainment board.

Signed-off-by: Vladimir Barinov <vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
---
Changes in version 2:
- added own compatible value "shimafuji,kingfisher"

 arch/arm64/boot/dts/renesas/Makefile              |  1 +
 arch/arm64/boot/dts/renesas/r8a7796-m3ulcb-kf.dts | 17 +++++++++++++++++
 2 files changed, 18 insertions(+)
 create mode 100644 arch/arm64/boot/dts/renesas/r8a7796-m3ulcb-kf.dts

diff --git a/arch/arm64/boot/dts/renesas/Makefile b/arch/arm64/boot/dts/renesas/Makefile
index 381928b..54e8316 100644
--- a/arch/arm64/boot/dts/renesas/Makefile
+++ b/arch/arm64/boot/dts/renesas/Makefile
@@ -2,6 +2,7 @@ dtb-$(CONFIG_ARCH_R8A7795) += r8a7795-salvator-x.dtb r8a7795-h3ulcb.dtb
 dtb-$(CONFIG_ARCH_R8A7795) += r8a7795-salvator-xs.dtb
 dtb-$(CONFIG_ARCH_R8A7795) += r8a7795-es1-salvator-x.dtb r8a7795-es1-h3ulcb.dtb
 dtb-$(CONFIG_ARCH_R8A7796) += r8a7796-salvator-x.dtb r8a7796-m3ulcb.dtb
+dtb-$(CONFIG_ARCH_R8A7796) += r8a7796-m3ulcb-kf.dtb
 dtb-$(CONFIG_ARCH_R8A77995) += r8a77995-draak.dtb
 
 always		:= $(dtb-y)
diff --git a/arch/arm64/boot/dts/renesas/r8a7796-m3ulcb-kf.dts b/arch/arm64/boot/dts/renesas/r8a7796-m3ulcb-kf.dts
new file mode 100644
index 0000000..22fad76c
--- /dev/null
+++ b/arch/arm64/boot/dts/renesas/r8a7796-m3ulcb-kf.dts
@@ -0,0 +1,19 @@
+/*
+ * Device Tree Source for the M3ULCB Kingfisher board
+ *
+ * Copyright (C) 2017 Renesas Electronics Corp.
+ * Copyright (C) 2017 Cogent Embedded, Inc.
+ *
+ * This file is licensed under the terms of the GNU General Public License
+ * version 2.  This program is licensed "as is" without any warranty of any
+ * kind, whether express or implied.
+ */
+
+#include "r8a7796-m3ulcb.dts"
+#include "ulcb-kf.dtsi"
+
+/ {
+	model = "Renesas M3ULCB Kingfisher board based on r8a7796";
+	compatible = "shimafuji,kingfisher", "renesas,m3ulcb",
+		     "renesas,r8a7796";
+};
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH v2 04/18] arm64: dts: m3ulcb-kf: initial device tree

[Vladimir Barinov]

Add the initial device tree for the M3ULCB with Kingfisher extension
infotainment board.

Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
---
Changes in version 2:
- added own compatible value "shimafuji,kingfisher"

 arch/arm64/boot/dts/renesas/Makefile              |  1 +
 arch/arm64/boot/dts/renesas/r8a7796-m3ulcb-kf.dts | 17 +++++++++++++++++
 2 files changed, 18 insertions(+)
 create mode 100644 arch/arm64/boot/dts/renesas/r8a7796-m3ulcb-kf.dts

diff --git a/arch/arm64/boot/dts/renesas/Makefile b/arch/arm64/boot/dts/renesas/Makefile
index 381928b..54e8316 100644
--- a/arch/arm64/boot/dts/renesas/Makefile
+++ b/arch/arm64/boot/dts/renesas/Makefile
@@ -2,6 +2,7 @@ dtb-$(CONFIG_ARCH_R8A7795) += r8a7795-salvator-x.dtb r8a7795-h3ulcb.dtb
 dtb-$(CONFIG_ARCH_R8A7795) += r8a7795-salvator-xs.dtb
 dtb-$(CONFIG_ARCH_R8A7795) += r8a7795-es1-salvator-x.dtb r8a7795-es1-h3ulcb.dtb
 dtb-$(CONFIG_ARCH_R8A7796) += r8a7796-salvator-x.dtb r8a7796-m3ulcb.dtb
+dtb-$(CONFIG_ARCH_R8A7796) += r8a7796-m3ulcb-kf.dtb
 dtb-$(CONFIG_ARCH_R8A77995) += r8a77995-draak.dtb
 
 always		:= $(dtb-y)
diff --git a/arch/arm64/boot/dts/renesas/r8a7796-m3ulcb-kf.dts b/arch/arm64/boot/dts/renesas/r8a7796-m3ulcb-kf.dts
new file mode 100644
index 0000000..22fad76c
--- /dev/null
+++ b/arch/arm64/boot/dts/renesas/r8a7796-m3ulcb-kf.dts
@@ -0,0 +1,19 @@
+/*
+ * Device Tree Source for the M3ULCB Kingfisher board
+ *
+ * Copyright (C) 2017 Renesas Electronics Corp.
+ * Copyright (C) 2017 Cogent Embedded, Inc.
+ *
+ * This file is licensed under the terms of the GNU General Public License
+ * version 2.  This program is licensed "as is" without any warranty of any
+ * kind, whether express or implied.
+ */
+
+#include "r8a7796-m3ulcb.dts"
+#include "ulcb-kf.dtsi"
+
+/ {
+	model = "Renesas M3ULCB Kingfisher board based on r8a7796";
+	compatible = "shimafuji,kingfisher", "renesas,m3ulcb",
+		     "renesas,r8a7796";
+};
-- 
1.9.1

Re: [PATCH v2 04/18] arm64: dts: m3ulcb-kf: initial device tree

[Geert Uytterhoeven]

Hi Vladimir,

[CC Pantelis]

On Thu, Sep 14, 2017 at 4:18 PM, Vladimir Barinov
<vladimir.barinov@cogentembedded.com> wrote:
> Add the initial device tree for the M3ULCB with Kingfisher extension
> infotainment board.
>
> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
> ---
> Changes in version 2:
> - added own compatible value "shimafuji,kingfisher"

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Some food for thought below...

> --- /dev/null
> +++ b/arch/arm64/boot/dts/renesas/r8a7796-m3ulcb-kf.dts
> @@ -0,0 +1,19 @@
> +/*
> + * Device Tree Source for the M3ULCB Kingfisher board
> + *
> + * Copyright (C) 2017 Renesas Electronics Corp.
> + * Copyright (C) 2017 Cogent Embedded, Inc.
> + *
> + * This file is licensed under the terms of the GNU General Public License
> + * version 2.  This program is licensed "as is" without any warranty of any
> + * kind, whether express or implied.
> + */
> +
> +#include "r8a7796-m3ulcb.dts"

Ideally, we don't include *.dts files, only *.dtsi.
But I don't see a better immediate solution.

> +#include "ulcb-kf.dtsi"

As the Kingfisher is actually an expansion board for H3ULCB (with R-Car H3
ES1.1 and ES2.0) and M3ULCB (with R-Car M3-W), turning ulcb-kf.dtsi into a
DT overlay would make sense.
That would also solve the issue of the 3 extra DTSes needed for all possible
combinations of ULCB and Kingfisher (r8a7795-es1-h3ulcb-kf.dts,
r8a7795-h3ulcb-kf.dts, r8a7796-h3ulcb-kf.dts (perhaps more to follow?)).

But that's too premature, without upstream support for the easy loading of
DT overlays.

> +/ {
> +       model = "Renesas M3ULCB Kingfisher board based on r8a7796";
> +       compatible = "shimafuji,kingfisher", "renesas,m3ulcb",
> +                    "renesas,r8a7796";
> +};

And how to support from an overlay the addition of "shimafuji,kingfisher" to
(not replacement of!) the main compatible value?

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH v2 04/18] arm64: dts: m3ulcb-kf: initial device tree

[Simon Horman]

On Wed, Sep 20, 2017 at 02:32:28PM +0200, Geert Uytterhoeven wrote:
> Hi Vladimir,
> 
> [CC Pantelis]
> 
> On Thu, Sep 14, 2017 at 4:18 PM, Vladimir Barinov
> <vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org> wrote:
> > Add the initial device tree for the M3ULCB with Kingfisher extension
> > infotainment board.
> >
> > Signed-off-by: Vladimir Barinov <vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
> > ---
> > Changes in version 2:
> > - added own compatible value "shimafuji,kingfisher"
> 
> Reviewed-by: Geert Uytterhoeven <geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>

Thanks, applied.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 04/18] arm64: dts: m3ulcb-kf: initial device tree

[Simon Horman]

On Wed, Sep 20, 2017 at 02:32:28PM +0200, Geert Uytterhoeven wrote:
> Hi Vladimir,
> 
> [CC Pantelis]
> 
> On Thu, Sep 14, 2017 at 4:18 PM, Vladimir Barinov
> <vladimir.barinov@cogentembedded.com> wrote:
> > Add the initial device tree for the M3ULCB with Kingfisher extension
> > infotainment board.
> >
> > Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
> > ---
> > Changes in version 2:
> > - added own compatible value "shimafuji,kingfisher"
> 
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Thanks, applied.

Re: [PATCH v2 04/18] arm64: dts: m3ulcb-kf: initial device tree

[Simon Horman]

On Thu, Sep 21, 2017 at 10:20:06AM +0200, Simon Horman wrote:
> On Wed, Sep 20, 2017 at 02:32:28PM +0200, Geert Uytterhoeven wrote:
> > Hi Vladimir,
> > 
> > [CC Pantelis]
> > 
> > On Thu, Sep 14, 2017 at 4:18 PM, Vladimir Barinov
> > <vladimir.barinov@cogentembedded.com> wrote:
> > > Add the initial device tree for the M3ULCB with Kingfisher extension
> > > infotainment board.
> > >
> > > Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
> > > ---
> > > Changes in version 2:
> > > - added own compatible value "shimafuji,kingfisher"
> > 
> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> 
> Thanks, applied.

Sorry, I spoke to soon. I seem to be missing
[PATCH v2 03/18] arm64: dts: ulcb-kf: initial device tree

Re: [PATCH v2 04/18] arm64: dts: m3ulcb-kf: initial device tree

[Pantelis Antoniou]

Hi Geert,

On Wed, 2017-09-20 at 14:32 +0200, Geert Uytterhoeven wrote:
> Hi Vladimir,
> 
> [CC Pantelis]
> 
> On Thu, Sep 14, 2017 at 4:18 PM, Vladimir Barinov
> <vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org> wrote:
> > Add the initial device tree for the M3ULCB with Kingfisher extension
> > infotainment board.
> >
> > Signed-off-by: Vladimir Barinov <vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
> > ---
> > Changes in version 2:
> > - added own compatible value "shimafuji,kingfisher"
> 
> Reviewed-by: Geert Uytterhoeven <geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>
> 
> Some food for thought below...
> 
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/renesas/r8a7796-m3ulcb-kf.dts
> > @@ -0,0 +1,19 @@
> > +/*
> > + * Device Tree Source for the M3ULCB Kingfisher board
> > + *
> > + * Copyright (C) 2017 Renesas Electronics Corp.
> > + * Copyright (C) 2017 Cogent Embedded, Inc.
> > + *
> > + * This file is licensed under the terms of the GNU General Public License
> > + * version 2.  This program is licensed "as is" without any warranty of any
> > + * kind, whether express or implied.
> > + */
> > +
> > +#include "r8a7796-m3ulcb.dts"
> 
> Ideally, we don't include *.dts files, only *.dtsi.
> But I don't see a better immediate solution.
> 
> > +#include "ulcb-kf.dtsi"
> 
> As the Kingfisher is actually an expansion board for H3ULCB (with R-Car H3
> ES1.1 and ES2.0) and M3ULCB (with R-Car M3-W), turning ulcb-kf.dtsi into a
> DT overlay would make sense.
> That would also solve the issue of the 3 extra DTSes needed for all possible
> combinations of ULCB and Kingfisher (r8a7795-es1-h3ulcb-kf.dts,
> r8a7795-h3ulcb-kf.dts, r8a7796-h3ulcb-kf.dts (perhaps more to follow?)).
> 
> But that's too premature, without upstream support for the easy loading of
> DT overlays.
> 

Sigh, yes.

> > +/ {
> > +       model = "Renesas M3ULCB Kingfisher board based on r8a7796";
> > +       compatible = "shimafuji,kingfisher", "renesas,m3ulcb",
> > +                    "renesas,r8a7796";
> > +};
> 
> And how to support from an overlay the addition of "shimafuji,kingfisher" to
> (not replacement of!) the main compatible value?
> 

You can hack something in DT but it will be gross indeed.

Ideally you'd want a += operator, but it's going to take a lot of
changes starting from DTB blob format.

In yaml we could easily do this with an append tag type

compatible: [ "renesas,m3ulcb", "renesas,r8a7796" ]

compatible: !append "shimafuji,kingfisher"

Are you going to be at ELCE? I have a bunch of thing to ask you about
your DT usage patterns.

Regards

-- Pantelis

> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds


--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 04/18] arm64: dts: m3ulcb-kf: initial device tree

[Pantelis Antoniou]

Hi Geert,

On Wed, 2017-09-20 at 14:32 +0200, Geert Uytterhoeven wrote:
> Hi Vladimir,
> 
> [CC Pantelis]
> 
> On Thu, Sep 14, 2017 at 4:18 PM, Vladimir Barinov
> <vladimir.barinov@cogentembedded.com> wrote:
> > Add the initial device tree for the M3ULCB with Kingfisher extension
> > infotainment board.
> >
> > Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
> > ---
> > Changes in version 2:
> > - added own compatible value "shimafuji,kingfisher"
> 
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> 
> Some food for thought below...
> 
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/renesas/r8a7796-m3ulcb-kf.dts
> > @@ -0,0 +1,19 @@
> > +/*
> > + * Device Tree Source for the M3ULCB Kingfisher board
> > + *
> > + * Copyright (C) 2017 Renesas Electronics Corp.
> > + * Copyright (C) 2017 Cogent Embedded, Inc.
> > + *
> > + * This file is licensed under the terms of the GNU General Public License
> > + * version 2.  This program is licensed "as is" without any warranty of any
> > + * kind, whether express or implied.
> > + */
> > +
> > +#include "r8a7796-m3ulcb.dts"
> 
> Ideally, we don't include *.dts files, only *.dtsi.
> But I don't see a better immediate solution.
> 
> > +#include "ulcb-kf.dtsi"
> 
> As the Kingfisher is actually an expansion board for H3ULCB (with R-Car H3
> ES1.1 and ES2.0) and M3ULCB (with R-Car M3-W), turning ulcb-kf.dtsi into a
> DT overlay would make sense.
> That would also solve the issue of the 3 extra DTSes needed for all possible
> combinations of ULCB and Kingfisher (r8a7795-es1-h3ulcb-kf.dts,
> r8a7795-h3ulcb-kf.dts, r8a7796-h3ulcb-kf.dts (perhaps more to follow?)).
> 
> But that's too premature, without upstream support for the easy loading of
> DT overlays.
> 

Sigh, yes.

> > +/ {
> > +       model = "Renesas M3ULCB Kingfisher board based on r8a7796";
> > +       compatible = "shimafuji,kingfisher", "renesas,m3ulcb",
> > +                    "renesas,r8a7796";
> > +};
> 
> And how to support from an overlay the addition of "shimafuji,kingfisher" to
> (not replacement of!) the main compatible value?
> 

You can hack something in DT but it will be gross indeed.

Ideally you'd want a += operator, but it's going to take a lot of
changes starting from DTB blob format.

In yaml we could easily do this with an append tag type

compatible: [ "renesas,m3ulcb", "renesas,r8a7796" ]

compatible: !append "shimafuji,kingfisher"

Are you going to be at ELCE? I have a bunch of thing to ask you about
your DT usage patterns.

Regards

-- Pantelis

> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds

Re: [PATCH v2 04/18] arm64: dts: m3ulcb-kf: initial device tree

[Geert Uytterhoeven]

Hi Pantelis,

On Thu, Sep 21, 2017 at 10:51 AM, Pantelis Antoniou
<pantelis.antoniou-OWPKS81ov/FWk0Htik3J/w@public.gmane.org> wrote:
> On Wed, 2017-09-20 at 14:32 +0200, Geert Uytterhoeven wrote:
>> On Thu, Sep 14, 2017 at 4:18 PM, Vladimir Barinov
>> <vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org> wrote:
>> > +#include "ulcb-kf.dtsi"
>>
>> As the Kingfisher is actually an expansion board for H3ULCB (with R-Car H3
>> ES1.1 and ES2.0) and M3ULCB (with R-Car M3-W), turning ulcb-kf.dtsi into a
>> DT overlay would make sense.
>> That would also solve the issue of the 3 extra DTSes needed for all possible
>> combinations of ULCB and Kingfisher (r8a7795-es1-h3ulcb-kf.dts,
>> r8a7795-h3ulcb-kf.dts, r8a7796-h3ulcb-kf.dts (perhaps more to follow?)).
>>
>> But that's too premature, without upstream support for the easy loading of
>> DT overlays.
>>
>
> Sigh, yes.
>
>> > +/ {
>> > +       model = "Renesas M3ULCB Kingfisher board based on r8a7796";
>> > +       compatible = "shimafuji,kingfisher", "renesas,m3ulcb",
>> > +                    "renesas,r8a7796";
>> > +};
>>
>> And how to support from an overlay the addition of "shimafuji,kingfisher" to
>> (not replacement of!) the main compatible value?
>
> You can hack something in DT but it will be gross indeed.
>
> Ideally you'd want a += operator, but it's going to take a lot of
> changes starting from DTB blob format.
>
> In yaml we could easily do this with an append tag type
>
> compatible: [ "renesas,m3ulcb", "renesas,r8a7796" ]
>
> compatible: !append "shimafuji,kingfisher"

As we already have /delete-property/, we could add /append-property/ and
/prepend-property/? Would be useful for a .dts including and enhancing
an .dtsi, too.

That doesn't solve the DTB blob format issue yet, though.

> Are you going to be at ELCE? I have a bunch of thing to ask you about
> your DT usage patterns.

Yes, and registered for the Device Tree Workshop.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 04/18] arm64: dts: m3ulcb-kf: initial device tree

[Geert Uytterhoeven]

Hi Pantelis,

On Thu, Sep 21, 2017 at 10:51 AM, Pantelis Antoniou
<pantelis.antoniou@konsulko.com> wrote:
> On Wed, 2017-09-20 at 14:32 +0200, Geert Uytterhoeven wrote:
>> On Thu, Sep 14, 2017 at 4:18 PM, Vladimir Barinov
>> <vladimir.barinov@cogentembedded.com> wrote:
>> > +#include "ulcb-kf.dtsi"
>>
>> As the Kingfisher is actually an expansion board for H3ULCB (with R-Car H3
>> ES1.1 and ES2.0) and M3ULCB (with R-Car M3-W), turning ulcb-kf.dtsi into a
>> DT overlay would make sense.
>> That would also solve the issue of the 3 extra DTSes needed for all possible
>> combinations of ULCB and Kingfisher (r8a7795-es1-h3ulcb-kf.dts,
>> r8a7795-h3ulcb-kf.dts, r8a7796-h3ulcb-kf.dts (perhaps more to follow?)).
>>
>> But that's too premature, without upstream support for the easy loading of
>> DT overlays.
>>
>
> Sigh, yes.
>
>> > +/ {
>> > +       model = "Renesas M3ULCB Kingfisher board based on r8a7796";
>> > +       compatible = "shimafuji,kingfisher", "renesas,m3ulcb",
>> > +                    "renesas,r8a7796";
>> > +};
>>
>> And how to support from an overlay the addition of "shimafuji,kingfisher" to
>> (not replacement of!) the main compatible value?
>
> You can hack something in DT but it will be gross indeed.
>
> Ideally you'd want a += operator, but it's going to take a lot of
> changes starting from DTB blob format.
>
> In yaml we could easily do this with an append tag type
>
> compatible: [ "renesas,m3ulcb", "renesas,r8a7796" ]
>
> compatible: !append "shimafuji,kingfisher"

As we already have /delete-property/, we could add /append-property/ and
/prepend-property/? Would be useful for a .dts including and enhancing
an .dtsi, too.

That doesn't solve the DTB blob format issue yet, though.

> Are you going to be at ELCE? I have a bunch of thing to ask you about
> your DT usage patterns.

Yes, and registered for the Device Tree Workshop.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH v2 04/18] arm64: dts: m3ulcb-kf: initial device tree

[Pantelis Antoniou]

Hi Geert,

On Thu, 2017-09-21 at 11:10 +0200, Geert Uytterhoeven wrote:
> Hi Pantelis,
> 
> On Thu, Sep 21, 2017 at 10:51 AM, Pantelis Antoniou
> <pantelis.antoniou-OWPKS81ov/FWk0Htik3J/w@public.gmane.org> wrote:
> > On Wed, 2017-09-20 at 14:32 +0200, Geert Uytterhoeven wrote:
> >> On Thu, Sep 14, 2017 at 4:18 PM, Vladimir Barinov
> >> <vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org> wrote:
> >> > +#include "ulcb-kf.dtsi"
> >>
> >> As the Kingfisher is actually an expansion board for H3ULCB (with R-Car H3
> >> ES1.1 and ES2.0) and M3ULCB (with R-Car M3-W), turning ulcb-kf.dtsi into a
> >> DT overlay would make sense.
> >> That would also solve the issue of the 3 extra DTSes needed for all possible
> >> combinations of ULCB and Kingfisher (r8a7795-es1-h3ulcb-kf.dts,
> >> r8a7795-h3ulcb-kf.dts, r8a7796-h3ulcb-kf.dts (perhaps more to follow?)).
> >>
> >> But that's too premature, without upstream support for the easy loading of
> >> DT overlays.
> >>
> >
> > Sigh, yes.
> >
> >> > +/ {
> >> > +       model = "Renesas M3ULCB Kingfisher board based on r8a7796";
> >> > +       compatible = "shimafuji,kingfisher", "renesas,m3ulcb",
> >> > +                    "renesas,r8a7796";
> >> > +};
> >>
> >> And how to support from an overlay the addition of "shimafuji,kingfisher" to
> >> (not replacement of!) the main compatible value?
> >
> > You can hack something in DT but it will be gross indeed.
> >
> > Ideally you'd want a += operator, but it's going to take a lot of
> > changes starting from DTB blob format.
> >
> > In yaml we could easily do this with an append tag type
> >
> > compatible: [ "renesas,m3ulcb", "renesas,r8a7796" ]
> >
> > compatible: !append "shimafuji,kingfisher"
> 
> As we already have /delete-property/, we could add /append-property/ and
> /prepend-property/? Would be useful for a .dts including and enhancing
> an .dtsi, too.
> 

Yes, that would work on the DTS source level. Doesn't help at runtime.

> That doesn't solve the DTB blob format issue yet, though.
> 

Right. The tree and property deletion commands do not have a mapping to
the DTB format. You could add special characters to a property name and
have the overlay application code do something about it.

For instance the original overlay submission did support property and
node deletion by using '-property' & '-node'. Alas it was removed.

> > Are you going to be at ELCE? I have a bunch of thing to ask you about
> > your DT usage patterns.
> 
> Yes, and registered for the Device Tree Workshop.
> 

Great. See you then.

> Gr{oetje,eeting}s,
> 
>                         Geert
> 

Regards

-- Pantelis

> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds


--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 04/18] arm64: dts: m3ulcb-kf: initial device tree

[Pantelis Antoniou]

Hi Geert,

On Thu, 2017-09-21 at 11:10 +0200, Geert Uytterhoeven wrote:
> Hi Pantelis,
> 
> On Thu, Sep 21, 2017 at 10:51 AM, Pantelis Antoniou
> <pantelis.antoniou@konsulko.com> wrote:
> > On Wed, 2017-09-20 at 14:32 +0200, Geert Uytterhoeven wrote:
> >> On Thu, Sep 14, 2017 at 4:18 PM, Vladimir Barinov
> >> <vladimir.barinov@cogentembedded.com> wrote:
> >> > +#include "ulcb-kf.dtsi"
> >>
> >> As the Kingfisher is actually an expansion board for H3ULCB (with R-Car H3
> >> ES1.1 and ES2.0) and M3ULCB (with R-Car M3-W), turning ulcb-kf.dtsi into a
> >> DT overlay would make sense.
> >> That would also solve the issue of the 3 extra DTSes needed for all possible
> >> combinations of ULCB and Kingfisher (r8a7795-es1-h3ulcb-kf.dts,
> >> r8a7795-h3ulcb-kf.dts, r8a7796-h3ulcb-kf.dts (perhaps more to follow?)).
> >>
> >> But that's too premature, without upstream support for the easy loading of
> >> DT overlays.
> >>
> >
> > Sigh, yes.
> >
> >> > +/ {
> >> > +       model = "Renesas M3ULCB Kingfisher board based on r8a7796";
> >> > +       compatible = "shimafuji,kingfisher", "renesas,m3ulcb",
> >> > +                    "renesas,r8a7796";
> >> > +};
> >>
> >> And how to support from an overlay the addition of "shimafuji,kingfisher" to
> >> (not replacement of!) the main compatible value?
> >
> > You can hack something in DT but it will be gross indeed.
> >
> > Ideally you'd want a += operator, but it's going to take a lot of
> > changes starting from DTB blob format.
> >
> > In yaml we could easily do this with an append tag type
> >
> > compatible: [ "renesas,m3ulcb", "renesas,r8a7796" ]
> >
> > compatible: !append "shimafuji,kingfisher"
> 
> As we already have /delete-property/, we could add /append-property/ and
> /prepend-property/? Would be useful for a .dts including and enhancing
> an .dtsi, too.
> 

Yes, that would work on the DTS source level. Doesn't help at runtime.

> That doesn't solve the DTB blob format issue yet, though.
> 

Right. The tree and property deletion commands do not have a mapping to
the DTB format. You could add special characters to a property name and
have the overlay application code do something about it.

For instance the original overlay submission did support property and
node deletion by using '-property' & '-node'. Alas it was removed.

> > Are you going to be at ELCE? I have a bunch of thing to ask you about
> > your DT usage patterns.
> 
> Yes, and registered for the Device Tree Workshop.
> 

Great. See you then.

> Gr{oetje,eeting}s,
> 
>                         Geert
> 

Regards

-- Pantelis

> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds

Re: [PATCH v2 04/18] arm64: dts: m3ulcb-kf: initial device tree

[Vladimir Barinov]

Hi Simon, Geert,

Do you need extra actions from my side to accept this patch?

On 20.09.2017 15:32, Geert Uytterhoeven wrote:
> Hi Vladimir,
>
> [CC Pantelis]
>
> On Thu, Sep 14, 2017 at 4:18 PM, Vladimir Barinov
> <vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org> wrote:
>> Add the initial device tree for the M3ULCB with Kingfisher extension
>> infotainment board.
>>
>> Signed-off-by: Vladimir Barinov <vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
>> ---
>> Changes in version 2:
>> - added own compatible value "shimafuji,kingfisher"
> Reviewed-by: Geert Uytterhoeven <geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>
>
> Some food for thought below...
>
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/renesas/r8a7796-m3ulcb-kf.dts
>> @@ -0,0 +1,19 @@
>> +/*
>> + * Device Tree Source for the M3ULCB Kingfisher board
>> + *
>> + * Copyright (C) 2017 Renesas Electronics Corp.
>> + * Copyright (C) 2017 Cogent Embedded, Inc.
>> + *
>> + * This file is licensed under the terms of the GNU General Public License
>> + * version 2.  This program is licensed "as is" without any warranty of any
>> + * kind, whether express or implied.
>> + */
>> +
>> +#include "r8a7796-m3ulcb.dts"
> Ideally, we don't include *.dts files, only *.dtsi.
> But I don't see a better immediate solution.
>
>> +#include "ulcb-kf.dtsi"
> As the Kingfisher is actually an expansion board for H3ULCB (with R-Car H3
> ES1.1 and ES2.0) and M3ULCB (with R-Car M3-W), turning ulcb-kf.dtsi into a
> DT overlay would make sense.
> That would also solve the issue of the 3 extra DTSes needed for all possible
> combinations of ULCB and Kingfisher (r8a7795-es1-h3ulcb-kf.dts,
> r8a7795-h3ulcb-kf.dts, r8a7796-h3ulcb-kf.dts (perhaps more to follow?)).
>
> But that's too premature, without upstream support for the easy loading of
> DT overlays.
>
>> +/ {
>> +       model = "Renesas M3ULCB Kingfisher board based on r8a7796";
>> +       compatible = "shimafuji,kingfisher", "renesas,m3ulcb",
>> +                    "renesas,r8a7796";
>> +};
> And how to support from an overlay the addition of "shimafuji,kingfisher" to
> (not replacement of!) the main compatible value?
>
> Gr{oetje,eeting}s,
>
>                          Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                  -- Linus Torvalds


-- 
Regards,
Vladimir

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 04/18] arm64: dts: m3ulcb-kf: initial device tree

[Vladimir Barinov]

Hi Simon, Geert,

Do you need extra actions from my side to accept this patch?

On 20.09.2017 15:32, Geert Uytterhoeven wrote:
> Hi Vladimir,
>
> [CC Pantelis]
>
> On Thu, Sep 14, 2017 at 4:18 PM, Vladimir Barinov
> <vladimir.barinov@cogentembedded.com> wrote:
>> Add the initial device tree for the M3ULCB with Kingfisher extension
>> infotainment board.
>>
>> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
>> ---
>> Changes in version 2:
>> - added own compatible value "shimafuji,kingfisher"
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> Some food for thought below...
>
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/renesas/r8a7796-m3ulcb-kf.dts
>> @@ -0,0 +1,19 @@
>> +/*
>> + * Device Tree Source for the M3ULCB Kingfisher board
>> + *
>> + * Copyright (C) 2017 Renesas Electronics Corp.
>> + * Copyright (C) 2017 Cogent Embedded, Inc.
>> + *
>> + * This file is licensed under the terms of the GNU General Public License
>> + * version 2.  This program is licensed "as is" without any warranty of any
>> + * kind, whether express or implied.
>> + */
>> +
>> +#include "r8a7796-m3ulcb.dts"
> Ideally, we don't include *.dts files, only *.dtsi.
> But I don't see a better immediate solution.
>
>> +#include "ulcb-kf.dtsi"
> As the Kingfisher is actually an expansion board for H3ULCB (with R-Car H3
> ES1.1 and ES2.0) and M3ULCB (with R-Car M3-W), turning ulcb-kf.dtsi into a
> DT overlay would make sense.
> That would also solve the issue of the 3 extra DTSes needed for all possible
> combinations of ULCB and Kingfisher (r8a7795-es1-h3ulcb-kf.dts,
> r8a7795-h3ulcb-kf.dts, r8a7796-h3ulcb-kf.dts (perhaps more to follow?)).
>
> But that's too premature, without upstream support for the easy loading of
> DT overlays.
>
>> +/ {
>> +       model = "Renesas M3ULCB Kingfisher board based on r8a7796";
>> +       compatible = "shimafuji,kingfisher", "renesas,m3ulcb",
>> +                    "renesas,r8a7796";
>> +};
> And how to support from an overlay the addition of "shimafuji,kingfisher" to
> (not replacement of!) the main compatible value?
>
> Gr{oetje,eeting}s,
>
>                          Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                  -- Linus Torvalds


-- 
Regards,
Vladimir

Re: [PATCH v2 04/18] arm64: dts: m3ulcb-kf: initial device tree

[Geert Uytterhoeven]

Hi Vladimir,

On Fri, Oct 6, 2017 at 4:47 AM, Vladimir Barinov
<vladimir.barinov@cogentembedded.com> wrote:
> Do you need extra actions from my side to accept this patch?

Not for me. Your patch is fine as-is, as upstream has no support for loading
DT overlays.

> On 20.09.2017 15:32, Geert Uytterhoeven wrote:
>> [CC Pantelis]
>>
>> On Thu, Sep 14, 2017 at 4:18 PM, Vladimir Barinov
>> <vladimir.barinov@cogentembedded.com> wrote:
>>>
>>> Add the initial device tree for the M3ULCB with Kingfisher extension
>>> infotainment board.
>>>
>>> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
>>> ---
>>> Changes in version 2:
>>> - added own compatible value "shimafuji,kingfisher"
>>
>> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>>
>> Some food for thought below...

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH v2 04/18] arm64: dts: m3ulcb-kf: initial device tree

[Simon Horman]

On Fri, Oct 06, 2017 at 05:47:25AM +0300, Vladimir Barinov wrote:
> Hi Simon, Geert,
> 
> Do you need extra actions from my side to accept this patch?

Yes, I need patch 3/18.
Could you repost it?
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 04/18] arm64: dts: m3ulcb-kf: initial device tree

[Simon Horman]

On Fri, Oct 06, 2017 at 05:47:25AM +0300, Vladimir Barinov wrote:
> Hi Simon, Geert,
> 
> Do you need extra actions from my side to accept this patch?

Yes, I need patch 3/18.
Could you repost it?

Re: [PATCH v2 04/18] arm64: dts: m3ulcb-kf: initial device tree

[Simon Horman]

On Fri, Oct 06, 2017 at 11:18:00AM +0200, Simon Horman wrote:
> On Fri, Oct 06, 2017 at 05:47:25AM +0300, Vladimir Barinov wrote:
> > Hi Simon, Geert,
> > 
> > Do you need extra actions from my side to accept this patch?
> 
> Yes, I need patch 3/18.
> Could you repost it?

I see you have done so, thanks.

I have applied this patch with Geert's tag.  I had to apply the patch
manually so please check that I did so correctly once I have pushed the
next branch to the renesas tree a little later today.

Re: [PATCH v2 04/18] arm64: dts: m3ulcb-kf: initial device tree

[Vladimir Barinov]

Hi Simon,

On 09.10.2017 10:18, Simon Horman wrote:
> On Fri, Oct 06, 2017 at 11:18:00AM +0200, Simon Horman wrote:
>> On Fri, Oct 06, 2017 at 05:47:25AM +0300, Vladimir Barinov wrote:
>>> Hi Simon, Geert,
>>>
>>> Do you need extra actions from my side to accept this patch?
>> Yes, I need patch 3/18.
>> Could you repost it?
> I see you have done so, thanks.
>
> I have applied this patch with Geert's tag.  I had to apply the patch
> manually so please check that I did so correctly once I have pushed the
> next branch to the renesas tree a little later today.
I've verified that all is correct.
Thank you.

-- 
Regards,
Vladimir

Re: [PATCH v2 04/18] arm64: dts: m3ulcb-kf: initial device tree

[Simon Horman]

On Tue, Oct 10, 2017 at 07:16:38PM +0300, Vladimir Barinov wrote:
> Hi Simon,
> 
> On 09.10.2017 10:18, Simon Horman wrote:
> >On Fri, Oct 06, 2017 at 11:18:00AM +0200, Simon Horman wrote:
> >>On Fri, Oct 06, 2017 at 05:47:25AM +0300, Vladimir Barinov wrote:
> >>>Hi Simon, Geert,
> >>>
> >>>Do you need extra actions from my side to accept this patch?
> >>Yes, I need patch 3/18.
> >>Could you repost it?
> >I see you have done so, thanks.
> >
> >I have applied this patch with Geert's tag.  I had to apply the patch
> >manually so please check that I did so correctly once I have pushed the
> >next branch to the renesas tree a little later today.
> I've verified that all is correct.
> Thank you.

Thanks for confirming.