All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ma, Jun" <majun@amd.com>
To: Thomas Zimmermann <tzimmermann@suse.de>,
	amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	daniel.vetter@ffwll.ch
Cc: majun@amd.com
Subject: Re: [RESEND PATCH] drm/plane-helper: Add the missing declaration of drm_atomic_state
Date: Fri, 16 Dec 2022 09:34:15 +0800	[thread overview]
Message-ID: <96362c49-f087-53b9-a9b6-dd6a90dd9621@amd.com> (raw)
In-Reply-To: <5960ab10-4929-1e0e-32a3-2c60bbbca37b@suse.de>



On 12/15/2022 4:40 PM, Thomas Zimmermann wrote:
> Hi
> 
> Am 15.12.22 um 04:01 schrieb Ma Jun:
>> Add the missing declaration of struct drm_atomic_state to fix the
>> compile error below:
>>
>> error: 'struct drm_atomic_state' declared inside parameter
>> list will not be visible outside of this definition or declaration [-Werror]
>>
>> Signed-off-by: Ma Jun <majun@amd.com>
>> ---
>>   include/drm/drm_plane_helper.h | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/include/drm/drm_plane_helper.h b/include/drm/drm_plane_helper.h
>> index b00ad36cf5b6..530f88176db4 100644
>> --- a/include/drm/drm_plane_helper.h
>> +++ b/include/drm/drm_plane_helper.h
>> @@ -30,6 +30,7 @@ struct drm_crtc;
>>   struct drm_framebuffer;
>>   struct drm_modeset_acquire_ctx;
>>   struct drm_plane;
>> +struct drm_atomic_state;
> 
> Thanks for the patch. Please sort the forward declarations alphabetically.
> 
Thanks for review. Will fix in v2

Regards,
Ma Jun
> Best regards
> Thomas
> 
>>   
>>   int drm_plane_helper_update_primary(struct drm_plane *plane, struct drm_crtc *crtc,
>>   				    struct drm_framebuffer *fb,
> 

WARNING: multiple messages have this Message-ID (diff)
From: "Ma, Jun" <majun@amd.com>
To: Thomas Zimmermann <tzimmermann@suse.de>,
	amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	daniel.vetter@ffwll.ch
Subject: Re: [RESEND PATCH] drm/plane-helper: Add the missing declaration of drm_atomic_state
Date: Fri, 16 Dec 2022 09:34:15 +0800	[thread overview]
Message-ID: <96362c49-f087-53b9-a9b6-dd6a90dd9621@amd.com> (raw)
In-Reply-To: <5960ab10-4929-1e0e-32a3-2c60bbbca37b@suse.de>



On 12/15/2022 4:40 PM, Thomas Zimmermann wrote:
> Hi
> 
> Am 15.12.22 um 04:01 schrieb Ma Jun:
>> Add the missing declaration of struct drm_atomic_state to fix the
>> compile error below:
>>
>> error: 'struct drm_atomic_state' declared inside parameter
>> list will not be visible outside of this definition or declaration [-Werror]
>>
>> Signed-off-by: Ma Jun <majun@amd.com>
>> ---
>>   include/drm/drm_plane_helper.h | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/include/drm/drm_plane_helper.h b/include/drm/drm_plane_helper.h
>> index b00ad36cf5b6..530f88176db4 100644
>> --- a/include/drm/drm_plane_helper.h
>> +++ b/include/drm/drm_plane_helper.h
>> @@ -30,6 +30,7 @@ struct drm_crtc;
>>   struct drm_framebuffer;
>>   struct drm_modeset_acquire_ctx;
>>   struct drm_plane;
>> +struct drm_atomic_state;
> 
> Thanks for the patch. Please sort the forward declarations alphabetically.
> 
Thanks for review. Will fix in v2

Regards,
Ma Jun
> Best regards
> Thomas
> 
>>   
>>   int drm_plane_helper_update_primary(struct drm_plane *plane, struct drm_crtc *crtc,
>>   				    struct drm_framebuffer *fb,
> 

  reply	other threads:[~2022-12-16  1:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-15  3:01 [RESEND PATCH] drm/plane-helper: Add the missing declaration of drm_atomic_state Ma Jun
2022-12-15  3:01 ` Ma Jun
2022-12-15  8:40 ` Thomas Zimmermann
2022-12-16  1:34   ` Ma, Jun [this message]
2022-12-16  1:34     ` Ma, Jun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=96362c49-f087-53b9-a9b6-dd6a90dd9621@amd.com \
    --to=majun@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.