* [PATCH] ima: Fix function name error in comment.
@ 2021-03-23 9:19 Jiele Zhao
2021-03-23 12:46 ` Mimi Zohar
2021-03-31 1:25 ` Jiele Zhao
0 siblings, 2 replies; 3+ messages in thread
From: Jiele Zhao @ 2021-03-23 9:19 UTC (permalink / raw)
To: zohar, dmitry.kasatkin, serge
Cc: linux-integrity, linux-security-module, Jiele Zhao
Function "ima_file_check" is written as "ima_path_check" in
the comment. Fix this error to prevent misunderstanding.
Signed-off-by: Jiele Zhao <unclexiaole@gmail.com>
---
security/integrity/ima/ima_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/security/integrity/ima/ima_main.c b/security/integrity/ima/ima_main.c
index 9ef748ea829f..03bef720ab44 100644
--- a/security/integrity/ima/ima_main.c
+++ b/security/integrity/ima/ima_main.c
@@ -482,7 +482,7 @@ int ima_bprm_check(struct linux_binprm *bprm)
}
/**
- * ima_path_check - based on policy, collect/store measurement.
+ * ima_file_check - based on policy, collect/store measurement.
* @file: pointer to the file to be measured
* @mask: contains MAY_READ, MAY_WRITE, MAY_EXEC or MAY_APPEND
*
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ima: Fix function name error in comment.
2021-03-23 9:19 [PATCH] ima: Fix function name error in comment Jiele Zhao
@ 2021-03-23 12:46 ` Mimi Zohar
2021-03-31 1:25 ` Jiele Zhao
1 sibling, 0 replies; 3+ messages in thread
From: Mimi Zohar @ 2021-03-23 12:46 UTC (permalink / raw)
To: Jiele Zhao, dmitry.kasatkin, serge; +Cc: linux-integrity, linux-security-module
Hi Jiele,
On Tue, 2021-03-23 at 09:19 +0000, Jiele Zhao wrote:
> Function "ima_file_check" is written as "ima_path_check" in
> the comment. Fix this error to prevent misunderstanding.
>
> Signed-off-by: Jiele Zhao <unclexiaole@gmail.com>
The original function name was ima_path_check(). The policy parsing
still supports PATH_CHECK. Commit 9bbb6cad0173 ("ima: rename
ima_path_check to ima_file_check") renamed the function to
ima_file_check(), but missed modifying the function name in the
comment.
Please update this patch description accordingly and add the "Fixes"
tag.
thanks,
Mimi
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] ima: Fix function name error in comment.
2021-03-23 9:19 [PATCH] ima: Fix function name error in comment Jiele Zhao
2021-03-23 12:46 ` Mimi Zohar
@ 2021-03-31 1:25 ` Jiele Zhao
1 sibling, 0 replies; 3+ messages in thread
From: Jiele Zhao @ 2021-03-31 1:25 UTC (permalink / raw)
To: zohar, dmitry.kasatkin, serge
Cc: linux-integrity, linux-security-module, Jiele zhao
Ping.
On 2021/3/23 17:19, Jiele Zhao wrote:
> Function "ima_file_check" is written as "ima_path_check" in
> the comment. Fix this error to prevent misunderstanding.
>
> Signed-off-by: Jiele Zhao <unclexiaole@gmail.com>
> ---
> security/integrity/ima/ima_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/security/integrity/ima/ima_main.c b/security/integrity/ima/ima_main.c
> index 9ef748ea829f..03bef720ab44 100644
> --- a/security/integrity/ima/ima_main.c
> +++ b/security/integrity/ima/ima_main.c
> @@ -482,7 +482,7 @@ int ima_bprm_check(struct linux_binprm *bprm)
> }
>
> /**
> - * ima_path_check - based on policy, collect/store measurement.
> + * ima_file_check - based on policy, collect/store measurement.
> * @file: pointer to the file to be measured
> * @mask: contains MAY_READ, MAY_WRITE, MAY_EXEC or MAY_APPEND
> *
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-03-31 1:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-23 9:19 [PATCH] ima: Fix function name error in comment Jiele Zhao
2021-03-23 12:46 ` Mimi Zohar
2021-03-31 1:25 ` Jiele Zhao
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.