* [PATCH] dt-bindings: watchdog: qcom-wdt: add the interrupts property
@ 2023-01-30 13:43 Bartosz Golaszewski
2023-01-30 22:59 ` Rob Herring
2023-02-02 13:48 ` Krzysztof Kozlowski
0 siblings, 2 replies; 3+ messages in thread
From: Bartosz Golaszewski @ 2023-01-30 13:43 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Georgi Djakov,
Rob Herring, Krzysztof Kozlowski
Cc: linux-arm-msm, linux-pm, devicetree, linux-kernel, Bartosz Golaszewski
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
The interrupts property is used in all nodes using this binding but not
defined in the document itself - hence dtbs_check fails for them. Add
the property and update the example.
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
.../devicetree/bindings/watchdog/qcom-wdt.yaml | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
index 27fb484d5f8d..45940d643b92 100644
--- a/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
+++ b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
@@ -46,6 +46,10 @@ properties:
clocks:
maxItems: 1
+ interrupts:
+ minItems: 1
+ maxItems: 5
+
required:
- compatible
- reg
@@ -55,9 +59,16 @@ unevaluatedProperties: false
examples:
- |
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+
watchdog@208a038 {
compatible = "qcom,kpss-wdt-ipq8064";
reg = <0x0208a038 0x40>;
clocks = <&sleep_clk>;
timeout-sec = <10>;
+ interrupts = <GIC_PPI 1 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_EDGE_RISING)>,
+ <GIC_PPI 2 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_EDGE_RISING)>,
+ <GIC_PPI 3 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_EDGE_RISING)>,
+ <GIC_PPI 4 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_EDGE_RISING)>,
+ <GIC_PPI 5 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_EDGE_RISING)>;
};
--
2.37.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: watchdog: qcom-wdt: add the interrupts property
2023-01-30 13:43 [PATCH] dt-bindings: watchdog: qcom-wdt: add the interrupts property Bartosz Golaszewski
@ 2023-01-30 22:59 ` Rob Herring
2023-02-02 13:48 ` Krzysztof Kozlowski
1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring @ 2023-01-30 22:59 UTC (permalink / raw)
To: Bartosz Golaszewski
Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Georgi Djakov,
Krzysztof Kozlowski, linux-arm-msm, linux-pm, devicetree,
linux-kernel, Bartosz Golaszewski
On Mon, Jan 30, 2023 at 02:43:28PM +0100, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> The interrupts property is used in all nodes using this binding but not
> defined in the document itself - hence dtbs_check fails for them. Add
> the property and update the example.
>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> ---
> .../devicetree/bindings/watchdog/qcom-wdt.yaml | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
> index 27fb484d5f8d..45940d643b92 100644
> --- a/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
> @@ -46,6 +46,10 @@ properties:
> clocks:
> maxItems: 1
>
> + interrupts:
> + minItems: 1
> + maxItems: 5
What is each interrupt?
> +
> required:
> - compatible
> - reg
> @@ -55,9 +59,16 @@ unevaluatedProperties: false
>
> examples:
> - |
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> +
> watchdog@208a038 {
> compatible = "qcom,kpss-wdt-ipq8064";
> reg = <0x0208a038 0x40>;
> clocks = <&sleep_clk>;
> timeout-sec = <10>;
> + interrupts = <GIC_PPI 1 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_EDGE_RISING)>,
> + <GIC_PPI 2 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_EDGE_RISING)>,
> + <GIC_PPI 3 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_EDGE_RISING)>,
> + <GIC_PPI 4 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_EDGE_RISING)>,
> + <GIC_PPI 5 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_EDGE_RISING)>;
> };
> --
> 2.37.2
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: watchdog: qcom-wdt: add the interrupts property
2023-01-30 13:43 [PATCH] dt-bindings: watchdog: qcom-wdt: add the interrupts property Bartosz Golaszewski
2023-01-30 22:59 ` Rob Herring
@ 2023-02-02 13:48 ` Krzysztof Kozlowski
1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2023-02-02 13:48 UTC (permalink / raw)
To: Bartosz Golaszewski, Andy Gross, Bjorn Andersson, Konrad Dybcio,
Georgi Djakov, Rob Herring, Krzysztof Kozlowski
Cc: linux-arm-msm, linux-pm, devicetree, linux-kernel, Bartosz Golaszewski
On 30/01/2023 14:43, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> The interrupts property is used in all nodes using this binding but not
> defined in the document itself - hence dtbs_check fails for them. Add
> the property and update the example.
>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> ---
> .../devicetree/bindings/watchdog/qcom-wdt.yaml | 11 +++++++++++
> 1 file changed, 11 insertions(+)
dfn in lore would save you some effort (or my pending branch which I
shared on IRC):
https://lore.kernel.org/all/20230113103346.29381-6-krzysztof.kozlowski@linaro.org/
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-02-02 13:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-30 13:43 [PATCH] dt-bindings: watchdog: qcom-wdt: add the interrupts property Bartosz Golaszewski
2023-01-30 22:59 ` Rob Herring
2023-02-02 13:48 ` Krzysztof Kozlowski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.