From: Geliang Tang <geliangtang@gmail.com>
To: Chas Williams <3chas3@gmail.com>
Cc: Geliang Tang <geliangtang@gmail.com>,
linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH] ambassador: use setup_timer
Date: Sat, 11 Mar 2017 08:46:56 +0800 [thread overview]
Message-ID: <964049df314453bb891ce71df7cd7a63540e6210.1489061130.git.geliangtang@gmail.com> (raw)
In-Reply-To: <3afa5498142ef68256023257dad37b9f8352e65e.1489060803.git.geliangtang@gmail.com>
Use setup_timer() instead of init_timer() to simplify the code.
Signed-off-by: Geliang Tang <geliangtang@gmail.com>
---
drivers/atm/ambassador.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/atm/ambassador.c b/drivers/atm/ambassador.c
index 4a61079..906705e 100644
--- a/drivers/atm/ambassador.c
+++ b/drivers/atm/ambassador.c
@@ -2267,9 +2267,8 @@ static int amb_probe(struct pci_dev *pci_dev,
dev->atm_dev->ci_range.vpi_bits = NUM_VPI_BITS;
dev->atm_dev->ci_range.vci_bits = NUM_VCI_BITS;
- init_timer(&dev->housekeeping);
- dev->housekeeping.function = do_housekeeping;
- dev->housekeeping.data = (unsigned long) dev;
+ setup_timer(&dev->housekeeping, do_housekeeping,
+ (unsigned long)dev);
mod_timer(&dev->housekeeping, jiffies);
// enable host interrupts
--
2.9.3
next prev parent reply other threads:[~2017-03-11 0:47 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-11 0:46 [PATCH] ACPI / APEI: use setup_deferrable_timer Geliang Tang
2017-03-11 0:46 ` Geliang Tang [this message]
2017-03-13 6:47 ` [PATCH] ambassador: use setup_timer David Miller
2017-03-11 0:46 ` [PATCH] auxdisplay: " Geliang Tang
2017-03-13 17:27 ` Paul Burton
2017-03-11 0:46 ` [PATCH] Bluetooth: bluecard: " Geliang Tang
2017-03-27 14:11 ` Marcel Holtmann
2017-03-11 0:46 ` [PATCH] drop_monitor: " Geliang Tang
2017-03-13 6:47 ` David Miller
2017-03-11 0:47 ` [PATCH] fs/ocfs2/cluster: " Geliang Tang
2017-03-11 0:47 ` [PATCH] libata: use setup_deferrable_timer Geliang Tang
2017-03-13 17:07 ` Tejun Heo
2017-03-14 18:06 ` [PATCH] ACPI / APEI: " Baicar, Tyler
2017-04-18 14:41 ` Rafael J. Wysocki
2017-04-18 17:21 ` Borislav Petkov
2017-04-19 10:09 ` [tip:ras/core] ACPI/APEI: Use setup_deferrable_timer() tip-bot for Geliang Tang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=964049df314453bb891ce71df7cd7a63540e6210.1489061130.git.geliangtang@gmail.com \
--to=geliangtang@gmail.com \
--cc=3chas3@gmail.com \
--cc=linux-atm-general@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.