All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Baicar, Tyler" <tbaicar@codeaurora.org>
To: Geliang Tang <geliangtang@gmail.com>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Len Brown <lenb@kernel.org>, Borislav Petkov <bp@suse.de>
Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ACPI / APEI: use setup_deferrable_timer
Date: Tue, 14 Mar 2017 12:06:48 -0600	[thread overview]
Message-ID: <eaf4a45e-2f63-7e04-5022-26f702522da4@codeaurora.org> (raw)
In-Reply-To: <3afa5498142ef68256023257dad37b9f8352e65e.1489060803.git.geliangtang@gmail.com>

Works for me!

On 3/10/2017 5:46 PM, Geliang Tang wrote:
> Use setup_deferrable_timer() instead of init_timer_deferrable() to
> simplify the code.
>
> Signed-off-by: Geliang Tang <geliangtang@gmail.com>
Tested-by: Tyler Baicar <tbaicar@codeaurora.org>
> ---
>   drivers/acpi/apei/ghes.c | 5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c
> index b192b42..33ca196 100644
> --- a/drivers/acpi/apei/ghes.c
> +++ b/drivers/acpi/apei/ghes.c
> @@ -1005,9 +1005,8 @@ static int ghes_probe(struct platform_device *ghes_dev)
>   
>   	switch (generic->notify.type) {
>   	case ACPI_HEST_NOTIFY_POLLED:
> -		ghes->timer.function = ghes_poll_func;
> -		ghes->timer.data = (unsigned long)ghes;
> -		init_timer_deferrable(&ghes->timer);
> +		setup_deferrable_timer(&ghes->timer, ghes_poll_func,
> +				       (unsigned long)ghes);
>   		ghes_add_timer(ghes);
>   		break;
>   	case ACPI_HEST_NOTIFY_EXTERNAL:

-- 
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project.

  parent reply	other threads:[~2017-03-14 18:06 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-11  0:46 [PATCH] ACPI / APEI: use setup_deferrable_timer Geliang Tang
2017-03-11  0:46 ` [PATCH] ambassador: use setup_timer Geliang Tang
2017-03-13  6:47   ` David Miller
2017-03-11  0:46 ` [PATCH] auxdisplay: " Geliang Tang
2017-03-13 17:27   ` Paul Burton
2017-03-11  0:46 ` [PATCH] Bluetooth: bluecard: " Geliang Tang
2017-03-27 14:11   ` Marcel Holtmann
2017-03-11  0:46 ` [PATCH] drop_monitor: " Geliang Tang
2017-03-13  6:47   ` David Miller
2017-03-11  0:47 ` [PATCH] fs/ocfs2/cluster: " Geliang Tang
2017-03-11  0:47 ` [PATCH] libata: use setup_deferrable_timer Geliang Tang
2017-03-13 17:07   ` Tejun Heo
2017-03-14 18:06 ` Baicar, Tyler [this message]
2017-04-18 14:41 ` [PATCH] ACPI / APEI: " Rafael J. Wysocki
2017-04-18 17:21   ` Borislav Petkov
2017-04-19 10:09 ` [tip:ras/core] ACPI/APEI: Use setup_deferrable_timer() tip-bot for Geliang Tang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eaf4a45e-2f63-7e04-5022-26f702522da4@codeaurora.org \
    --to=tbaicar@codeaurora.org \
    --cc=bp@suse.de \
    --cc=geliangtang@gmail.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rjw@rjwysocki.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.