From: "Philippe Mathieu-Daudé" <philmd@redhat.com> To: minyard@acm.org Cc: qemu-devel@nongnu.org, Aleksandar Markovic <amarkovic@wavecomp.com>, Aleksandar Rikalo <arikalo@wavecomp.com>, "Michael S. Tsirkin" <mst@redhat.com>, Aurelien Jarno <aurelien@aurel32.net>, Paolo Bonzini <pbonzini@redhat.com>, Igor Mammedov <imammedo@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 1/6] hw/acpi: Move the IPMI stub to the stubs/ directory Date: Thu, 2 May 2019 18:28:56 +0200 [thread overview] Message-ID: <9657d158-b952-b30e-f8ab-64b32e42a41c@redhat.com> (raw) In-Reply-To: <20190502132437.GI6623@minyard.net> Hi Corey, On 5/2/19 3:24 PM, Corey Minyard wrote: > On Sun, Apr 28, 2019 at 08:47:26AM +0200, Philippe Mathieu-Daudé wrote: >> Move the IPMI stub file to the stubs/ directory to simplify the >> hw/acpi Makefile. >> >> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> > > I'm not sure of the overall view of this, but this is ok from an > IPMI point of view in my view. IIRC I had linking failure when building with Kconfig +ACPI -IPMI on MIPS/PPC (series will come on top of this one). I'll verify, I only looked at MIPS but it seems UEFI firmwares also use it on PPC and ARM (currently the ACPI table is only built on X86). Also I'll might rename stubs/ipmi.c -> stubs/acpi-ipmi.c. > > Acked-by: Corey Minyard <cminyard@mvista.com> Thanks for the review! > >> --- >> MAINTAINERS | 1 + >> hw/acpi/Makefile.objs | 3 +-- >> stubs/Makefile.objs | 1 + >> hw/acpi/ipmi-stub.c => stubs/ipmi.c | 0 >> 4 files changed, 3 insertions(+), 2 deletions(-) >> rename hw/acpi/ipmi-stub.c => stubs/ipmi.c (100%) >> >> diff --git a/MAINTAINERS b/MAINTAINERS >> index 23db6f8408a..e1681eca5cb 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -1309,6 +1309,7 @@ S: Maintained >> F: include/hw/ipmi/* >> F: hw/ipmi/* >> F: hw/smbios/smbios_type_38.c >> +F: stubs/ipmi.c >> F: tests/ipmi* >> T: git https://github.com/cminyard/qemu.git master-ipmi-rebase >> >> diff --git a/hw/acpi/Makefile.objs b/hw/acpi/Makefile.objs >> index 2d46e3789ae..4e302feb885 100644 >> --- a/hw/acpi/Makefile.objs >> +++ b/hw/acpi/Makefile.objs >> @@ -14,8 +14,7 @@ common-obj-y += aml-build.o >> common-obj-$(CONFIG_TPM) += tpm.o >> >> common-obj-$(CONFIG_IPMI) += ipmi.o >> -common-obj-$(call lnot,$(CONFIG_IPMI)) += ipmi-stub.o >> else >> common-obj-y += acpi-stub.o >> endif >> -common-obj-$(CONFIG_ALL) += acpi-stub.o ipmi-stub.o >> +common-obj-$(CONFIG_ALL) += acpi-stub.o >> diff --git a/stubs/Makefile.objs b/stubs/Makefile.objs >> index 269dfa58326..36bb9ff0b1d 100644 >> --- a/stubs/Makefile.objs >> +++ b/stubs/Makefile.objs >> @@ -9,6 +9,7 @@ stub-obj-y += error-printf.o >> stub-obj-y += fdset.o >> stub-obj-y += gdbstub.o >> stub-obj-y += get-vm-name.o >> +stub-obj-y += ipmi.o >> stub-obj-y += iothread.o >> stub-obj-y += iothread-lock.o >> stub-obj-y += is-daemonized.o >> diff --git a/hw/acpi/ipmi-stub.c b/stubs/ipmi.c >> similarity index 100% >> rename from hw/acpi/ipmi-stub.c >> rename to stubs/ipmi.c >> -- >> 2.20.1 >>
WARNING: multiple messages have this Message-ID (diff)
From: "Philippe Mathieu-Daudé" <philmd@redhat.com> To: minyard@acm.org Cc: "Michael S. Tsirkin" <mst@redhat.com>, Aleksandar Rikalo <arikalo@wavecomp.com>, qemu-devel@nongnu.org, Aleksandar Markovic <amarkovic@wavecomp.com>, Igor Mammedov <imammedo@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Aurelien Jarno <aurelien@aurel32.net> Subject: Re: [Qemu-devel] [PATCH v2 1/6] hw/acpi: Move the IPMI stub to the stubs/ directory Date: Thu, 2 May 2019 18:28:56 +0200 [thread overview] Message-ID: <9657d158-b952-b30e-f8ab-64b32e42a41c@redhat.com> (raw) Message-ID: <20190502162856.KY9EzXHV7udvf7L0Fd8ox_97UI8LFBulXALPDgjGfVw@z> (raw) In-Reply-To: <20190502132437.GI6623@minyard.net> Hi Corey, On 5/2/19 3:24 PM, Corey Minyard wrote: > On Sun, Apr 28, 2019 at 08:47:26AM +0200, Philippe Mathieu-Daudé wrote: >> Move the IPMI stub file to the stubs/ directory to simplify the >> hw/acpi Makefile. >> >> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> > > I'm not sure of the overall view of this, but this is ok from an > IPMI point of view in my view. IIRC I had linking failure when building with Kconfig +ACPI -IPMI on MIPS/PPC (series will come on top of this one). I'll verify, I only looked at MIPS but it seems UEFI firmwares also use it on PPC and ARM (currently the ACPI table is only built on X86). Also I'll might rename stubs/ipmi.c -> stubs/acpi-ipmi.c. > > Acked-by: Corey Minyard <cminyard@mvista.com> Thanks for the review! > >> --- >> MAINTAINERS | 1 + >> hw/acpi/Makefile.objs | 3 +-- >> stubs/Makefile.objs | 1 + >> hw/acpi/ipmi-stub.c => stubs/ipmi.c | 0 >> 4 files changed, 3 insertions(+), 2 deletions(-) >> rename hw/acpi/ipmi-stub.c => stubs/ipmi.c (100%) >> >> diff --git a/MAINTAINERS b/MAINTAINERS >> index 23db6f8408a..e1681eca5cb 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -1309,6 +1309,7 @@ S: Maintained >> F: include/hw/ipmi/* >> F: hw/ipmi/* >> F: hw/smbios/smbios_type_38.c >> +F: stubs/ipmi.c >> F: tests/ipmi* >> T: git https://github.com/cminyard/qemu.git master-ipmi-rebase >> >> diff --git a/hw/acpi/Makefile.objs b/hw/acpi/Makefile.objs >> index 2d46e3789ae..4e302feb885 100644 >> --- a/hw/acpi/Makefile.objs >> +++ b/hw/acpi/Makefile.objs >> @@ -14,8 +14,7 @@ common-obj-y += aml-build.o >> common-obj-$(CONFIG_TPM) += tpm.o >> >> common-obj-$(CONFIG_IPMI) += ipmi.o >> -common-obj-$(call lnot,$(CONFIG_IPMI)) += ipmi-stub.o >> else >> common-obj-y += acpi-stub.o >> endif >> -common-obj-$(CONFIG_ALL) += acpi-stub.o ipmi-stub.o >> +common-obj-$(CONFIG_ALL) += acpi-stub.o >> diff --git a/stubs/Makefile.objs b/stubs/Makefile.objs >> index 269dfa58326..36bb9ff0b1d 100644 >> --- a/stubs/Makefile.objs >> +++ b/stubs/Makefile.objs >> @@ -9,6 +9,7 @@ stub-obj-y += error-printf.o >> stub-obj-y += fdset.o >> stub-obj-y += gdbstub.o >> stub-obj-y += get-vm-name.o >> +stub-obj-y += ipmi.o >> stub-obj-y += iothread.o >> stub-obj-y += iothread-lock.o >> stub-obj-y += is-daemonized.o >> diff --git a/hw/acpi/ipmi-stub.c b/stubs/ipmi.c >> similarity index 100% >> rename from hw/acpi/ipmi-stub.c >> rename to stubs/ipmi.c >> -- >> 2.20.1 >>
next prev parent reply other threads:[~2019-05-02 16:29 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-04-28 6:47 [Qemu-devel] [PATCH v2 0/6] hw/acpi: Improve build modularity (targeting MIPS/PPC) Philippe Mathieu-Daudé 2019-04-28 6:47 ` Philippe Mathieu-Daudé 2019-04-28 6:47 ` [Qemu-devel] [PATCH v2 1/6] hw/acpi: Move the IPMI stub to the stubs/ directory Philippe Mathieu-Daudé 2019-04-28 6:47 ` Philippe Mathieu-Daudé 2019-05-02 13:24 ` Corey Minyard 2019-05-02 13:24 ` Corey Minyard 2019-05-02 16:28 ` Philippe Mathieu-Daudé [this message] 2019-05-02 16:28 ` Philippe Mathieu-Daudé 2019-04-28 6:47 ` [Qemu-devel] [PATCH v2 2/6] hw/acpi: Move the ACPI " Philippe Mathieu-Daudé 2019-04-28 6:47 ` Philippe Mathieu-Daudé 2019-04-28 6:47 ` [Qemu-devel] [PATCH v2 3/6] hw/acpi: Simplify the Makefile logic Philippe Mathieu-Daudé 2019-04-28 6:47 ` Philippe Mathieu-Daudé 2019-04-28 6:47 ` [Qemu-devel] [PATCH v2 4/6] hw/acpi: Always build the 'core' ACPI functions Philippe Mathieu-Daudé 2019-04-28 6:47 ` Philippe Mathieu-Daudé 2019-04-28 6:47 ` [Qemu-devel] [PATCH v2 5/6] stubs: Add missing ACPI symbols Philippe Mathieu-Daudé 2019-04-28 6:47 ` Philippe Mathieu-Daudé 2019-04-28 6:47 ` [Qemu-devel] [PATCH v2 6/6] vl: Do not set acpi_enabled when ACPI is disabled at build time Philippe Mathieu-Daudé 2019-04-28 6:47 ` Philippe Mathieu-Daudé
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=9657d158-b952-b30e-f8ab-64b32e42a41c@redhat.com \ --to=philmd@redhat.com \ --cc=amarkovic@wavecomp.com \ --cc=arikalo@wavecomp.com \ --cc=aurelien@aurel32.net \ --cc=imammedo@redhat.com \ --cc=minyard@acm.org \ --cc=mst@redhat.com \ --cc=pbonzini@redhat.com \ --cc=qemu-devel@nongnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.