All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wadim Egorov <W.Egorov@phytec.de>
To: Stefan Roese <sr@denx.de>, Samuel Holland <samuel@sholland.org>,
	Tom Rini <trini@konsulko.com>
Cc: Simon Glass <sjg@chromium.org>,
	"u-boot@lists.denx.de" <u-boot@lists.denx.de>,
	Philipp Tomsich <philipp.tomsich@vrull.eu>,
	"Kever Yang" <kever.yang@rock-chips.com>
Subject: Re: [PATCH] serial: ns16550: Enable clocks during probe
Date: Tue, 13 Dec 2022 10:40:50 +0000	[thread overview]
Message-ID: <966157ee-4eeb-cf96-7320-851b87bb1bb8@phytec.de> (raw)
In-Reply-To: <4c711ad2-693f-05b9-e0f6-72464c4eb33c@denx.de>

Hi Stefan,

Am 13.12.22 um 07:14 schrieb Stefan Roese:
> Hi Samuel,
>
> On 12/13/22 02:46, Samuel Holland wrote:
>> On 12/12/22 12:54, Tom Rini wrote:
>>> On Sun, Nov 27, 2022 at 11:48:34PM -0600, Samuel Holland wrote:
>>>
>>>> If the UART bus or baud clock has a gate, it must be enabled before the
>>>> UART can be used.
>>>>
>>>> Signed-off-by: Samuel Holland <samuel@sholland.org>
>>>> Reviewed-by: Stefan Roese <sr@denx.de>
>>>
>>> This breaks building on phycore-rk3288
>>
>> I get:
>>
>> binman: Error 1 running 'mkimage -d ./mkimage.simple-bin.mkimage -n
>> rk3288 -T rksd ./idbloader.img': Error: SPL image is too large (size
>> 0x8800 than 0x8000)
>>
>> Before applying this patch:
>>
>> $ ls -l spl/u-boot-spl.bin
>> -rw-r--r-- 1 samuel samuel 32704 Dec 12 19:35 spl/u-boot-spl.bin
>>
>> So the board was quite close to its SPL size limit already.
>>
>> I was trying to be general with this patch, but I suppose for my
>> immediate purposes (Allwinner D1), I only care about the first clock. If
>> I use clk_get_by_index() instead of clk_get_bulk(), the phycore-rk3288
>> build passes with 4 bytes to spare:
>>
>> $ ls -l spl/u-boot-spl.bin
>> -rw-r--r-- 1 samuel samuel 32760 Dec 12 19:36 spl/u-boot-spl.bin
>>
>> I will send a v2, but I imagine some other unsuspecting patch will run
>> into this limit again before long.
>
> Why not enable LTO to save more space. I just checked this on this
> platform:
>
> w/o LTO:
> spl/u-boot-spl.bin 32604
>
> with LTO enabled:
> spl/u-boot-spl.bin 30016
>
> Not tested though.

Thanks for the hint with the LTO. I just send out a patch to enable it for the 
phycore-rk3288

   https://lists.denx.de/pipermail/u-boot/2022-December/502125.html


Regards,
Wadim

>
> Thanks,
> Stefan



      reply	other threads:[~2022-12-13 10:40 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-28  5:48 [PATCH] serial: ns16550: Enable clocks during probe Samuel Holland
2022-11-29  8:46 ` Stefan Roese
2022-12-12 18:54 ` Tom Rini
2022-12-13  1:46   ` Samuel Holland
2022-12-13  6:14     ` Stefan Roese
2022-12-13 10:40       ` Wadim Egorov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=966157ee-4eeb-cf96-7320-851b87bb1bb8@phytec.de \
    --to=w.egorov@phytec.de \
    --cc=kever.yang@rock-chips.com \
    --cc=philipp.tomsich@vrull.eu \
    --cc=samuel@sholland.org \
    --cc=sjg@chromium.org \
    --cc=sr@denx.de \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.