From: Christophe Kerello <christophe.kerello@foss.st.com>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
<miquel.raynal@bootlin.com>, <richard@nod.at>, <vigneshr@ti.com>,
<robh+dt@kernel.org>
Cc: <linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
<linux-stm32@st-md-mailman.stormreply.com>,
<devicetree@vger.kernel.org>, <chenshumin86@sina.com>
Subject: Re: [PATCH 3/3] nvmem: core: Fix a conflict between MTD and NVMEM on wp-gpios property
Date: Wed, 26 Jan 2022 12:08:38 +0100 [thread overview]
Message-ID: <9662651a-12d9-4893-95c2-aa1a3a10302d@foss.st.com> (raw)
In-Reply-To: <3f9a9731-c096-bc9b-63df-bd1dff032737@linaro.org>
Hi Srinivas, Miquel,
On 1/25/22 11:44, Srinivas Kandagatla wrote:
>
>
> On 05/01/2022 13:57, Christophe Kerello wrote:
>> diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c
>> index e765d3d0542e..e11c74db64f9 100644
>> --- a/drivers/nvmem/core.c
>> +++ b/drivers/nvmem/core.c
>> @@ -769,7 +769,7 @@ struct nvmem_device *nvmem_register(const struct
>> nvmem_config *config)
>> if (config->wp_gpio)
>> nvmem->wp_gpio = config->wp_gpio;
>> - else
>> + else if (config->reg_write)
> This is clearly not going to work for everyone.
>
> A flag in nvmem_config to indicate that wp gpio is managed by provider
> driver would be the right thing to do here.
Based on your inputs, I will add a new boolean flag in nvmen_config
(proposal name: skip_wp_gpio) and I will set it to true in mtdcore.c
when nvmen_config structure is initialized. It will be part of the V2.
Regards,
Christophe Kerello.
>> nvmem->wp_gpio = gpiod_get_optional(config->dev, "wp",
>> GPIOD_OUT_HIGH);
>
> --srini
>
WARNING: multiple messages have this Message-ID (diff)
From: Christophe Kerello <christophe.kerello@foss.st.com>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
<miquel.raynal@bootlin.com>, <richard@nod.at>, <vigneshr@ti.com>,
<robh+dt@kernel.org>
Cc: <linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
<linux-stm32@st-md-mailman.stormreply.com>,
<devicetree@vger.kernel.org>, <chenshumin86@sina.com>
Subject: Re: [PATCH 3/3] nvmem: core: Fix a conflict between MTD and NVMEM on wp-gpios property
Date: Wed, 26 Jan 2022 12:08:38 +0100 [thread overview]
Message-ID: <9662651a-12d9-4893-95c2-aa1a3a10302d@foss.st.com> (raw)
In-Reply-To: <3f9a9731-c096-bc9b-63df-bd1dff032737@linaro.org>
Hi Srinivas, Miquel,
On 1/25/22 11:44, Srinivas Kandagatla wrote:
>
>
> On 05/01/2022 13:57, Christophe Kerello wrote:
>> diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c
>> index e765d3d0542e..e11c74db64f9 100644
>> --- a/drivers/nvmem/core.c
>> +++ b/drivers/nvmem/core.c
>> @@ -769,7 +769,7 @@ struct nvmem_device *nvmem_register(const struct
>> nvmem_config *config)
>> if (config->wp_gpio)
>> nvmem->wp_gpio = config->wp_gpio;
>> - else
>> + else if (config->reg_write)
> This is clearly not going to work for everyone.
>
> A flag in nvmem_config to indicate that wp gpio is managed by provider
> driver would be the right thing to do here.
Based on your inputs, I will add a new boolean flag in nvmen_config
(proposal name: skip_wp_gpio) and I will set it to true in mtdcore.c
when nvmen_config structure is initialized. It will be part of the V2.
Regards,
Christophe Kerello.
>> nvmem->wp_gpio = gpiod_get_optional(config->dev, "wp",
>> GPIOD_OUT_HIGH);
>
> --srini
>
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2022-01-26 11:09 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-05 13:57 [PATCH 0/3] mtd: rawnand: stm32_fmc2: Add NAND Write Protect support Christophe Kerello
2022-01-05 13:57 ` Christophe Kerello
2022-01-05 13:57 ` [PATCH 1/3] dt-binding: mtd: nand: Document the wp-gpios property Christophe Kerello
2022-01-05 13:57 ` Christophe Kerello
2022-01-21 21:19 ` Rob Herring
2022-01-21 21:19 ` Rob Herring
2022-01-05 13:57 ` [PATCH 2/3] mtd: rawnand: stm32_fmc2: Add NAND Write Protect support Christophe Kerello
2022-01-05 13:57 ` Christophe Kerello
2022-01-05 13:57 ` [PATCH 3/3] nvmem: core: Fix a conflict between MTD and NVMEM on wp-gpios property Christophe Kerello
2022-01-05 13:57 ` Christophe Kerello
2022-01-25 10:11 ` Miquel Raynal
2022-01-25 10:11 ` Miquel Raynal
2022-01-25 10:44 ` Srinivas Kandagatla
2022-01-25 10:44 ` Srinivas Kandagatla
2022-01-26 11:08 ` Christophe Kerello [this message]
2022-01-26 11:08 ` Christophe Kerello
2022-01-26 11:19 ` Miquel Raynal
2022-01-26 11:19 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9662651a-12d9-4893-95c2-aa1a3a10302d@foss.st.com \
--to=christophe.kerello@foss.st.com \
--cc=chenshumin86@sina.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.