From: Tero Kristo <t-kristo@ti.com> To: Bjorn Andersson <bjorn.andersson@linaro.org> Cc: ohad@wizery.com, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, s-anna@ti.com Subject: Re: [PATCH 06/17] remoteproc/omap: Add the rproc ops .da_to_va() implementation Date: Tue, 12 Nov 2019 10:22:39 +0200 [thread overview] Message-ID: <9670e8ad-4c36-2ad1-5967-931b0fc97343@ti.com> (raw) In-Reply-To: <20191111232251.GH3108315@builder> On 12/11/2019 01:22, Bjorn Andersson wrote: > On Mon 28 Oct 05:42 PDT 2019, Tero Kristo wrote: > >> From: Suman Anna <s-anna@ti.com> >> >> An implementation for the rproc ops .da_to_va() has been added >> that provides the address translation between device addresses >> to kernel virtual addresses for internal RAMs present on that >> particular remote processor device. The implementation provides >> the translations based on the addresses parsed and stored during >> the probe. >> >> This ops gets invoked by the exported rproc_da_to_va() function >> and allows the remoteproc core's ELF loader to be able to load >> program data directly into the internal memories. >> >> Signed-off-by: Suman Anna <s-anna@ti.com> >> Signed-off-by: Tero Kristo <t-kristo@ti.com> >> --- >> drivers/remoteproc/omap_remoteproc.c | 35 ++++++++++++++++++++++++++++ >> 1 file changed, 35 insertions(+) >> >> diff --git a/drivers/remoteproc/omap_remoteproc.c b/drivers/remoteproc/omap_remoteproc.c >> index bbd6ff360e10..0524f7e0ffa4 100644 >> --- a/drivers/remoteproc/omap_remoteproc.c >> +++ b/drivers/remoteproc/omap_remoteproc.c >> @@ -230,10 +230,45 @@ static int omap_rproc_stop(struct rproc *rproc) >> return 0; >> } >> >> +/* >> + * Internal Memory translation helper > > Please format this as kerneldoc. > >> + * >> + * Custom function implementing the rproc .da_to_va ops to provide address >> + * translation (device address to kernel virtual address) for internal RAMs >> + * present in a DSP or IPU device). The translated addresses can be used >> + * either by the remoteproc core for loading, or by any rpmsg bus drivers. >> + */ >> +static void *omap_rproc_da_to_va(struct rproc *rproc, u64 da, int len) >> +{ >> + struct omap_rproc *oproc = rproc->priv; >> + void *va = NULL; >> + int i; >> + u32 offset; >> + >> + if (len <= 0) >> + return NULL; >> + >> + if (!oproc->num_mems) >> + return NULL; >> + >> + for (i = 0; i < oproc->num_mems; i++) { >> + if (da >= oproc->mem[i].dev_addr && da + len <= >> + oproc->mem[i].dev_addr + oproc->mem[i].size) { >> + offset = da - oproc->mem[i].dev_addr; >> + /* __force to make sparse happy with type conversion */ >> + va = (__force void *)(oproc->mem[i].cpu_addr + offset); > > Replace va = and break; with just a return here. Right, va seems to be completely redundant local variable. > >> + break; >> + } >> + } >> + >> + return va; > > return NULL here. Yep will do. -Tero -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
WARNING: multiple messages have this Message-ID (diff)
From: Tero Kristo <t-kristo@ti.com> To: Bjorn Andersson <bjorn.andersson@linaro.org> Cc: <ohad@wizery.com>, <linux-remoteproc@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <linux-omap@vger.kernel.org>, <s-anna@ti.com> Subject: Re: [PATCH 06/17] remoteproc/omap: Add the rproc ops .da_to_va() implementation Date: Tue, 12 Nov 2019 10:22:39 +0200 [thread overview] Message-ID: <9670e8ad-4c36-2ad1-5967-931b0fc97343@ti.com> (raw) In-Reply-To: <20191111232251.GH3108315@builder> On 12/11/2019 01:22, Bjorn Andersson wrote: > On Mon 28 Oct 05:42 PDT 2019, Tero Kristo wrote: > >> From: Suman Anna <s-anna@ti.com> >> >> An implementation for the rproc ops .da_to_va() has been added >> that provides the address translation between device addresses >> to kernel virtual addresses for internal RAMs present on that >> particular remote processor device. The implementation provides >> the translations based on the addresses parsed and stored during >> the probe. >> >> This ops gets invoked by the exported rproc_da_to_va() function >> and allows the remoteproc core's ELF loader to be able to load >> program data directly into the internal memories. >> >> Signed-off-by: Suman Anna <s-anna@ti.com> >> Signed-off-by: Tero Kristo <t-kristo@ti.com> >> --- >> drivers/remoteproc/omap_remoteproc.c | 35 ++++++++++++++++++++++++++++ >> 1 file changed, 35 insertions(+) >> >> diff --git a/drivers/remoteproc/omap_remoteproc.c b/drivers/remoteproc/omap_remoteproc.c >> index bbd6ff360e10..0524f7e0ffa4 100644 >> --- a/drivers/remoteproc/omap_remoteproc.c >> +++ b/drivers/remoteproc/omap_remoteproc.c >> @@ -230,10 +230,45 @@ static int omap_rproc_stop(struct rproc *rproc) >> return 0; >> } >> >> +/* >> + * Internal Memory translation helper > > Please format this as kerneldoc. > >> + * >> + * Custom function implementing the rproc .da_to_va ops to provide address >> + * translation (device address to kernel virtual address) for internal RAMs >> + * present in a DSP or IPU device). The translated addresses can be used >> + * either by the remoteproc core for loading, or by any rpmsg bus drivers. >> + */ >> +static void *omap_rproc_da_to_va(struct rproc *rproc, u64 da, int len) >> +{ >> + struct omap_rproc *oproc = rproc->priv; >> + void *va = NULL; >> + int i; >> + u32 offset; >> + >> + if (len <= 0) >> + return NULL; >> + >> + if (!oproc->num_mems) >> + return NULL; >> + >> + for (i = 0; i < oproc->num_mems; i++) { >> + if (da >= oproc->mem[i].dev_addr && da + len <= >> + oproc->mem[i].dev_addr + oproc->mem[i].size) { >> + offset = da - oproc->mem[i].dev_addr; >> + /* __force to make sparse happy with type conversion */ >> + va = (__force void *)(oproc->mem[i].cpu_addr + offset); > > Replace va = and break; with just a return here. Right, va seems to be completely redundant local variable. > >> + break; >> + } >> + } >> + >> + return va; > > return NULL here. Yep will do. -Tero -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
next prev parent reply other threads:[~2019-11-12 8:22 UTC|newest] Thread overview: 102+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-10-28 12:42 [PATCH 00/17] remoteproc: omap changes on top of v5.4-rc1 Tero Kristo 2019-10-28 12:42 ` Tero Kristo 2019-10-28 12:42 ` [PATCH 01/17] dt-bindings: remoteproc: Add OMAP remoteproc bindings Tero Kristo 2019-10-28 12:42 ` Tero Kristo 2019-11-06 3:27 ` Rob Herring 2019-11-06 3:27 ` Rob Herring 2019-11-06 12:44 ` Tero Kristo 2019-11-06 12:44 ` Tero Kristo 2019-11-06 13:27 ` Rob Herring 2019-11-06 13:27 ` Rob Herring 2019-11-06 13:50 ` Tero Kristo 2019-11-06 13:50 ` Tero Kristo 2019-11-07 14:05 ` [PATCHv2 " Tero Kristo 2019-11-07 14:05 ` Tero Kristo 2019-11-13 14:25 ` Rob Herring 2019-10-28 12:42 ` [PATCH 02/17] remoteproc/omap: Switch to SPDX license identifiers Tero Kristo 2019-10-28 12:42 ` Tero Kristo 2019-11-09 1:03 ` Bjorn Andersson 2019-11-09 1:03 ` Bjorn Andersson 2019-11-12 8:16 ` Tero Kristo 2019-11-12 8:16 ` Tero Kristo 2019-12-20 3:30 ` Suman Anna 2019-12-20 3:30 ` Suman Anna 2019-10-28 12:42 ` [PATCH 03/17] remoteproc/omap: Add device tree support Tero Kristo 2019-10-28 12:42 ` Tero Kristo 2019-11-11 23:16 ` Bjorn Andersson 2019-11-11 23:16 ` Bjorn Andersson 2019-11-12 8:14 ` Tero Kristo 2019-11-12 8:14 ` Tero Kristo 2019-10-28 12:42 ` [PATCH 04/17] remoteproc/omap: Add a sanity check for DSP boot address alignment Tero Kristo 2019-10-28 12:42 ` Tero Kristo 2019-11-11 23:18 ` Bjorn Andersson 2019-11-11 23:18 ` Bjorn Andersson 2019-10-28 12:42 ` [PATCH 05/17] remoteproc/omap: Add support to parse internal memories from DT Tero Kristo 2019-10-28 12:42 ` Tero Kristo 2019-11-11 23:21 ` Bjorn Andersson 2019-11-11 23:21 ` Bjorn Andersson 2019-11-12 8:21 ` Tero Kristo 2019-11-12 8:21 ` Tero Kristo 2019-10-28 12:42 ` [PATCH 06/17] remoteproc/omap: Add the rproc ops .da_to_va() implementation Tero Kristo 2019-10-28 12:42 ` Tero Kristo 2019-11-11 23:22 ` Bjorn Andersson 2019-11-11 23:22 ` Bjorn Andersson 2019-11-12 8:22 ` Tero Kristo [this message] 2019-11-12 8:22 ` Tero Kristo 2019-10-28 12:42 ` [PATCH 07/17] remoteproc/omap: Initialize and assign reserved memory node Tero Kristo 2019-10-28 12:42 ` Tero Kristo 2019-11-11 23:23 ` Bjorn Andersson 2019-11-11 23:23 ` Bjorn Andersson 2019-10-28 12:42 ` [PATCH 08/17] remoteproc/omap: Add support for DRA7xx remote processors Tero Kristo 2019-10-28 12:42 ` Tero Kristo 2019-11-11 23:37 ` Bjorn Andersson 2019-11-11 23:37 ` Bjorn Andersson 2019-11-12 8:37 ` Tero Kristo 2019-11-12 8:37 ` Tero Kristo 2019-11-12 18:13 ` Bjorn Andersson 2019-11-12 18:13 ` Bjorn Andersson 2019-11-13 8:08 ` Tero Kristo 2019-11-13 8:08 ` Tero Kristo 2019-10-28 12:42 ` [PATCH 09/17] remoteproc/omap: Remove the unused fields from platform data Tero Kristo 2019-10-28 12:42 ` Tero Kristo 2019-11-11 23:37 ` Bjorn Andersson 2019-11-11 23:37 ` Bjorn Andersson 2019-10-28 12:42 ` [PATCH 10/17] remoteproc/omap: Remove the omap_rproc_reserve_cma declaration Tero Kristo 2019-10-28 12:42 ` Tero Kristo 2019-11-11 23:37 ` Bjorn Andersson 2019-11-11 23:37 ` Bjorn Andersson 2019-10-28 12:42 ` [PATCH 11/17] remoteproc/omap: Check for undefined mailbox messages Tero Kristo 2019-10-28 12:42 ` Tero Kristo 2019-11-11 23:39 ` Bjorn Andersson 2019-11-11 23:39 ` Bjorn Andersson 2019-11-12 8:38 ` Tero Kristo 2019-11-12 8:38 ` Tero Kristo 2019-10-28 12:42 ` [PATCH 12/17] remoteproc/omap: Request a timer(s) for remoteproc usage Tero Kristo 2019-10-28 12:42 ` Tero Kristo 2019-11-12 4:13 ` Bjorn Andersson 2019-11-12 4:13 ` Bjorn Andersson 2019-11-12 8:42 ` Tero Kristo 2019-11-12 8:42 ` Tero Kristo 2019-10-28 12:42 ` [PATCH 13/17] remoteproc/omap: add support for system suspend/resume Tero Kristo 2019-10-28 12:42 ` Tero Kristo 2019-10-30 4:01 ` kbuild test robot 2019-11-12 6:15 ` Bjorn Andersson 2019-11-12 6:15 ` Bjorn Andersson 2019-11-12 8:45 ` Tero Kristo 2019-11-12 8:45 ` Tero Kristo 2019-11-12 18:06 ` Bjorn Andersson 2019-11-12 18:06 ` Bjorn Andersson 2019-10-28 12:42 ` [PATCH 14/17] remoteproc/omap: add support for runtime auto-suspend/resume Tero Kristo 2019-10-28 12:42 ` Tero Kristo 2019-10-28 12:42 ` [PATCH 15/17] remoteproc/omap: report device exceptions and trigger recovery Tero Kristo 2019-10-28 12:42 ` Tero Kristo 2019-11-12 6:26 ` Bjorn Andersson 2019-11-12 6:26 ` Bjorn Andersson 2019-11-12 8:46 ` Tero Kristo 2019-11-12 8:46 ` Tero Kristo 2019-10-28 12:42 ` [PATCH 16/17] remoteproc/omap: add watchdog functionality for remote processors Tero Kristo 2019-10-28 12:42 ` Tero Kristo 2019-10-28 12:42 ` [PATCH 17/17] remoteproc/omap: fix auto-suspend failure warning during crashed state Tero Kristo 2019-10-28 12:42 ` Tero Kristo 2019-11-12 6:28 ` Bjorn Andersson 2019-11-12 6:28 ` Bjorn Andersson
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=9670e8ad-4c36-2ad1-5967-931b0fc97343@ti.com \ --to=t-kristo@ti.com \ --cc=bjorn.andersson@linaro.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-omap@vger.kernel.org \ --cc=linux-remoteproc@vger.kernel.org \ --cc=ohad@wizery.com \ --cc=s-anna@ti.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.