All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krishna Kurapati PSSNV <quic_kriskura@quicinc.com>
To: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Andy Gross <agross@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konrad.dybcio@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Felipe Balbi <balbi@kernel.org>,
	"Wesley Cheng" <quic_wcheng@quicinc.com>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"quic_pkondeti@quicinc.com" <quic_pkondeti@quicinc.com>,
	"quic_ppratap@quicinc.com" <quic_ppratap@quicinc.com>,
	"quic_jackp@quicinc.com" <quic_jackp@quicinc.com>,
	"quic_harshq@quicinc.com" <quic_harshq@quicinc.com>,
	"ahalaney@redhat.com" <ahalaney@redhat.com>,
	"quic_shazhuss@quicinc.com" <quic_shazhuss@quicinc.com>
Subject: Re: [PATCH v7 5/9] usb: dwc3: core: Refactor PHY logic to support Multiport Controller
Date: Thu, 4 May 2023 09:57:27 +0530	[thread overview]
Message-ID: <9672285c-d81c-2ef5-46bc-13708392b5aa@quicinc.com> (raw)
In-Reply-To: <20230503215511.52udfef6amdcapng@synopsys.com>



On 5/4/2023 3:25 AM, Thinh Nguyen wrote:
> On Wed, May 03, 2023, Krishna Kurapati PSSNV wrote:
>>
>>
>> On 5/3/2023 3:41 AM, Thinh Nguyen wrote:
>>> On Mon, May 01, 2023, Krishna Kurapati wrote:
>>>> Currently the DWC3 driver supports only single port controller
>>>> which requires at most one HS and one SS PHY.
>>>>
>>>> But the DWC3 USB controller can be connected to multiple ports and
>>>> each port can have their own PHYs. Each port of the multiport
>>>> controller can either be HS+SS capable or HS only capable
>>>> Proper quantification of them is required to modify GUSB2PHYCFG
>>>> and GUSB3PIPECTL registers appropriately.
>>>>
>>>> Add support for detecting, obtaining and configuring phy's supported
>>>> by a multiport controller and limit the max number of ports
>>>> supported to 4.
>>>>
>>>> Signed-off-by: Harsh Agarwal <quic_harshq@quicinc.com>
>>>> Signed-off-by: Krishna Kurapati <quic_kriskura@quicinc.com>
>>>
>>> Are you a co-author or only Harsh is the main author of this patch?
>>>
>> Harsh began developing this series and pushed the first 3 RFC versions
>> (supporting both usb-phy / generic phy frameworks) until maintainers pointed
>> out that we only support generic phy changes.
>>
>>  From then on I took it up and started pushing next versions. I would say
>> both of us are primary authors for this patch. But if there has to be only
>> one, I would say its Harsh.
>>
>> Regards,
>> Krishna,
>>
> 
> I just want to check to give you proper credit for the patch's
> contribution. Since Harsh isn't the only one working on this you're not
> simply transporting this change. Perhaps you should add Co-developed-by
> tags.
> 
> Thanks,
> Thinh

Sure,

  Let me put myself under Co-developed-by in the next version.

Regards,
Krishna,

  reply	other threads:[~2023-05-04  4:27 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-01 14:34 [PATCH v7 0/9] Add multiport support for DWC3 controllers Krishna Kurapati
2023-05-01 14:34 ` [PATCH v7 1/9] dt-bindings: usb: qcom,dwc3: Add bindings for SC8280 Multiport Krishna Kurapati
2023-05-02  7:48   ` Krzysztof Kozlowski
2023-05-02  8:35     ` Krishna Kurapati PSSNV
2023-05-02  8:47       ` Krzysztof Kozlowski
2023-05-02  8:52         ` Krishna Kurapati PSSNV
2023-05-02 10:15           ` Krzysztof Kozlowski
2023-05-01 14:34 ` [PATCH v7 2/9] dt-bindings: usb: Add bindings for multiport properties on DWC3 controller Krishna Kurapati
2023-05-01 14:34 ` [PATCH v7 3/9] usb: dwc3: core: Access XHCI address space temporarily to read port info Krishna Kurapati
2023-05-02 12:27   ` kernel test robot
2023-05-02 21:41   ` Thinh Nguyen
2023-05-03  3:48     ` Krishna Kurapati PSSNV
2023-05-03 21:49       ` Thinh Nguyen
2023-05-04  4:05         ` Krishna Kurapati PSSNV
2023-05-01 14:34 ` [PATCH v7 4/9] usb: dwc3: core: Skip setting event buffers for host only controllers Krishna Kurapati
2023-05-02 21:44   ` Thinh Nguyen
2023-05-03  3:49     ` Krishna Kurapati PSSNV
2023-05-01 14:34 ` [PATCH v7 5/9] usb: dwc3: core: Refactor PHY logic to support Multiport Controller Krishna Kurapati
2023-05-02 22:11   ` Thinh Nguyen
2023-05-03  3:52     ` Krishna Kurapati PSSNV
2023-05-03 21:55       ` Thinh Nguyen
2023-05-04  4:27         ` Krishna Kurapati PSSNV [this message]
2023-05-03 11:10   ` Johan Hovold
2023-05-03 14:20     ` Krishna Kurapati PSSNV
2023-05-03 14:27       ` Johan Hovold
2023-05-01 14:34 ` [PATCH v7 6/9] usb: dwc3: qcom: Add multiport controller support for qcom wrapper Krishna Kurapati
2023-05-01 14:34 ` [PATCH v7 7/9] arm64: dts: qcom: sc8280xp: Add multiport controller node for SC8280 Krishna Kurapati
2023-05-02  7:47   ` Krzysztof Kozlowski
2023-05-02  8:37     ` Krishna Kurapati PSSNV
2023-05-03 14:40   ` Johan Hovold
2023-05-01 14:34 ` [PATCH v7 8/9] arm64: dts: qcom: sa8295p: Enable tertiary controller and its 4 USB ports Krishna Kurapati
2023-05-02 11:06   ` Konrad Dybcio
2023-05-03  3:55     ` Krishna Kurapati PSSNV
2023-05-04  6:37       ` Konrad Dybcio
2023-05-01 14:34 ` [PATCH v7 9/9] arm64: dts: qcom: sa8540-ride: Enable first port of tertiary usb controller Krishna Kurapati
2023-05-02 11:07   ` Konrad Dybcio
2023-05-04 18:03     ` Krishna Kurapati PSSNV
2023-05-04 20:06       ` Andrew Halaney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9672285c-d81c-2ef5-46bc-13708392b5aa@quicinc.com \
    --to=quic_kriskura@quicinc.com \
    --cc=Thinh.Nguyen@synopsys.com \
    --cc=agross@kernel.org \
    --cc=ahalaney@redhat.com \
    --cc=andersson@kernel.org \
    --cc=balbi@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=quic_harshq@quicinc.com \
    --cc=quic_jackp@quicinc.com \
    --cc=quic_pkondeti@quicinc.com \
    --cc=quic_ppratap@quicinc.com \
    --cc=quic_shazhuss@quicinc.com \
    --cc=quic_wcheng@quicinc.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.