[Qemu-devel] [PATCH] Add 'none' as type for drive's if option

[Qemu-devel] [PATCH] Add 'none' as type for drive's if option

[Craig Jellick]

Signed-off-by: Craig Jellick <craig@rancher.com>
---
 qemu-options.hx | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/qemu-options.hx b/qemu-options.hx
index 99af8ed..8291e64 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -591,7 +591,7 @@ Special files such as iSCSI devices can be specified using protocol
 specific URLs. See the section for "Device URL Syntax" for more information.
 @item if=@var{interface}
 This option defines on which type on interface the drive is connected.
-Available types are: ide, scsi, sd, mtd, floppy, pflash, virtio.
+Available types are: ide, scsi, sd, mtd, floppy, pflash, virtio, none.
 @item bus=@var{bus},unit=@var{unit}
 These options define where is connected the drive by defining the bus number and
 the unit id.
-- 
2.7.4

Re: [Qemu-devel] [PATCH] Add 'none' as type for drive's if option

[Stefan Hajnoczi]

[-- Attachment #1: Type: text/plain, Size: 247 bytes --]

On Fri, Mar 17, 2017 at 08:49:55AM -0700, Craig Jellick wrote:
> Signed-off-by: Craig Jellick <craig@rancher.com>
> ---
>  qemu-options.hx | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]

Re: [Qemu-devel] [PATCH] Add 'none' as type for drive's if option

[Markus Armbruster]

Perhaps this can go via qemu-trivial.

Craig Jellick <craig@rancher.com> writes:

> Signed-off-by: Craig Jellick <craig@rancher.com>
> ---
>  qemu-options.hx | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qemu-options.hx b/qemu-options.hx
> index 99af8ed..8291e64 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -591,7 +591,7 @@ Special files such as iSCSI devices can be specified using protocol
>  specific URLs. See the section for "Device URL Syntax" for more information.
>  @item if=@var{interface}
>  This option defines on which type on interface the drive is connected.
> -Available types are: ide, scsi, sd, mtd, floppy, pflash, virtio.
> +Available types are: ide, scsi, sd, mtd, floppy, pflash, virtio, none.
>  @item bus=@var{bus},unit=@var{unit}
>  These options define where is connected the drive by defining the bus number and
>  the unit id.

Re: [Qemu-devel] [PATCH] Add 'none' as type for drive's if option

[Craig Jellick]

Is there an action I need to take for that?

________________________________
From: Markus Armbruster <armbru@redhat.com>
Sent: Tuesday, April 11, 2017 6:17:10 AM
To: Craig Jellick
Cc: qemu-devel@nongnu.org; qemu-trivial@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Add 'none' as type for drive's if option

Perhaps this can go via qemu-trivial.

Craig Jellick <craig@rancher.com> writes:

> Signed-off-by: Craig Jellick <craig@rancher.com>
> ---
>  qemu-options.hx | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qemu-options.hx b/qemu-options.hx
> index 99af8ed..8291e64 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -591,7 +591,7 @@ Special files such as iSCSI devices can be specified using protocol
>  specific URLs. See the section for "Device URL Syntax" for more information.
>  @item if=@var{interface}
>  This option defines on which type on interface the drive is connected.
> -Available types are: ide, scsi, sd, mtd, floppy, pflash, virtio.
> +Available types are: ide, scsi, sd, mtd, floppy, pflash, virtio, none.
>  @item bus=@var{bus},unit=@var{unit}
>  These options define where is connected the drive by defining the bus number and
>  the unit id.

Re: [Qemu-devel] [PATCH] Add 'none' as type for drive's if option

[Markus Armbruster]

Craig Jellick <craig@rancher.com> writes:

> Is there an action I need to take for that?

Fair question.

Expect e-mail from a qemu-trivial maintainer that your patch has been
merged.  If you don't get one within a reasonable time frame, we failed
you.  Send a reminder as a reply to this message then.

I figure one week after 2.10 opens would be reasonable.  It's expected
to open in a week.

Thanks!

Re: [Qemu-devel] [PATCH] Add 'none' as type for drive's if option

[Michael Tokarev]

17.03.2017 18:49, Craig Jellick wrote:
>  qemu-options.hx | 2 +-

Applied to -trivial, thank you!

/mjt