* [PATCH mptcp-next] Squash to "mptcp: don't return sockets in foreign netns"
@ 2021-09-18 8:05 Matthieu Baerts
2021-09-19 7:06 ` Matthieu Baerts
0 siblings, 1 reply; 2+ messages in thread
From: Matthieu Baerts @ 2021-09-18 8:05 UTC (permalink / raw)
To: mptcp; +Cc: Matthieu Baerts, Florian Westphal
Add missing doc for the new 'net' parameter.
'make W=1' returned this warning:
net/mptcp/token.c:242: warning: Function parameter or member 'net' not described in 'mptcp_token_get_sock'
This caused the failure reported by Github Action job:
https://github.com/multipath-tcp/mptcp_net-next/runs/3623640967?check_suite_focus=true
Cc: Florian Westphal <fw@strlen.de>
Signed-off-by: Matthieu Baerts <matthieu.baerts@tessares.net>
---
Notes:
to be squashed in "mptcp: don't return sockets in foreign netns"
net/mptcp/token.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/mptcp/token.c b/net/mptcp/token.c
index 313a3e793e61..e581b341c5be 100644
--- a/net/mptcp/token.c
+++ b/net/mptcp/token.c
@@ -231,6 +231,7 @@ bool mptcp_token_exists(u32 token)
/**
* mptcp_token_get_sock - retrieve mptcp connection sock using its token
+ * @net: restrict to this namespace
* @token: token of the mptcp connection to retrieve
*
* This function returns the mptcp connection structure with the given token.
--
2.32.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH mptcp-next] Squash to "mptcp: don't return sockets in foreign netns"
2021-09-18 8:05 [PATCH mptcp-next] Squash to "mptcp: don't return sockets in foreign netns" Matthieu Baerts
@ 2021-09-19 7:06 ` Matthieu Baerts
0 siblings, 0 replies; 2+ messages in thread
From: Matthieu Baerts @ 2021-09-19 7:06 UTC (permalink / raw)
To: mptcp; +Cc: Florian Westphal
Hi Florian,
On 18/09/2021 10:05, Matthieu Baerts wrote:
> Add missing doc for the new 'net' parameter.
>
> 'make W=1' returned this warning:
>
> net/mptcp/token.c:242: warning: Function parameter or member 'net' not described in 'mptcp_token_get_sock'
Thank you for the review! Now in our tree:
- 91017a33fdaf: "squashed" in "mptcp: don't return sockets in foreign netns"
- Without co-dev tags for just that
- Results: 9362f2920995..3d2c77807730
Builds are now in progress:
https://cirrus-ci.com/github/multipath-tcp/mptcp_net-next/export/20210919T070621
Cheers,
Matt
--
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-09-19 7:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-18 8:05 [PATCH mptcp-next] Squash to "mptcp: don't return sockets in foreign netns" Matthieu Baerts
2021-09-19 7:06 ` Matthieu Baerts
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.