* [PATCH] ASoC: Intel: mrfld: return error codes when an error occurs
@ 2020-02-08 22:07 ` Colin King
0 siblings, 0 replies; 13+ messages in thread
From: Colin King @ 2020-02-08 22:07 UTC (permalink / raw)
To: Cezary Rojewski, Pierre-Louis Bossart, Liam Girdwood, Jie Yang,
Mark Brown, Jaroslav Kysela, Takashi Iwai, Vinod Koul,
Subhransu S . Prusty, alsa-devel
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Currently function sst_platform_get_resources always returns zero and
error return codes set by the function are never returned. Fix this
by returning the error return code in variable ret rather than the
hard coded zero.
Addresses-Coverity: ("Unused value")
Fixes: f533a035e4da ("ASoC: Intel: mrfld - create separate module for pci part")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
sound/soc/intel/atom/sst/sst_pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/intel/atom/sst/sst_pci.c b/sound/soc/intel/atom/sst/sst_pci.c
index d952719bc098..5862fe968083 100644
--- a/sound/soc/intel/atom/sst/sst_pci.c
+++ b/sound/soc/intel/atom/sst/sst_pci.c
@@ -99,7 +99,7 @@ static int sst_platform_get_resources(struct intel_sst_drv *ctx)
dev_dbg(ctx->dev, "DRAM Ptr %p\n", ctx->dram);
do_release_regions:
pci_release_regions(pci);
- return 0;
+ return ret;
}
/*
--
2.25.0
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH] ASoC: Intel: mrfld: return error codes when an error occurs
@ 2020-02-08 22:07 ` Colin King
0 siblings, 0 replies; 13+ messages in thread
From: Colin King @ 2020-02-08 22:07 UTC (permalink / raw)
To: Cezary Rojewski, Pierre-Louis Bossart, Liam Girdwood, Jie Yang,
Mark Brown, Jaroslav Kysela, Takashi Iwai, Vinod Koul,
Subhransu S . Prusty, alsa-devel
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Currently function sst_platform_get_resources always returns zero and
error return codes set by the function are never returned. Fix this
by returning the error return code in variable ret rather than the
hard coded zero.
Addresses-Coverity: ("Unused value")
Fixes: f533a035e4da ("ASoC: Intel: mrfld - create separate module for pci part")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
sound/soc/intel/atom/sst/sst_pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/intel/atom/sst/sst_pci.c b/sound/soc/intel/atom/sst/sst_pci.c
index d952719bc098..5862fe968083 100644
--- a/sound/soc/intel/atom/sst/sst_pci.c
+++ b/sound/soc/intel/atom/sst/sst_pci.c
@@ -99,7 +99,7 @@ static int sst_platform_get_resources(struct intel_sst_drv *ctx)
dev_dbg(ctx->dev, "DRAM Ptr %p\n", ctx->dram);
do_release_regions:
pci_release_regions(pci);
- return 0;
+ return ret;
}
/*
--
2.25.0
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [alsa-devel] [PATCH] ASoC: Intel: mrfld: return error codes when an error occurs
@ 2020-02-08 22:07 ` Colin King
0 siblings, 0 replies; 13+ messages in thread
From: Colin King @ 2020-02-08 22:07 UTC (permalink / raw)
To: Cezary Rojewski, Pierre-Louis Bossart, Liam Girdwood, Jie Yang,
Mark Brown, Jaroslav Kysela, Takashi Iwai, Vinod Koul,
Subhransu S . Prusty, alsa-devel
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Currently function sst_platform_get_resources always returns zero and
error return codes set by the function are never returned. Fix this
by returning the error return code in variable ret rather than the
hard coded zero.
Addresses-Coverity: ("Unused value")
Fixes: f533a035e4da ("ASoC: Intel: mrfld - create separate module for pci part")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
sound/soc/intel/atom/sst/sst_pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/intel/atom/sst/sst_pci.c b/sound/soc/intel/atom/sst/sst_pci.c
index d952719bc098..5862fe968083 100644
--- a/sound/soc/intel/atom/sst/sst_pci.c
+++ b/sound/soc/intel/atom/sst/sst_pci.c
@@ -99,7 +99,7 @@ static int sst_platform_get_resources(struct intel_sst_drv *ctx)
dev_dbg(ctx->dev, "DRAM Ptr %p\n", ctx->dram);
do_release_regions:
pci_release_regions(pci);
- return 0;
+ return ret;
}
/*
--
2.25.0
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH] ASoC: Intel: mrfld: return error codes when an error occurs
2020-02-08 22:07 ` Colin King
(?)
@ 2020-02-09 15:34 ` Cezary Rojewski
-1 siblings, 0 replies; 13+ messages in thread
From: Cezary Rojewski @ 2020-02-09 15:34 UTC (permalink / raw)
To: Colin King
Cc: Pierre-Louis Bossart, Liam Girdwood, Jie Yang, Mark Brown,
Jaroslav Kysela, Takashi Iwai, Vinod Koul, Subhransu S . Prusty,
alsa-devel, kernel-janitors, linux-kernel
On 2020-02-08 23:07, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Currently function sst_platform_get_resources always returns zero and
> error return codes set by the function are never returned. Fix this
> by returning the error return code in variable ret rather than the
> hard coded zero.
>
> Addresses-Coverity: ("Unused value")
> Fixes: f533a035e4da ("ASoC: Intel: mrfld - create separate module for pci part")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> sound/soc/intel/atom/sst/sst_pci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/intel/atom/sst/sst_pci.c b/sound/soc/intel/atom/sst/sst_pci.c
> index d952719bc098..5862fe968083 100644
> --- a/sound/soc/intel/atom/sst/sst_pci.c
> +++ b/sound/soc/intel/atom/sst/sst_pci.c
> @@ -99,7 +99,7 @@ static int sst_platform_get_resources(struct intel_sst_drv *ctx)
> dev_dbg(ctx->dev, "DRAM Ptr %p\n", ctx->dram);
> do_release_regions:
> pci_release_regions(pci);
> - return 0;
> + return ret;
> }
>
> /*
>
Thank you for the fix.
Acked-by: Cezary Rojewski <cezary.rojewski@intel.com>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] ASoC: Intel: mrfld: return error codes when an error occurs
@ 2020-02-09 15:34 ` Cezary Rojewski
0 siblings, 0 replies; 13+ messages in thread
From: Cezary Rojewski @ 2020-02-09 15:34 UTC (permalink / raw)
To: Colin King
Cc: alsa-devel, kernel-janitors, Jie Yang, Takashi Iwai,
Pierre-Louis Bossart, Liam Girdwood, Vinod Koul, Mark Brown,
Subhransu S . Prusty, linux-kernel
On 2020-02-08 23:07, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Currently function sst_platform_get_resources always returns zero and
> error return codes set by the function are never returned. Fix this
> by returning the error return code in variable ret rather than the
> hard coded zero.
>
> Addresses-Coverity: ("Unused value")
> Fixes: f533a035e4da ("ASoC: Intel: mrfld - create separate module for pci part")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> sound/soc/intel/atom/sst/sst_pci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/intel/atom/sst/sst_pci.c b/sound/soc/intel/atom/sst/sst_pci.c
> index d952719bc098..5862fe968083 100644
> --- a/sound/soc/intel/atom/sst/sst_pci.c
> +++ b/sound/soc/intel/atom/sst/sst_pci.c
> @@ -99,7 +99,7 @@ static int sst_platform_get_resources(struct intel_sst_drv *ctx)
> dev_dbg(ctx->dev, "DRAM Ptr %p\n", ctx->dram);
> do_release_regions:
> pci_release_regions(pci);
> - return 0;
> + return ret;
> }
>
> /*
>
Thank you for the fix.
Acked-by: Cezary Rojewski <cezary.rojewski@intel.com>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [alsa-devel] [PATCH] ASoC: Intel: mrfld: return error codes when an error occurs
@ 2020-02-09 15:34 ` Cezary Rojewski
0 siblings, 0 replies; 13+ messages in thread
From: Cezary Rojewski @ 2020-02-09 15:34 UTC (permalink / raw)
To: Colin King
Cc: alsa-devel, kernel-janitors, Jie Yang, Takashi Iwai,
Pierre-Louis Bossart, Liam Girdwood, Vinod Koul, Mark Brown,
Subhransu S . Prusty, linux-kernel
On 2020-02-08 23:07, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Currently function sst_platform_get_resources always returns zero and
> error return codes set by the function are never returned. Fix this
> by returning the error return code in variable ret rather than the
> hard coded zero.
>
> Addresses-Coverity: ("Unused value")
> Fixes: f533a035e4da ("ASoC: Intel: mrfld - create separate module for pci part")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> sound/soc/intel/atom/sst/sst_pci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/intel/atom/sst/sst_pci.c b/sound/soc/intel/atom/sst/sst_pci.c
> index d952719bc098..5862fe968083 100644
> --- a/sound/soc/intel/atom/sst/sst_pci.c
> +++ b/sound/soc/intel/atom/sst/sst_pci.c
> @@ -99,7 +99,7 @@ static int sst_platform_get_resources(struct intel_sst_drv *ctx)
> dev_dbg(ctx->dev, "DRAM Ptr %p\n", ctx->dram);
> do_release_regions:
> pci_release_regions(pci);
> - return 0;
> + return ret;
> }
>
> /*
>
Thank you for the fix.
Acked-by: Cezary Rojewski <cezary.rojewski@intel.com>
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] ASoC: Intel: mrfld: return error codes when an error occurs
2020-02-08 22:07 ` Colin King
(?)
@ 2020-02-10 8:49 ` Dan Carpenter
-1 siblings, 0 replies; 13+ messages in thread
From: Dan Carpenter @ 2020-02-10 8:49 UTC (permalink / raw)
To: Colin King, Vinod Koul
Cc: Cezary Rojewski, Pierre-Louis Bossart, Liam Girdwood, Jie Yang,
Mark Brown, Jaroslav Kysela, Takashi Iwai, Subhransu S . Prusty,
alsa-devel, kernel-janitors, linux-kernel
On Sat, Feb 08, 2020 at 10:07:20PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Currently function sst_platform_get_resources always returns zero and
> error return codes set by the function are never returned. Fix this
> by returning the error return code in variable ret rather than the
> hard coded zero.
>
> Addresses-Coverity: ("Unused value")
> Fixes: f533a035e4da ("ASoC: Intel: mrfld - create separate module for pci part")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> sound/soc/intel/atom/sst/sst_pci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/intel/atom/sst/sst_pci.c b/sound/soc/intel/atom/sst/sst_pci.c
> index d952719bc098..5862fe968083 100644
> --- a/sound/soc/intel/atom/sst/sst_pci.c
> +++ b/sound/soc/intel/atom/sst/sst_pci.c
> @@ -99,7 +99,7 @@ static int sst_platform_get_resources(struct intel_sst_drv *ctx)
> dev_dbg(ctx->dev, "DRAM Ptr %p\n", ctx->dram);
> do_release_regions:
> pci_release_regions(pci);
It's weird that we release the regions on the success path.
regards,
dan carpenter
> - return 0;
> + return ret;
> }
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] ASoC: Intel: mrfld: return error codes when an error occurs
@ 2020-02-10 8:49 ` Dan Carpenter
0 siblings, 0 replies; 13+ messages in thread
From: Dan Carpenter @ 2020-02-10 8:49 UTC (permalink / raw)
To: Colin King, Vinod Koul
Cc: Cezary Rojewski, alsa-devel, kernel-janitors, Takashi Iwai,
Jie Yang, Pierre-Louis Bossart, Liam Girdwood, Mark Brown,
Subhransu S . Prusty, linux-kernel
On Sat, Feb 08, 2020 at 10:07:20PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Currently function sst_platform_get_resources always returns zero and
> error return codes set by the function are never returned. Fix this
> by returning the error return code in variable ret rather than the
> hard coded zero.
>
> Addresses-Coverity: ("Unused value")
> Fixes: f533a035e4da ("ASoC: Intel: mrfld - create separate module for pci part")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> sound/soc/intel/atom/sst/sst_pci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/intel/atom/sst/sst_pci.c b/sound/soc/intel/atom/sst/sst_pci.c
> index d952719bc098..5862fe968083 100644
> --- a/sound/soc/intel/atom/sst/sst_pci.c
> +++ b/sound/soc/intel/atom/sst/sst_pci.c
> @@ -99,7 +99,7 @@ static int sst_platform_get_resources(struct intel_sst_drv *ctx)
> dev_dbg(ctx->dev, "DRAM Ptr %p\n", ctx->dram);
> do_release_regions:
> pci_release_regions(pci);
It's weird that we release the regions on the success path.
regards,
dan carpenter
> - return 0;
> + return ret;
> }
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [alsa-devel] [PATCH] ASoC: Intel: mrfld: return error codes when an error occurs
@ 2020-02-10 8:49 ` Dan Carpenter
0 siblings, 0 replies; 13+ messages in thread
From: Dan Carpenter @ 2020-02-10 8:49 UTC (permalink / raw)
To: Colin King, Vinod Koul
Cc: Cezary Rojewski, alsa-devel, kernel-janitors, Takashi Iwai,
Jie Yang, Pierre-Louis Bossart, Liam Girdwood, Mark Brown,
Subhransu S . Prusty, linux-kernel
On Sat, Feb 08, 2020 at 10:07:20PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Currently function sst_platform_get_resources always returns zero and
> error return codes set by the function are never returned. Fix this
> by returning the error return code in variable ret rather than the
> hard coded zero.
>
> Addresses-Coverity: ("Unused value")
> Fixes: f533a035e4da ("ASoC: Intel: mrfld - create separate module for pci part")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> sound/soc/intel/atom/sst/sst_pci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/intel/atom/sst/sst_pci.c b/sound/soc/intel/atom/sst/sst_pci.c
> index d952719bc098..5862fe968083 100644
> --- a/sound/soc/intel/atom/sst/sst_pci.c
> +++ b/sound/soc/intel/atom/sst/sst_pci.c
> @@ -99,7 +99,7 @@ static int sst_platform_get_resources(struct intel_sst_drv *ctx)
> dev_dbg(ctx->dev, "DRAM Ptr %p\n", ctx->dram);
> do_release_regions:
> pci_release_regions(pci);
It's weird that we release the regions on the success path.
regards,
dan carpenter
> - return 0;
> + return ret;
> }
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [alsa-devel] [PATCH] ASoC: Intel: mrfld: return error codes when an error occurs
2020-02-08 22:07 ` Colin King
(?)
@ 2020-02-10 14:09 ` Pierre-Louis Bossart
-1 siblings, 0 replies; 13+ messages in thread
From: Pierre-Louis Bossart @ 2020-02-10 14:09 UTC (permalink / raw)
To: Colin King, Cezary Rojewski, Liam Girdwood, Jie Yang, Mark Brown,
Jaroslav Kysela, Takashi Iwai, Vinod Koul, Subhransu S . Prusty,
alsa-devel
Cc: kernel-janitors, linux-kernel
On 2/8/20 4:07 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Currently function sst_platform_get_resources always returns zero and
> error return codes set by the function are never returned. Fix this
> by returning the error return code in variable ret rather than the
> hard coded zero.
>
> Addresses-Coverity: ("Unused value")
> Fixes: f533a035e4da ("ASoC: Intel: mrfld - create separate module for pci part")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Yes, it's clearly bad.
Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
I don't think this impacts anyone though, the code can only be used for
Merrifield/Tangier.
> ---
> sound/soc/intel/atom/sst/sst_pci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/intel/atom/sst/sst_pci.c b/sound/soc/intel/atom/sst/sst_pci.c
> index d952719bc098..5862fe968083 100644
> --- a/sound/soc/intel/atom/sst/sst_pci.c
> +++ b/sound/soc/intel/atom/sst/sst_pci.c
> @@ -99,7 +99,7 @@ static int sst_platform_get_resources(struct intel_sst_drv *ctx)
> dev_dbg(ctx->dev, "DRAM Ptr %p\n", ctx->dram);
> do_release_regions:
> pci_release_regions(pci);
> - return 0;
> + return ret;
> }
>
> /*
>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [alsa-devel] [PATCH] ASoC: Intel: mrfld: return error codes when an error occurs
@ 2020-02-10 14:09 ` Pierre-Louis Bossart
0 siblings, 0 replies; 13+ messages in thread
From: Pierre-Louis Bossart @ 2020-02-10 14:09 UTC (permalink / raw)
To: Colin King, Cezary Rojewski, Liam Girdwood, Jie Yang, Mark Brown,
Jaroslav Kysela, Takashi Iwai, Vinod Koul, Subhransu S . Prusty,
alsa-devel
Cc: kernel-janitors, linux-kernel
On 2/8/20 4:07 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Currently function sst_platform_get_resources always returns zero and
> error return codes set by the function are never returned. Fix this
> by returning the error return code in variable ret rather than the
> hard coded zero.
>
> Addresses-Coverity: ("Unused value")
> Fixes: f533a035e4da ("ASoC: Intel: mrfld - create separate module for pci part")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Yes, it's clearly bad.
Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
I don't think this impacts anyone though, the code can only be used for
Merrifield/Tangier.
> ---
> sound/soc/intel/atom/sst/sst_pci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/intel/atom/sst/sst_pci.c b/sound/soc/intel/atom/sst/sst_pci.c
> index d952719bc098..5862fe968083 100644
> --- a/sound/soc/intel/atom/sst/sst_pci.c
> +++ b/sound/soc/intel/atom/sst/sst_pci.c
> @@ -99,7 +99,7 @@ static int sst_platform_get_resources(struct intel_sst_drv *ctx)
> dev_dbg(ctx->dev, "DRAM Ptr %p\n", ctx->dram);
> do_release_regions:
> pci_release_regions(pci);
> - return 0;
> + return ret;
> }
>
> /*
>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [alsa-devel] [PATCH] ASoC: Intel: mrfld: return error codes when an error occurs
@ 2020-02-10 14:09 ` Pierre-Louis Bossart
0 siblings, 0 replies; 13+ messages in thread
From: Pierre-Louis Bossart @ 2020-02-10 14:09 UTC (permalink / raw)
To: Colin King, Cezary Rojewski, Liam Girdwood, Jie Yang, Mark Brown,
Jaroslav Kysela, Takashi Iwai, Vinod Koul, Subhransu S . Prusty,
alsa-devel
Cc: kernel-janitors, linux-kernel
On 2/8/20 4:07 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Currently function sst_platform_get_resources always returns zero and
> error return codes set by the function are never returned. Fix this
> by returning the error return code in variable ret rather than the
> hard coded zero.
>
> Addresses-Coverity: ("Unused value")
> Fixes: f533a035e4da ("ASoC: Intel: mrfld - create separate module for pci part")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Yes, it's clearly bad.
Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
I don't think this impacts anyone though, the code can only be used for
Merrifield/Tangier.
> ---
> sound/soc/intel/atom/sst/sst_pci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/intel/atom/sst/sst_pci.c b/sound/soc/intel/atom/sst/sst_pci.c
> index d952719bc098..5862fe968083 100644
> --- a/sound/soc/intel/atom/sst/sst_pci.c
> +++ b/sound/soc/intel/atom/sst/sst_pci.c
> @@ -99,7 +99,7 @@ static int sst_platform_get_resources(struct intel_sst_drv *ctx)
> dev_dbg(ctx->dev, "DRAM Ptr %p\n", ctx->dram);
> do_release_regions:
> pci_release_regions(pci);
> - return 0;
> + return ret;
> }
>
> /*
>
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
^ permalink raw reply [flat|nested] 13+ messages in thread
* [alsa-devel] Applied "ASoC: Intel: mrfld: return error codes when an error occurs" to the asoc tree
2020-02-08 22:07 ` Colin King
` (4 preceding siblings ...)
(?)
@ 2020-02-11 15:49 ` Mark Brown
-1 siblings, 0 replies; 13+ messages in thread
From: Mark Brown @ 2020-02-11 15:49 UTC (permalink / raw)
To: Colin Ian King
Cc: Pierre-Louis Bossart, alsa-devel, Jie Yang, Takashi Iwai,
kernel-janitors, Cezary Rojewski, Liam Girdwood, Vinod Koul,
Mark Brown, Subhransu S . Prusty, linux-kernel
The patch
ASoC: Intel: mrfld: return error codes when an error occurs
has been applied to the asoc tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-5.7
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
From 3025571edd9df653e1ad649f0638368a39d1bbb5 Mon Sep 17 00:00:00 2001
From: Colin Ian King <colin.king@canonical.com>
Date: Sat, 8 Feb 2020 22:07:20 +0000
Subject: [PATCH] ASoC: Intel: mrfld: return error codes when an error occurs
Currently function sst_platform_get_resources always returns zero and
error return codes set by the function are never returned. Fix this
by returning the error return code in variable ret rather than the
hard coded zero.
Addresses-Coverity: ("Unused value")
Fixes: f533a035e4da ("ASoC: Intel: mrfld - create separate module for pci part")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Cezary Rojewski <cezary.rojewski@intel.com>
Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20200208220720.36657-1-colin.king@canonical.com
Signed-off-by: Mark Brown <broonie@kernel.org>
---
sound/soc/intel/atom/sst/sst_pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/intel/atom/sst/sst_pci.c b/sound/soc/intel/atom/sst/sst_pci.c
index d952719bc098..5862fe968083 100644
--- a/sound/soc/intel/atom/sst/sst_pci.c
+++ b/sound/soc/intel/atom/sst/sst_pci.c
@@ -99,7 +99,7 @@ static int sst_platform_get_resources(struct intel_sst_drv *ctx)
dev_dbg(ctx->dev, "DRAM Ptr %p\n", ctx->dram);
do_release_regions:
pci_release_regions(pci);
- return 0;
+ return ret;
}
/*
--
2.20.1
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
^ permalink raw reply related [flat|nested] 13+ messages in thread
end of thread, other threads:[~2020-02-11 16:06 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-08 22:07 [PATCH] ASoC: Intel: mrfld: return error codes when an error occurs Colin King
2020-02-08 22:07 ` [alsa-devel] " Colin King
2020-02-08 22:07 ` Colin King
2020-02-09 15:34 ` Cezary Rojewski
2020-02-09 15:34 ` [alsa-devel] " Cezary Rojewski
2020-02-09 15:34 ` Cezary Rojewski
2020-02-10 8:49 ` Dan Carpenter
2020-02-10 8:49 ` [alsa-devel] " Dan Carpenter
2020-02-10 8:49 ` Dan Carpenter
2020-02-10 14:09 ` [alsa-devel] " Pierre-Louis Bossart
2020-02-10 14:09 ` Pierre-Louis Bossart
2020-02-10 14:09 ` Pierre-Louis Bossart
2020-02-11 15:49 ` [alsa-devel] Applied "ASoC: Intel: mrfld: return error codes when an error occurs" to the asoc tree Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.