All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chao Yu <yuchao0@huawei.com>
To: Hridya Valsaraju <hridya@google.com>
Cc: Jaegeuk Kim <jaegeuk@kernel.org>,
	<linux-f2fs-devel@lists.sourceforge.net>,
	LKML <linux-kernel@vger.kernel.org>,
	Android Kernel Team <kernel-team@android.com>
Subject: Re: [PATCH 2/2] f2fs: Add f2fs stats to sysfs
Date: Fri, 25 Oct 2019 16:30:57 +0800	[thread overview]
Message-ID: <96f89e7c-d91e-e263-99f7-16998cc443a7@huawei.com> (raw)
In-Reply-To: <CA+wgaPNas7ixNtepJE_6e7b6Dcutb9a1Who4WrUfKSw1ZnQhTA@mail.gmail.com>

On 2019/10/25 11:51, Hridya Valsaraju wrote:
> On Thu, Oct 24, 2019 at 2:26 AM Chao Yu <yuchao0@huawei.com> wrote:
>>
>> On 2019/10/24 5:48, Hridya Valsaraju wrote:
>>> Currently f2fs stats are only available from /d/f2fs/status. This patch
>>> adds some of the f2fs stats to sysfs so that they are accessible even
>>> when debugfs is not mounted.
>>
>> Why don't we mount debugfs first?
> 
> Thank you for taking a look at the patch Chao. We will not be mounting
> debugfs for security reasons.

Hi, Hridya,

May I ask is there any use case for those new entries?

So many sysfs entries exist, if there is real use case, how about backuping
entire /d/f2fs/status entry into /proc/fs/f2fs/<dev>/ directory rather than
adding some of stats as a single entry in sysfs directory?

Thanks,

> 
> Regards,
> Hridya
> 
>>
>> Thanks,
> .
> 

WARNING: multiple messages have this Message-ID (diff)
From: Chao Yu <yuchao0@huawei.com>
To: Hridya Valsaraju <hridya@google.com>
Cc: Jaegeuk Kim <jaegeuk@kernel.org>,
	Android Kernel Team <kernel-team@android.com>,
	LKML <linux-kernel@vger.kernel.org>,
	linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH 2/2] f2fs: Add f2fs stats to sysfs
Date: Fri, 25 Oct 2019 16:30:57 +0800	[thread overview]
Message-ID: <96f89e7c-d91e-e263-99f7-16998cc443a7@huawei.com> (raw)
In-Reply-To: <CA+wgaPNas7ixNtepJE_6e7b6Dcutb9a1Who4WrUfKSw1ZnQhTA@mail.gmail.com>

On 2019/10/25 11:51, Hridya Valsaraju wrote:
> On Thu, Oct 24, 2019 at 2:26 AM Chao Yu <yuchao0@huawei.com> wrote:
>>
>> On 2019/10/24 5:48, Hridya Valsaraju wrote:
>>> Currently f2fs stats are only available from /d/f2fs/status. This patch
>>> adds some of the f2fs stats to sysfs so that they are accessible even
>>> when debugfs is not mounted.
>>
>> Why don't we mount debugfs first?
> 
> Thank you for taking a look at the patch Chao. We will not be mounting
> debugfs for security reasons.

Hi, Hridya,

May I ask is there any use case for those new entries?

So many sysfs entries exist, if there is real use case, how about backuping
entire /d/f2fs/status entry into /proc/fs/f2fs/<dev>/ directory rather than
adding some of stats as a single entry in sysfs directory?

Thanks,

> 
> Regards,
> Hridya
> 
>>
>> Thanks,
> .
> 


_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

  reply	other threads:[~2019-10-25  8:31 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-23 21:48 [PATCH 1/2] f2fs: delete duplicate information on sysfs nodes Hridya Valsaraju
2019-10-23 21:48 ` [f2fs-dev] " Hridya Valsaraju via Linux-f2fs-devel
2019-10-23 21:48 ` [PATCH 2/2] f2fs: Add f2fs stats to sysfs Hridya Valsaraju
2019-10-23 21:48   ` [f2fs-dev] " Hridya Valsaraju via Linux-f2fs-devel
2019-10-24  9:26   ` Chao Yu
2019-10-24  9:26     ` [f2fs-dev] " Chao Yu
2019-10-25  3:51     ` Hridya Valsaraju
2019-10-25  3:51       ` [f2fs-dev] " Hridya Valsaraju via Linux-f2fs-devel
2019-10-25  8:30       ` Chao Yu [this message]
2019-10-25  8:30         ` Chao Yu
2019-10-25 18:22         ` Jaegeuk Kim
2019-10-25 18:22           ` [f2fs-dev] " Jaegeuk Kim
2019-10-26  1:37           ` Chao Yu
2019-10-26  1:37             ` [f2fs-dev] " Chao Yu
2019-10-29  0:26             ` Hridya Valsaraju
2019-10-29  0:26               ` [f2fs-dev] " Hridya Valsaraju via Linux-f2fs-devel
2019-10-24  9:15 ` [PATCH 1/2] f2fs: delete duplicate information on sysfs nodes Chao Yu
2019-10-24  9:15   ` [f2fs-dev] " Chao Yu
2019-10-25 18:23   ` Jaegeuk Kim
2019-10-25 18:23     ` [f2fs-dev] " Jaegeuk Kim
2019-10-26  1:40     ` Chao Yu
2019-10-26  1:40       ` [f2fs-dev] " Chao Yu
2020-01-23  1:13 Jaegeuk Kim
2020-01-23  1:13 ` [PATCH 2/2] f2fs: Add f2fs stats to sysfs Jaegeuk Kim
2020-01-23  2:13   ` Eric Biggers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=96f89e7c-d91e-e263-99f7-16998cc443a7@huawei.com \
    --to=yuchao0@huawei.com \
    --cc=hridya@google.com \
    --cc=jaegeuk@kernel.org \
    --cc=kernel-team@android.com \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.