[meta-virtualization][PATCH] ceph: set CXXFLAGS and CFLAGS

[meta-virtualization][PATCH] ceph: set CXXFLAGS and CFLAGS

[Sakib Sajal]

commit a83623a54a375d3ae9198a135b94379881a2b7a5 was added
to oe-core which removes CXXFLAGS and CFLAGS causing
compilation for ceph to fail.

Set CXXFLAGS and CFLAGS to resolve the issue.

Signed-off-by: Sakib Sajal <sakib.sajal@windriver.com>
---
 recipes-extended/ceph/ceph_15.2.15.bb | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/recipes-extended/ceph/ceph_15.2.15.bb b/recipes-extended/ceph/ceph_15.2.15.bb
index c72953a..17dbcf3 100644
--- a/recipes-extended/ceph/ceph_15.2.15.bb
+++ b/recipes-extended/ceph/ceph_15.2.15.bb
@@ -66,6 +66,9 @@ EXTRA_OECMAKE = "-DWITH_MANPAGE=OFF \
                  -DWITH_REENTRANT_STRSIGNAL=ON \
 "
 
+CXXFLAGS += "${HOST_CC_ARCH} ${TOOLCHAIN_OPTIONS}"
+CFLAGS += "${HOST_CC_ARCH} ${TOOLCHAIN_OPTIONS}"
+
 export STAGING_DIR_HOST
 
 do_configure:prepend () {
-- 
2.33.0

Re: [meta-virtualization][PATCH] ceph: set CXXFLAGS and CFLAGS

[Randy MacLeod]

On 2022-03-16 11:20, sakib.sajal@windriver.com wrote:
> commit a83623a54a375d3ae9198a135b94379881a2b7a5 was added
> to oe-core which removes 

The phrase:
    "was added ... which removes"
is awkward. As a student of Strunk and White, I suggest:

---
In oe-core, the commit:
    a83623a54a Revert "cmake.bbclass: Set CXXFLAGS and CFLAGS"

drops compiler flags overrides for all cmake-based recipes,
causing the ceph compile to fail with the error:
   ld: cannot find crtn.o: No such file or directory

   collect2: error: ld returned 1 exit status


Add the override back for ceph to fix the build error.

---

It's always good to include the key parts of the error log
so that someone can search the commit logs for help given
a keyword.

Bruce,

Did/does this error show up in your meta-virt testing?


> CXXFLAGS and CFLAGS causing
> compilation for ceph to fail.
> 
> Set CXXFLAGS and CFLAGS to resolve the issue.
> 
> Signed-off-by: Sakib Sajal <sakib.sajal@windriver.com>
> ---
>   recipes-extended/ceph/ceph_15.2.15.bb | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/recipes-extended/ceph/ceph_15.2.15.bb b/recipes-extended/ceph/ceph_15.2.15.bb
> index c72953a..17dbcf3 100644
> --- a/recipes-extended/ceph/ceph_15.2.15.bb
> +++ b/recipes-extended/ceph/ceph_15.2.15.bb
> @@ -66,6 +66,9 @@ EXTRA_OECMAKE = "-DWITH_MANPAGE=OFF \
>                    -DWITH_REENTRANT_STRSIGNAL=ON \
>   "
>   
> +CXXFLAGS += "${HOST_CC_ARCH} ${TOOLCHAIN_OPTIONS}"
> +CFLAGS += "${HOST_CC_ARCH} ${TOOLCHAIN_OPTIONS}"

Does ceph need both of the _ARCH and _OPTIONS to be set?
Since the error is at link time, try adding only TOOLCHAIN_OPTIONS
as is done for:

recipes-core/runx/runx_git.bb

97:        export CFLAGS="${HOST_CC_ARCH}${TOOLCHAIN_OPTIONS} ${CFLAGS}"

98:        export LDFLAGS="${TOOLCHAIN_OPTIONS} ${HOST_LD_ARCH} ${LDFLAGS}"




../Randy

> +
>   export STAGING_DIR_HOST
>   
>   do_configure:prepend () {
> 
> 
> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#7093): https://lists.yoctoproject.org/g/meta-virtualization/message/7093
> Mute This Topic: https://lists.yoctoproject.org/mt/89824093/3616765
> Group Owner: meta-virtualization+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub [randy.macleod@windriver.com]
> -=-=-=-=-=-=-=-=-=-=-=-
> 


-- 
# Randy MacLeod
# Wind River Linux

Re: [meta-virtualization][PATCH] ceph: set CXXFLAGS and CFLAGS

[Bruce Ashfield]

[-- Attachment #1: Type: text/plain, Size: 3003 bytes --]

On Wed, Mar 16, 2022 at 12:22 PM Randy MacLeod <randy.macleod@windriver.com>
wrote:

> On 2022-03-16 11:20, sakib.sajal@windriver.com wrote:
> > commit a83623a54a375d3ae9198a135b94379881a2b7a5 was added
> > to oe-core which removes
>
> The phrase:
>     "was added ... which removes"
> is awkward. As a student of Strunk and White, I suggest:
>
> ---
> In oe-core, the commit:
>     a83623a54a Revert "cmake.bbclass: Set CXXFLAGS and CFLAGS"
>
> drops compiler flags overrides for all cmake-based recipes,
> causing the ceph compile to fail with the error:
>    ld: cannot find crtn.o: No such file or directory
>
>    collect2: error: ld returned 1 exit status
>
>
> Add the override back for ceph to fix the build error.
>
> ---
>
> It's always good to include the key parts of the error log
> so that someone can search the commit logs for help given
> a keyword.
>
> Bruce,
>
> Did/does this error show up in your meta-virt testing?
>

I'm seeing it now as well. I've been working on a few things, so my testing
against oe-core was at an older commit.

So the change is likely good, but I'm waiting for a v2 with Randy's
suggested re-wording.

Bruce


>
> > CXXFLAGS and CFLAGS causing
> > compilation for ceph to fail.
> >
> > Set CXXFLAGS and CFLAGS to resolve the issue.
> >
> > Signed-off-by: Sakib Sajal <sakib.sajal@windriver.com>
> > ---
> >   recipes-extended/ceph/ceph_15.2.15.bb | 3 +++
> >   1 file changed, 3 insertions(+)
> >
> > diff --git a/recipes-extended/ceph/ceph_15.2.15.bb
> b/recipes-extended/ceph/ceph_15.2.15.bb
> > index c72953a..17dbcf3 100644
> > --- a/recipes-extended/ceph/ceph_15.2.15.bb
> > +++ b/recipes-extended/ceph/ceph_15.2.15.bb
> > @@ -66,6 +66,9 @@ EXTRA_OECMAKE = "-DWITH_MANPAGE=OFF \
> >                    -DWITH_REENTRANT_STRSIGNAL=ON \
> >   "
> >
> > +CXXFLAGS += "${HOST_CC_ARCH} ${TOOLCHAIN_OPTIONS}"
> > +CFLAGS += "${HOST_CC_ARCH} ${TOOLCHAIN_OPTIONS}"
>
> Does ceph need both of the _ARCH and _OPTIONS to be set?
> Since the error is at link time, try adding only TOOLCHAIN_OPTIONS
> as is done for:
>
> recipes-core/runx/runx_git.bb
>
> 97:        export CFLAGS="${HOST_CC_ARCH}${TOOLCHAIN_OPTIONS} ${CFLAGS}"
>
> 98:        export LDFLAGS="${TOOLCHAIN_OPTIONS} ${HOST_LD_ARCH} ${LDFLAGS}"
>
>
>
>
> ../Randy
>
> > +
> >   export STAGING_DIR_HOST
> >
> >   do_configure:prepend () {
> >
> >
> >
> > -=-=-=-=-=-=-=-=-=-=-=-
> > Links: You receive all messages sent to this group.
> > View/Reply Online (#7093):
> https://lists.yoctoproject.org/g/meta-virtualization/message/7093
> > Mute This Topic: https://lists.yoctoproject.org/mt/89824093/3616765
> > Group Owner: meta-virtualization+owner@lists.yoctoproject.org
> > Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub
> [randy.macleod@windriver.com]
> > -=-=-=-=-=-=-=-=-=-=-=-
> >
>
>
> --
> # Randy MacLeod
> # Wind River Linux
>
>

-- 
- Thou shalt not follow the NULL pointer, for chaos and madness await thee
at its end
- "Use the force Harry" - Gandalf, Star Trek II

[-- Attachment #2: Type: text/html, Size: 5489 bytes --]