[PATCH 0/2] Remove unused virtualization technology specific headers

[PATCH 0/2] Remove unused virtualization technology specific headers

[Xenia Ragiadakou]

The patches remove forgotten and now unused virtualization technology specific
headers from arch/x86/cpu/vpmu.c and arch/x86/hvm/emulate.c.

Xenia Ragiadakou (2):
  x86/emulate: remove unused svm specific header
  x86/vpmu: remove unused svm and vmx specific headers

 xen/arch/x86/cpu/vpmu.c    | 4 ----
 xen/arch/x86/hvm/emulate.c | 1 -
 2 files changed, 5 deletions(-)

-- 
2.37.2

[PATCH 1/2] x86/emulate: remove unused svm specific header

[Xenia Ragiadakou]

Fixes: 2191599bacb7 ("x86/emul: Simplfy emulation state setup")
Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com>
---

I 'm not sure that a Fixes tag applies in this case. I 've added it mostly
for reference.

 xen/arch/x86/hvm/emulate.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/xen/arch/x86/hvm/emulate.c b/xen/arch/x86/hvm/emulate.c
index cb221f70e8..95364deb19 100644
--- a/xen/arch/x86/hvm/emulate.c
+++ b/xen/arch/x86/hvm/emulate.c
@@ -24,7 +24,6 @@
 #include <asm/hvm/monitor.h>
 #include <asm/hvm/trace.h>
 #include <asm/hvm/support.h>
-#include <asm/hvm/svm/svm.h>
 #include <asm/iocap.h>
 #include <asm/vm_event.h>
 
-- 
2.37.2

[PATCH 2/2] x86/vpmu: remove unused svm and vmx specific headers

[Xenia Ragiadakou]

Fixes: 8c20aca6751b ("x86/vPMU: invoke <vendor>_vpmu_initialise() through a hook as well")
Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com>
---

I 'm not sure that a Fixes tag applies in this case. I 've added it mostly
for reference.

 xen/arch/x86/cpu/vpmu.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/xen/arch/x86/cpu/vpmu.c b/xen/arch/x86/cpu/vpmu.c
index 64cdbfc48c..33e2fca8cd 100644
--- a/xen/arch/x86/cpu/vpmu.c
+++ b/xen/arch/x86/cpu/vpmu.c
@@ -31,10 +31,6 @@
 #include <asm/p2m.h>
 #include <asm/vpmu.h>
 #include <asm/hvm/support.h>
-#include <asm/hvm/vmx/vmx.h>
-#include <asm/hvm/vmx/vmcs.h>
-#include <asm/hvm/svm/svm.h>
-#include <asm/hvm/svm/vmcb.h>
 #include <asm/apic.h>
 #include <irq_vectors.h>
 #include <public/pmu.h>
-- 
2.37.2

Re: [PATCH 0/2] Remove unused virtualization technology specific headers

[Andrew Cooper]

On 27/01/2023 9:46 am, Xenia Ragiadakou wrote:
> The patches remove forgotten and now unused virtualization technology specific
> headers from arch/x86/cpu/vpmu.c and arch/x86/hvm/emulate.c.
>
> Xenia Ragiadakou (2):
>   x86/emulate: remove unused svm specific header
>   x86/vpmu: remove unused svm and vmx specific headers
>
>  xen/arch/x86/cpu/vpmu.c    | 4 ----
>  xen/arch/x86/hvm/emulate.c | 1 -
>  2 files changed, 5 deletions(-)
>

Oh excellent.  Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>

IMO the fixes tags are useful even if we won't want to backport them. 
It's an easy pointer for people to follow if needs be.

~Andrew